)]}'
{"attributes/tempest_conf.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"901cbe6cc78ab6f52fcd5d43420dd2a8891ec023","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  conf[\u0027service_available\u0027][\u0027swift\u0027] \u003d false"},{"line_number":142,"context_line":"  conf[\u0027service_available\u0027][\u0027neutron\u0027] \u003d false"},{"line_number":143,"context_line":"  conf[\u0027service_available\u0027][\u0027glance\u0027] \u003d true"},{"line_number":144,"context_line":"  conf[\u0027service_available\u0027][\u0027cinder\u0027] \u003d false"},{"line_number":145,"context_line":"  conf[\u0027service_available\u0027][\u0027nova\u0027] \u003d true"},{"line_number":146,"context_line":"  conf[\u0027oslo_concurrency\u0027][\u0027lock_path\u0027] \u003d \u0027/opt/tempest/tempest_lock\u0027"},{"line_number":147,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_3aecacba","line":144,"updated":"2020-01-29 11:38:31.000000000","message":"Wouldn\u0027t you need to set this to true in order to run cinder tests at all?","commit_id":"d9d7b11b08495f2d22b23ce7e56e670c1e0286b8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"a3c3b5843284c7836d78ee277219534ded9fa85d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  conf[\u0027service_available\u0027][\u0027swift\u0027] \u003d false"},{"line_number":142,"context_line":"  conf[\u0027service_available\u0027][\u0027neutron\u0027] \u003d false"},{"line_number":143,"context_line":"  conf[\u0027service_available\u0027][\u0027glance\u0027] \u003d true"},{"line_number":144,"context_line":"  conf[\u0027service_available\u0027][\u0027cinder\u0027] \u003d false"},{"line_number":145,"context_line":"  conf[\u0027service_available\u0027][\u0027nova\u0027] \u003d true"},{"line_number":146,"context_line":"  conf[\u0027oslo_concurrency\u0027][\u0027lock_path\u0027] \u003d \u0027/opt/tempest/tempest_lock\u0027"},{"line_number":147,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_2d9d3cb9","line":144,"in_reply_to":"3fa7e38b_3aecacba","updated":"2020-01-29 18:23:21.000000000","message":"This gets set to true in the role in openstack-cinder. But I suppose if you don\u0027t use that and you want to use this out right, it probably should be enabled. I also should remove some of these services as they no longer exist in tempest.","commit_id":"d9d7b11b08495f2d22b23ce7e56e670c1e0286b8"}],"recipes/setup.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"901cbe6cc78ab6f52fcd5d43420dd2a8891ec023","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# merge all config options and secrets to be used in the nova.conf.erb"},{"line_number":178,"context_line":"integration_test_conf_options \u003d merge_config_options \u0027integration-test\u0027"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"nova_user \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027user\u0027]"},{"line_number":181,"context_line":"nova_group \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027group\u0027]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# create the keystone.conf from attributes"},{"line_number":184,"context_line":"template \u0027/opt/tempest/etc/tempest.conf\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_7a5c644b","side":"PARENT","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":50},"updated":"2020-01-29 11:38:31.000000000","message":"I\u0027m assuming you are deleting this because you cannot assume those attributes to be defined anymore.\n\nBut what will happen when someone has changed the default in their deployment, won\u0027t that imply that the discover call below will fail?","commit_id":"4c2082764b83bb71572340984e0d0d58e51d7485"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"a3c3b5843284c7836d78ee277219534ded9fa85d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# merge all config options and secrets to be used in the nova.conf.erb"},{"line_number":178,"context_line":"integration_test_conf_options \u003d merge_config_options \u0027integration-test\u0027"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"nova_user \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027user\u0027]"},{"line_number":181,"context_line":"nova_group \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027group\u0027]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# create the keystone.conf from attributes"},{"line_number":184,"context_line":"template \u0027/opt/tempest/etc/tempest.conf\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_edd644c4","side":"PARENT","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":50},"in_reply_to":"3fa7e38b_7a5c644b","updated":"2020-01-29 18:23:21.000000000","message":"Yes, I was trying to avoid additional dependencies just to get the user/group for nova. I think it might be better if I just add some attributes in integration-test to work around that situation. Since this shouldn\u0027t be used in production, I wasn\u0027t that worried about it.","commit_id":"4c2082764b83bb71572340984e0d0d58e51d7485"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"901cbe6cc78ab6f52fcd5d43420dd2a8891ec023","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    action [:create, :grant_role, :grant_domain]"},{"line_number":78,"context_line":"  end"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  heat_stack_user_role \u003d node[\u0027openstack\u0027][\u0027integration-test\u0027][\u0027heat_stack_user_role\u0027]"},{"line_number":81,"context_line":"  openstack_role heat_stack_user_role do"},{"line_number":82,"context_line":"    connection_params connection_params"},{"line_number":83,"context_line":"    only_if { service_available[\u0027heat\u0027] }"},{"line_number":84,"context_line":"  end"},{"line_number":85,"context_line":"end"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"include_recipe \u0027openstack-common\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_1a62103e","line":84,"range":{"start_line":80,"start_character":2,"end_line":84,"end_character":5},"updated":"2020-01-29 11:38:31.000000000","message":"Looks like this should happen outside of the loop and thus be executed only once.","commit_id":"d9d7b11b08495f2d22b23ce7e56e670c1e0286b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"901cbe6cc78ab6f52fcd5d43420dd2a8891ec023","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  conf_secrets[\u0027auth\u0027][\u0027admin_project_name\u0027] \u003d admin_project"},{"line_number":179,"context_line":"end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# merge all config options and secrets to be used in the nova.conf.erb"},{"line_number":182,"context_line":"integration_test_conf_options \u003d merge_config_options \u0027integration-test\u0027"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"template \u0027/opt/tempest/etc/tempest-blacklist\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3fa7e38b_3aa4ac4b","line":181,"range":{"start_line":181,"start_character":57,"end_line":181,"end_character":61},"updated":"2020-01-29 11:38:31.000000000","message":"tempest","commit_id":"d9d7b11b08495f2d22b23ce7e56e670c1e0286b8"}]}