)]}'
{"spec/balancer_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"ae89fa8ef671843c0f798235b971ece571a8a925","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^interface_driver \u003d neutron.agent.linux.interface.BridgeInterfaceDriver$/)"},{"line_number":70,"context_line":"        end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        it \u0027displays the a null interface driver setting for other lbaas plugins\u0027 do"},{"line_number":73,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas_plugin\u0027] \u003d \u0027another_lbaas-plugin\u0027"},{"line_number":74,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^interface_driver \u003d$/)"},{"line_number":75,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_ed6665ec","line":72,"updated":"2014-09-03 18:22:52.000000000","message":"wording?","commit_id":"57cdef2436efdaa5dd950ceb282600699e1656e2"},{"author":{"_account_id":10791,"name":"Federico Gimenez","email":"fgimenez@canonical.com","username":"fgimenez"},"change_message_id":"e4fbc4d9b9bc530cdcb95186f52e5148b166a1bc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^interface_driver \u003d neutron.agent.linux.interface.BridgeInterfaceDriver$/)"},{"line_number":70,"context_line":"        end"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        it \u0027displays the a null interface driver setting for other lbaas plugins\u0027 do"},{"line_number":73,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas_plugin\u0027] \u003d \u0027another_lbaas-plugin\u0027"},{"line_number":74,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^interface_driver \u003d$/)"},{"line_number":75,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_7bd0aff7","line":72,"in_reply_to":"fa98f980_ed6665ec","updated":"2014-09-19 13:37:05.000000000","message":"Done","commit_id":"57cdef2436efdaa5dd950ceb282600699e1656e2"}],"spec/common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"ae89fa8ef671843c0f798235b971ece571a8a925","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^nova_admin_password \u003d nova-pass$/)"},{"line_number":245,"context_line":"        end"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # TODO: set the expectation for nova_admin_auth_url when it will be fixed (now it is set to the output of the"},{"line_number":248,"context_line":"        # :to_s method called on the object returned by an :endpoint call)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        it \u0027sets the misc_neutron values\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_8ddb194e","line":247,"updated":"2014-09-03 18:22:52.000000000","message":"Maybe create a bug for this?","commit_id":"57cdef2436efdaa5dd950ceb282600699e1656e2"},{"author":{"_account_id":10791,"name":"Federico Gimenez","email":"fgimenez@canonical.com","username":"fgimenez"},"change_message_id":"e4fbc4d9b9bc530cdcb95186f52e5148b166a1bc","unresolved":false,"context_lines":[{"line_number":244,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^nova_admin_password \u003d nova-pass$/)"},{"line_number":245,"context_line":"        end"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # TODO: set the expectation for nova_admin_auth_url when it will be fixed (now it is set to the output of the"},{"line_number":248,"context_line":"        # :to_s method called on the object returned by an :endpoint call)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        it \u0027sets the misc_neutron values\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_bb1f77b6","line":247,"in_reply_to":"fa98f980_8ddb194e","updated":"2014-09-19 13:37:05.000000000","message":"After digging a little further in the code I\u0027ve seen that endpoint returns a URI object, in the next patchset I\u0027ve added a to_s to the double","commit_id":"57cdef2436efdaa5dd950ceb282600699e1656e2"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"79e959b5dbd00f4ad6be60586745f6325dbfe948","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":25,"context_line":"          user: \u0027neutron\u0027,"},{"line_number":26,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":27,"context_line":"          mode: 0640"},{"line_number":28,"context_line":"        )"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa98f980_da7b4bf2","line":27,"updated":"2014-09-19 20:22:20.000000000","message":"Can\u0027t change this without also changing the recipe, right?  And no need for this change as no pwds are in here I believe.","commit_id":"5d279614259c753072502c28566a8541b62a26ef"},{"author":{"_account_id":10791,"name":"Federico Gimenez","email":"fgimenez@canonical.com","username":"fgimenez"},"change_message_id":"2646922f5433a8bba3147973be09c39c764d61fa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":25,"context_line":"          user: \u0027neutron\u0027,"},{"line_number":26,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":27,"context_line":"          mode: 0640"},{"line_number":28,"context_line":"        )"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da9df570_5abb44c4","line":27,"in_reply_to":"fa98f980_da7b4bf2","updated":"2014-09-20 10:33:24.000000000","message":"Sure, this is related to the other comment, I misplaced the file modes, already fixed","commit_id":"5d279614259c753072502c28566a8541b62a26ef"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"79e959b5dbd00f4ad6be60586745f6325dbfe948","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":55,"context_line":"          user: \u0027neutron\u0027,"},{"line_number":56,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":57,"context_line":"          mode: 0644"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"      end"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa98f980_9a71c30e","line":57,"updated":"2014-09-19 20:22:20.000000000","message":"This has changed now to 640 via another patch.","commit_id":"5d279614259c753072502c28566a8541b62a26ef"},{"author":{"_account_id":10791,"name":"Federico Gimenez","email":"fgimenez@canonical.com","username":"fgimenez"},"change_message_id":"2646922f5433a8bba3147973be09c39c764d61fa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":55,"context_line":"          user: \u0027neutron\u0027,"},{"line_number":56,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":57,"context_line":"          mode: 0644"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"      end"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da9df570_7ab008de","line":57,"in_reply_to":"fa98f980_9a71c30e","updated":"2014-09-20 10:33:24.000000000","message":"Done","commit_id":"5d279614259c753072502c28566a8541b62a26ef"}]}
