)]}'
{"recipes/default.rb":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"3bef2142b9e821b4c0b4b8e119d677dc3d78482a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  mq_password \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027qpid\u0027][\u0027username\u0027]"},{"line_number":117,"context_line":"end"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity-api\u0027"},{"line_number":120,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":121,"context_line":"auth_uri \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_68c0e8e0","line":119,"updated":"2015-02-03 06:48:25.000000000","message":"While it may be very possible that this should be the internal_endpoint in the config and elsewhere the variable identity_endpoint seems to suggest it\u0027s the normal public_endpoint.\n\nAlso will internal_endpoint return correctly with the string \"identity-api\"?","commit_id":"6fda460a39c6d6bf7900440ffcb0dd47d7190552"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"7a0be1b96d6a214f729f60a54f74312846bed819","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  mq_password \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027qpid\u0027][\u0027username\u0027]"},{"line_number":117,"context_line":"end"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity-api\u0027"},{"line_number":120,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":121,"context_line":"auth_uri \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_8a7df5b3","line":119,"in_reply_to":"da86d52c_4a406656","updated":"2015-02-03 17:23:30.000000000","message":"Ah, I double checked and see that the unit test in identity_registration_spec.rb is not for identity-api. (It shows that internal_endpoint works, but not with \u0027identity-api\u0027 as its input.) I checked the identity cookbook tests and there\u0027s nothing that specifically tests that.  I\u0027ll get something added over there. (E.g. I\u0027ll add it to https://review.openstack.org/#/c/151738/)\n\nThanks for pointing that out!","commit_id":"6fda460a39c6d6bf7900440ffcb0dd47d7190552"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"4b55b2b3ef833cfb4fa7186381978176c56482e4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  mq_password \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027qpid\u0027][\u0027username\u0027]"},{"line_number":117,"context_line":"end"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity-api\u0027"},{"line_number":120,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":121,"context_line":"auth_uri \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da86d52c_4a406656","line":119,"in_reply_to":"da86d52c_68c0e8e0","updated":"2015-02-03 15:17:57.000000000","message":"The main idea behind the type_endpoint routines is that if they don\u0027t find value specified for that type it will then default to what I\u0027ve been calling the general endpoint. This means that things will continue to work just fine for folks who just specify the one endpoint for a service. That endpoint will be used for admin, internal, *and* public.  So yes, the internal_endpoint and public_endpoint routines will return the same value but only in the case where just the general endpoint was defined.\n\nBTW, the \"identity-api\u0027 and \u0027identity-admin\u0027 endpoints are something that I\u0027d like to clean up where \u0027identity-admin\u0027 would be replaced by admin_endpoint \u0027identity-api\u0027.   I\u0027d rather not do it this time around just because I\u0027m trying to keep everything backward compatible.\n\nAs for internal_endpoint working with \u0027identity-api\u0027, please see test \u0027with different internal url values\u0027 in spec/identity_registration_spec.rb.","commit_id":"6fda460a39c6d6bf7900440ffcb0dd47d7190552"}]}