)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"313f37ef685a19bc0d79e111cf87c14dbe16dd15","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"    \u0027neutron_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027openstack-neutron-ml2\u0027, \u0027iproute\u0027],"},{"line_number":1046,"context_line":"    \u0027neutron_client_packages\u0027 \u003d\u003e [\u0027python-neutronclient\u0027],"},{"line_number":1047,"context_line":"    \u0027neutron_dhcp_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027],"},{"line_number":1048,"context_line":"    \u0027neutron_l3_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027, \u0027radvd\u0027, \u0027python-neutron-fwaas\u0027],"},{"line_number":1049,"context_line":"    \u0027neutron_vpn_packages\u0027 \u003d\u003e [\u0027python-neutron-vpnaas\u0027, \u0027iproute\u0027],"},{"line_number":1050,"context_line":"    \u0027vpn_device_driver_packages\u0027 \u003d\u003e [\u0027openswan\u0027],"},{"line_number":1051,"context_line":"    \u0027neutron_lb_packages\u0027 \u003d\u003e [\u0027python-neutron-lbaas\u0027, \u0027haproxy\u0027, \u0027iproute\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_148b0369","line":1048,"updated":"2015-03-12 05:36:32.000000000","message":"whether to enable fwaas by setting the boolean value, but your put fwaas packages in neutron_l3_packages,  if we enable l3 and disable fwaas, the fwaas packages will be installed, which is not needed.","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"5f2b892c9af6ecb9b0e2351b1e0ac53d67a450c4","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"    \u0027neutron_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027openstack-neutron-ml2\u0027, \u0027iproute\u0027],"},{"line_number":1046,"context_line":"    \u0027neutron_client_packages\u0027 \u003d\u003e [\u0027python-neutronclient\u0027],"},{"line_number":1047,"context_line":"    \u0027neutron_dhcp_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027],"},{"line_number":1048,"context_line":"    \u0027neutron_l3_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027, \u0027radvd\u0027, \u0027python-neutron-fwaas\u0027],"},{"line_number":1049,"context_line":"    \u0027neutron_vpn_packages\u0027 \u003d\u003e [\u0027python-neutron-vpnaas\u0027, \u0027iproute\u0027],"},{"line_number":1050,"context_line":"    \u0027vpn_device_driver_packages\u0027 \u003d\u003e [\u0027openswan\u0027],"},{"line_number":1051,"context_line":"    \u0027neutron_lb_packages\u0027 \u003d\u003e [\u0027python-neutron-lbaas\u0027, \u0027haproxy\u0027, \u0027iproute\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_6b41bd38","line":1048,"in_reply_to":"9a80dd14_148b0369","updated":"2015-03-12 07:04:31.000000000","message":"This is reasonable, l3 agent has a close dependency on fwaas, after refactoring l3 agnet, it will import firewall_l3_agent from neutron_fwaas, so python-neutron-fwaas should be installed as well as enabling l3 agent.Here is the code link:\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L52","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"e045670042b458411c9c3089f71c62235855c18c","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"    \u0027neutron_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027openstack-neutron-ml2\u0027, \u0027iproute\u0027],"},{"line_number":1046,"context_line":"    \u0027neutron_client_packages\u0027 \u003d\u003e [\u0027python-neutronclient\u0027],"},{"line_number":1047,"context_line":"    \u0027neutron_dhcp_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027],"},{"line_number":1048,"context_line":"    \u0027neutron_l3_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027, \u0027radvd\u0027, \u0027python-neutron-fwaas\u0027],"},{"line_number":1049,"context_line":"    \u0027neutron_vpn_packages\u0027 \u003d\u003e [\u0027python-neutron-vpnaas\u0027, \u0027iproute\u0027],"},{"line_number":1050,"context_line":"    \u0027vpn_device_driver_packages\u0027 \u003d\u003e [\u0027openswan\u0027],"},{"line_number":1051,"context_line":"    \u0027neutron_lb_packages\u0027 \u003d\u003e [\u0027python-neutron-lbaas\u0027, \u0027haproxy\u0027, \u0027iproute\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_9a8475b2","line":1048,"in_reply_to":"9a80dd14_31de5440","updated":"2015-03-12 09:55:28.000000000","message":"it is ok","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"cdfba84f79da4a15fff9afbdcfaa00fc846170d6","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"    \u0027neutron_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027openstack-neutron-ml2\u0027, \u0027iproute\u0027],"},{"line_number":1046,"context_line":"    \u0027neutron_client_packages\u0027 \u003d\u003e [\u0027python-neutronclient\u0027],"},{"line_number":1047,"context_line":"    \u0027neutron_dhcp_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027],"},{"line_number":1048,"context_line":"    \u0027neutron_l3_packages\u0027 \u003d\u003e [\u0027openstack-neutron\u0027, \u0027iproute\u0027, \u0027radvd\u0027, \u0027python-neutron-fwaas\u0027],"},{"line_number":1049,"context_line":"    \u0027neutron_vpn_packages\u0027 \u003d\u003e [\u0027python-neutron-vpnaas\u0027, \u0027iproute\u0027],"},{"line_number":1050,"context_line":"    \u0027vpn_device_driver_packages\u0027 \u003d\u003e [\u0027openswan\u0027],"},{"line_number":1051,"context_line":"    \u0027neutron_lb_packages\u0027 \u003d\u003e [\u0027python-neutron-lbaas\u0027, \u0027haproxy\u0027, \u0027iproute\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_31de5440","line":1048,"in_reply_to":"9a80dd14_6b41bd38","updated":"2015-03-12 08:15:21.000000000","message":"Hi Wen Cheng, I think I agree with Jian Li, Do you agree with him?","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"}],"recipes/l3_agent.rb":[{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"5f2b892c9af6ecb9b0e2351b1e0ac53d67a450c4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  end"},{"line_number":97,"context_line":"end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"bash \u0027migrate fwaas database\u0027 do"},{"line_number":100,"context_line":"  timeout node[\u0027openstack\u0027][\u0027network\u0027][\u0027dbsync_timeout\u0027]"},{"line_number":101,"context_line":"  plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"},{"line_number":102,"context_line":"  migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_0b6201ad","line":99,"updated":"2015-03-12 07:04:31.000000000","message":"use only_if to do this operation when enable_fwaas is true","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"cdfba84f79da4a15fff9afbdcfaa00fc846170d6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  end"},{"line_number":97,"context_line":"end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"bash \u0027migrate fwaas database\u0027 do"},{"line_number":100,"context_line":"  timeout node[\u0027openstack\u0027][\u0027network\u0027][\u0027dbsync_timeout\u0027]"},{"line_number":101,"context_line":"  plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"},{"line_number":102,"context_line":"  migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_71e7ec12","line":99,"in_reply_to":"9a80dd14_0b6201ad","updated":"2015-03-12 08:15:21.000000000","message":"addressed","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"313f37ef685a19bc0d79e111cf87c14dbe16dd15","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"},{"line_number":102,"context_line":"  migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""},{"line_number":103,"context_line":"  code \u003c\u003c-EOF"},{"line_number":104,"context_line":"#{migrate_command} upgrade head "},{"line_number":105,"context_line":"EOF"},{"line_number":106,"context_line":"end"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_3482c752","line":104,"updated":"2015-03-12 05:36:32.000000000","message":"remove the space","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"cdfba84f79da4a15fff9afbdcfaa00fc846170d6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"},{"line_number":102,"context_line":"  migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""},{"line_number":103,"context_line":"  code \u003c\u003c-EOF"},{"line_number":104,"context_line":"#{migrate_command} upgrade head "},{"line_number":105,"context_line":"EOF"},{"line_number":106,"context_line":"end"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_91e2a0ff","line":104,"in_reply_to":"9a80dd14_3482c752","updated":"2015-03-12 08:15:21.000000000","message":"addressed","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"5f2b892c9af6ecb9b0e2351b1e0ac53d67a450c4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":110,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":111,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":112,"context_line":"  mode   00640"},{"line_number":113,"context_line":"end"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"driver_name \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027interface_driver\u0027].split(\u0027.\u0027).last"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_ebba0de0","line":112,"updated":"2015-03-12 07:04:31.000000000","message":"delete the redundant space","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"cdfba84f79da4a15fff9afbdcfaa00fc846170d6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":110,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":111,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":112,"context_line":"  mode   00640"},{"line_number":113,"context_line":"end"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"driver_name \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027interface_driver\u0027].split(\u0027.\u0027).last"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_b1f164cf","line":112,"in_reply_to":"9a80dd14_ebba0de0","updated":"2015-03-12 08:15:21.000000000","message":"addressed","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"44c3fbc89d65be9be1daea28e87f7ec42bde9ab1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""},{"line_number":104,"context_line":"    code \u003c\u003c-EOF"},{"line_number":105,"context_line":"  #{migrate_command} upgrade head"},{"line_number":106,"context_line":"  EOF"},{"line_number":107,"context_line":"  end"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  template \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a80dd14_3a138967","line":106,"updated":"2015-03-12 09:55:17.000000000","message":"care for align","commit_id":"03b46099c8ab38b01399d9df806cc1e332450133"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"76ce91b3265a1df6324587023872aaa32e08397a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  end"},{"line_number":97,"context_line":"end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027]"},{"line_number":100,"context_line":"  bash \u0027migrate fwaas database\u0027 do"},{"line_number":101,"context_line":"    timeout node[\u0027openstack\u0027][\u0027network\u0027][\u0027dbsync_timeout\u0027]"},{"line_number":102,"context_line":"    plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a80dd14_fe07c0c7","line":99,"updated":"2015-03-14 03:04:16.000000000","message":"I think only_if may be more proper than if here.\nlinks:https://github.com/stackforge/cookbook-openstack-network/search?utf8\u003d%E2%9C%93\u0026q\u003donly_if\u0026type\u003dCode","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"d18fcdc3efbdfc525711eb8a10f9d9027fe45e6b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  end"},{"line_number":97,"context_line":"end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027]"},{"line_number":100,"context_line":"  bash \u0027migrate fwaas database\u0027 do"},{"line_number":101,"context_line":"    timeout node[\u0027openstack\u0027][\u0027network\u0027][\u0027dbsync_timeout\u0027]"},{"line_number":102,"context_line":"    plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a80dd14_1a6d72cc","line":99,"in_reply_to":"9a80dd14_fe07c0c7","updated":"2015-03-15 12:24:16.000000000","message":"addressed.\nThanks for give the advise.","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"28d8d3563cd9fd4b41a588fcb2499176daf94458","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    EOF"},{"line_number":107,"context_line":"  end"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  template \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027 do"},{"line_number":110,"context_line":"    source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":111,"context_line":"    user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":112,"context_line":"    group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a80dd14_2105d979","line":109,"updated":"2015-03-13 15:08:33.000000000","message":"Does any service need to be restarted to pickup these changes?","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"76ce91b3265a1df6324587023872aaa32e08397a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    EOF"},{"line_number":107,"context_line":"  end"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  template \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027 do"},{"line_number":110,"context_line":"    source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":111,"context_line":"    user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":112,"context_line":"    group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a80dd14_7ec6709b","line":109,"in_reply_to":"9a80dd14_2105d979","updated":"2015-03-14 03:04:16.000000000","message":"Service neutron-l3-agent should be notified.","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"d18fcdc3efbdfc525711eb8a10f9d9027fe45e6b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    EOF"},{"line_number":107,"context_line":"  end"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  template \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027 do"},{"line_number":110,"context_line":"    source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":111,"context_line":"    user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":112,"context_line":"    group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a80dd14_5a6a8ab3","line":109,"in_reply_to":"9a80dd14_2105d979","updated":"2015-03-15 12:24:16.000000000","message":"yes, you are right. Have addressed that.\nThanks very much for your review.","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"4ea99e4cc17e613c45c6ba9a6459b28a09702b97","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Only if the fwaas is enabled, migrate the database."},{"line_number":100,"context_line":"bash \u0027migrate fwaas database\u0027 do"},{"line_number":101,"context_line":"  only_if { node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027] \u003d\u003d true }"},{"line_number":102,"context_line":"  timeout node[\u0027openstack\u0027][\u0027network\u0027][\u0027dbsync_timeout\u0027]"},{"line_number":103,"context_line":"  plugin_config_file \u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027]"},{"line_number":104,"context_line":"  migrate_command \u003d \"neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf --config-file #{plugin_config_file}\""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a80dd14_642251ba","line":101,"updated":"2015-03-16 02:06:42.000000000","message":"To be exactly, when using enable_fwaas to replace enabled option in fwaas_driver.ini.erb, it should be a string, but may user always misused it with bool, so I think use only_if [true, \u0027true\u0027, \u0027True\u0027].include?(node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027]) is better","commit_id":"92d1c169b09ada87a7636dc589d13c2448a75978"}],"spec/l3_agent_spec.rb":[{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"5f2b892c9af6ecb9b0e2351b1e0ac53d67a450c4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"      end"},{"line_number":132,"context_line":"    end"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    describe \u0027create ovs bridges\u0027 do"},{"line_number":135,"context_line":"      let(:iplink) { \u0027ip link set eth1 up\u0027 }"},{"line_number":136,"context_line":"      let(:cmd) { \u0027ovs-vsctl add-br br-ex \u0026\u0026 ovs-vsctl add-port br-ex eth1\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a80dd14_cbc38955","line":133,"updated":"2015-03-12 07:04:31.000000000","message":"add db migration spec","commit_id":"488b7268971c529d357a584f1d1b637ce4153e33"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"4ea99e4cc17e613c45c6ba9a6459b28a09702b97","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        it \"displays the driver attribute\" do"},{"line_number":143,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] \u003d \"neutron_fwaas_driver_value\""},{"line_number":144,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^driver \u003d neutron_fwaas_driver_value$/)"},{"line_number":145,"context_line":"        end"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a80dd14_5f3ef4b8","line":143,"updated":"2015-03-16 02:06:42.000000000","message":"you needn\u0027t to override the fwaas_driver option here, just display the default value.","commit_id":"92d1c169b09ada87a7636dc589d13c2448a75978"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"4ea99e4cc17e613c45c6ba9a6459b28a09702b97","unresolved":false,"context_lines":[{"line_number":144,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^driver \u003d neutron_fwaas_driver_value$/)"},{"line_number":145,"context_line":"        end"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        it \"displays the enabled attribute\" do"},{"line_number":148,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027] \u003d \"neutron_fwaas_enabled_value\""},{"line_number":149,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^enabled \u003d neutron_fwaas_enabled_value$/)"},{"line_number":150,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a80dd14_df790494","line":147,"updated":"2015-03-16 02:06:42.000000000","message":"display the default value \u0027True\u0027.\nhttps://github.com/openstack/neutron-fwaas/blob/master/etc/fwaas_driver.ini#L3","commit_id":"92d1c169b09ada87a7636dc589d13c2448a75978"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d2858e83f9793de0db19e952264a06163ef9843b","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        it \u0027displays the fwaas section attributes\u0027 do"},{"line_number":139,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d True$/].each do |line|"},{"line_number":140,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":141,"context_line":"          end"},{"line_number":142,"context_line":"        end"},{"line_number":143,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a80dd14_4f30ea55","line":140,"updated":"2015-03-16 15:54:42.000000000","message":"Missing the enabled attr check here","commit_id":"4884d4368488fab618742b8f6634183caa1fea06"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"5844fb0c172253e1d7b4059f197f3b9524d06b6c","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        it \u0027displays the fwaas section attributes\u0027 do"},{"line_number":139,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d True$/].each do |line|"},{"line_number":140,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":141,"context_line":"          end"},{"line_number":142,"context_line":"        end"},{"line_number":143,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a80dd14_d3cb8a71","line":140,"in_reply_to":"9a80dd14_4f30ea55","updated":"2015-03-17 01:59:31.000000000","message":"Hi Mark, thanks for your review.\nI used \u0027with_section_content\u0027 function. and exec\n[/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriv\ner$/, /^enabled \u003d True$/].each do |line|\nThen the function will check each line of the section [fwaas] in fwaas_driver.ini file.\nThanks","commit_id":"4884d4368488fab618742b8f6634183caa1fea06"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d2858e83f9793de0db19e952264a06163ef9843b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        expect(chef_run).to upgrade_package(\u0027python-neutron-fwaas\u0027)"},{"line_number":147,"context_line":"      end"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      it \u0027uses db upgrade head\u0027 do"},{"line_number":150,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"},{"line_number":151,"context_line":"          --config-file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head)"},{"line_number":152,"context_line":"        expect(chef_run).to run_bash(\u0027migrate fwaas database\u0027).with(code: migrate_cmd)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a80dd14_8fe90281","line":149,"updated":"2015-03-16 15:54:42.000000000","message":"Since the recipe has logic gate around this, need to check for False case in here as well.","commit_id":"4884d4368488fab618742b8f6634183caa1fea06"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"5844fb0c172253e1d7b4059f197f3b9524d06b6c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        expect(chef_run).to upgrade_package(\u0027python-neutron-fwaas\u0027)"},{"line_number":147,"context_line":"      end"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      it \u0027uses db upgrade head\u0027 do"},{"line_number":150,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"},{"line_number":151,"context_line":"          --config-file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head)"},{"line_number":152,"context_line":"        expect(chef_run).to run_bash(\u0027migrate fwaas database\u0027).with(code: migrate_cmd)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a80dd14_5386ba17","line":149,"in_reply_to":"9a80dd14_8fe90281","updated":"2015-03-17 01:59:31.000000000","message":"yes, you are right. thanks","commit_id":"4884d4368488fab618742b8f6634183caa1fea06"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1c973f25fcec90e3f69c6324cc5603b911c37050","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"      end"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      it \u0027creates fwaas_driver.ini when fwaasis is not enabled\u0027 do"},{"line_number":134,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":135,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":136,"context_line":"          user: \u0027neutron\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a80dd14_1693395d","line":133,"updated":"2015-03-17 13:52:57.000000000","message":"This seems weird, why not add the same gate to the ini template resource, so it\u0027s NOT created when fwaas is NOT enabled.   Is there any reason to have this created with it disabled?","commit_id":"79f68e94fa38307d17fc711dd327ecf255aa6863"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"078fe0df1b47c48d489bbed2b4d05274a8aa5d32","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"      end"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      it \u0027creates fwaas_driver.ini when fwaasis is not enabled\u0027 do"},{"line_number":134,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":135,"context_line":"        expect(chef_run).to create_template(file.name).with("},{"line_number":136,"context_line":"          user: \u0027neutron\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a80dd14_38566707","line":133,"in_reply_to":"9a80dd14_1693395d","updated":"2015-03-17 14:31:54.000000000","message":"Yes, l3 agent has a close dependency on fwaas, after refactoring l3 agnet, it will import firewall_l3_agent from neutron_fwaas, so python-neutron-fwaas should be installed as well as enabling l3 agent. After the the python-neutron-fwaas package is installed, there will be a fwaas_driver.ini The difference between enable for disable fwaas, reflected in \u0027enabled\u0027 attribute in the configuration file fwaas_dirver.ini.","commit_id":"79f68e94fa38307d17fc711dd327ecf255aa6863"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"90eef809390d45649cafde877c4b808e0da5ad01","unresolved":false,"context_lines":[{"line_number":137,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":138,"context_line":"          mode: 0640"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":143,"context_line":"        it_behaves_like \u0027custom template banner displayer\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_64e73ead","line":140,"updated":"2015-03-18 02:16:10.000000000","message":"Hi, in my comprehension, this section is used to test if the fwaas_driver.ini is created from the template, and do not care about the content, so it\u0027s the same,  no matter fwaas is enabled or disabled, and we just need to check it once, am I right?","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"4d04a8b13e89478dcf1a823b365d7811f7196208","unresolved":false,"context_lines":[{"line_number":137,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":138,"context_line":"          mode: 0640"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":143,"context_line":"        it_behaves_like \u0027custom template banner displayer\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_e79df067","line":140,"in_reply_to":"9a80dd14_64e73ead","updated":"2015-03-18 02:24:13.000000000","message":"Although we know the fwaas_driver.ini is created always, we should still test that. The UT will cover cases as more as possible. The test case just confirm the situation when enabled\u003d\u0027False\u0027","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"c47aa7a1665bb3a1c1a74a271ae175dd5e4829be","unresolved":false,"context_lines":[{"line_number":137,"context_line":"          group: \u0027neutron\u0027,"},{"line_number":138,"context_line":"          mode: 0640"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":143,"context_line":"        it_behaves_like \u0027custom template banner displayer\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_87b8b476","line":140,"in_reply_to":"9a80dd14_64e73ead","updated":"2015-03-18 02:34:50.000000000","message":"got that, addressed","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"90eef809390d45649cafde877c4b808e0da5ad01","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      it \u0027upgrades neutron fwaas package when fwaas is not enabled\u0027 do"},{"line_number":166,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":167,"context_line":"        expect(chef_run).to upgrade_package(\u0027python-neutron-fwaas\u0027)"},{"line_number":168,"context_line":"      end"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      it \u0027uses db upgrade head\u0027 do"},{"line_number":171,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_8414324e","line":168,"updated":"2015-03-18 02:16:10.000000000","message":"Due to dependency with l3 agent, no matter fwaas is enabled or disabled, python-neutron-fwaas always be installed, so check it once.","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"4d04a8b13e89478dcf1a823b365d7811f7196208","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      it \u0027upgrades neutron fwaas package when fwaas is not enabled\u0027 do"},{"line_number":166,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":167,"context_line":"        expect(chef_run).to upgrade_package(\u0027python-neutron-fwaas\u0027)"},{"line_number":168,"context_line":"      end"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      it \u0027uses db upgrade head\u0027 do"},{"line_number":171,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_c7754c34","line":168,"in_reply_to":"9a80dd14_8414324e","updated":"2015-03-18 02:24:13.000000000","message":"As I said that in the above comment, UT is just cover all case, here we should use UT to make sure then enabled\u003d\u0027False\u0027 the package is still installed. Do you agree?","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"c47aa7a1665bb3a1c1a74a271ae175dd5e4829be","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      it \u0027upgrades neutron fwaas package when fwaas is not enabled\u0027 do"},{"line_number":166,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":167,"context_line":"        expect(chef_run).to upgrade_package(\u0027python-neutron-fwaas\u0027)"},{"line_number":168,"context_line":"      end"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      it \u0027uses db upgrade head\u0027 do"},{"line_number":171,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_c7a9cc26","line":168,"in_reply_to":"9a80dd14_8414324e","updated":"2015-03-18 02:34:50.000000000","message":"got that,addressed","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"90eef809390d45649cafde877c4b808e0da5ad01","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      end"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"      it \u0027not uses db upgrade head\u0027 do"},{"line_number":177,"context_line":"        # when fwaas is not enabled, do not migrate db"},{"line_number":178,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":179,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"},{"line_number":180,"context_line":"          --config-file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head)"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_c7d62c53","line":177,"updated":"2015-03-18 02:16:10.000000000","message":"move this comment to the it message, like \"don\u0027t use db upgrade head when fwaas is disabled\",so you can see it from the output of the UT, this may be a little clear.","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"4d04a8b13e89478dcf1a823b365d7811f7196208","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      end"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"      it \u0027not uses db upgrade head\u0027 do"},{"line_number":177,"context_line":"        # when fwaas is not enabled, do not migrate db"},{"line_number":178,"context_line":"        node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":179,"context_line":"        migrate_cmd \u003d %r(neutron-db-manage --service fwaas --config-file /etc/neutron/neutron.conf|"},{"line_number":180,"context_line":"          --config-file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head)"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a80dd14_c79c6c5e","line":177,"in_reply_to":"9a80dd14_c7d62c53","updated":"2015-03-18 02:24:13.000000000","message":"ok, that great","commit_id":"0e6d808ed564f1823594d6406b0c3abcaf5b343e"},{"author":{"_account_id":9978,"name":"Pierre Rambaud","email":"pierre.rambaud@numergy.com","username":"GoT"},"change_message_id":"99346483a645528d7658e825e4c87df8334acc3e","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":134,"context_line":"        it_behaves_like \u0027custom template banner displayer\u0027 do"},{"line_number":135,"context_line":"          let(:file_name) { file.name }"},{"line_number":136,"context_line":"        end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is enabled\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a80dd14_a5711ee0","line":135,"updated":"2015-03-18 13:12:57.000000000","message":"Why setting file_name variable here and never use it?","commit_id":"ce2ae14df04e9773b7e034439311b922225268b5"},{"author":{"_account_id":9978,"name":"Pierre Rambaud","email":"pierre.rambaud@numergy.com","username":"GoT"},"change_message_id":"3ca528da08ec64e5c7e30637266f388b48ab882b","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":134,"context_line":"        it_behaves_like \u0027custom template banner displayer\u0027 do"},{"line_number":135,"context_line":"          let(:file_name) { file.name }"},{"line_number":136,"context_line":"        end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is enabled\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a80dd14_40121063","line":135,"in_reply_to":"9a80dd14_a5711ee0","updated":"2015-03-18 13:27:38.000000000","message":"My bad, it\u0027s about this line: https://github.com/stackforge/cookbook-openstack-network/blob/6ec0caf1815f5de0383a43e24f3e76d800d646df/spec/spec_helper.rb#L149","commit_id":"ce2ae14df04e9773b7e034439311b922225268b5"}],"templates/default/services/neutron-fwaas/fwaas_driver.ini.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"28d8d3563cd9fd4b41a588fcb2499176daf94458","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[fwaas]"},{"line_number":2,"context_line":"driver \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] %\u003e"},{"line_number":3,"context_line":"enabled \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"9a80dd14_211319b9","line":1,"updated":"2015-03-13 15:08:33.000000000","message":"Please add banner in here, and then use the custom template banner displayer\u0027  spec test","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"28d8d3563cd9fd4b41a588fcb2499176daf94458","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[fwaas]"},{"line_number":2,"context_line":"driver \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] %\u003e"},{"line_number":3,"context_line":"enabled \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"9a80dd14_6180b1bf","line":2,"updated":"2015-03-13 15:08:33.000000000","message":"I don\u0027t see these 2 being tested.  Please use the new Common library matcher to check for correct section. thx.","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"d18fcdc3efbdfc525711eb8a10f9d9027fe45e6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[fwaas]"},{"line_number":2,"context_line":"driver \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] %\u003e"},{"line_number":3,"context_line":"enabled \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_fwaas\u0027] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"9a80dd14_7a658edf","line":2,"in_reply_to":"9a80dd14_6180b1bf","updated":"2015-03-15 12:24:16.000000000","message":"have addressed the two comments. Thanks for your comments.","commit_id":"01499d7ae2c3a03939e6bad742999bae6bb45bdb"}]}