)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":410,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027vpn\u0027][\u0027ipsec_status_check_interval\u0027] \u003d 60"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"# Custom the vpnaas config file path"},{"line_number":413,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027vpn\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-vpnaas/vpn_agent.ini\u0027"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Metadata Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da9b358b_6b6a0df0","line":413,"updated":"2015-04-01 13:31:33.000000000","message":"Default should be for ubuntu,  /etc/neutron","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":410,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027vpn\u0027][\u0027ipsec_status_check_interval\u0027] \u003d 60"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"# Custom the vpnaas config file path"},{"line_number":413,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027vpn\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-vpnaas/vpn_agent.ini\u0027"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Metadata Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_a35e8474","line":413,"in_reply_to":"da9b358b_6b6a0df0","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"# Custom the lbaas config file path"},{"line_number":435,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"# Set lbaas plugin"},{"line_number":438,"context_line":"# Supported types are: \u0027ovs\u0027 (ovs based plugins(OVS, Ryu, NEC, NVP, BigSwitch/Floodlight))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da9b358b_0b7a61bd","line":435,"updated":"2015-04-01 13:31:33.000000000","message":"default for ubuntu","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":432,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas\u0027][\u0027enabled\u0027] \u003d \u0027False\u0027"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"# Custom the lbaas config file path"},{"line_number":435,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027lbaas\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"# Set lbaas plugin"},{"line_number":438,"context_line":"# Supported types are: \u0027ovs\u0027 (ovs based plugins(OVS, Ryu, NEC, NVP, BigSwitch/Floodlight))"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_434e98c2","line":435,"in_reply_to":"da9b358b_0b7a61bd","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":457,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] \u003d \u0027neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\u0027"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"# Custom the fwaas config file path"},{"line_number":460,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d OVS Plugin Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da9b358b_eb761dd6","line":460,"updated":"2015-04-01 13:31:33.000000000","message":"ubuntu default","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":457,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027driver\u0027] \u003d \u0027neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\u0027"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"# Custom the fwaas config file path"},{"line_number":460,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027config_file\u0027] \u003d \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d OVS Plugin Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_a3d564ba","line":460,"in_reply_to":"da9b358b_eb761dd6","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"}],"recipes/l3_agent.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    agent_mode \u003d \u0027dvr\u0027"},{"line_number":84,"context_line":"  end"},{"line_number":85,"context_line":"end"},{"line_number":86,"context_line":"template \u0027/etc/neutron/l3_agent.ini\u0027 do"},{"line_number":87,"context_line":"  source \u0027l3_agent.ini.erb\u0027"},{"line_number":88,"context_line":"  owner node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":89,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_24efc188","line":86,"updated":"2015-03-31 15:26:55.000000000","message":"line break above here?","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# As the fwaas package will be installed anyway, configure its config-file attributes following environment."},{"line_number":100,"context_line":"template \u0027/etc/neutron/services/neutron-fwaas/fwaas_driver.ini\u0027 do"},{"line_number":101,"context_line":"  source \u0027services/neutron-fwaas/fwaas_driver.ini.erb\u0027"},{"line_number":102,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":103,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_5fe85010","line":100,"updated":"2015-03-31 15:26:55.000000000","message":"his will still fail on ubuntu and rhel, see bug https://bugs.launchpad.net/openstack-chef/+bug/1438292 Need to fix this as well so this will pass the basic repo test aio_neutron: https://github.com/stackforge/openstack-chef-repo/blob/master/environments/vagrant-aio-neutron.json","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"}],"recipes/vpn_agent.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  subscribes :restart, \u0027template[/etc/neutron/neutron.conf]\u0027"},{"line_number":67,"context_line":"end"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"template \u0027/etc/neutron/services/neutron-vpnaas/vpn_agent.ini\u0027 do"},{"line_number":70,"context_line":"  source \u0027services/neutron-vpnaas/vpn_agent.ini.erb\u0027"},{"line_number":71,"context_line":"  owner node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":72,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_9fded86b","line":69,"updated":"2015-03-31 15:26:55.000000000","message":"his will still fail on ubuntu and rhel, see bug https://bugs.launchpad.net/openstack-chef/+bug/1438292 Need to fix this as well so this will pass the basic repo test aio_neutron: https://github.com/stackforge/openstack-chef-repo/blob/master/environments/vagrant-aio-neutron.json","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"}],"spec/balancer-redhat_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    include_context \u0027neutron-stubs\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    describe \u0027lbaas_agent.ini\u0027 do"},{"line_number":17,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027) }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"      it \u0027creates lbaas_agent.ini\u0027 do"},{"line_number":20,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_e09fe2b2","line":17,"updated":"2015-04-01 13:31:33.000000000","message":"default rhel rdo path?","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    include_context \u0027neutron-stubs\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    describe \u0027lbaas_agent.ini\u0027 do"},{"line_number":17,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027) }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"      it \u0027creates lbaas_agent.ini\u0027 do"},{"line_number":20,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_a3168453","line":17,"in_reply_to":"baa041b7_e09fe2b2","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9eaf3aea8d36dc61f86af2e4d6bc4b596c69a5b9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      it \u0027displays user_group as nobody\u0027 do"},{"line_number":28,"context_line":"        expect(chef_run).to render_file(\u0027/etc/neutron/lbaas_agent.ini\u0027).with_content(/^user_group \u003d nobody$/)"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baa041b7_b587d2d6","line":28,"updated":"2015-04-01 16:09:26.000000000","message":"use  file.name here?","commit_id":"2bdad0cb3d927952c243194375e5fb4b590a40c0"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"b0504e849a8edd863eba91e57258627352f7dd1c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      it \u0027displays user_group as nobody\u0027 do"},{"line_number":28,"context_line":"        expect(chef_run).to render_file(\u0027/etc/neutron/lbaas_agent.ini\u0027).with_content(/^user_group \u003d nobody$/)"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baa041b7_91f3a273","line":28,"in_reply_to":"baa041b7_b587d2d6","updated":"2015-04-02 10:59:19.000000000","message":"addressed","commit_id":"2bdad0cb3d927952c243194375e5fb4b590a40c0"}],"spec/balancer_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    describe \u0027lbaas_agent.ini\u0027 do"},{"line_number":37,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      it \u0027creates lbaas_agent.ini\u0027 do"},{"line_number":40,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_7f92f4a0","line":37,"updated":"2015-03-31 15:26:55.000000000","message":"this will still fail on ubuntu and rhel, see bug https://bugs.launchpad.net/openstack-chef/+bug/1438292\nNeed to fix this as well so this will pass the basic repo test  aio_neutron: https://github.com/stackforge/openstack-chef-repo/blob/master/environments/vagrant-aio-neutron.json","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    describe \u0027lbaas_agent.ini\u0027 do"},{"line_number":37,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      it \u0027creates lbaas_agent.ini\u0027 do"},{"line_number":40,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_208dca7b","line":37,"updated":"2015-04-01 13:31:33.000000000","message":"default ubuntu path","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    describe \u0027lbaas_agent.ini\u0027 do"},{"line_number":37,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-lbaas/lbaas_agent.ini\u0027) }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      it \u0027creates lbaas_agent.ini\u0027 do"},{"line_number":40,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_064d3e72","line":37,"in_reply_to":"baa041b7_208dca7b","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"}],"spec/db_migration_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    it \u0027does not use db upgrade head when vpnaas is not enabled\u0027 do"},{"line_number":37,"context_line":"      node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027] \u003d false"},{"line_number":38,"context_line":"      migrate_cmd \u003d %r(neutron-db-manage --service vpnaas --config-file /etc/neutron/neutron.conf|"},{"line_number":39,"context_line":"        --config-file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head)"},{"line_number":40,"context_line":"      expect(chef_run).not_to run_bash(\u0027migrate vpnaas database\u0027).with(code: migrate_cmd)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_5f1e1064","line":37,"updated":"2015-03-31 15:26:55.000000000","message":"this is the default, no need to reset it","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"}],"spec/l3_agent_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        end"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is enabled\u0027 do"},{"line_number":137,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d False$/].each do |line|"},{"line_number":138,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":139,"context_line":"          end"},{"line_number":140,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_3f47cc4c","line":137,"updated":"2015-03-31 15:26:55.000000000","message":"Need to set enable to true here for the \"enabled\" test right?","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"a46f8d1e3982f6fdc0f961cd5845458f6417a2a7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        end"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is enabled\u0027 do"},{"line_number":137,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d False$/].each do |line|"},{"line_number":138,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":139,"context_line":"          end"},{"line_number":140,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_72d45446","line":137,"in_reply_to":"da9b358b_3f47cc4c","updated":"2015-04-01 03:04:59.000000000","message":"Yes, I will address the comment and others from you include the ini file path problem in new patch. Thanks","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4af68564c4148b79b9173313176b7433f6f6cfb4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is not enabled\u0027 do"},{"line_number":143,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027True\u0027"},{"line_number":144,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d True$/].each do |line|"},{"line_number":145,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":146,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_64dca912","line":143,"updated":"2015-03-31 15:26:55.000000000","message":"Why was this changed?  above line states \"not enabled\"\n\nNo need for reset to False, it\u0027s defaulted that way.","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"c5ef5d520d9953f99efa63dfa5ed58e38ad757d0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is not enabled\u0027 do"},{"line_number":143,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027True\u0027"},{"line_number":144,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d True$/].each do |line|"},{"line_number":145,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":146,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_ec9409e3","line":143,"in_reply_to":"da9b358b_64dca912","updated":"2015-04-01 02:09:55.000000000","message":"+1, actually, I think those two ut need not change.","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"a46f8d1e3982f6fdc0f961cd5845458f6417a2a7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        it \u0027displays the fwaas section attributes when fwaas is not enabled\u0027 do"},{"line_number":143,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027enabled\u0027] \u003d \u0027True\u0027"},{"line_number":144,"context_line":"          [/^driver \u003d neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver$/, /^enabled \u003d True$/].each do |line|"},{"line_number":145,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027fwaas\u0027, line)"},{"line_number":146,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_f2d98484","line":143,"in_reply_to":"da9b358b_ec9409e3","updated":"2015-04-01 03:04:59.000000000","message":"yes, I will address the comment in the new patch. Thanks for your advise :)","commit_id":"6b533ca17f30d5226a415cfc6d1a6247780ecf7d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    end"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    describe \u0027fwaas_driver.ini\u0027 do"},{"line_number":121,"context_line":"      let(:file) { chef_run.template(node[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027config_file\u0027]) }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      it \u0027creates fwaas_driver.ini\u0027 do"},{"line_number":124,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da9b358b_46074018","line":121,"updated":"2015-04-01 13:31:33.000000000","message":"should not used the attr here, just hard code the ubuntu file path.","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    end"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    describe \u0027fwaas_driver.ini\u0027 do"},{"line_number":121,"context_line":"      let(:file) { chef_run.template(node[\u0027openstack\u0027][\u0027network\u0027][\u0027fwaas\u0027][\u0027config_file\u0027]) }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      it \u0027creates fwaas_driver.ini\u0027 do"},{"line_number":124,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_a6a9f2e1","line":121,"in_reply_to":"da9b358b_46074018","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"}],"spec/vpn_agent_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7e8fe5a4a287ffc04a5bf702a84337970d783f0b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    describe \u0027vpn_agent.ini\u0027 do"},{"line_number":47,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-vpnaas/vpn_agent.ini\u0027) }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      it \u0027creates vpn_agent.ini\u0027 do"},{"line_number":50,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_005e46e9","line":47,"updated":"2015-04-01 13:31:33.000000000","message":"default ubuntu path","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"855b9ef6751181f4c17063347a0f19537041eeff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    describe \u0027vpn_agent.ini\u0027 do"},{"line_number":47,"context_line":"      let(:file) { chef_run.template(\u0027/etc/neutron/services/neutron-vpnaas/vpn_agent.ini\u0027) }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      it \u0027creates vpn_agent.ini\u0027 do"},{"line_number":50,"context_line":"        expect(chef_run).to create_template(file.name).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baa041b7_c6f2b606","line":47,"in_reply_to":"baa041b7_005e46e9","updated":"2015-04-01 14:08:49.000000000","message":"addressed","commit_id":"6674141e7e521dfc4f5d1fbdc4d79796a5991f43"}]}