)]}'
{"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a56a0b378d414a63f1726e2389f893ed27d595dd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license           \u0027Apache 2.0\u0027"},{"line_number":6,"context_line":"description       \u0027Installs and configures the OpenStack Network API Service and various agents and plugins\u0027"},{"line_number":7,"context_line":"long_description  IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":8,"context_line":"version           \u002711.0.1\u0027"},{"line_number":9,"context_line":"recipe            \u0027openstack-network::client\u0027, \u0027Install packages required for network client\u0027"},{"line_number":10,"context_line":"recipe            \u0027openstack-network::server\u0027, \u0027Installs packages required for a OpenStack Network server\u0027"},{"line_number":11,"context_line":"recipe            \u0027openstack-network::openvswitch\u0027, \u0027Installs packages required for OVS\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_30f5ad82","line":8,"updated":"2015-04-08 15:37:10.000000000","message":"No need to bump this for master development changes that have no  other cookbook dependent on them.","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8aedb2f719092c4c2f7f781a14d832f250c54a86","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license           \u0027Apache 2.0\u0027"},{"line_number":6,"context_line":"description       \u0027Installs and configures the OpenStack Network API Service and various agents and plugins\u0027"},{"line_number":7,"context_line":"long_description  IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":8,"context_line":"version           \u002711.0.1\u0027"},{"line_number":9,"context_line":"recipe            \u0027openstack-network::client\u0027, \u0027Install packages required for network client\u0027"},{"line_number":10,"context_line":"recipe            \u0027openstack-network::server\u0027, \u0027Installs packages required for a OpenStack Network server\u0027"},{"line_number":11,"context_line":"recipe            \u0027openstack-network::openvswitch\u0027, \u0027Installs packages required for OVS\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_78be6566","line":8,"in_reply_to":"9aa53dc9_30f5ad82","updated":"2015-04-09 05:10:54.000000000","message":"Done","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a56a0b378d414a63f1726e2389f893ed27d595dd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  supports os"},{"line_number":18,"context_line":"end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"depends           \u0027openstack-common\u0027, \u0027\u003e\u003d 11.0.0\u0027"},{"line_number":21,"context_line":"depends           \u0027openstack-identity\u0027, \u0027\u003e\u003d 11.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_f0d745eb","line":20,"updated":"2015-04-08 15:37:10.000000000","message":"Will need to bump this to 11.2 right?","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8aedb2f719092c4c2f7f781a14d832f250c54a86","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  supports os"},{"line_number":18,"context_line":"end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"depends           \u0027openstack-common\u0027, \u0027\u003e\u003d 11.0.0\u0027"},{"line_number":21,"context_line":"depends           \u0027openstack-identity\u0027, \u0027\u003e\u003d 11.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_988ec9ce","line":20,"in_reply_to":"9aa53dc9_f0d745eb","updated":"2015-04-09 05:10:54.000000000","message":"Yep","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"}],"spec/default_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b16e580a75921ca6459d02e2feb775646f7e53c6","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 1"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d1$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_017f38ab","line":515,"updated":"2015-04-07 14:28:57.000000000","message":"Since these are already set in common, probably use some different value for this test.  123?","commit_id":"45dae96907cfb1c2ab0bd930be46fe5aee1cbf83"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"3c8695b2f5a62415040270c453baa68ff20c677f","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 1"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d1$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_ec854d59","line":515,"in_reply_to":"9aa53dc9_017f38ab","updated":"2015-04-08 02:15:33.000000000","message":"OK, change to 20. Since 30 is the maximum.","commit_id":"45dae96907cfb1c2ab0bd930be46fe5aee1cbf83"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"90ec38197cb7caaad40eaa62ca775f44c0168237","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 1"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d1$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_b8a86d21","line":515,"in_reply_to":"9aa53dc9_2c68d586","updated":"2015-04-09 05:07:44.000000000","message":"I don\u0027t think we can do those check here. There are so many openstack options, we can not check all the options\u0027 values are fine for openstack.","commit_id":"45dae96907cfb1c2ab0bd930be46fe5aee1cbf83"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4b4f42abd907a15df1387048a8831b3b4e7f8601","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 1"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d1$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_b0be3463","line":515,"in_reply_to":"9aa53dc9_b8a86d21","updated":"2015-04-09 13:42:00.000000000","message":"I agree, we don\u0027t to any range checking today in the cookbooks.  These values are setup by Admin type person and they should know what values are allowed.","commit_id":"45dae96907cfb1c2ab0bd930be46fe5aee1cbf83"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e19ee4970a8d95bf98cc3a6a3f6e7822039a9139","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 1"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d1$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_2c68d586","line":515,"in_reply_to":"9aa53dc9_ec854d59","updated":"2015-04-08 03:03:28.000000000","message":"If this attribute\u0027s value has a maximum, should we do some check to this, maybe user will set a value larger than the maximum?","commit_id":"45dae96907cfb1c2ab0bd930be46fe5aee1cbf83"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a56a0b378d414a63f1726e2389f893ed27d595dd","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 20"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d20$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_908479d4","line":515,"updated":"2015-04-08 15:37:10.000000000","message":"Since this attrs are defined in Common, either remove this node.set and use them directly so we actually test them.  Or add a second set of tests for that.","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"1933f4f50c27303688db1ef3a903e13b8ae8d404","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 20"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d20$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_5ef800c3","line":515,"in_reply_to":"9aa53dc9_1054c050","updated":"2015-04-10 01:58:28.000000000","message":"OK. Thanks for your remind.","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8aedb2f719092c4c2f7f781a14d832f250c54a86","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 20"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d20$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_d85d7148","line":515,"in_reply_to":"9aa53dc9_908479d4","updated":"2015-04-09 05:10:54.000000000","message":"I think remove node.set here before that openstack-common patch merged will result error. Because the existing openstack-common cookbook does not define this attributes.\n\nI\u0027ll remove this node.set until that patch merged.","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3efae040dba7017659010846f5e775bcd4bde657","unresolved":false,"context_lines":[{"line_number":512,"context_line":"          end"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"          it \u0027sets the rabbit_retry_interval\u0027 do"},{"line_number":515,"context_line":"            node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027network\u0027][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027] \u003d 20"},{"line_number":516,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^rabbit_retry_interval\u003d20$/)"},{"line_number":517,"context_line":"          end"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_1054c050","line":515,"in_reply_to":"9aa53dc9_d85d7148","updated":"2015-04-09 13:39:33.000000000","message":"It\u0027s fine to remove these now and just log a comment that this is dependent upon a change in Common.  Once the Common patch gets merged, can just \"recheck no bug\" on this to spin it clean for final reviews.","commit_id":"150d2fc9c7541f44651b445e949df435863bcbe3"}]}