)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"6034739d867ea2645153bdd2ea7d704e6c525e25","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":418,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":419,"context_line":"# manages them."},{"line_number":420,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 0"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d LBaaS Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_1842253f","line":420,"updated":"2015-04-20 14:34:19.000000000","message":"nil is better.","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7899,"name":"Kun Ge","email":"gekun@cn.ibm.com","username":"gekun"},"change_message_id":"5c3988ed7d4344fcd359a9364856ca5241becba3","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":418,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":419,"context_line":"# manages them."},{"line_number":420,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 0"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d LBaaS Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_f8f53183","line":420,"in_reply_to":"dac4157f_1842253f","updated":"2015-04-20 14:49:20.000000000","message":"My intention is to specify the default value of metadata_workers to be 0, which follows the api_workers or rpc_workers in neutron.conf. I don\u0027t think default to nil fulfill my purpose. Pls see: https://github.com/stackforge/cookbook-openstack-network/blob/master/attributes/default.rb#L56; https://github.com/stackforge/cookbook-openstack-network/blob/master/attributes/default.rb#L63","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7899,"name":"Kun Ge","email":"gekun@cn.ibm.com","username":"gekun"},"change_message_id":"87329ddf0614ce83d1fcb845ed271892003484c4","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":418,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":419,"context_line":"# manages them."},{"line_number":420,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 0"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d LBaaS Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_ef52eedc","line":420,"in_reply_to":"dac4157f_cfe29d9f","updated":"2015-04-21 01:16:47.000000000","message":"Mark, thanks for your explanation, I will change the patch accordingly. BTW, the metadata_workers is defined in file: https://github.com/openstack/nova/blob/master/nova/service.py#L92","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5cf34d931ae9819c18ff3f27f9528d53db915751","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":418,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":419,"context_line":"# manages them."},{"line_number":420,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 0"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d LBaaS Agent Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_cfe29d9f","line":420,"in_reply_to":"dac4157f_f8f53183","updated":"2015-04-20 16:21:37.000000000","message":"The metadata_workers are defined here:https://github.com/openstack/neutron/blob/f4a2a7d9c7eca441577e57fae7c75aa1b069d066/neutron/agent/metadata/config.py#L124\n\nIt has one of those messy calc\u0027d defaults based upon cpu_count, which is never good.\n\nWhere the api and rpc workers are defined differently here: https://github.com/openstack/neutron/blob/e898e5e556a4e3fad0023998888dc69fbb5c5ec6/neutron/service.py#L42  with just a Zero.\n\nIn nova work calc\u0027d workers, they are defined as nil (https://github.com/openstack/neutron/blob/e898e5e556a4e3fad0023998888dc69fbb5c5ec6/neutron/service.py#L42)\nand then gated in the template here: https://github.com/stackforge/cookbook-openstack-compute/blob/master/templates/default/nova.conf.erb#L257\n\nNet, I agree with Mars here, use nil as default, and if gate logic in template and specs.","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"}],"spec/metadata_agent_spec.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"c3b0d812ae76c6e021e178f887cb91490ea461be","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        end"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        it \u0027sets the metadata_workers attribute\u0027 do"},{"line_number":89,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d \u0027network_metadata_workers\u0027"},{"line_number":90,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^metadata_workers \u003d network_metadata_workers$/)"},{"line_number":91,"context_line":"        end"},{"line_number":92,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_4f3b1ad2","line":89,"updated":"2015-04-21 01:09:06.000000000","message":"The value should be meaningful.","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"bb3b5e05b37bdf9b1a4a01129bf21a859c754952","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        it \u0027sets the metadata_workers attribute\u0027 do"},{"line_number":89,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 4"},{"line_number":90,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^metadata_workers \u003d 4$/)"},{"line_number":91,"context_line":"        end"},{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"dac4157f_3e45a86f","line":90,"updated":"2015-04-21 13:03:45.000000000","message":"For any new specs, please use the common matcher to allow section to also be checked. See https://github.com/stackforge/cookbook-openstack-network/blob/master/spec/default_spec.rb#L98","commit_id":"a5c99a4992bb9651427578a12605d22d7d2becf6"},{"author":{"_account_id":7899,"name":"Kun Ge","email":"gekun@cn.ibm.com","username":"gekun"},"change_message_id":"fa3e10e76a1ea86e7a68d2e95dce6a7777f801a2","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        it \u0027sets the metadata_workers attribute\u0027 do"},{"line_number":89,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] \u003d 4"},{"line_number":90,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/^metadata_workers \u003d 4$/)"},{"line_number":91,"context_line":"        end"},{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"dac4157f_6f5a4752","line":90,"in_reply_to":"dac4157f_3e45a86f","updated":"2015-04-21 14:20:43.000000000","message":"Done","commit_id":"a5c99a4992bb9651427578a12605d22d7d2becf6"}],"templates/default/metadata_agent.ini.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"6034739d867ea2645153bdd2ea7d704e6c525e25","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Number of separate metadata agent worker processes to spawn.  The default, 0,"},{"line_number":44,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":45,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":46,"context_line":"# manages them."},{"line_number":47,"context_line":"metadata_workers \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"metadata\"][\"metadata_workers\"] %\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Number of backlog requests to configure the metadata server socket with"}],"source_content_type":"application/x-erb","patch_set":2,"id":"dac4157f_18b0e542","line":46,"updated":"2015-04-20 14:34:19.000000000","message":"should add an \"if\" check, if not nil, then configure this attr","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7899,"name":"Kun Ge","email":"gekun@cn.ibm.com","username":"gekun"},"change_message_id":"5c3988ed7d4344fcd359a9364856ca5241becba3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Number of separate metadata agent worker processes to spawn.  The default, 0,"},{"line_number":44,"context_line":"# runs the worker thread in the current process.  Greater than 0 launches that"},{"line_number":45,"context_line":"# number of child processes as metadata agent workers.  The parent process"},{"line_number":46,"context_line":"# manages them."},{"line_number":47,"context_line":"metadata_workers \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"metadata\"][\"metadata_workers\"] %\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Number of backlog requests to configure the metadata server socket with"}],"source_content_type":"application/x-erb","patch_set":2,"id":"dac4157f_58b65d8b","line":46,"in_reply_to":"dac4157f_18b0e542","updated":"2015-04-20 14:49:20.000000000","message":"Pls see my comments in the attribute file. and also: https://github.com/stackforge/cookbook-openstack-network/blob/master/templates/default/neutron.conf.erb#L311; https://github.com/stackforge/cookbook-openstack-network/blob/master/templates/default/neutron.conf.erb#L318","commit_id":"d7f05ca2039ae7c1b92cd7397d7f2ba5a7708bbc"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"bb3b5e05b37bdf9b1a4a01129bf21a859c754952","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# half the number of CPU cores if not speficied explicitly via attribute."},{"line_number":45,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] %\u003e"},{"line_number":46,"context_line":"metadata_workers \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] %\u003e"},{"line_number":47,"context_line":"\u003c% else %\u003e"},{"line_number":48,"context_line":"# metadata_workers \u003d"},{"line_number":49,"context_line":"\u003c% end %\u003e"},{"line_number":50,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dac4157f_1ed544b8","line":47,"updated":"2015-04-21 13:03:45.000000000","message":"I don\u0027t think there\u0027s a need for the else and the # comment line.","commit_id":"a5c99a4992bb9651427578a12605d22d7d2becf6"},{"author":{"_account_id":7899,"name":"Kun Ge","email":"gekun@cn.ibm.com","username":"gekun"},"change_message_id":"fa3e10e76a1ea86e7a68d2e95dce6a7777f801a2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# half the number of CPU cores if not speficied explicitly via attribute."},{"line_number":45,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] %\u003e"},{"line_number":46,"context_line":"metadata_workers \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027network\u0027][\u0027metadata\u0027][\u0027metadata_workers\u0027] %\u003e"},{"line_number":47,"context_line":"\u003c% else %\u003e"},{"line_number":48,"context_line":"# metadata_workers \u003d"},{"line_number":49,"context_line":"\u003c% end %\u003e"},{"line_number":50,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dac4157f_2f2b2f96","line":47,"in_reply_to":"dac4157f_1ed544b8","updated":"2015-04-21 14:20:43.000000000","message":"Done","commit_id":"a5c99a4992bb9651427578a12605d22d7d2becf6"}]}