)]}'
{"recipes/l3_agent.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"48f7bf67de12a51b67e36e4318bf7f429798f3cd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":104,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronize problems when vpn agent and l3 agent both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_1969c78b","line":106,"updated":"2015-05-08 02:35:38.000000000","message":"synchronization ?","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"7d78865572b0df22dccaaf429f1ae806a19175e0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":104,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronize problems when vpn agent and l3 agent both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_59229fba","line":106,"in_reply_to":"1aca2d91_1969c78b","updated":"2015-05-08 03:15:13.000000000","message":"yes, For example, when l3-agent and vpn-agent both running, most of the functions can works well, but there is situation: some changes taken by l3-agent, it should affect vpn-agent. Indeed, some times, it does not. It was the synchronization problem means.\nSo l3-agent and vpn-agent are not advised to running together.","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"a99fe4ba35542de1dc869a48c8ad978b96248120","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":104,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronize problems when vpn agent and l3 agent both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_743c42c8","line":106,"in_reply_to":"1aca2d91_59229fba","updated":"2015-05-08 03:23:39.000000000","message":"yes, should change \"synchronize\" to \"synchronization\"","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"f2fb6ee98e76fa455051eab3e4af8ce4c1e481cc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  user node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":104,"context_line":"  group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronize problems when vpn agent and l3 agent both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_5465c6de","line":106,"in_reply_to":"1aca2d91_743c42c8","updated":"2015-05-08 03:27:13.000000000","message":"oh, thanks for your remind :)","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d9c3f98fbbd24ce229619a8f412a9955392f051e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"},{"line_number":112,"context_line":"    notifies :restart, \u0027service[neutron-l3-agent]\u0027, :immediately"},{"line_number":113,"context_line":"  end"},{"line_number":114,"context_line":"end"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_1b51e30e","line":112,"updated":"2015-05-07 09:45:45.000000000","message":"shouldn\u0027t the l3-agent be disabled when vpn-agent is enabled since they replace each other?","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"653f61025dc32e05ab328a0f437176d3c481defa","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"},{"line_number":112,"context_line":"    notifies :restart, \u0027service[neutron-l3-agent]\u0027, :immediately"},{"line_number":113,"context_line":"  end"},{"line_number":114,"context_line":"end"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_bb7d4f1e","line":112,"in_reply_to":"1aca2d91_1b51e30e","updated":"2015-05-07 09:53:42.000000000","message":"Yes, I think so.\nWhen vpn-agent and l3-agent both running in controller node, there will be potential problem, for example, when some change addressed by l3-agent, vpn-agent did not get the change. They both using the basic l3 code, and they can replaced by each other.","commit_id":"f114c42cbd8284c0375e4c4399e5fcc4c13e84cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"64afd272d522e71fc36625326d6838c261a30866","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronization problems when vpn and l3 agents both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_e6077a1a","line":108,"updated":"2015-05-08 14:44:33.000000000","message":"Maybe move this comment to the above service resource as that is the real place where the service is stopped and disabled.   Then add simple ref comments to where enable_vpn was also needed, line 95 and here line 109.","commit_id":"4aa0894207da5014662c781a571f5e297c05b862"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"8082cdb000d7858b8826cbcfcf5bf047c1bdbb28","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronization problems when vpn and l3 agents both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9af37de9_00175d52","line":108,"in_reply_to":"1aca2d91_56c805a8","updated":"2015-05-11 13:43:58.000000000","message":"I think the detailed comment should go with the service resource around #69.  The in the other places this also effect, a shorter comment ref (#95 #109)","commit_id":"4aa0894207da5014662c781a571f5e297c05b862"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"d5304eb0dc12cef61209f6b3bf3a580479fdc500","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronization problems when vpn and l3 agents both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_56c805a8","line":108,"in_reply_to":"1aca2d91_e6077a1a","updated":"2015-05-09 09:55:27.000000000","message":"Thanks for your advise, just one question:\ncould I add the detail explain comment in line 69 with the current comment for disable l3 in service resource?","commit_id":"4aa0894207da5014662c781a571f5e297c05b862"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"379d7f0e208be39e9fa83359cf8d6837df43db91","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  mode 00640"},{"line_number":106,"context_line":"  # There will be potential synchronization problems when vpn and l3 agents both running in network node."},{"line_number":107,"context_line":"  # Disable l3 agent when vpn is enabled, and restart the vpn agent to enable firewall to make sure only"},{"line_number":108,"context_line":"  # vpn agent is running when vpn is enabled."},{"line_number":109,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027]"},{"line_number":110,"context_line":"    notifies :restart, \u0027service[neutron-vpn-agent]\u0027, :delayed"},{"line_number":111,"context_line":"  else"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a0c5dc1_61e4fa0c","line":108,"in_reply_to":"9af37de9_00175d52","updated":"2015-05-12 06:17:10.000000000","message":"addressed, thank you for advise.","commit_id":"4aa0894207da5014662c781a571f5e297c05b862"}]}