)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ee1301fb5de1981ccec6dc59641db7d3ba65f407","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Neutron Nova interactions \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":225,"context_line":"# Name of the plugin to load"},{"line_number":226,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d \u0027v2password\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# CA file for novaclient to verify server certificates"},{"line_number":229,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027cafile\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5afe65bd_cbdc7214","line":226,"updated":"2015-06-04 01:36:37.000000000","message":"the v2password auth_plugin looks reasonable, \nin fact,  the identity-admin url path is v2.0, https://github.com/stackforge/cookbook-openstack-common/blob/master/attributes/default.rb#L234-238 , \nin another way, can we change [\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-admin\u0027][\u0027path\u0027] to adapt to the version of auth_plugin ?","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"8f7614ce860ad9e073840171cfc5fcf46f75467a","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Neutron Nova interactions \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":225,"context_line":"# Name of the plugin to load"},{"line_number":226,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d \u0027v2password\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# CA file for novaclient to verify server certificates"},{"line_number":229,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027cafile\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5afe65bd_32b137e2","line":226,"in_reply_to":"5afe65bd_cbdc7214","updated":"2015-06-04 06:25:56.000000000","message":"Yes, I think we can use that to adapt the version of auth_plugin. I don\u0027t think it meaningful to use v3password, when openstack common is using v2. So auth_plugin might be ok to follow [\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-admin\u0027][\u0027path\u0027]","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"}],"spec/default_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"69529d33e28d431c28ecfd1e65578e890d162a10","unresolved":false,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        it \u0027sets the nova project_name attribute when auth_plugin is v3password\u0027 do"},{"line_number":694,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d \u0027v3password\u0027"},{"line_number":695,"context_line":"          expect(chef_run).to render_config_file(file.name).with_section_content(\u0027nova\u0027, /^project_name \u003d service$/)"},{"line_number":696,"context_line":"        end"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        it \u0027sets the nova region_name attribute\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5afe65bd_93d251ff","line":695,"updated":"2015-06-03 13:30:39.000000000","message":"maybe combine this with #716?  for dry","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"8f7614ce860ad9e073840171cfc5fcf46f75467a","unresolved":false,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        it \u0027sets the nova project_name attribute when auth_plugin is v3password\u0027 do"},{"line_number":694,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d \u0027v3password\u0027"},{"line_number":695,"context_line":"          expect(chef_run).to render_config_file(file.name).with_section_content(\u0027nova\u0027, /^project_name \u003d service$/)"},{"line_number":696,"context_line":"        end"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        it \u0027sets the nova region_name attribute\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5afe65bd_12ebdbb1","line":695,"in_reply_to":"5afe65bd_93d251ff","updated":"2015-06-04 06:25:56.000000000","message":"yes, that\u0027s a good idea. thanks","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"}],"templates/default/neutron.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"69529d33e28d431c28ecfd1e65578e890d162a10","unresolved":false,"context_lines":[{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project name(using tenant name when auth_plugin\u003dv2password)."},{"line_number":592,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d\u003d \"v2password\" -%\u003e"},{"line_number":593,"context_line":"tenant_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"},{"line_number":594,"context_line":"\u003c% else -%\u003e"},{"line_number":595,"context_line":"project_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"5afe65bd_13c8a121","line":592,"updated":"2015-06-03 13:30:39.000000000","message":"This logic seems very ugly, can we get a reference to the neutron code where this is coming from? (its not mentioned in the commit message)\n\n   Wouldn\u0027t it be easier to just have the key name as an attribute, and add switching it to the existing logic in the recipe?","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"8f7614ce860ad9e073840171cfc5fcf46f75467a","unresolved":false,"context_lines":[{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project name(using tenant name when auth_plugin\u003dv2password)."},{"line_number":592,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027network\u0027][\u0027nova\u0027][\u0027auth_plugin\u0027] \u003d\u003d \"v2password\" -%\u003e"},{"line_number":593,"context_line":"tenant_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"},{"line_number":594,"context_line":"\u003c% else -%\u003e"},{"line_number":595,"context_line":"project_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"5afe65bd_2d58b631","line":592,"in_reply_to":"5afe65bd_13c8a121","updated":"2015-06-04 06:25:56.000000000","message":"the configuration is not parsed by neutron code, it was parsed by keystoneclient directly.\nwhen v2password, it will construct below:\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/auth/identity/v2.py#L52\nwhen v3password, it constructs below:\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/auth/identity/v3/base.py#L50\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nI have tried using project_name in v2password, we faced some error like empty catalog.","commit_id":"68eb5276acdccb484ad1bc6fd7a1d431dc2d15e5"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"567da39a2bf239e2a2825259584ff968ba5fae82","unresolved":false,"context_lines":[{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project name(using tenant_name when auth_plugin\u003dv2password)."},{"line_number":592,"context_line":"\u003c%\u003d @nova_tenant_keyname %\u003e \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# Project\u0027s domain ID for project."},{"line_number":595,"context_line":"project_domain_id \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_domain_id\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":6,"id":"5afe65bd_c907c3c8","line":592,"updated":"2015-06-04 14:51:40.000000000","message":"Just a thought, but another approach would be to just put in both keys, and avoid all this keyname logic?   And then add a good comment in here that explains this ugliness in the keystone python client.","commit_id":"92f167cfd1c1dc0eda87718ff0e34a3897060763"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"ea207967b953b302f165e9dc6e6abe8b3967e18d","unresolved":false,"context_lines":[{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project name(using tenant_name when auth_plugin\u003dv2password)."},{"line_number":592,"context_line":"\u003c%\u003d @nova_tenant_keyname %\u003e \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# Project\u0027s domain ID for project."},{"line_number":595,"context_line":"project_domain_id \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_domain_id\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":6,"id":"3afb71cf_35bbcf10","line":592,"in_reply_to":"5afe65bd_c907c3c8","updated":"2015-06-05 03:13:33.000000000","message":"yes, that\u0027s a good idea, thanks","commit_id":"92f167cfd1c1dc0eda87718ff0e34a3897060763"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f685e3910c7eae6c67fdab9268277949d9ce9b45","unresolved":false,"context_lines":[{"line_number":588,"context_line":"# Password for connection to nova in admin context."},{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project/tenant name. Keystoneclient v2.0 is using tenant_name while v3 is using"},{"line_number":592,"context_line":"# project_name, and neither can be compatible. Keep the tenant_name and project_name"},{"line_number":593,"context_line":"# both existed with same value to fit all the situation."},{"line_number":594,"context_line":"tenant_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"3afb71cf_4288bae7","line":591,"updated":"2015-06-05 16:14:21.000000000","message":"Maybe a bit of rewording?\n\n\n# Project/tenant name. Keystone client v2 requires using tenant_name while v3 requires using project_name. The value for both of them is the same.  Adding both of them to handle both situations.","commit_id":"01e6074cf7db87a77b43fccd3e0431648ccb4385"},{"author":{"_account_id":10486,"name":"Song Li","email":"lisongbj@cn.ibm.com","username":"sbookworm"},"change_message_id":"25e65acc7e3c4c8566898d248e5da5079e8738da","unresolved":false,"context_lines":[{"line_number":588,"context_line":"# Password for connection to nova in admin context."},{"line_number":589,"context_line":"password \u003d \u003c%\u003d @nova_admin_pass %\u003e"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"# Project/tenant name. Keystoneclient v2.0 is using tenant_name while v3 is using"},{"line_number":592,"context_line":"# project_name, and neither can be compatible. Keep the tenant_name and project_name"},{"line_number":593,"context_line":"# both existed with same value to fit all the situation."},{"line_number":594,"context_line":"tenant_name \u003d \u003c%\u003d node[\"openstack\"][\"network\"][\"nova\"][\"project_name\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"3afb71cf_970a5dd1","line":591,"in_reply_to":"3afb71cf_4288bae7","updated":"2015-06-06 14:35:32.000000000","message":"Thanks very much, I will address that next patch :)","commit_id":"01e6074cf7db87a77b43fccd3e0431648ccb4385"}]}