)]}'
{"libraries/utils.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4df0617e01054aa715fe1896559a6de01135fa92","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Library:: utils"},{"line_number":5,"context_line":"module ::Utils"},{"line_number":6,"context_line":"  def recipe_included?(recipe)"},{"line_number":7,"context_line":"    node.recipes.include?(recipe)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  def role_included?(role)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a41bdd9_a0a65351","line":7,"updated":"2015-07-13 14:28:35.000000000","message":"would like to see a test or something to verify this difference.\n\nAlso, we should probably change role_included to be consistent?  Or is it that roles can only be defined in run list?","commit_id":"0030e17d0a062e39648c8341b0dc17f64d9fadbe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fc1e42402d145091d4991c621288c714858c74aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Library:: utils"},{"line_number":5,"context_line":"module ::Utils"},{"line_number":6,"context_line":"  def recipe_included?(recipe)"},{"line_number":7,"context_line":"    node.recipes.include?(recipe)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  def role_included?(role)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a41bdd9_4410dba8","line":7,"in_reply_to":"9a41bdd9_439671f1","updated":"2015-07-17 07:53:42.000000000","message":"Can you explain to a chef-illiterate like me, what exactly the change in behaviour is?\n\nAlso, FC019 seems to say that if you change the access here, you have to change it everywhere in this file.","commit_id":"0030e17d0a062e39648c8341b0dc17f64d9fadbe"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"01b6a1794160324fd6c6e5e28221e66611f6e7fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Library:: utils"},{"line_number":5,"context_line":"module ::Utils"},{"line_number":6,"context_line":"  def recipe_included?(recipe)"},{"line_number":7,"context_line":"    node.recipes.include?(recipe)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  def role_included?(role)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a41bdd9_439671f1","line":7,"in_reply_to":"9a41bdd9_a0a65351","updated":"2015-07-13 14:45:04.000000000","message":"Hmm, I will think about the verification.\n\nChanging role_included to be consistent is good code style here, so it is ok to me, not a big deal. I\u0027m not sure wheter roles can only be defined in run list, but as I known, we have include_recipe, include_context, include_attribute in openstack cookbooks, but I didn\u0027t see include_role yet.\n\nI will try to find something to verify that difference first.","commit_id":"0030e17d0a062e39648c8341b0dc17f64d9fadbe"}]}