)]}'
{"recipes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1c0e4454af2ffd4b53a691590a093f8cf5085786","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  package pkg do"},{"line_number":83,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":84,"context_line":"    action :upgrade"},{"line_number":85,"context_line":"    # The vpn agent is depends on l3_agent, need check providers use the generic L3 agent."},{"line_number":86,"context_line":"    only_if { node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027] \u0026\u0026 role_match \u0026\u0026 ![\u0027nicira\u0027, \u0027plumgrid\u0027, \u0027bigswitch\u0027].include?(main_plugin) }"},{"line_number":87,"context_line":"  end"},{"line_number":88,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa1b9901_8e0c523c","line":85,"updated":"2015-08-20 02:11:19.000000000","message":"Not sure I understand this comment or code.  What does the L3 agent have to do with nicira, plumgrid or bigswitch?\n\nAnd them maybe instead of checking these provider explicitly, why not have a attribute (single or list) to allow this to be data driven, not hard coded.","commit_id":"9d05198f92df14f6a73b246ab67ecccfd973f2f9"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"684daef5d659374d5c2e7fb26dc4cf7c59be5754","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  package pkg do"},{"line_number":83,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":84,"context_line":"    action :upgrade"},{"line_number":85,"context_line":"    # The vpn agent is depends on l3_agent, need check providers use the generic L3 agent."},{"line_number":86,"context_line":"    only_if { node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027] \u0026\u0026 role_match \u0026\u0026 ![\u0027nicira\u0027, \u0027plumgrid\u0027, \u0027bigswitch\u0027].include?(main_plugin) }"},{"line_number":87,"context_line":"  end"},{"line_number":88,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa1b9901_ce656ab5","line":85,"in_reply_to":"fa1b9901_8e0c523c","updated":"2015-08-20 02:17:11.000000000","message":"I find the three providers checking in recipe vpn_agent.rb, these providers do not use the generic L3 agent. Maybe I should keep the previous comments ?","commit_id":"9d05198f92df14f6a73b246ab67ecccfd973f2f9"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"becffa61bc2c6f5c5eff4cdbcc59701601a4cf33","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":"end"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"platform_options[\u0027neutron_lb_packages\u0027].each do |pkg|"},{"line_number":74,"context_line":"  package pkg do"},{"line_number":75,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":76,"context_line":"    action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa1b9901_6c3c63c8","line":73,"updated":"2015-08-20 05:33:01.000000000","message":"I think you should provide more info for this section, not only in commit message.","commit_id":"dce4dc129cedb646846b55f9d125b83e937faa04"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"becffa61bc2c6f5c5eff4cdbcc59701601a4cf33","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  end"},{"line_number":79,"context_line":"end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"platform_options[\u0027neutron_vpn_packages\u0027].each do |pkg|"},{"line_number":82,"context_line":"  package pkg do"},{"line_number":83,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":84,"context_line":"    action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa1b9901_8c39b7d9","line":81,"updated":"2015-08-20 05:33:01.000000000","message":"I think you should provide more info for this section, not only in commit message.","commit_id":"dce4dc129cedb646846b55f9d125b83e937faa04"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"763c8a1d74f2c8219670b8b8f75341a204bca90f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  end"},{"line_number":71,"context_line":"end"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Make sure neutron lbaas packages get installed on network ndoe before neutron-server start/restart, when lbaas is enabled."},{"line_number":74,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find lbaas plugin when invoking plugins from serviec_plugins."},{"line_number":75,"context_line":"platform_options[\u0027neutron_lb_packages\u0027].each do |pkg|"},{"line_number":76,"context_line":"  package pkg do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_af3eed88","line":73,"updated":"2015-08-20 06:22:33.000000000","message":"ndoe to node.","commit_id":"a370e9a76421778d4e1c08fba32fbcc3fecd9e3c"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"763c8a1d74f2c8219670b8b8f75341a204bca90f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"end"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Make sure neutron lbaas packages get installed on network ndoe before neutron-server start/restart, when lbaas is enabled."},{"line_number":74,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find lbaas plugin when invoking plugins from serviec_plugins."},{"line_number":75,"context_line":"platform_options[\u0027neutron_lb_packages\u0027].each do |pkg|"},{"line_number":76,"context_line":"  package pkg do"},{"line_number":77,"context_line":"    options platform_options[\u0027package_overrides\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_6f745567","line":74,"updated":"2015-08-20 06:22:33.000000000","message":"serviec typo","commit_id":"a370e9a76421778d4e1c08fba32fbcc3fecd9e3c"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"763c8a1d74f2c8219670b8b8f75341a204bca90f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Make sure neutron lbaas packages get installed on network ndoe before neutron-server start/restart, when lbaas is enabled."},{"line_number":74,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find lbaas plugin when invoking plugins from serviec_plugins."},{"line_number":75,"context_line":"platform_options[\u0027neutron_lb_packages\u0027].each do |pkg|"},{"line_number":76,"context_line":"  package pkg do"},{"line_number":77,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":78,"context_line":"    action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_cfb6c1f8","line":75,"updated":"2015-08-20 06:22:33.000000000","message":"You should point that this section is used to handle when neutron-server is not running on network node(which lbaas running on) case.","commit_id":"a370e9a76421778d4e1c08fba32fbcc3fecd9e3c"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"763c8a1d74f2c8219670b8b8f75341a204bca90f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"end"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Make sure neutron vpnaas packages get installed on network node before neutron-server start/restart, when vpnaas is enabled."},{"line_number":84,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find vpnaas plugin when invoking plugins from serviec_plugins."},{"line_number":85,"context_line":"platform_options[\u0027neutron_vpn_packages\u0027].each do |pkg|"},{"line_number":86,"context_line":"  package pkg do"},{"line_number":87,"context_line":"    options platform_options[\u0027package_overrides\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa1b9901_ef0625cd","line":84,"updated":"2015-08-20 06:22:33.000000000","message":"typo","commit_id":"a370e9a76421778d4e1c08fba32fbcc3fecd9e3c"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fea15f61d4735d6e16a6e5355cbd24f1fd46e4dc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# neutron-lbaas-agent may not running on network node, but on network node, neutron-server still need neutron_lbaas module"},{"line_number":74,"context_line":"# when loading plugin if lbaas is list in service_plugins. In this case, we don\u0027t need include balance recipe for network node, but"},{"line_number":75,"context_line":"# we need make sure neutron lbaas packages get installed on network ndoe before neutron-server start/restart, when lbaas is enabled."},{"line_number":76,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find lbaas plugin when invoking plugins from serviec_plugins."},{"line_number":77,"context_line":"platform_options[\u0027neutron_lb_packages\u0027].each do |pkg|"},{"line_number":78,"context_line":"  package pkg do"},{"line_number":79,"context_line":"    options platform_options[\u0027package_overrides\u0027]"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa1b9901_a30e018a","line":76,"updated":"2015-08-20 09:16:25.000000000","message":"s/service_plugins/","commit_id":"78bdbec34366d94aaab19d12cbe13a09ec09f259"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fea15f61d4735d6e16a6e5355cbd24f1fd46e4dc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# neutron-vpnaas-agent may not running on network node, but on network node, neutron-server still need neutron_vpnaas module"},{"line_number":86,"context_line":"# when loading plugin if vpnaas is list in service_plugins. In this case, we don\u0027t need include vpn_agent recipe for network node, but"},{"line_number":87,"context_line":"# we need make sure neutron vpnaas packages get installed on network node before neutron-server start/restart, when vpnaas is enabled."},{"line_number":88,"context_line":"# Otherwise neutron-server will crash for couldn\u0027t find vpnaas plugin when invoking plugins from serviec_plugins."},{"line_number":89,"context_line":"platform_options[\u0027neutron_vpn_packages\u0027].each do |pkg|"},{"line_number":90,"context_line":"  package pkg do"},{"line_number":91,"context_line":"    options platform_options[\u0027package_overrides\u0027]"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa1b9901_034c8dc6","line":88,"updated":"2015-08-20 09:16:25.000000000","message":"s/service_plugins/","commit_id":"78bdbec34366d94aaab19d12cbe13a09ec09f259"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fea15f61d4735d6e16a6e5355cbd24f1fd46e4dc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  package pkg do"},{"line_number":91,"context_line":"    options platform_options[\u0027package_overrides\u0027]"},{"line_number":92,"context_line":"    action :upgrade"},{"line_number":93,"context_line":"    # The vpn agent is depends on l3_agent and the providers below do not use the generic L3 agent."},{"line_number":94,"context_line":"    only_if { node[\u0027openstack\u0027][\u0027network\u0027][\u0027enable_vpn\u0027] \u0026\u0026 role_match \u0026\u0026 ![\u0027nicira\u0027, \u0027plumgrid\u0027, \u0027bigswitch\u0027].include?(main_plugin) }"},{"line_number":95,"context_line":"  end"},{"line_number":96,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa1b9901_632469c4","line":93,"updated":"2015-08-20 09:16:25.000000000","message":"remove \"is\", can you explain the ![\u0027nicira\u0027, \u0027plumgrid\u0027, \u0027bigswitch\u0027].include?(main_plugin) judgement ?","commit_id":"78bdbec34366d94aaab19d12cbe13a09ec09f259"}]}