)]}'
{"recipes/default.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"3b7eb23ff513d74b78cf74f31f85705f225b25af","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    owner node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":524,"context_line":"    group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":525,"context_line":"    action :create"},{"line_number":526,"context_line":"    only_if { platform_family? %w(fedora rhel) }"},{"line_number":527,"context_line":"  end"},{"line_number":528,"context_line":"end"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_7190fa43","line":526,"updated":"2016-01-22 07:29:39.000000000","message":"not_if { main_plugin \u003d\u003d \u0027contrail\u0027 }","commit_id":"d3702a147a7fadd52ef01f6c4c073fba13dd04c5"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"39e55bd0f5e6c3c41feab730c10989301a46967d","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    owner node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027user\u0027]"},{"line_number":524,"context_line":"    group node[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027group\u0027]"},{"line_number":525,"context_line":"    action :create"},{"line_number":526,"context_line":"    only_if { platform_family? %w(fedora rhel) }"},{"line_number":527,"context_line":"  end"},{"line_number":528,"context_line":"end"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_31b7e287","line":526,"in_reply_to":"9a68dd71_7190fa43","updated":"2016-01-22 07:37:41.000000000","message":"yes, sounds better.","commit_id":"d3702a147a7fadd52ef01f6c4c073fba13dd04c5"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"85a5097866985d3e2199b06acea159d201d5bbc3","unresolved":false,"context_lines":[{"line_number":507,"context_line":"      enable_distributed_routing: enable_distributed_routing"},{"line_number":508,"context_line":"    )"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    notifies :restart, \u0027service[neutron-server]\u0027, :delayed if role_match"},{"line_number":511,"context_line":"    if node[\u0027recipes\u0027].include?(\u0027openstack-network::openvswitch\u0027)"},{"line_number":512,"context_line":"      notifies :restart, \u0027service[neutron-plugin-openvswitch-agent]\u0027, :delayed"},{"line_number":513,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"9a68dd71_1a366e52","line":510,"range":{"start_line":510,"start_character":0,"end_line":510,"end_character":4},"updated":"2016-01-22 10:27:17.000000000","message":"do your spec tests cover the \u0027template\u0027 , the \"notifies\" ?","commit_id":"6a77bdd83ab5beab8da14596873df0da4ac39120"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"bb454d0ea43406b694f0996e1a8778d66dca7a72","unresolved":false,"context_lines":[{"line_number":507,"context_line":"      enable_distributed_routing: enable_distributed_routing"},{"line_number":508,"context_line":"    )"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    notifies :restart, \u0027service[neutron-server]\u0027, :delayed if role_match"},{"line_number":511,"context_line":"    if node[\u0027recipes\u0027].include?(\u0027openstack-network::openvswitch\u0027)"},{"line_number":512,"context_line":"      notifies :restart, \u0027service[neutron-plugin-openvswitch-agent]\u0027, :delayed"},{"line_number":513,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"9a68dd71_b0e1839c","line":510,"range":{"start_line":510,"start_character":0,"end_line":510,"end_character":4},"in_reply_to":"9a68dd71_1a366e52","updated":"2016-01-22 11:01:32.000000000","message":"OK, will at them.","commit_id":"6a77bdd83ab5beab8da14596873df0da4ac39120"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"0daf47cfc27f7cee677bced3efa0955eb5c8447e","unresolved":false,"context_lines":[{"line_number":507,"context_line":"      enable_distributed_routing: enable_distributed_routing"},{"line_number":508,"context_line":"    )"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    notifies :restart, \u0027service[neutron-server]\u0027, :delayed if role_match"},{"line_number":511,"context_line":"    if node[\u0027recipes\u0027].include?(\u0027openstack-network::openvswitch\u0027)"},{"line_number":512,"context_line":"      notifies :restart, \u0027service[neutron-plugin-openvswitch-agent]\u0027, :delayed"},{"line_number":513,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"9a68dd71_6006d887","line":510,"range":{"start_line":510,"start_character":0,"end_line":510,"end_character":4},"in_reply_to":"9a68dd71_b0e1839c","updated":"2016-01-22 12:41:26.000000000","message":"the spec for template is already included.\nNow I added the spec for notifies.","commit_id":"6a77bdd83ab5beab8da14596873df0da4ac39120"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"85a5097866985d3e2199b06acea159d201d5bbc3","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    notifies :restart, \u0027service[neutron-server]\u0027, :delayed if role_match"},{"line_number":511,"context_line":"    if node[\u0027recipes\u0027].include?(\u0027openstack-network::openvswitch\u0027)"},{"line_number":512,"context_line":"      notifies :restart, \u0027service[neutron-plugin-openvswitch-agent]\u0027, :delayed"},{"line_number":513,"context_line":"    end"},{"line_number":514,"context_line":"  end"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":15,"id":"9a68dd71_3f16c455","line":512,"range":{"start_line":512,"start_character":34,"end_line":512,"end_character":41},"updated":"2016-01-22 10:27:17.000000000","message":"default notification is delayed, just be aware, but this is ok too.","commit_id":"6a77bdd83ab5beab8da14596873df0da4ac39120"}],"spec/default_spec.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"3b7eb23ff513d74b78cf74f31f85705f225b25af","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        it \"sets the default #{attr} value\" do"},{"line_number":27,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{default_value}$/)"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        it \"sets the #{attr} attribute\" do"},{"line_number":31,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][plugin_name][attr] \u003d \"#{attr}_value\""},{"line_number":32,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{attr}_value$/)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_319a8264","side":"PARENT","line":29,"updated":"2016-01-22 07:29:39.000000000","message":"why did you remove this blank line?","commit_id":"8eeaeeced4d3368c96a0e5b138fdd318702653bb"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"39e55bd0f5e6c3c41feab730c10989301a46967d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        it \"sets the default #{attr} value\" do"},{"line_number":27,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{default_value}$/)"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        it \"sets the #{attr} attribute\" do"},{"line_number":31,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][plugin_name][attr] \u003d \"#{attr}_value\""},{"line_number":32,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{attr}_value$/)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_91c00ee2","side":"PARENT","line":29,"in_reply_to":"9a68dd71_319a8264","updated":"2016-01-22 07:37:41.000000000","message":"Will add it back.","commit_id":"8eeaeeced4d3368c96a0e5b138fdd318702653bb"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"3b7eb23ff513d74b78cf74f31f85705f225b25af","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{default_value}$/)"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        it \"sets the #{attr} attribute\" do"},{"line_number":30,"context_line":"          if plugin_name \u003d\u003d \u0027contrail\u0027"},{"line_number":31,"context_line":"            component_name \u003d \u0027ml2\u0027"},{"line_number":32,"context_line":"          else"},{"line_number":33,"context_line":"            component_name \u003d plugin_name"},{"line_number":34,"context_line":"          end"},{"line_number":35,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][component_name][attr] \u003d \"#{attr}_value\""},{"line_number":36,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{attr}_value$/)"},{"line_number":37,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_f1f94a81","line":34,"range":{"start_line":30,"start_character":0,"end_line":34,"end_character":13},"updated":"2016-01-22 07:29:39.000000000","message":"plugin_name \u003d \u0027ml2\u0027 if plugin_name \u003d\u003d \u0027contrial\u0027","commit_id":"d3702a147a7fadd52ef01f6c4c073fba13dd04c5"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"39e55bd0f5e6c3c41feab730c10989301a46967d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{default_value}$/)"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        it \"sets the #{attr} attribute\" do"},{"line_number":30,"context_line":"          if plugin_name \u003d\u003d \u0027contrail\u0027"},{"line_number":31,"context_line":"            component_name \u003d \u0027ml2\u0027"},{"line_number":32,"context_line":"          else"},{"line_number":33,"context_line":"            component_name \u003d plugin_name"},{"line_number":34,"context_line":"          end"},{"line_number":35,"context_line":"          node.set[\u0027openstack\u0027][\u0027network\u0027][component_name][attr] \u003d \"#{attr}_value\""},{"line_number":36,"context_line":"          expect(chef_run).to render_file(cfg_file.name).with_content(/^#{attr} \u003d #{attr}_value$/)"},{"line_number":37,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"9a68dd71_f18aaabe","line":34,"range":{"start_line":30,"start_character":0,"end_line":34,"end_character":13},"in_reply_to":"9a68dd71_f1f94a81","updated":"2016-01-22 07:37:41.000000000","message":"Good catch!","commit_id":"d3702a147a7fadd52ef01f6c4c073fba13dd04c5"}],"spec/spec_helper.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"080ee83d47c8b9b80e4a5ab81ba83b58d52f4f23","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  \u0027nec\u0027 \u003d\u003e \u0027nec.ini\u0027,"},{"line_number":66,"context_line":"  \u0027nicira\u0027 \u003d\u003e \u0027nvp.ini\u0027,"},{"line_number":67,"context_line":"  \u0027nuage\u0027 \u003d\u003e \u0027nuage_plugin.ini\u0027,"},{"line_number":68,"context_line":"  \u0027contrail\u0027 \u003d\u003e \u0027/etc/neutron/plugins/contrail/contrail_plugin.ini\u0027,"},{"line_number":69,"context_line":"  \u0027openvswitch\u0027 \u003d\u003e \u0027ovs_neutron_plugin.ini\u0027,"},{"line_number":70,"context_line":"  \u0027plumgrid\u0027 \u003d\u003e \u0027plumgrid.ini\u0027,"},{"line_number":71,"context_line":"  \u0027ryu\u0027 \u003d\u003e \u0027ryu.ini\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba63e191_fb829793","line":68,"updated":"2016-01-20 07:10:09.000000000","message":"Why to use full path here?","commit_id":"1d68a07fe6fd03e97460ba2b6ee57f7554cd9015"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"7b0b87910e83001e7a3ed29a68b4bda63188eb05","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  \u0027nec\u0027 \u003d\u003e \u0027nec.ini\u0027,"},{"line_number":66,"context_line":"  \u0027nicira\u0027 \u003d\u003e \u0027nvp.ini\u0027,"},{"line_number":67,"context_line":"  \u0027nuage\u0027 \u003d\u003e \u0027nuage_plugin.ini\u0027,"},{"line_number":68,"context_line":"  \u0027contrail\u0027 \u003d\u003e \u0027/etc/neutron/plugins/contrail/contrail_plugin.ini\u0027,"},{"line_number":69,"context_line":"  \u0027openvswitch\u0027 \u003d\u003e \u0027ovs_neutron_plugin.ini\u0027,"},{"line_number":70,"context_line":"  \u0027plumgrid\u0027 \u003d\u003e \u0027plumgrid.ini\u0027,"},{"line_number":71,"context_line":"  \u0027ryu\u0027 \u003d\u003e \u0027ryu.ini\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba63e191_1b03eb10","line":68,"in_reply_to":"ba63e191_fb829793","updated":"2016-01-20 07:16:23.000000000","message":"Good catch.Thanks.","commit_id":"1d68a07fe6fd03e97460ba2b6ee57f7554cd9015"}]}