)]}'
{"recipes/_bridge_config_example.rb":[{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"8ecb988458d9ed388ba16bc3bab8a4022c0a484e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"vlan_bridge \u003d vlan.split(\u0027:\u0027).last"},{"line_number":60,"context_line":"ex_bridge \u003d ex.split(\u0027:\u0027).last"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"execute \u0027create external network bridge\u0027 do"},{"line_number":64,"context_line":"  command \"ovs-vsctl --may-exist add-br #{ex_bridge} \""},{"line_number":65,"context_line":"  action :run"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dae33548_867eb1e1","line":62,"updated":"2016-02-18 22:27:05.000000000","message":"Extra blank line. Rubocop complains","commit_id":"9cbb4ce576d053e925b66b139b6ca8077e1cb56e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"c55f9bd321eaa7666cff87cbfa4920e9f57b8511","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# vlan bridge"},{"line_number":34,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027vlan_network_bridge_interface\u0027] \u003d \u0027eth1\u0027"},{"line_number":35,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027openvswitch\u0027][\u0027conf\u0027]"},{"line_number":36,"context_line":".[](\u0027OVS\u0027)[\u0027bridge_mappings\u0027] \u003d \u0027vlan:br-vlan,external:br-ex\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# external bridge"},{"line_number":39,"context_line":"node.default[\u0027openstack\u0027][\u0027network_l3\u0027][\u0027external_network_bridge_interface\u0027] \u003d \u0027eth0\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bae84128_3b6dfb04","line":36,"updated":"2016-02-25 16:04:04.000000000","message":"Would be nice to see some doc around the bridge_mappings?\n\nhttps://github.com/openstack/cookbook-openstack-network/blob/stable/liberty/attributes/default.rb#L536","commit_id":"f4608e57b19a9f5fcd5125d51ecba939e7a91164"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"c55f9bd321eaa7666cff87cbfa4920e9f57b8511","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# tunnel bridge"},{"line_number":42,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027tun_network_bridge_interface\u0027] \u003d \u0027eth2\u0027"},{"line_number":43,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027openvswitch\u0027][\u0027conf\u0027]"},{"line_number":44,"context_line":".[](\u0027OVS\u0027)[\u0027tunnel_bridge\u0027] \u003d \u0027br-tun\u0027"},{"line_number":45,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027openvswitch\u0027][\u0027conf\u0027]"},{"line_number":46,"context_line":".[](\u0027OVS\u0027)[\u0027local_ip\u0027] \u003d"},{"line_number":47,"context_line":"  address_for(node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027tun_network_bridge_interface\u0027])"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bae84128_db4ccf9f","line":44,"updated":"2016-02-25 16:04:04.000000000","message":"I really don\u0027t like no indenting here, very hard to read this .[]  stuff.  Is there a better to format these lines?","commit_id":"f4608e57b19a9f5fcd5125d51ecba939e7a91164"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"6122b074f9f8f3301263a007a3cec57b7c314065","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# This needs to be done during compile time to ensure that the address_for"},{"line_number":37,"context_line":"# method used lateron works"},{"line_number":38,"context_line":"execute \u0027create eth-ext dummy interface\u0027 do"},{"line_number":39,"context_line":"\tcommand \u0027ip link add eth-ext type dummy;\u0027\\"},{"line_number":40,"context_line":"    \u0027ip link set dev eth-ext up\u0027"},{"line_number":41,"context_line":"  not_if \u0027ip link show | grep eth-ext\u0027"},{"line_number":42,"context_line":"end.run_action(:run)"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7af24918_b6bac021","line":39,"updated":"2016-03-02 05:27:56.000000000","message":"tab character before space.","commit_id":"8629bad66c51edf2bc2b4db2630b459c3b1f6d84"}],"recipes/openvswitch_agent.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"c55f9bd321eaa7666cff87cbfa4920e9f57b8511","unresolved":false,"context_lines":[{"line_number":36,"context_line":".[](\u0027DEFAULT\u0027)[\u0027integration_bridge\u0027]"},{"line_number":37,"context_line":"execute \u0027create integration network bridge\u0027 do"},{"line_number":38,"context_line":"  command \"ovs-vsctl --may-exist add-br #{int_bridge}\""},{"line_number":39,"context_line":"  action :run"},{"line_number":40,"context_line":"end"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"service \u0027neutron-plugin-openvswitch-agent\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bae84128_1e858506","line":39,"updated":"2016-02-25 16:04:04.000000000","message":"should there be a conditional only_if here, so if the int_bridge is Nil this will be skipped?","commit_id":"f4608e57b19a9f5fcd5125d51ecba939e7a91164"}],"spec/_bridge_config_example_spec.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"6122b074f9f8f3301263a007a3cec57b7c314065","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it \u0027adds external network bridge\u0027 do"},{"line_number":29,"context_line":"        expect(chef_run).to run_execute(name)"},{"line_number":30,"context_line":"          .with(command: cmd_br)"},{"line_number":31,"context_line":"      end"},{"line_number":32,"context_line":"      it \u0027adds external network bridge port\u0027 do"},{"line_number":33,"context_line":"        expect(chef_run).to run_execute(\"#{name} port\")"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7af24918_f6d0c855","line":30,"updated":"2016-03-02 05:27:56.000000000","message":"Above two lines can be put together.","commit_id":"8629bad66c51edf2bc2b4db2630b459c3b1f6d84"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"6122b074f9f8f3301263a007a3cec57b7c314065","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      end"},{"line_number":32,"context_line":"      it \u0027adds external network bridge port\u0027 do"},{"line_number":33,"context_line":"        expect(chef_run).to run_execute(\"#{name} port\")"},{"line_number":34,"context_line":"          .with(command: cmd_port)"},{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7af24918_16ce14b4","line":34,"updated":"2016-03-02 05:27:56.000000000","message":"put together.","commit_id":"8629bad66c51edf2bc2b4db2630b459c3b1f6d84"}]}
