)]}'
{"spec/ml2_linuxbridge-redhat_spec.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38fdead6c465407ff46f9e54177a10b4c8f6ccf9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    include_context \u0027neutron-stubs\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    before do"},{"line_number":21,"context_line":"    end"},{"line_number":22,"context_line":"    it \u0027creates the /etc/neutron/plugins/ml2 agent directory\u0027 do"},{"line_number":23,"context_line":"      expect(chef_run).to create_directory(\u0027/etc/neutron/plugins/ml2\u0027).with("},{"line_number":24,"context_line":"        owner: \u0027neutron\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_f6e88fa7","line":21,"range":{"start_line":20,"start_character":4,"end_line":21,"end_character":7},"updated":"2020-01-07 14:04:01.000000000","message":"can\u0027t we just drop this now empty \"before do/end\" block?","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"e23cd1bd3517ecfd2a409e7675e01829276c8335","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    include_context \u0027neutron-stubs\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    before do"},{"line_number":21,"context_line":"    end"},{"line_number":22,"context_line":"    it \u0027creates the /etc/neutron/plugins/ml2 agent directory\u0027 do"},{"line_number":23,"context_line":"      expect(chef_run).to create_directory(\u0027/etc/neutron/plugins/ml2\u0027).with("},{"line_number":24,"context_line":"        owner: \u0027neutron\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_627a9abb","line":21,"range":{"start_line":20,"start_character":4,"end_line":21,"end_character":7},"in_reply_to":"3fa7e38b_f6e88fa7","updated":"2020-01-07 17:23:40.000000000","message":"Yes, this was missed. Thanks for catching!","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"}],"spec/server_spec.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38fdead6c465407ff46f9e54177a10b4c8f6ccf9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      context \u0027allows overriding package names\u0027 do"},{"line_number":22,"context_line":"        cust_pkgs \u003d %w(my-neutron my-other-neutron)"},{"line_number":23,"context_line":"        cached(:chef_run) do"},{"line_number":24,"context_line":"          node.override[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027service_type\u0027] \u003d \u0027neutron\u0027"},{"line_number":25,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027ml2\u0027][\u0027path\u0027] \u003d \u0027/etc/neutron/plugins/ml2\u0027"},{"line_number":26,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027ml2\u0027][\u0027filename\u0027] \u003d \u0027ml2_conf.ini\u0027"},{"line_number":27,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027neutron_server_packages\u0027] \u003d cust_pkgs"},{"line_number":28,"context_line":"          runner.converge(described_recipe)"},{"line_number":29,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_96759b02","line":26,"range":{"start_line":24,"start_character":10,"end_line":26,"end_character":94},"updated":"2020-01-07 14:04:01.000000000","message":"Do we really have to repeat these overrides every time? This looks clumsy and error-prone to me, would be good to have a better solution, ideally to make the additive to what we have globally in this spec.","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"e23cd1bd3517ecfd2a409e7675e01829276c8335","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      context \u0027allows overriding package names\u0027 do"},{"line_number":22,"context_line":"        cust_pkgs \u003d %w(my-neutron my-other-neutron)"},{"line_number":23,"context_line":"        cached(:chef_run) do"},{"line_number":24,"context_line":"          node.override[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027service_type\u0027] \u003d \u0027neutron\u0027"},{"line_number":25,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027ml2\u0027][\u0027path\u0027] \u003d \u0027/etc/neutron/plugins/ml2\u0027"},{"line_number":26,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027plugins\u0027][\u0027ml2\u0027][\u0027filename\u0027] \u003d \u0027ml2_conf.ini\u0027"},{"line_number":27,"context_line":"          node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027platform\u0027][\u0027neutron_server_packages\u0027] \u003d cust_pkgs"},{"line_number":28,"context_line":"          runner.converge(described_recipe)"},{"line_number":29,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_62537a3b","line":26,"range":{"start_line":24,"start_character":10,"end_line":26,"end_character":94},"in_reply_to":"3fa7e38b_96759b02","updated":"2020-01-07 17:23:40.000000000","message":"I agree. Let me see what I can do to work around this.","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"}],"spec/spec_helper.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38fdead6c465407ff46f9e54177a10b4c8f6ccf9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  end"},{"line_number":54,"context_line":"  shared_examples \u0027custom template banner displayer\u0027 do"},{"line_number":55,"context_line":"    it \u0027shows the custom banner\u0027 do"},{"line_number":56,"context_line":"      node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027custom_template_banner\u0027] \u003d \u0027custom_template_banner_value\u0027"},{"line_number":57,"context_line":"      expect(chef_run).to render_file(file_name).with_content(/^custom_template_banner_value$/)"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_d66eb32b","line":56,"updated":"2020-01-07 14:04:01.000000000","message":"Doesn\u0027t this need to be wrapped in cached(), too?","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"e23cd1bd3517ecfd2a409e7675e01829276c8335","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  end"},{"line_number":54,"context_line":"  shared_examples \u0027custom template banner displayer\u0027 do"},{"line_number":55,"context_line":"    it \u0027shows the custom banner\u0027 do"},{"line_number":56,"context_line":"      node.override[\u0027openstack\u0027][\u0027network\u0027][\u0027custom_template_banner\u0027] \u003d \u0027custom_template_banner_value\u0027"},{"line_number":57,"context_line":"      expect(chef_run).to render_file(file_name).with_content(/^custom_template_banner_value$/)"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_4232fe10","line":56,"in_reply_to":"3fa7e38b_d66eb32b","updated":"2020-01-07 17:23:40.000000000","message":"Yes. I\u0027ll fix this.","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38fdead6c465407ff46f9e54177a10b4c8f6ccf9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      expect(chef_run).to render_file(file_name).with_content(/^custom_template_banner_value$/)"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":"  shared_examples \u0027common network attributes displayer\u0027 do |plugin|"},{"line_number":61,"context_line":"    cached(:chef_run) do"},{"line_number":62,"context_line":"      node.override[\u0027openstack\u0027][\"network_#{plugin}\"][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027interface_driver\u0027] \u003d \u0027network_interface_driver_value\u0027"},{"line_number":63,"context_line":"      runner.converge(described_recipe)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_d64793a3","line":60,"updated":"2020-01-07 14:04:01.000000000","message":"Is a shared example also a new context implicitly? Or would you also need to insert a context here in order to avoid side-effects on the global spec run?","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"e23cd1bd3517ecfd2a409e7675e01829276c8335","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      expect(chef_run).to render_file(file_name).with_content(/^custom_template_banner_value$/)"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":"  shared_examples \u0027common network attributes displayer\u0027 do |plugin|"},{"line_number":61,"context_line":"    cached(:chef_run) do"},{"line_number":62,"context_line":"      node.override[\u0027openstack\u0027][\"network_#{plugin}\"][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027interface_driver\u0027] \u003d \u0027network_interface_driver_value\u0027"},{"line_number":63,"context_line":"      runner.converge(described_recipe)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_62285a97","line":60,"in_reply_to":"3fa7e38b_d64793a3","updated":"2020-01-07 17:23:40.000000000","message":"IIRC I needed to insert it here for it to properly.","commit_id":"4ffef3fdb6193ba558b405a8b681779a2ff9e912"}]}