)]}'
{"id":"openstack%2Fcookbook-openstack-network~699739","triplet_id":"openstack%2Fcookbook-openstack-network~master~Ib10a6828e6886a57527a5e5a506cc57364ec0c2a","project":"openstack/cookbook-openstack-network","branch":"master","topic":"faster-chefspec","hashtags":[],"change_id":"Ib10a6828e6886a57527a5e5a506cc57364ec0c2a","subject":"Improve ChefSpec test speed by enabling caching","status":"MERGED","created":"2019-12-18 17:42:00.000000000","updated":"2020-01-10 13:49:12.000000000","submitted":"2020-01-10 13:49:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"699739-1578664152688-0e1c537b","meta_rev_id":"3f9ee7ce43dbce12e8860db2ca5221b43c51a4f3","_number":699739,"virtual_id_number":699739,"owner":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-10 13:49:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-01-10 12:54:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2020-01-10 12:54:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-10 12:54:22.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-01-10 13:49:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6210fc561a78116aeafd2bb5ac8db5aac3723741","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-12-18 17:42:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"858f80a8883af07191d4c564789b0b011ab5354a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 18:32:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/367816e9c8f043029edb9d03de72b142 : SUCCESS in 3m 37s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/a2e80e33b37f475a8f4c1201af0c77e9 : SUCCESS in 48m 14s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/7f36c2a0aed64760a77e11965df37e47 : SUCCESS in 45m 28s","accounts_in_message":[],"_revision_number":1},{"id":"2af5530ec6aef4c055b3a911db23231c0e1af8d8","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-01-06 19:59:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cb09a4d1494e62c71929c8ab234301a539519f06","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-06 20:56:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/20b0345e54ed402dbc783d7357b6c1c8 : SUCCESS in 4m 13s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/8937787e5b6940b89f5af8a216d3e015 : SUCCESS in 44m 49s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/52fb573fab6a483e80fd69f600efaf92 : SUCCESS in 51m 56s","accounts_in_message":[],"_revision_number":2},{"id":"38fdead6c465407ff46f9e54177a10b4c8f6ccf9","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-01-07 14:04:01.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e23cd1bd3517ecfd2a409e7675e01829276c8335","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-01-07 17:23:40.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"12e23b7105f6b8f99e9823c1f94906c093f2fa38","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-01-07 17:56:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"60d6f274b64bf1d02a403324c876761ee6d90407","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-07 18:59:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/7b4c56550c054da38b99321565fa5999 : SUCCESS in 4m 07s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/cdf37f63662740db8f235760b6b2b20c : SUCCESS in 42m 14s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/e6176e672d3f493dad1dd08bb9326de7 : SUCCESS in 52m 33s","accounts_in_message":[],"_revision_number":3},{"id":"c9614f73bc1bb54ae6efc432646e738eb239994e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-01-10 12:54:22.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"bb7fc6dbb4eeb97207738123c21b0f6ba47a6e7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 12:54:33.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"2ccabcd55fc27e515a08cce7bd75292638a2c83c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 13:49:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"d7046baeb67bccb512f7824b4088195d7852d70d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 13:49:12.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/7051af63bd25457089555c0d3e6c728f : SUCCESS in 3m 46s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/af1287726d2f4685a455d83243c3bb7f : SUCCESS in 51m 47s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/19498b46544c4e3dbeb934ded150eccf : SUCCESS in 54m 23s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1c40ad731e4b7d3413767a978b075eba39a23488","revisions":{"23cd28721754ac49b18dc958812ddbe7641b9f81":{"kind":"REWORK","_number":1,"created":"2019-12-18 17:42:00.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/39/699739/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-network","ref":"refs/changes/39/699739/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/1"}}},"commit":{"parents":[{"commit":"70fda6ae3a87fa962214daff6e8bc2ec39afb836","subject":"Updates for rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/70fda6ae3a87fa962214daff6e8bc2ec39afb836"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-18 17:40:53.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-18 17:41:33.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to\nspeed up tests. By doing this, we have to create a new cached(:chef_run)\nblock whenever we need to adjust node attributes for testing.\n\nChange-Id: Ib10a6828e6886a57527a5e5a506cc57364ec0c2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/23cd28721754ac49b18dc958812ddbe7641b9f81"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/23cd28721754ac49b18dc958812ddbe7641b9f81"}]},"branch":"refs/heads/master"},"4ffef3fdb6193ba558b405a8b681779a2ff9e912":{"kind":"REWORK","_number":2,"created":"2020-01-06 19:59:13.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/39/699739/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-network","ref":"refs/changes/39/699739/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/2"}}},"commit":{"parents":[{"commit":"70fda6ae3a87fa962214daff6e8bc2ec39afb836","subject":"Updates for rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/70fda6ae3a87fa962214daff6e8bc2ec39afb836"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-18 17:40:53.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-01-06 19:57:45.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to\nspeed up tests. By doing this, we have to create a new cached(:chef_run)\nblock whenever we need to adjust node attributes for testing.\n\nSpeed was improved from 4 minutes 18.7 seconds to 1 minute 2.73 seconds\n\nChange-Id: Ib10a6828e6886a57527a5e5a506cc57364ec0c2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/4ffef3fdb6193ba558b405a8b681779a2ff9e912"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/4ffef3fdb6193ba558b405a8b681779a2ff9e912"}]},"branch":"refs/heads/master"},"1c40ad731e4b7d3413767a978b075eba39a23488":{"kind":"REWORK","_number":3,"created":"2020-01-07 17:56:55.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/39/699739/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-network","ref":"refs/changes/39/699739/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-network refs/changes/39/699739/3"}}},"commit":{"parents":[{"commit":"70fda6ae3a87fa962214daff6e8bc2ec39afb836","subject":"Updates for rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/70fda6ae3a87fa962214daff6e8bc2ec39afb836"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-18 17:40:53.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-01-07 17:55:25.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to\nspeed up tests. By doing this, we have to create a new cached(:chef_run)\nblock whenever we need to adjust node attributes for testing.\n\nAdditional fixes:\n- Pull in openstack-network::ml2_core_plugin in server spec so that we get the\n  default attributes set\n- Remove unused shared_examples\n\nSpeed was improved from 4 minutes 18.7 seconds to 1 minute 2.73 seconds\n\nChange-Id: Ib10a6828e6886a57527a5e5a506cc57364ec0c2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/1c40ad731e4b7d3413767a978b075eba39a23488"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-network/commit/1c40ad731e4b7d3413767a978b075eba39a23488"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}