)]}'
{"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":171,"context_line":"default[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":172,"context_line":"# Firewall service driver with linux iptables"},{"line_number":173,"context_line":"default[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":174,"context_line":"  conf[\u0027fwaas\u0027][\u0027agent_version\u0027] \u003d \u0027v2\u0027"},{"line_number":175,"context_line":"  conf[\u0027fwaas\u0027][\u0027driver\u0027] \u003d"},{"line_number":176,"context_line":"    \u0027neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2.IptablesFwaasDriver\u0027"},{"line_number":177,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_fcbc28dd","line":174,"updated":"2020-03-23 08:46:32.000000000","message":"According to my local testing, fwaas v2 is very buggy. Being maintainerless and about to be dropped from Neutron in the next cycle, this is unlikely to change, so I would actually suggest to drop support for it. But maybe we can do this as a followup.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"default[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":172,"context_line":"# Firewall service driver with linux iptables"},{"line_number":173,"context_line":"default[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":174,"context_line":"  conf[\u0027fwaas\u0027][\u0027agent_version\u0027] \u003d \u0027v2\u0027"},{"line_number":175,"context_line":"  conf[\u0027fwaas\u0027][\u0027driver\u0027] \u003d"},{"line_number":176,"context_line":"    \u0027neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2.IptablesFwaasDriver\u0027"},{"line_number":177,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_e708bb29","line":174,"in_reply_to":"1fa4df85_fcbc28dd","updated":"2020-03-23 17:35:11.000000000","message":"I was actually considering doing that and think it would be OK to drop it in this patch since I\u0027m already dealing with it. I\u0027ll go ahead and do that.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"}],"attributes/neutron_conf.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# saved after successfull chef run)"},{"line_number":3,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf_secrets\u0027] \u003d {}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"service_provider \u003d node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027service_provider\u0027]"},{"line_number":6,"context_line":"if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":7,"context_line":"  service_provider \u003c\u003c"},{"line_number":8,"context_line":"    \u0027FIREWALL_V2:fwaas_db:neutron_fwaas.services.firewall.service_drivers.agents.agents.FirewallAgentDriver:default\u0027"},{"line_number":9,"context_line":"end"},{"line_number":10,"context_line":"if node[\u0027openstack\u0027][\u0027network_lbaas\u0027][\u0027enabled\u0027]"},{"line_number":11,"context_line":"  service_provider \u003c\u003c"},{"line_number":12,"context_line":"    \u0027LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default\u0027"},{"line_number":13,"context_line":"end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":16,"context_line":"  # [DEFAULT] section"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_9c53b46b","line":13,"range":{"start_line":5,"start_character":0,"end_line":13,"end_character":3},"updated":"2020-03-23 08:46:32.000000000","message":"This doesn\u0027t seem to get used below?","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# saved after successfull chef run)"},{"line_number":3,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf_secrets\u0027] \u003d {}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"service_provider \u003d node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027service_provider\u0027]"},{"line_number":6,"context_line":"if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":7,"context_line":"  service_provider \u003c\u003c"},{"line_number":8,"context_line":"    \u0027FIREWALL_V2:fwaas_db:neutron_fwaas.services.firewall.service_drivers.agents.agents.FirewallAgentDriver:default\u0027"},{"line_number":9,"context_line":"end"},{"line_number":10,"context_line":"if node[\u0027openstack\u0027][\u0027network_lbaas\u0027][\u0027enabled\u0027]"},{"line_number":11,"context_line":"  service_provider \u003c\u003c"},{"line_number":12,"context_line":"    \u0027LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default\u0027"},{"line_number":13,"context_line":"end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":16,"context_line":"  # [DEFAULT] section"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_073ddfba","line":13,"range":{"start_line":5,"start_character":0,"end_line":13,"end_character":3},"in_reply_to":"1fa4df85_9c53b46b","updated":"2020-03-23 17:35:11.000000000","message":"I believe what happens here is that we\u0027re editing the node attribute literally as service_provider when we do this code block. IIRC when I tried modifying the content this before, Chef wouldn\u0027t allow me to do that. If you can think of a better way of doing this, please let me know.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027control_exchange\u0027] \u003d \u0027neutron\u0027"},{"line_number":23,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027core_plugin\u0027] \u003d \u0027ml2\u0027"},{"line_number":24,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_strategy\u0027] \u003d \u0027keystone\u0027"},{"line_number":25,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_status_changes\u0027] \u003d true"},{"line_number":26,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_data_changes\u0027] \u003d true"},{"line_number":27,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d \u0027router\u0027"},{"line_number":28,"context_line":"  if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":29,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_9cc9745a","line":26,"range":{"start_line":24,"start_character":2,"end_line":26,"end_character":60},"updated":"2020-03-23 08:46:32.000000000","message":"These all seem to be defaults, why do you want to set those explicitly?","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027control_exchange\u0027] \u003d \u0027neutron\u0027"},{"line_number":23,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027core_plugin\u0027] \u003d \u0027ml2\u0027"},{"line_number":24,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_strategy\u0027] \u003d \u0027keystone\u0027"},{"line_number":25,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_status_changes\u0027] \u003d true"},{"line_number":26,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_data_changes\u0027] \u003d true"},{"line_number":27,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d \u0027router\u0027"},{"line_number":28,"context_line":"  if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":29,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_07667fee","line":26,"range":{"start_line":24,"start_character":2,"end_line":26,"end_character":60},"in_reply_to":"1fa4df85_9cc9745a","updated":"2020-03-23 17:35:11.000000000","message":"I was following the upstream documentation, but I suppose if they\u0027re the defaults then we don\u0027t really need to set them here. I\u0027ll double check that before I remove this.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_strategy\u0027] \u003d \u0027keystone\u0027"},{"line_number":25,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_status_changes\u0027] \u003d true"},{"line_number":26,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_data_changes\u0027] \u003d true"},{"line_number":27,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d \u0027router\u0027"},{"line_number":28,"context_line":"  if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":29,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d"},{"line_number":30,"context_line":"      ["}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_9c6ad417","line":27,"updated":"2020-03-23 08:46:32.000000000","message":"In our deployments we need additional options here like \"qos\", so hard-coding it is wrong. I\u0027m not sure doing extended computations with this like you are trying below is a really sane way, either. Maybe just don\u0027t set it by default, allowing to set deployments what they really need in a wrapper without having to resort to overrides.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_strategy\u0027] \u003d \u0027keystone\u0027"},{"line_number":25,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_status_changes\u0027] \u003d true"},{"line_number":26,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027notify_nova_on_port_data_changes\u0027] \u003d true"},{"line_number":27,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d \u0027router\u0027"},{"line_number":28,"context_line":"  if node[\u0027openstack\u0027][\u0027network_fwaas\u0027][\u0027enabled\u0027]"},{"line_number":29,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027service_plugins\u0027] \u003d"},{"line_number":30,"context_line":"      ["}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_8793af4f","line":27,"in_reply_to":"1fa4df85_9c6ad417","updated":"2020-03-23 17:35:11.000000000","message":"Ok, I was pondering how this might impact other deployments. I\u0027ll go ahead and remove it. FWIW we set it in our environment.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"}],"recipes/db_migration.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# The node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027] attribute is set in the default.rb recipe"},{"line_number":25,"context_line":"execute \u0027migrate network database\u0027 do"},{"line_number":26,"context_line":"  timeout timeout"},{"line_number":27,"context_line":"  command \u003c\u003c-EOF.gsub(/^ {4}/, \u0027\u0027)"},{"line_number":28,"context_line":"    neutron-db-manage --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":29,"context_line":"  EOF"},{"line_number":30,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_bcb47083","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":28},"updated":"2020-03-23 08:46:32.000000000","message":"Seems pretty nerdy to use this regex instead of \"    \", is there a reason for that? Also, does the command really fail when executed with leading spaces? I\u0027d be thinking the shell should just ignore it.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# The node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027] attribute is set in the default.rb recipe"},{"line_number":25,"context_line":"execute \u0027migrate network database\u0027 do"},{"line_number":26,"context_line":"  timeout timeout"},{"line_number":27,"context_line":"  command \u003c\u003c-EOF.gsub(/^ {4}/, \u0027\u0027)"},{"line_number":28,"context_line":"    neutron-db-manage --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":29,"context_line":"  EOF"},{"line_number":30,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_e7e6fbe8","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":28},"in_reply_to":"1fa4df85_bcb47083","updated":"2020-03-23 17:35:11.000000000","message":"It\u0027s not really required however it makes it easier for ChefSpec tests. I\u0027ve seen it used in other Chef cookbooks such as jenkins and it seems pretty command. What issue do you have with doing this?","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d58bf3d5e5cc98835ac00f7650be56972ca9e046","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# The node[\u0027openstack\u0027][\u0027network\u0027][\u0027plugin_config_file\u0027] attribute is set in the default.rb recipe"},{"line_number":25,"context_line":"execute \u0027migrate network database\u0027 do"},{"line_number":26,"context_line":"  timeout timeout"},{"line_number":27,"context_line":"  command \u003c\u003c-EOF.gsub(/^ {4}/, \u0027\u0027)"},{"line_number":28,"context_line":"    neutron-db-manage --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":29,"context_line":"  EOF"},{"line_number":30,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_ac804f8d","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":28},"in_reply_to":"df33271e_e7e6fbe8","updated":"2020-03-24 04:37:41.000000000","message":"I don\u0027t have a real issue, I was more just questioning why this is being used, easing ChefSpec tests is a valid enough argument for me.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"}],"recipes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"bind_service \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027][\u0027network\u0027]"},{"line_number":78,"context_line":"bind_service_address \u003d bind_address bind_service"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# The auth_url in nova section follows auth_type"},{"line_number":81,"context_line":"nova_auth_url \u003d nil"},{"line_number":82,"context_line":"nova_auth_url \u003d auth_url"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":85,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027syslog\u0027][\u0027use\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_7c0ef83b","line":82,"range":{"start_line":80,"start_character":0,"end_line":82,"end_character":24},"updated":"2020-03-23 08:46:32.000000000","message":"Why not drop this completely? ...","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"bind_service \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027][\u0027network\u0027]"},{"line_number":78,"context_line":"bind_service_address \u003d bind_address bind_service"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# The auth_url in nova section follows auth_type"},{"line_number":81,"context_line":"nova_auth_url \u003d nil"},{"line_number":82,"context_line":"nova_auth_url \u003d auth_url"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":85,"context_line":"  if node[\u0027openstack\u0027][\u0027network\u0027][\u0027syslog\u0027][\u0027use\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_c704977e","line":82,"range":{"start_line":80,"start_character":0,"end_line":82,"end_character":24},"in_reply_to":"1fa4df85_7c0ef83b","updated":"2020-03-23 17:35:11.000000000","message":"Hmm, good point :)","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  end"},{"line_number":88,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_host\u0027] \u003d bind_service_address"},{"line_number":89,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_port\u0027] \u003d bind_service[\u0027port\u0027]"},{"line_number":90,"context_line":"  conf[\u0027nova\u0027][\u0027auth_url\u0027] \u003d nova_auth_url if nova_auth_url"},{"line_number":91,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_url\u0027] \u003d auth_url"},{"line_number":92,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027www_authenticate_uri\u0027] \u003d auth_url"},{"line_number":93,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_9c0bb428","line":90,"range":{"start_line":90,"start_character":29,"end_line":90,"end_character":59},"updated":"2020-03-23 08:46:32.000000000","message":"... and replace this with \"auth_url\"?","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  end"},{"line_number":88,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_host\u0027] \u003d bind_service_address"},{"line_number":89,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_port\u0027] \u003d bind_service[\u0027port\u0027]"},{"line_number":90,"context_line":"  conf[\u0027nova\u0027][\u0027auth_url\u0027] \u003d nova_auth_url if nova_auth_url"},{"line_number":91,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_url\u0027] \u003d auth_url"},{"line_number":92,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027www_authenticate_uri\u0027] \u003d auth_url"},{"line_number":93,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_47a8871e","line":90,"range":{"start_line":90,"start_character":29,"end_line":90,"end_character":59},"in_reply_to":"1fa4df85_9c0bb428","updated":"2020-03-23 17:35:11.000000000","message":"+1","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d22b6084f93b6093c58a3168f6ed43194e984caa","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_port\u0027] \u003d bind_service[\u0027port\u0027]"},{"line_number":90,"context_line":"  conf[\u0027nova\u0027][\u0027auth_url\u0027] \u003d nova_auth_url if nova_auth_url"},{"line_number":91,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_url\u0027] \u003d auth_url"},{"line_number":92,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027www_authenticate_uri\u0027] \u003d auth_url"},{"line_number":93,"context_line":"end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# define secrets that are needed in the neutron.conf.erb"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1fa4df85_fc31880c","line":92,"updated":"2020-03-23 08:46:32.000000000","message":"Nope, if set at all, this should be the public endpoint, not the internal one. I\u0027d rather not set this at all here and leave it up to deployments to decide.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"89fc7918b1592dc6ed4ef29dd23948244400da9e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027bind_port\u0027] \u003d bind_service[\u0027port\u0027]"},{"line_number":90,"context_line":"  conf[\u0027nova\u0027][\u0027auth_url\u0027] \u003d nova_auth_url if nova_auth_url"},{"line_number":91,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_url\u0027] \u003d auth_url"},{"line_number":92,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027www_authenticate_uri\u0027] \u003d auth_url"},{"line_number":93,"context_line":"end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# define secrets that are needed in the neutron.conf.erb"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df33271e_27b10391","line":92,"in_reply_to":"1fa4df85_fc31880c","updated":"2020-03-23 17:35:11.000000000","message":"Alright, sounds good. I\u0027ll remove it.","commit_id":"6ac97d8bd1f4428e60b5daa95532b0ba2313e4f8"}]}