)]}'
{"attributes/mysql.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bc9a0f9096f1a72b3d8d847c3a131e8d9da1153","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# InnoDB number of commit transactions to flush log"},{"line_number":43,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_flush_log_at_trx_commit\u0027] \u003d \u00272\u0027"},{"line_number":44,"context_line":"# InnoDB memory buffer for caching table data and indexes"},{"line_number":45,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_buffer_pool_size\u0027] \u003d \u00278388608\u0027"},{"line_number":46,"context_line":"# InnoDB size of each log file in a log group"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_log_file_size\u0027] \u003d \u00275242880\u0027"},{"line_number":48,"context_line":"# InnoDB size of buffer for logs"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aa53dc9_e51d0e63","line":45,"updated":"2015-04-09 19:47:52.000000000","message":"This default looks in correct, from http://dev.mysql.com/doc/refman/5.5/en/innodb-parameters.html Am I looking in the wrong place?","commit_id":"29bd479c2fd4d6f4bebb378751fba617a03aa251"},{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"c1f360f78af2d49c9fd86983fd01fb94d0b6ec4a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Storage engine, base OpenStack requires the InnoDB flavor"},{"line_number":31,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027default-storage-engine\u0027] \u003d \u0027InnoDB\u0027"},{"line_number":32,"context_line":"# InnoDB lock mode for generating auto-increment values"},{"line_number":33,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_autoinc_lock_mode\u0027] \u003d \u00271\u0027"},{"line_number":34,"context_line":"# InnoDB give each table its own file"},{"line_number":35,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_file_per_table\u0027] \u003d \u0027OFF\u0027"},{"line_number":36,"context_line":"# InnoDB thread concurrency"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9aa53dc9_ca0b32d5","line":33,"updated":"2015-04-09 22:18:16.000000000","message":"Correct several default values here to be in line with the actual MySQL \u003e\u003d 5.5 defaults","commit_id":"acc54b26803ae630b3b1580de88d8f55180cd853"},{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"c1f360f78af2d49c9fd86983fd01fb94d0b6ec4a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Memory allocated for caching query results"},{"line_number":55,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027query_cache_size\u0027] \u003d \u00270\u0027"},{"line_number":56,"context_line":"# Maximum number of connections"},{"line_number":57,"context_line":"default[\u0027openstack\u0027][\u0027mysql\u0027][\u0027max_connections\u0027] \u003d \u0027151\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9aa53dc9_6afb06c2","line":57,"updated":"2015-04-09 22:18:16.000000000","message":"151 is low but it is actually the default, so changing it back to 151 as we should be consistent with all defaults mimicking MySQL defaults.","commit_id":"acc54b26803ae630b3b1580de88d8f55180cd853"}],"spec/mariadb-server-redhat_spec.rb":[{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"c1f360f78af2d49c9fd86983fd01fb94d0b6ec4a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      )"},{"line_number":20,"context_line":"      expect(file).to notify(\u0027service[mysql]\u0027)"},{"line_number":21,"context_line":"      [/^default-storage-engine \u003d InnoDB$/,"},{"line_number":22,"context_line":"       /^innodb_autoinc_lock_mode \u003d 1$/,"},{"line_number":23,"context_line":"       /^innodb_file_per_table \u003d OFF$/,"},{"line_number":24,"context_line":"       /^innodb_thread_concurrency \u003d 0$/,"},{"line_number":25,"context_line":"       /^innodb_commit_concurrency \u003d 0$/,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9aa53dc9_ca3212a7","line":22,"updated":"2015-04-09 22:18:16.000000000","message":"Fixing this test to match new complete set of attributes and defaults","commit_id":"acc54b26803ae630b3b1580de88d8f55180cd853"}],"spec/mariadb-server_spec.rb":[{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"c1f360f78af2d49c9fd86983fd01fb94d0b6ec4a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      )"},{"line_number":32,"context_line":"      expect(file).to notify(\u0027service[mysql]\u0027)"},{"line_number":33,"context_line":"      [/^default-storage-engine \u003d InnoDB$/,"},{"line_number":34,"context_line":"       /^innodb_autoinc_lock_mode \u003d 1$/,"},{"line_number":35,"context_line":"       /^innodb_file_per_table \u003d OFF$/,"},{"line_number":36,"context_line":"       /^innodb_thread_concurrency \u003d 0$/,"},{"line_number":37,"context_line":"       /^innodb_commit_concurrency \u003d 0$/,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9aa53dc9_aa234e57","line":34,"updated":"2015-04-09 22:18:16.000000000","message":"Fixing this test to match new complete set of attributes and defaults","commit_id":"acc54b26803ae630b3b1580de88d8f55180cd853"}],"spec/mysql-server_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1a9bef6bb68f8097644baae6dc7f0aaa66c42dd0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    include_context \u0027database-stubs\u0027"},{"line_number":8,"context_line":"    let(:chef_run) do"},{"line_number":9,"context_line":"      ChefSpec::Runner.new do |node|"},{"line_number":10,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027data_dir\u0027] \u003d nil"},{"line_number":11,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027version\u0027] \u003d \u00275.5\u0027"},{"line_number":12,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027service_name\u0027] \u003d \u0027default\u0027"},{"line_number":13,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027default-storage-engine\u0027] \u003d \u0027InnoDB\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da9b358b_49d1f0cc","line":10,"updated":"2015-03-30 15:22:34.000000000","message":"Yeah, I don\u0027t think this is really doing any testing.   the way to test is if a bit different since this recipe does not own the template resource, it\u0027s part of the mysql cookbook.  But I think  we could take the approach to just check the file contents like this:\n\ndescribe \u0027openstack.cnf\u0027 do\n      let(:file) { \u0027/etc/mysql-default/conf.d/openstack.cnf\u0027) }\n\n      it \u0027has valid mysql openstack options set\u0027 do\n         [/^default-storage-engine \u003d InnoDB$/,\n          /^innodb_autoinc_lock_mode \u003d 1$/,\n          /^innodb_file_per_table \u003d OFF$/,\n          ...\n        ].each do |line|\n        expect(chef_run).to render_config_file(file)\\\n          .with_section_content(\u0027mysqld\u0027, line)\n      end\nend","commit_id":"1f934b074d890176d59e68d8119a6a6a1d29bf9c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3349b1304645c4bff2ca7efa3047eea975f0053b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  describe \u0027ubuntu\u0027 do"},{"line_number":7,"context_line":"    include_context \u0027database-stubs\u0027"},{"line_number":8,"context_line":"    let(:chef_run) do"},{"line_number":9,"context_line":"      ChefSpec::Runner.new do |node|"},{"line_number":10,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027default-storage-engine\u0027] \u003d \u0027InnoDB\u0027"},{"line_number":11,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_autoinc_lock_mode\u0027] \u003d \u00271\u0027"},{"line_number":12,"context_line":"        node.set[\u0027openstack\u0027][\u0027mysql\u0027][\u0027innodb_file_per_table\u0027] \u003d \u0027OFF\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"da9b358b_6677113b","line":9,"updated":"2015-03-31 14:41:15.000000000","message":"I don\u0027t think these node.set are necessary as these attribute are used directly in the config file, so the file content checking below will handle testing that.\n\nAnd by changing this to Runner.new()   without options, is I think why you are seeing the issue in gate specs.  If you put lines 8-10 back as before, I think this will be ready.","commit_id":"6f5cc742dbb032d0df1b52dbeee4aaf86a4b7fa2"},{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"345cee64860a8771ce08ac402d462594c64d1331","unresolved":false,"context_lines":[{"line_number":51,"context_line":"         /^character-set-server \u003d utf8$/,"},{"line_number":52,"context_line":"         /^query_cache_size \u003d 0$/,"},{"line_number":53,"context_line":"         /^max_connections \u003d 1024$/].each do |line|"},{"line_number":54,"context_line":"          expect(chef_run).to render_config_file(file)\\"},{"line_number":55,"context_line":"            .with_section_content(\u0027mysqld\u0027, line)"},{"line_number":56,"context_line":"        end"},{"line_number":57,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"da9b358b_e3badd09","line":54,"updated":"2015-03-31 22:44:28.000000000","message":"This doesn\u0027t work because file doesn\u0027t exist since it would come from an LWRP from the mysql cookbook.","commit_id":"ffa78494b4dd0ce59d2193011e914fe279d5f078"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bc9a0f9096f1a72b3d8d847c3a131e8d9da1153","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        resource \u003d chef_run.find_resource(\u0027mysql_config\u0027, \u0027openstack\u0027)"},{"line_number":36,"context_line":"        expect(resource).to notify(\u0027mysql_service[default]\u0027).to(:restart).delayed"},{"line_number":37,"context_line":"      end"},{"line_number":38,"context_line":"\t\t\t"},{"line_number":39,"context_line":"\t\t\t# TODO: Verify contents of openstack.cnf. This cannot be done properly at"},{"line_number":40,"context_line":"\t\t\t# present because the mysql_config LWRP comes from the mysql cookbook but"},{"line_number":41,"context_line":"\t\t\t# does not expose a custom matcher for testing the templates contents."}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aa53dc9_1a7badf6","line":38,"updated":"2015-04-09 19:47:52.000000000","message":"cleanup?","commit_id":"29bd479c2fd4d6f4bebb378751fba617a03aa251"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bc9a0f9096f1a72b3d8d847c3a131e8d9da1153","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        expect(resource).to notify(\u0027mysql_service[default]\u0027).to(:restart).delayed"},{"line_number":37,"context_line":"      end"},{"line_number":38,"context_line":"\t\t\t"},{"line_number":39,"context_line":"\t\t\t# TODO: Verify contents of openstack.cnf. This cannot be done properly at"},{"line_number":40,"context_line":"\t\t\t# present because the mysql_config LWRP comes from the mysql cookbook but"},{"line_number":41,"context_line":"\t\t\t# does not expose a custom matcher for testing the templates contents."},{"line_number":42,"context_line":"\t\t\t# See ChefSpec docs on testing LWRPs from other cookbooks."}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aa53dc9_1a628d3e","line":39,"updated":"2015-04-09 19:47:52.000000000","message":"and no tabs?","commit_id":"29bd479c2fd4d6f4bebb378751fba617a03aa251"}]}