)]}'
{"recipes/mariadb-client.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"3f0e466151ed2b9415b400f1dfbd8cf5ead68535","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"node.override[\u0027mariadb\u0027][\u0027use_default_repository\u0027] \u003d true"},{"line_number":20,"context_line":"node.override[\u0027mariadb\u0027][\u0027install\u0027][\u0027version\u0027] \u003d \u002710.1\u0027"},{"line_number":21,"context_line":"include_recipe \u0027mariadb::client\u0027"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df87a7cf_515f9740","line":19,"updated":"2017-12-15 09:20:48.000000000","message":"i think we should use node.normal here to allow wrapping this (same for the one below)","commit_id":"332bdfbb91a67afb5ca61d3986177ca54035817d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2a60602158eadc59b82946f06312981b55acb5f1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"node.normal[\u0027mariadb\u0027][\u0027use_default_repository\u0027] \u003d true"},{"line_number":20,"context_line":"node.normal[\u0027mariadb\u0027][\u0027install\u0027][\u0027version\u0027] \u003d \u002710.1\u0027"},{"line_number":21,"context_line":"include_recipe \u0027mariadb::client\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"mysql2_chef_gem_mariadb \u0027default\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9f91af0f_b8ba7b07","line":20,"updated":"2018-01-04 10:42:47.000000000","message":"I don\u0027t think that we should try to dictate a version to deployers here, the default should be updated in the upstream cookbook, see https://github.com/sous-chefs/mariadb/issues/146\n\nIf we need to select 10.1 for the CI to work, we should set this in openstack-chef-repo","commit_id":"ecf5c71881f978160b1ef625e5962ba898c27409"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"e1d1c86c7633d4ba802583a2919d874fb2d0af34","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"node.normal[\u0027mariadb\u0027][\u0027use_default_repository\u0027] \u003d true"},{"line_number":20,"context_line":"node.normal[\u0027mariadb\u0027][\u0027install\u0027][\u0027version\u0027] \u003d \u002710.1\u0027"},{"line_number":21,"context_line":"include_recipe \u0027mariadb::client\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"mysql2_chef_gem_mariadb \u0027default\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9f91af0f_eb8d8ad3","line":20,"in_reply_to":"9f91af0f_b8ba7b07","updated":"2018-01-04 16:35:23.000000000","message":"Done","commit_id":"ecf5c71881f978160b1ef625e5962ba898c27409"}],"recipes/mariadb-server.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"17d764e7c71034e454dcdd3c70fe192069120fa0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"super_password \u003d get_password \u0027db\u0027, node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"node.override[\u0027mariadb\u0027][\u0027remove_test_database\u0027] \u003d true"},{"line_number":34,"context_line":"node.override[\u0027mariadb\u0027][\u0027allow_root_pass_change\u0027] \u003d true"},{"line_number":35,"context_line":"node.override[\u0027mariadb\u0027][\u0027server_root_password\u0027] \u003d super_password"},{"line_number":36,"context_line":"node.override[\u0027mariadb\u0027][\u0027mysqld\u0027][\u0027bind_address\u0027] \u003d listen_address"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df87a7cf_112eefa4","line":33,"updated":"2017-12-15 09:21:37.000000000","message":"i think we should use node.normal here to allow wrapping this (same for the ones below)","commit_id":"332bdfbb91a67afb5ca61d3986177ca54035817d"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"e1d1c86c7633d4ba802583a2919d874fb2d0af34","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"super_password \u003d get_password \u0027db\u0027, node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"node.override[\u0027mariadb\u0027][\u0027remove_test_database\u0027] \u003d true"},{"line_number":34,"context_line":"node.override[\u0027mariadb\u0027][\u0027allow_root_pass_change\u0027] \u003d true"},{"line_number":35,"context_line":"node.override[\u0027mariadb\u0027][\u0027server_root_password\u0027] \u003d super_password"},{"line_number":36,"context_line":"node.override[\u0027mariadb\u0027][\u0027mysqld\u0027][\u0027bind_address\u0027] \u003d listen_address"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df87a7cf_9c4e8bbf","line":33,"in_reply_to":"df87a7cf_112eefa4","updated":"2018-01-04 16:35:23.000000000","message":"Done","commit_id":"332bdfbb91a67afb5ca61d3986177ca54035817d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8fb270f4a903da3828ea02b17eb8eee666339272","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  password: super_password,"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"mysql_database \u0027flush priviledges after cleanup\u0027 do"},{"line_number":66,"context_line":"  database_name \u0027mysql\u0027"},{"line_number":67,"context_line":"  sql \u0027FLUSH PRIVILEGES\u0027"},{"line_number":68,"context_line":"  connection mysql_connection_info"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df87a7cf_9b20d5f9","line":65,"updated":"2017-12-15 14:35:57.000000000","message":"No sure that this is needed anymore when you don\u0027t delete the user before, so maybe everything after L57 can be dropped?","commit_id":"332bdfbb91a67afb5ca61d3986177ca54035817d"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"e1d1c86c7633d4ba802583a2919d874fb2d0af34","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  password: super_password,"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"mysql_database \u0027flush priviledges after cleanup\u0027 do"},{"line_number":66,"context_line":"  database_name \u0027mysql\u0027"},{"line_number":67,"context_line":"  sql \u0027FLUSH PRIVILEGES\u0027"},{"line_number":68,"context_line":"  connection mysql_connection_info"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df87a7cf_fc4f97bb","line":65,"in_reply_to":"df87a7cf_9b20d5f9","updated":"2018-01-04 16:35:23.000000000","message":"Done","commit_id":"332bdfbb91a67afb5ca61d3986177ca54035817d"}]}
