)]}'
{"metadata.rb":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"746c821075ae15ed3a54adc1d9b72c1621e100c5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  supports os"},{"line_number":14,"context_line":"end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":17,"context_line":"depends \u0027rabbitmq\u0027, \u0027\u003e\u003d 3.0.4\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baada198_4283c6a8","line":16,"updated":"2014-08-08 11:51:43.000000000","message":"Should this be updated since the cookbook now depends on the new rabbitmq use_ssl attribute?","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"dcfaed67d4ebaa74cef83e0f2bc35e65d440315b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  supports os"},{"line_number":14,"context_line":"end"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":17,"context_line":"depends \u0027rabbitmq\u0027, \u0027\u003e\u003d 3.0.4\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baada198_0b2526ad","line":16,"in_reply_to":"baada198_4283c6a8","updated":"2014-08-15 06:07:25.000000000","message":"yes, this need the openstack-common merged firstly","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"}],"recipes/rabbitmq-server.rb":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5de289daf91e6a50ccf3227b36c0a18513529ec0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"unless node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027mq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"end"},{"line_number":39,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027address\u0027] \u003d listen_address"},{"line_number":40,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027default_user\u0027] \u003d user"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"baada198_edc4f862","line":37,"updated":"2014-08-07 11:34:03.000000000","message":"This is for the non-ssl case but what about setting default[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] for the ssl case.","commit_id":"dee0b073a51fef899e6981586beb9de32ac3649e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"71b314d97cc40ebe636e694cf74c5efa41cdb588","unresolved":false,"context_lines":[{"line_number":34,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"unless node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027mq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"end"},{"line_number":39,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027address\u0027] \u003d listen_address"},{"line_number":40,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027default_user\u0027] \u003d user"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"baada198_e51168f9","line":37,"in_reply_to":"baada198_edc4f862","updated":"2014-08-08 06:02:25.000000000","message":"in rabbitmq cookbook,  default[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] is 5671  , but default[\u0027rabbitmq\u0027][\u0027port\u0027] is nil","commit_id":"dee0b073a51fef899e6981586beb9de32ac3649e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"746c821075ae15ed3a54adc1d9b72c1621e100c5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"unless node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"end"},{"line_number":39,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027address\u0027] \u003d listen_address"},{"line_number":40,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027default_user\u0027] \u003d user"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baada198_a2c4a20e","line":37,"updated":"2014-08-08 11:51:43.000000000","message":"My previous point was that this recipe needs to use the rabbit_endpoint.port for both ssl and non-ssl cases.  Otherwise, there could be a mismatch between the OpenStack services and rabbitmq with respect to the port.","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"dcfaed67d4ebaa74cef83e0f2bc35e65d440315b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"unless node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"end"},{"line_number":39,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027address\u0027] \u003d listen_address"},{"line_number":40,"context_line":"node.override[\u0027rabbitmq\u0027][\u0027default_user\u0027] \u003d user"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7ac7a964_fe4f59bc","line":37,"in_reply_to":"baada198_a2c4a20e","updated":"2014-08-15 06:07:25.000000000","message":"yes, should check both ssl and non-ssl cases.","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"76362505ebd96dfeb424b67b1dda7d8c98267728","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":42,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1abeadc6_8110b4a9","line":39,"updated":"2014-08-19 14:47:53.000000000","message":"Do we need to consider an else leg here that if the ports match, we raise an error?","commit_id":"50a37a3dd771483c67b4e89f91869287bb22f9aa"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"db29fee57cff78b93a9b8a9539529025b218d1df","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":37,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":42,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1abeadc6_67db5e4f","line":39,"in_reply_to":"1abeadc6_8110b4a9","updated":"2014-08-21 14:10:59.000000000","message":"added Chef::Log.error, it will not break chef client running, but output the info to log file.","commit_id":"50a37a3dd771483c67b4e89f91869287bb22f9aa"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"9fe45c3248c2ccf35d397a1d8a82b28f7dca5a91","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":39,"context_line":"  else"},{"line_number":40,"context_line":"    Chef::Log.error \u0027Configuring rabbitmq port exception report!\u0027"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":"else"},{"line_number":43,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"1abeadc6_d4f62890","line":40,"updated":"2014-08-25 13:45:27.000000000","message":"I think this error should be more descriptive and actually say what went wrong in this case. What is wrong with the ssl_port being the same as the normal port? When can this happen?","commit_id":"133cc420a1f140b0c70a205c822be8c3696bb7ee"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"0d3c0852148a3784d35a9cbe7b14d608af85f195","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":38,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"},{"line_number":39,"context_line":"  else"},{"line_number":40,"context_line":"    Chef::Log.error \u0027Configuring rabbitmq port exception report!\u0027"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":"else"},{"line_number":43,"context_line":"  node.override[\u0027rabbitmq\u0027][\u0027port\u0027] \u003d rabbit_endpoint.port"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"1abeadc6_8f73a414","line":40,"in_reply_to":"1abeadc6_d4f62890","updated":"2014-08-26 01:35:22.000000000","message":"Done","commit_id":"133cc420a1f140b0c70a205c822be8c3696bb7ee"}],"spec/rabbitmq-server_spec.rb":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"746c821075ae15ed3a54adc1d9b72c1621e100c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      it \u0027overrides rabbit ssl attributes\u0027 do"},{"line_number":44,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]).to be_truthy"},{"line_number":45,"context_line":"        expect(chef_run.node[\u0027rabbitmq\u0027][\u0027port\u0027]).to be_nil"},{"line_number":46,"context_line":"      end"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baada198_a2ebc279","line":45,"updated":"2014-08-08 11:51:43.000000000","message":"This should validate that the rabbitmq ssl port is set correctly.","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"dcfaed67d4ebaa74cef83e0f2bc35e65d440315b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      it \u0027overrides rabbit ssl attributes\u0027 do"},{"line_number":44,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]).to be_truthy"},{"line_number":45,"context_line":"        expect(chef_run.node[\u0027rabbitmq\u0027][\u0027port\u0027]).to be_nil"},{"line_number":46,"context_line":"      end"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7ac7a964_3e4ab1ac","line":45,"in_reply_to":"baada198_a2ebc279","updated":"2014-08-15 06:07:25.000000000","message":"Done","commit_id":"8c625c84992219fb1733ab3f8b9d2d61d83f3020"}]}