)]}'
{"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"654c27c15a5d06cf87f8f745de1c943fbb32f342","unresolved":false,"context_lines":[{"line_number":9,"context_line":"recipe \u0027server\u0027, \u0027Installs and configures server packages for messaging queue used by the deployment.\u0027"},{"line_number":10,"context_line":"recipe \u0027rabbitmq-server\u0027, \u0027Installs and configures RabbitMQ and is called via the server recipe\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"%w(fedora ubuntu redhat centos suse).each do |os|"},{"line_number":13,"context_line":"  supports os"},{"line_number":14,"context_line":"end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a5ae5dd_4d472dbc","line":12,"updated":"2016-02-05 17:13:30.000000000","message":"Keep consistent with Common  ubuntu, redhat, centos","commit_id":"792b99660e51c1950f3af7ee70a63bebae57f9db"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"1158878c1646c65380ede3cb04863d5d03949a73","unresolved":false,"context_lines":[{"line_number":9,"context_line":"recipe \u0027server\u0027, \u0027Installs and configures server packages for messaging queue used by the deployment.\u0027"},{"line_number":10,"context_line":"recipe \u0027rabbitmq-server\u0027, \u0027Installs and configures RabbitMQ and is called via the server recipe\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"%w(fedora ubuntu redhat centos suse).each do |os|"},{"line_number":13,"context_line":"  supports os"},{"line_number":14,"context_line":"end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a5ae5dd_45ccb4ba","line":12,"in_reply_to":"5a5ae5dd_4d472dbc","updated":"2016-02-08 09:42:57.000000000","message":"Done","commit_id":"792b99660e51c1950f3af7ee70a63bebae57f9db"}],"recipes/rabbitmq-server.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"654c27c15a5d06cf87f8f745de1c943fbb32f342","unresolved":false,"context_lines":[{"line_number":39,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":40,"context_line":"if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":41,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":42,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] \u003d rabbit_endpoint.port"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    Chef::Log.error \u0027Unable to listen on the port #{rabbit_endpoint.port} for RabbitMQ TCP, which is listened on by SSL!\u0027"},{"line_number":45,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a5ae5dd_8d8be5c2","line":42,"updated":"2016-02-05 17:13:30.000000000","message":"humm, I recall this was meant to be just port because of something in the rabbit cookbook (I think rabbit did some internal checking to see if the ports matched)    Have you tested the ssl path?    I would rather leave this alone and fix it later if needed.","commit_id":"792b99660e51c1950f3af7ee70a63bebae57f9db"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"1158878c1646c65380ede3cb04863d5d03949a73","unresolved":false,"context_lines":[{"line_number":39,"context_line":"node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027listen\u0027] \u003d listen_address"},{"line_number":40,"context_line":"if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027use_ssl\u0027]"},{"line_number":41,"context_line":"  if node[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] !\u003d rabbit_endpoint.port"},{"line_number":42,"context_line":"    node.override[\u0027rabbitmq\u0027][\u0027ssl_port\u0027] \u003d rabbit_endpoint.port"},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    Chef::Log.error \u0027Unable to listen on the port #{rabbit_endpoint.port} for RabbitMQ TCP, which is listened on by SSL!\u0027"},{"line_number":45,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a5ae5dd_657c50ec","line":42,"in_reply_to":"5a5ae5dd_8d8be5c2","updated":"2016-02-08 09:42:57.000000000","message":"I do not see how this should work if just setting the [\u0027rabbitmq\u0027][\u0027port\u0027] and could not find a logic in the rabbitmq cookbook to make this work. The old spec was just working since it was using the default ssl_port 5671, which is set by the rabbitmq cookbook no matter what. If we want to keep it like that, we need to change or remove the corresponding spec.","commit_id":"792b99660e51c1950f3af7ee70a63bebae57f9db"}]}