)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1a831483d2d1477e97026db0df4da21fbcd31a9f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027service_role\u0027] \u003d \u0027admin\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027] \u003d node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# clients configurations"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] \u003d nil"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baa201ad_df020e3d","line":44,"updated":"2014-10-16 16:04:25.000000000","message":"Please add the full comments for each of these on the line above each one.  We are trying to move toward auto-gen Readme attr section based from comments in this file. thx.","commit_id":"31a6d7e2569d88e508b066f897acffe4ec0819bc"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"39aa03dbfa87151014cf4fbe444037b90311611a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027service_role\u0027] \u003d \u0027admin\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027] \u003d node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# clients configurations"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] \u003d nil"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baa201ad_f8bfe9cd","line":44,"in_reply_to":"baa201ad_df020e3d","updated":"2014-10-16 16:41:48.000000000","message":"Done","commit_id":"31a6d7e2569d88e508b066f897acffe4ec0819bc"}],"spec/spec_helper.rb":[{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"5a22d1b28b0c40bea8b8d936e310215819d6d2ee","unresolved":false,"context_lines":[{"line_number":247,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":248,"context_line":"        end"},{"line_number":249,"context_line":"      end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      it \u0027has no such values\u0027 do"},{"line_number":252,"context_line":"        ["},{"line_number":253,"context_line":"          /^ca_file\u003d/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9aa7fdbe_55122ab5","line":250,"updated":"2014-10-20 10:09:48.000000000","message":"I feel like the tests here should have followed the existing style. Look at \u0027domain values\u0027 below. There is a separate section defined for them and then two test cases inside, one for no default values and one for setting custom values. \n\nRight now this test case reads as: \"default values ... has no such values\" which is confusing.","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"4faa2c6664a0a160a9294252449075454337b2af","unresolved":false,"context_lines":[{"line_number":247,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":248,"context_line":"        end"},{"line_number":249,"context_line":"      end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      it \u0027has no such values\u0027 do"},{"line_number":252,"context_line":"        ["},{"line_number":253,"context_line":"          /^ca_file\u003d/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9aa7fdbe_b4b6ef88","line":250,"in_reply_to":"9aa7fdbe_55122ab5","updated":"2014-10-20 15:17:00.000000000","message":"thanks for the comment. Seems that a separate commit to re-org all the test cases in the spec is a good choice, so far as I see, \"default values ... has no such values\"  here means that \" 1st part: the default values for these attributes are XXX and  2nd part: it should not have these inside\".  So let\u0027s try do that in another commit to reorg all the cases. thanks again for the comment","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"b5867ea57688322fe68026193bb5439512476ebb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":248,"context_line":"        end"},{"line_number":249,"context_line":"      end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      it \u0027has no such values\u0027 do"},{"line_number":252,"context_line":"        ["},{"line_number":253,"context_line":"          /^ca_file\u003d/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9aa7fdbe_cd958541","line":250,"in_reply_to":"9aa7fdbe_b4b6ef88","updated":"2014-10-21 14:32:19.000000000","message":"I\u0027m not saying we should reorganize all the test cases. As far as I\u0027m concerned the existing test cases are fine. What I don\u0027t understand is why your commit didn\u0027t stick to the existing organization. \n\nI see no reason to create a second commit just to remedy the problems with this one.","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"}],"templates/default/heat.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3098804d006d095e2b8ebfe155acb0dfcdcafaa1","unresolved":false,"context_lines":[{"line_number":604,"context_line":"# Optional CA cert file to use in SSL connections. (string"},{"line_number":605,"context_line":"# value)"},{"line_number":606,"context_line":"#ca_file\u003d\u003cNone\u003e"},{"line_number":607,"context_line":"\u003c% unless node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027].nil? %\u003e"},{"line_number":608,"context_line":"ca_file\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":609,"context_line":"\u003c% end %\u003e"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-erb","patch_set":4,"id":"baa201ad_7f6922f8","line":607,"updated":"2014-10-16 16:05:31.000000000","message":"to be cleaner, use\n\n\u003c% if node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] %\u003e\n\nhere and below?   avoid the dbl negative.","commit_id":"31a6d7e2569d88e508b066f897acffe4ec0819bc"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"39aa03dbfa87151014cf4fbe444037b90311611a","unresolved":false,"context_lines":[{"line_number":604,"context_line":"# Optional CA cert file to use in SSL connections. (string"},{"line_number":605,"context_line":"# value)"},{"line_number":606,"context_line":"#ca_file\u003d\u003cNone\u003e"},{"line_number":607,"context_line":"\u003c% unless node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027].nil? %\u003e"},{"line_number":608,"context_line":"ca_file\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":609,"context_line":"\u003c% end %\u003e"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-erb","patch_set":4,"id":"baa201ad_78e4d90c","line":607,"in_reply_to":"baa201ad_7f6922f8","updated":"2014-10-16 16:41:48.000000000","message":"thanks,Mark. I changed it to sth like line#136.","commit_id":"31a6d7e2569d88e508b066f897acffe4ec0819bc"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"1604dd81619d98c3d8772c62deb0fb2e70946095","unresolved":false,"context_lines":[{"line_number":763,"context_line":"#ca_file\u003d\u003cNone\u003e"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"# Optional PEM-formatted certificate chain file. (string"},{"line_number":766,"context_line":"# value)"},{"line_number":767,"context_line":"#cert_file\u003d\u003cNone\u003e"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"# Optional PEM-formatted file that contains the private key."}],"source_content_type":"application/x-erb","patch_set":5,"id":"9aa7fdbe_405b2e87","line":766,"updated":"2014-10-21 02:46:27.000000000","message":"clients_keystone.cert_file, this is used by heat_keystoneclient_v2, shouldn\u0027t add that change too?","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"83214bf5b7dc3a4a1b4d82df1f72ab2ed2f90c5d","unresolved":false,"context_lines":[{"line_number":763,"context_line":"#ca_file\u003d\u003cNone\u003e"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"# Optional PEM-formatted certificate chain file. (string"},{"line_number":766,"context_line":"# value)"},{"line_number":767,"context_line":"#cert_file\u003d\u003cNone\u003e"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"# Optional PEM-formatted file that contains the private key."}],"source_content_type":"application/x-erb","patch_set":5,"id":"9aa7fdbe_0c315d5a","line":766,"in_reply_to":"9aa7fdbe_037a10f1","updated":"2014-10-21 06:49:35.000000000","message":"ok, so the heat client call will fall into the clients section configurations if clients_\u003ccomponent\u003e not configured. I am ok with configuration with clients.","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"c97b5ad7800c9771b0861890398f82b9a0c55f2c","unresolved":false,"context_lines":[{"line_number":763,"context_line":"#ca_file\u003d\u003cNone\u003e"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"# Optional PEM-formatted certificate chain file. (string"},{"line_number":766,"context_line":"# value)"},{"line_number":767,"context_line":"#cert_file\u003d\u003cNone\u003e"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"# Optional PEM-formatted file that contains the private key."}],"source_content_type":"application/x-erb","patch_set":5,"id":"9aa7fdbe_037a10f1","line":766,"in_reply_to":"9aa7fdbe_405b2e87","updated":"2014-10-21 03:56:50.000000000","message":"thanks for the comment. If these are not configured here, it will use the attributes defined in [clients] section. that is why i didnt configure them under this section.","commit_id":"51c940a0e8e6525915e1c3135bad276d7a063320"}]}