)]}'
{"recipes/identity_registration.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"bd65e5d1c3795d9385665fb3a76553adc8a274e1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  cert_file \u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027]"},{"line_number":153,"context_line":"  key_file \u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027key_file\u0027]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  execute \"heat-keystone-setup-domain #{secure_flag}\" do"},{"line_number":156,"context_line":"    environment \u0027OS_USERNAME\u0027 \u003d\u003e admin_user,"},{"line_number":157,"context_line":"                \u0027OS_PASSWORD\u0027 \u003d\u003e admin_pass,"},{"line_number":158,"context_line":"                \u0027OS_AUTH_URL\u0027 \u003d\u003e auth_url,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a8c0949_42d76dbf","line":155,"updated":"2014-11-07 09:20:16.000000000","message":"I don\u0027t think we want or need a calc\u0027d value in the resource name.  \nI would rather keep that resource name simple and specify the unique command via the resource cmd attribute.\n\nIf you want more info, just add some logging entries here.\n\nAnd since this contains a password, we should probably add \"sensitive true\" attribute to this resource.","commit_id":"782acae8bb9f6692c173685c4051866e51309707"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"664d189af3e7478b33cba7c618c3bebcd024b490","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  cert_file \u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027]"},{"line_number":153,"context_line":"  key_file \u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027key_file\u0027]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  execute \"heat-keystone-setup-domain #{secure_flag}\" do"},{"line_number":156,"context_line":"    environment \u0027OS_USERNAME\u0027 \u003d\u003e admin_user,"},{"line_number":157,"context_line":"                \u0027OS_PASSWORD\u0027 \u003d\u003e admin_pass,"},{"line_number":158,"context_line":"                \u0027OS_AUTH_URL\u0027 \u003d\u003e auth_url,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a8c0949_555649d3","line":155,"in_reply_to":"7a8c0949_42d76dbf","updated":"2014-11-07 09:34:15.000000000","message":"Mark, thanks for review. \nSo you are suggesting using below?\nexecute \"heat-keystone-setup-domain\" do\n   environment ...\n   command \"heat-keystone-setup-domain ..\"\nend\n\nThis command will not contain password, only a argument like \u0027--insecure\u0027 which decided from a boolean attribute defined in cookbook.","commit_id":"782acae8bb9f6692c173685c4051866e51309707"}],"spec/identity_registration_spec.rb":[{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"f6ad51d390d2a0ce6598efa149727f6797b0dfe3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027stack_user_domain_name\u0027] \u003d \u0027stack_user_domain_name\u0027"},{"line_number":154,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027stack_domain_admin\u0027] \u003d \u0027stack_domain_admin\u0027"},{"line_number":155,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027insecure\u0027] \u003d true"},{"line_number":156,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] \u003d \u0027path/cacert\u0027"},{"line_number":157,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027] \u003d \u0027path/cert_file\u0027"},{"line_number":158,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027key_file\u0027] \u003d \u0027path/key_file\u0027"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"5a890539_88e9af82","line":156,"updated":"2014-11-12 04:55:40.000000000","message":"If using insecure mode, no need to set ca_file cert_file key_file. \nWe can keep them as nil, it\u0027s more like a real world usage. Not a blocker any way.","commit_id":"2b5e5ec2c2505b217e9ae4c3b269ff9154561cea"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"c0530e7c835315fd123f2facb6a6fbee522bcad7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027stack_user_domain_name\u0027] \u003d \u0027stack_user_domain_name\u0027"},{"line_number":154,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027stack_domain_admin\u0027] \u003d \u0027stack_domain_admin\u0027"},{"line_number":155,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027insecure\u0027] \u003d true"},{"line_number":156,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027ca_file\u0027] \u003d \u0027path/cacert\u0027"},{"line_number":157,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027cert_file\u0027] \u003d \u0027path/cert_file\u0027"},{"line_number":158,"context_line":"      node.set[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027clients\u0027][\u0027key_file\u0027] \u003d \u0027path/key_file\u0027"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"5a890539_aeaf5393","line":156,"in_reply_to":"5a890539_88e9af82","updated":"2014-11-12 06:28:05.000000000","message":"that\u0027s ok. In real case, if insecure and put the cert, the operation can be success.","commit_id":"2b5e5ec2c2505b217e9ae4c3b269ff9154561cea"}]}