)]}'
{"attributes/default.rb":[{"author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"change_message_id":"a524a1971e24f388a492973a9301392a508ccdf0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027service_role\u0027] \u003d \u0027service\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027ec2authtoken\u0027][\u0027auth\u0027][\u0027version\u0027] \u003d \u0027v2.0\u0027"},{"line_number":56,"context_line":"default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027] \u003d \u0027v3.0\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# platform-specific settings"},{"line_number":59,"context_line":"case node[\u0027platform_family\u0027]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7faddb67_7ab905ca","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":72},"updated":"2019-07-15 09:09:29.000000000","message":"IMO this can be dropped entirely, since it isn\u0027t used/needed anymore","commit_id":"9e9c2444572653a54cb2e08b82928a2557f66a79"}],"recipes/common.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0b9c20ba8f38a340baae40ab06a0d928c34c7c9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"db_pass \u003d get_password \u0027db\u0027, \u0027heat\u0027"},{"line_number":53,"context_line":"stack_domain_admin \u003d node[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027stack_domain_admin\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"bind_services \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027]"},{"line_number":58,"context_line":"api_bind \u003d bind_services[\u0027orchestration-api\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7faddb67_0cf6545e","line":55,"updated":"2019-08-06 08:20:11.000000000","message":"In most other cookbooks we have switched to using the internal endpoint for this, I think we should follow that lead here.","commit_id":"cd52c71b6cdb4616c25c12b2bc64a9db84df9dda"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0b9c20ba8f38a340baae40ab06a0d928c34c7c9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ec2_auth_uri \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":63,"context_line":"auth_uri \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":64,"context_line":"base_auth_uri \u003d public_endpoint \u0027identity\u0027"},{"line_number":65,"context_line":"base_auth_uri.path \u003d \u0027/\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# We need these URIs without their default path"},{"line_number":68,"context_line":"metadata_uri \u003d \"#{api_cfn_endpoint.scheme}://#{api_cfn_endpoint.host}:#{api_cfn_endpoint.port}\""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7faddb67_2cdc70e2","line":65,"updated":"2019-08-06 08:20:11.000000000","message":"This most certainly is wrong, we want to allow for base URLs like \"http://api/identity\" like devstack uses them now.\n\nI think with recent advances in discovery, we should be able to assume that our identity endpoints are the plain unversioned endpoints and drop all this URL mangling completely. We need to verify this in detail with how heat works, though.","commit_id":"cd52c71b6cdb4616c25c12b2bc64a9db84df9dda"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0b9c20ba8f38a340baae40ab06a0d928c34c7c9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"base_auth_uri.path \u003d \u0027/\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# We need these URIs without their default path"},{"line_number":68,"context_line":"metadata_uri \u003d \"#{api_cfn_endpoint.scheme}://#{api_cfn_endpoint.host}:#{api_cfn_endpoint.port}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# define attributes that are needed in the heat.conf"},{"line_number":71,"context_line":"node.default[\u0027openstack\u0027][\u0027orchestration\u0027][\u0027conf\u0027].tap do |conf|"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7faddb67_0cddf4db","line":68,"updated":"2019-08-06 08:20:11.000000000","message":"This is wrong, too, once we want to allow path-based selection of APIs instead of port-based.","commit_id":"cd52c71b6cdb4616c25c12b2bc64a9db84df9dda"}],"recipes/identity_registration.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0b9c20ba8f38a340baae40ab06a0d928c34c7c9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  include ::Openstack"},{"line_number":25,"context_line":"end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"auth_url \u003d ::URI.decode identity_endpoint.to_s"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7faddb67_4c00cc34","line":27,"updated":"2019-08-06 08:20:11.000000000","message":"In most other cookbooks we have switched to using the internal endpoint for this, I think we should follow that lead here.","commit_id":"cd52c71b6cdb4616c25c12b2bc64a9db84df9dda"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0b9c20ba8f38a340baae40ab06a0d928c34c7c9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"admin_domain \u003d node[\u0027openstack\u0027][\u0027identity\u0027][\u0027admin_domain_name\u0027]"},{"line_number":49,"context_line":"region \u003d node[\u0027openstack\u0027][\u0027region\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"connection_params \u003d {"},{"line_number":52,"context_line":"  openstack_auth_url:     auth_url,"},{"line_number":53,"context_line":"  openstack_username:     admin_user,"},{"line_number":54,"context_line":"  openstack_api_key:      admin_pass,"},{"line_number":55,"context_line":"  openstack_project_name: admin_project,"},{"line_number":56,"context_line":"  openstack_domain_name:    admin_domain,"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -"},{"line_number":60,"context_line":"# Create Orchestration service, endpoints"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7faddb67_8c9fa400","line":57,"range":{"start_line":51,"start_character":0,"end_line":57,"end_character":1},"updated":"2019-08-06 08:20:11.000000000","message":"While touching this, I think we should add a TODO note about the still missing endpoint selection here, like we have in the other cookbooks.\n\nSadly the fix we need for that in fog-openstack hasn\u0027t been released yet.","commit_id":"cd52c71b6cdb4616c25c12b2bc64a9db84df9dda"}]}