)]}'
{"README.md":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ca368b724c62c2b598c97e2e9549469722f29828","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Docker configuration Attributes"},{"line_number":83,"context_line":"-------------------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* `[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027enable\u0027]` - Mark this as true to to enable docker support. Docker computes are supported only in Ubuntu and Rhel"},{"line_number":86,"context_line":"* `[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027group\u0027]` - Docker group which will be created(if not already created) and added with openstack telemetry user"},{"line_number":87,"context_line":"* `[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027hypervisor_inspector\u0027]` - Hypervisor inspector type when docker support is enabled"},{"line_number":88,"context_line":"* `[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027plugin\u0027]` - Additional configurations required to enable ceilometer docker plugin. This may not be required in future releases."}],"source_content_type":"text/x-gfm","patch_set":10,"id":"dac4157f_814fc2bc","line":85,"updated":"2015-04-21 07:40:27.000000000","message":"can add \"default is false\"","commit_id":"82786d114f921515dc3308869acc9758fccd636e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[{"line_number":125,"context_line":"| **Author**           |  Chen Zhiwei (\u003czhiwchen@cn.ibm.com\u003e)               |"},{"line_number":126,"context_line":"| **Author**           |  David Geng (\u003cgengjh@cn.ibm.com\u003e)                  |"},{"line_number":127,"context_line":"| **Author**           |  Mark Vanderwiel (\u003cvanderwl@us.ibm.com\u003e)           |"},{"line_number":128,"context_line":"| **Author**           |  Sudheesh S K (\u003cskairali@in.ibm.com\u003e)           |"},{"line_number":129,"context_line":"|                      |                                                    |"},{"line_number":130,"context_line":"| **Copyright**        |  Copyright (c) 2013, Opscode, Inc.                 |"},{"line_number":131,"context_line":"| **Copyright**        |  Copyright (c) 2013, AT\u0026T Services, Inc.           |"}],"source_content_type":"text/x-gfm","patch_set":10,"id":"dac4157f_a17e5dac","line":128,"updated":"2015-04-20 17:36:56.000000000","message":"last bar aligned?","commit_id":"82786d114f921515dc3308869acc9758fccd636e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[{"line_number":130,"context_line":"| **Copyright**        |  Copyright (c) 2013, Opscode, Inc.                 |"},{"line_number":131,"context_line":"| **Copyright**        |  Copyright (c) 2013, AT\u0026T Services, Inc.           |"},{"line_number":132,"context_line":"| **Copyright**        |  Copyright (c) 2013, Rackspace US, Inc.            |"},{"line_number":133,"context_line":"| **Copyright**        |  Copyright (c) 2013-2014, IBM, Corp.               |"},{"line_number":134,"context_line":"| **Copyright**        |  Copyright (c) 2013-2014, SUSE Linux GmbH          |"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":10,"id":"dac4157f_21492d8c","line":133,"updated":"2015-04-20 17:36:56.000000000","message":"probably should bump to 2015","commit_id":"82786d114f921515dc3308869acc9758fccd636e"}],"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ca368b724c62c2b598c97e2e9549469722f29828","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# Docker configuration is supported only in Rhel and Ubuntu"},{"line_number":155,"context_line":"# This is to be true to enable docker support"},{"line_number":156,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027enable\u0027] \u003d false"},{"line_number":157,"context_line":"# Docker group which will be created(if not already created) and added with openstack telemetry user"},{"line_number":158,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027group\u0027] \u003d \u0027docker\u0027"},{"line_number":159,"context_line":"# Hypervisor inspector type when docker support is enabled"},{"line_number":160,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027hypervisor_inspector\u0027] \u003d \u0027docker\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"dac4157f_81fd823c","line":157,"updated":"2015-04-21 07:40:27.000000000","message":"move this blank line to the above.","commit_id":"82786d114f921515dc3308869acc9758fccd636e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# Hypervisor inspector type when docker support is enabled"},{"line_number":160,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027hypervisor_inspector\u0027] \u003d \u0027docker\u0027"},{"line_number":161,"context_line":"# ceilometer docker plugin configurations"},{"line_number":162,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027plugin\u0027] \u003d {"},{"line_number":163,"context_line":"  \u0027files\u0027 \u003d\u003e [\u0027cadvisorClient.py\u0027, \u0027inspector.py\u0027, \u0027__init__.py\u0027],"},{"line_number":164,"context_line":"  \u0027path\u0027 \u003d\u003e \u0027/ceilometer/compute/virt/docker\u0027,"},{"line_number":165,"context_line":"  \u0027entry_points_file\u0027 \u003d\u003e \u0027/ceilometer-*.egg-info/entry_points.txt\u0027,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"dac4157f_e109f532","line":162,"updated":"2015-04-20 17:36:56.000000000","message":"Are any of these platform specific?  redhat, ubuntu differences?","commit_id":"82786d114f921515dc3308869acc9758fccd636e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ca368b724c62c2b598c97e2e9549469722f29828","unresolved":false,"context_lines":[{"line_number":160,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027hypervisor_inspector\u0027] \u003d \u0027docker\u0027"},{"line_number":161,"context_line":"# ceilometer docker plugin configurations"},{"line_number":162,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027docker\u0027][\u0027plugin\u0027] \u003d {"},{"line_number":163,"context_line":"  \u0027files\u0027 \u003d\u003e [\u0027cadvisorClient.py\u0027, \u0027inspector.py\u0027, \u0027__init__.py\u0027],"},{"line_number":164,"context_line":"  \u0027path\u0027 \u003d\u003e \u0027/ceilometer/compute/virt/docker\u0027,"},{"line_number":165,"context_line":"  \u0027entry_points_file\u0027 \u003d\u003e \u0027/ceilometer-*.egg-info/entry_points.txt\u0027,"},{"line_number":166,"context_line":"  \u0027entry_points_section\u0027 \u003d\u003e \u0027[ceilometer.compute.virt]\u0027,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"dac4157f_c18a5abf","line":163,"updated":"2015-04-21 07:40:27.000000000","message":"agreed with Mark, should specify the platform info.","commit_id":"82786d114f921515dc3308869acc9758fccd636e"}],"files/default/docker-plugin/__init__.py":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dac4157f_d437d1e1","line":1,"updated":"2015-04-20 17:36:56.000000000","message":"empty file?  should at least have a header","commit_id":"82786d114f921515dc3308869acc9758fccd636e"}],"files/default/docker-plugin/cadvisorClient.py":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 dotCloud, Inc."},{"line_number":2,"context_line":"# Copyright 2015 IBM Corp."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"dac4157f_34dded42","line":1,"updated":"2015-04-20 17:36:56.000000000","message":"Is there a better home for all this python code, the cookbook seems like an odd place to maintain this logic.","commit_id":"82786d114f921515dc3308869acc9758fccd636e"}],"recipes/docker-setup.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aed028b551ceec8825c0b55c56620c82f0328b79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"ruby_block \u0027insert docker hypervisor inspector in entrypoints\u0027 do"},{"line_number":50,"context_line":"  block do"},{"line_number":51,"context_line":"    absloute_docker_entry_points_file \u003d (Dir.glob docker_entry_points_file)[0]"},{"line_number":52,"context_line":"    file \u003d File.read(absloute_docker_entry_points_file)"},{"line_number":53,"context_line":"    if File.readlines(absloute_docker_entry_points_file).grep(/^(#{docker_entry_points_config})/).size \u003d\u003d 0"},{"line_number":54,"context_line":"      File.write(absloute_docker_entry_points_file, file.insert(file.index(docker_entry_points_section) + docker_entry_points_section.length, \"\\n\" + docker_entry_points_config))"},{"line_number":55,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"dac4157f_f4cad54e","line":52,"updated":"2015-04-20 17:36:56.000000000","message":"This looks to be touching code source files from an the installed ceilometer python package.  This seems very odd.  I would think there would be just a simple plugin called out from the ceilometer.conf file that would handle this cleaner.","commit_id":"82786d114f921515dc3308869acc9758fccd636e"}]}