)]}'
{"attributes/ceilometer_conf.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d83cde3b96839c018f33675a5b4fc405095ee22","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":4,"context_line":"  # [DEFAULT] section"},{"line_number":5,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027meter_dispatchers\u0027] \u003d \u0027gnocchi\u0027"},{"line_number":6,"context_line":"  # [keystone_authtoken] section"},{"line_number":7,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027username\u0027] \u003d \u0027ceilometer\u0027"},{"line_number":8,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027project_name\u0027] \u003d \u0027service\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_da93634d","side":"PARENT","line":5,"updated":"2019-11-18 15:12:13.000000000","message":"How is this related to dropping telemetry-api?","commit_id":"fd3d9ceb621e5f82a8278cce23e623393a98c160"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"6ae9f0f7e7758baf3b7d166407257f0d6fe8fd1f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"default[\u0027openstack\u0027][\u0027telemetry\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":4,"context_line":"  # [DEFAULT] section"},{"line_number":5,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027meter_dispatchers\u0027] \u003d \u0027gnocchi\u0027"},{"line_number":6,"context_line":"  # [keystone_authtoken] section"},{"line_number":7,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027username\u0027] \u003d \u0027ceilometer\u0027"},{"line_number":8,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027project_name\u0027] \u003d \u0027service\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_06e521a4","side":"PARENT","line":5,"in_reply_to":"3fa7e38b_da93634d","updated":"2019-11-18 23:15:25.000000000","message":"\u003e How is this related to dropping telemetry-api?\n\nThis is more related to this being deprecated in this change: https://review.opendev.org/435899","commit_id":"fd3d9ceb621e5f82a8278cce23e623393a98c160"}],"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d83cde3b96839c018f33675a5b4fc405095ee22","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Set the endpoints for the telemetry services to allow all other cookbooks to"},{"line_number":29,"context_line":"# access and use them"},{"line_number":30,"context_line":"%w(telemetry telemetry_metric aodh).each do |ts|"},{"line_number":31,"context_line":"  %w(public internal admin).each do |ep_type|"},{"line_number":32,"context_line":"    default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][ts][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":33,"context_line":"    default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][ts][\u0027scheme\u0027] \u003d \u0027http\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_ba90e74f","line":30,"updated":"2019-11-18 15:12:13.000000000","message":"Wouldn\u0027t you drop \"telemetry\" from this loop completely, if that is defining the API endpoint?","commit_id":"0c072b88b959519504a59cfa672902d35fa4af7f"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"6ae9f0f7e7758baf3b7d166407257f0d6fe8fd1f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Set the endpoints for the telemetry services to allow all other cookbooks to"},{"line_number":29,"context_line":"# access and use them"},{"line_number":30,"context_line":"%w(telemetry telemetry_metric aodh).each do |ts|"},{"line_number":31,"context_line":"  %w(public internal admin).each do |ep_type|"},{"line_number":32,"context_line":"    default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][ts][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":33,"context_line":"    default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][ts][\u0027scheme\u0027] \u003d \u0027http\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_c6b0698e","line":30,"in_reply_to":"3fa7e38b_ba90e74f","updated":"2019-11-18 23:15:25.000000000","message":"\u003e Wouldn\u0027t you drop \"telemetry\" from this loop completely, if that is\n \u003e defining the API endpoint?\n\nThis is true and the reason I kept it in here was because it was being referenced in identity_registration do to the loop it was using. We still need a \"ceilometer\" service, tenant and user. However we _do not_ need an endpoint.\n\nPerhaps it makes sense to remove it here and refactor identity_registration?","commit_id":"0c072b88b959519504a59cfa672902d35fa4af7f"}],"spec/gnocchi_install_spec.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7d83cde3b96839c018f33675a5b4fc405095ee22","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    include_context \u0027telemetry-stubs\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    it do"},{"line_number":14,"context_line":"      expect(chef_run).to upgrade_package \u0027gnocchi-api\u0027"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_7a6fcf5f","side":"PARENT","line":14,"updated":"2019-11-18 15:12:13.000000000","message":"Hmm, gnocchi-api seems different from telemetry-api, why is this being dropped?","commit_id":"fd3d9ceb621e5f82a8278cce23e623393a98c160"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"6ae9f0f7e7758baf3b7d166407257f0d6fe8fd1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    include_context \u0027telemetry-stubs\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    it do"},{"line_number":14,"context_line":"      expect(chef_run).to upgrade_package \u0027gnocchi-api\u0027"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_a651ad32","side":"PARENT","line":14,"in_reply_to":"3fa7e38b_7a6fcf5f","updated":"2019-11-18 23:15:25.000000000","message":"Done","commit_id":"fd3d9ceb621e5f82a8278cce23e623393a98c160"}]}