)]}'
{"id":"openstack%2Fcookbook-openstackclient~747542","triplet_id":"openstack%2Fcookbook-openstackclient~master~Iaa0ccfa7dd47a729423fc7ce1115849a282d2511","project":"openstack/cookbook-openstackclient","branch":"master","topic":"chef-16","hashtags":[],"change_id":"Iaa0ccfa7dd47a729423fc7ce1115849a282d2511","subject":"Cookstyle fixes for Chef 16","status":"MERGED","created":"2020-08-22 20:52:21.000000000","updated":"2020-09-02 16:43:11.000000000","submitted":"2020-09-02 16:43:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747542-1599064991375-b29784c5","meta_rev_id":"0ed3e6a51ae3e6eaee51833461e87f88bdaecb44","_number":747542,"virtual_id_number":747542,"owner":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-02 16:43:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-08-26 09:47:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2020-09-02 15:26:32.000000000","_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-26 09:47:42.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-09-02 16:43:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e93b75ba3fe20eb56289a60fcbfff343d8135dbc","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-08-22 20:52:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0200453eb87057fcd395a12f53f2206b53d9f82","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-08-22 21:02:15.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"de20dd35b1780c45668ba3011fb9317ebc056f8c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-22 21:57:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/4b2133fe326c4c898b049f89824cc220 : SUCCESS in 5m 21s\n- openstack-chef-integration-centos-15 https://zuul.opendev.org/t/openstack/build/61d48304712b444cb2d4703490d0013a : SUCCESS in 17m 57s (non-voting)\n- openstack-chef-integration-centos-16 https://zuul.opendev.org/t/openstack/build/c7e1bae937e1412dacc0fc9a2b91337a : FAILURE in 20m 22s (non-voting)\n- openstack-chef-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/91da0274bbb54051bb5d6a96b131ab32 : SUCCESS in 20m 47s (non-voting)\n- openstack-chef-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/8b440a38c1854e4381b5edac44567fb6 : FAILURE in 17m 11s (non-voting)\n- openstack-chef-minimal-integration-centos-15 https://zuul.opendev.org/t/openstack/build/14f3e2e9921e448da6c1d6b91c4b9e3f : SUCCESS in 53m 50s (non-voting)\n- openstack-chef-minimal-integration-centos-16 https://zuul.opendev.org/t/openstack/build/e1daaeb32d6942c1aedad8deabdf1bac : FAILURE in 39m 13s (non-voting)\n- openstack-chef-minimal-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/dc4c6f1680b2485c931f6792768022b9 : SUCCESS in 47m 15s (non-voting)\n- openstack-chef-minimal-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/166bd64ac1844659827430773f8bb688 : FAILURE in 26m 33s (non-voting)\n- openstack-cinc-integration-centos-15 https://zuul.opendev.org/t/openstack/build/a5a4291bff0d474f83a18ff2baebe051 : SUCCESS in 15m 54s (non-voting)\n- openstack-cinc-integration-centos-16 https://zuul.opendev.org/t/openstack/build/d800c336867d4833a4fd87312830205e : FAILURE in 20m 08s (non-voting)\n- openstack-cinc-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/d43ade0b6df742b6bab35ffd3c0c22a8 : SUCCESS in 15m 36s (non-voting)\n- openstack-cinc-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/b1091b3330e0451d8cb8021478848210 : FAILURE in 18m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e5907203c38716b0b7afd2e3504ebe7b696be2cf","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-08-24 02:24:02.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"7d4856123aa6ee2e5a83514266bf306dc5066dad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 03:16:20.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/c5d551eb840e45baa6c32030fc700c0c : SUCCESS in 4m 18s\n- openstack-chef-integration-centos-15 https://zuul.opendev.org/t/openstack/build/a889239f3f8645488ad5a58a0b544ba3 : SUCCESS in 20m 31s (non-voting)\n- openstack-chef-integration-centos-16 https://zuul.opendev.org/t/openstack/build/ee283fb23e3048e8bea0174c164f411d : SUCCESS in 20m 02s (non-voting)\n- openstack-chef-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/0bf911e2148d410d920b2a1baa1e3ebf : SUCCESS in 12m 36s (non-voting)\n- openstack-chef-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/32789d11641e4d72b02276e0a621a3aa : SUCCESS in 13m 13s (non-voting)\n- openstack-chef-minimal-integration-centos-15 https://zuul.opendev.org/t/openstack/build/ba2af847459d41d78b15510c29578fb3 : SUCCESS in 50m 33s (non-voting)\n- openstack-chef-minimal-integration-centos-16 https://zuul.opendev.org/t/openstack/build/d699b4e00d2449ef88db1fe9a4475c10 : SUCCESS in 43m 49s (non-voting)\n- openstack-chef-minimal-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/e3d33ecdfcba40478fa7d4fe789ac72d : SUCCESS in 47m 16s (non-voting)\n- openstack-chef-minimal-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/bcf9113fe8434c40a3ef0ba2cadf3768 : SUCCESS in 36m 38s (non-voting)\n- openstack-cinc-integration-centos-15 https://zuul.opendev.org/t/openstack/build/47d96188da1f46b38bb24bfd3ab0ec22 : SUCCESS in 20m 26s (non-voting)\n- openstack-cinc-integration-centos-16 https://zuul.opendev.org/t/openstack/build/ce20a3be50e2479ebd2d98692a9325c5 : SUCCESS in 16m 50s (non-voting)\n- openstack-cinc-integration-ubuntu-15 https://zuul.opendev.org/t/openstack/build/220f802edc5644dbaa4b7d2942d3aaec : SUCCESS in 19m 32s (non-voting)\n- openstack-cinc-integration-ubuntu-16 https://zuul.opendev.org/t/openstack/build/5362f4270f6c46ee8b19e40343f56bcf : SUCCESS in 15m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e0defc30847ebc8aa350cc53172ed4d5bb54ff9c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-08-26 09:47:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9fcd45e9e2a62dd7ac189d1c953862c0fc9772b9","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-09-02 15:26:32.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"746911721a22cc23c8df885d532b0eab9815d8d5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 15:30:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b44122a1659173c59d4c420097fc0ab8f489ccf2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 16:43:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"28b8079bf13bc1047c9f48983c28e8cf155a05ae","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 16:43:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/c4be6f82f4a74fa4b5c189a5ba3ee35a : SUCCESS in 4m 18s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/ba833b3a781b428e8a0290cd08d7b67a : SUCCESS in 16m 34s (non-voting)\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/7a5200b70ad94d208f083bb45fdbbd84 : SUCCESS in 15m 13s (non-voting)\n- openstack-chef-minimal-integration-centos https://zuul.opendev.org/t/openstack/build/a208684ebca744cfb88f6dd7a511077e : SUCCESS in 51m 12s (non-voting)\n- openstack-chef-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/2641ced05ec64a42ba12e14c2de2a2ed : SUCCESS in 34m 56s (non-voting)\n- openstack-chef15-minimal-integration-centos https://zuul.opendev.org/t/openstack/build/f58f82ec1a6143e99b83d2d4a68527c4 : SUCCESS in 45m 05s (non-voting)\n- openstack-chef15-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/79825768a6e84ba2970e8e213f0e3b9a : SUCCESS in 30m 53s (non-voting)\n- openstack-cinc15-integration-centos https://zuul.opendev.org/t/openstack/build/b032d268aa284a05a134e872155d71dd : SUCCESS in 20m 20s (non-voting)\n- openstack-cinc15-integration-ubuntu https://zuul.opendev.org/t/openstack/build/aae4cfceb0114b30acc0d3297f1085ea : SUCCESS in 16m 43s (non-voting)\n- openstack-cinc-integration-centos https://zuul.opendev.org/t/openstack/build/e2adf05aab024b9aafb1d82d8d42f05e : SUCCESS in 20m 23s (non-voting)\n- openstack-cinc-integration-ubuntu https://zuul.opendev.org/t/openstack/build/ca1ea1cd4a2c461d82bd26aaa399b514 : SUCCESS in 17m 31s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e216cc621e8ea92197ae3a63b3dbf35858564470","revisions":{"d4c37bae00a59def16ceba335e5e40f459c01e05":{"kind":"REWORK","_number":1,"created":"2020-08-22 20:52:21.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/42/747542/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstackclient","ref":"refs/changes/42/747542/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/1"}}},"commit":{"parents":[{"commit":"a2d102d5e24b08a2d611a00bbe513c94a21c3f9f","subject":"Merge \"Updates for Train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/a2d102d5e24b08a2d611a00bbe513c94a21c3f9f"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-08-22 20:50:51.000000000","tz":-420},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-08-22 20:51:45.000000000","tz":-420},"subject":"Cookstyle fixes for Chef 16","message":"Cookstyle fixes for Chef 16\n\nAlso loosen the fog-openstack dependency a bit since this is now included in\nChef Workstation and will likely cause issues when doing testing.\n\nDepends-On: https://review.opendev.org/747503\nChange-Id: Iaa0ccfa7dd47a729423fc7ce1115849a282d2511\nSigned-off-by: Lance Albertson \u003clance@osuosl.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/d4c37bae00a59def16ceba335e5e40f459c01e05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/d4c37bae00a59def16ceba335e5e40f459c01e05"}]},"branch":"refs/heads/master"},"e216cc621e8ea92197ae3a63b3dbf35858564470":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-08-22 21:02:15.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/42/747542/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstackclient","ref":"refs/changes/42/747542/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/42/747542/2"}}},"commit":{"parents":[{"commit":"a2d102d5e24b08a2d611a00bbe513c94a21c3f9f","subject":"Merge \"Updates for Train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/a2d102d5e24b08a2d611a00bbe513c94a21c3f9f"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-08-22 20:50:51.000000000","tz":-420},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-08-22 21:02:00.000000000","tz":-420},"subject":"Cookstyle fixes for Chef 16","message":"Cookstyle fixes for Chef 16\n\nAlso loosen the fog-openstack dependency a bit since this is now included in\nChef Workstation and will likely cause issues when doing testing.\n\nDepends-On: https://review.opendev.org/747503\nDepends-On: https://review.opendev.org/740342\nChange-Id: Iaa0ccfa7dd47a729423fc7ce1115849a282d2511\nSigned-off-by: Lance Albertson \u003clance@osuosl.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/e216cc621e8ea92197ae3a63b3dbf35858564470"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/e216cc621e8ea92197ae3a63b3dbf35858564470"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}