)]}'
{"id":"openstack%2Fcookbook-openstackclient~838416","triplet_id":"openstack%2Fcookbook-openstackclient~master~I33601eb5595c794a9a025417ed3bc88cfa6cfaf0","project":"openstack/cookbook-openstackclient","branch":"master","topic":"openstackclient-idempotency","hashtags":[],"change_id":"I33601eb5595c794a9a025417ed3bc88cfa6cfaf0","subject":"Migrate to using converge_by and fix idempotency issues","status":"MERGED","created":"2022-04-18 23:55:53.000000000","updated":"2022-06-03 23:03:27.000000000","submitted":"2022-06-03 23:03:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"838416-openstackclient-idempotency","meta_rev_id":"8155386d97e3985231f2c6d96e3ab14dd9f2e5b8","_number":838416,"virtual_id_number":838416,"owner":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-03 23:03:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-06-03 21:56:07.000000000","_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-06-03 21:56:07.000000000","_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-19 00:25:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9225302f02fedc3e28e3f4778cecb932f2c477f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2022-04-18 23:55:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"641b3d40a11a2540066c5e79cc4234a909f4eed1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-19 00:25:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/db3c5f1c705046fc88c0f0ee4ffb63fd : SUCCESS in 3m 43s (non-voting)\n- openstack-chef-integration-centos-7 https://zuul.opendev.org/t/openstack/build/48ddf44f782f4768bae5f38496863d1a : FAILURE in 15m 15s (non-voting)\n- openstack-chef-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/47ae284a0f4a4efca3bcac69b23e0a33 : FAILURE in 22m 06s (non-voting)\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/e6576d50630c485dbb46bc2acc88e581 : FAILURE in 10m 49s (non-voting)\n- openstack-chef-minimal-integration-centos-7 https://zuul.opendev.org/t/openstack/build/3807b50cbcc04d81a8221e82bc44194a : FAILURE in 15m 32s (non-voting)\n- openstack-chef-minimal-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/cc887e04b413455097114b514b59cb15 : FAILURE in 20m 00s (non-voting)\n- openstack-chef-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/47de2eea807d496382a63d93ac1c55ca : FAILURE in 24m 42s (non-voting)\n- openstack-chef16-minimal-integration-centos-7 https://zuul.opendev.org/t/openstack/build/828ef6597b1d457e83b31c2b3a944c1c : FAILURE in 14m 05s (non-voting)\n- openstack-chef16-minimal-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/5a3f847e5b6a4f04bf8a4f57bf873652 : FAILURE in 18m 07s (non-voting)\n- openstack-chef16-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/3740712ac79747849c16ef19abd6166b : FAILURE in 28m 49s (non-voting)\n- openstack-cinc16-integration-centos-7 https://zuul.opendev.org/t/openstack/build/40aa1edd8adc46c695bf1102adfb368d : FAILURE in 18m 57s (non-voting)\n- openstack-cinc16-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/500963b73c6d461099ab314530ab6bc2 : FAILURE in 17m 26s (non-voting)\n- openstack-cinc16-integration-ubuntu https://zuul.opendev.org/t/openstack/build/3811c5d2c3394b30aebdaa720352d622 : FAILURE in 11m 35s (non-voting)\n- openstack-cinc-integration-centos-7 https://zuul.opendev.org/t/openstack/build/01b1f2ca18d14463a594c72d924a3493 : FAILURE in 18m 24s (non-voting)\n- openstack-cinc-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/01fcdd4ad30c4e6485c8c0e623ef726b : FAILURE in 19m 52s (non-voting)\n- openstack-cinc-integration-ubuntu https://zuul.opendev.org/t/openstack/build/a6646156ca4f4ad59aa78f1b0e23eee3 : FAILURE in 13m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b23e2c007fe86e9633635fc4f1af5a2215351cf4","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2022-06-03 21:56:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8167d86e8b13749a900a0d5c4ceb86bc8ab8fdc2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-03 21:56:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"67173c53b311c2cd6722e39202a0ad5dffa5a648","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-03 23:03:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/cb1b3729e0094ee1b9986a06d96c45cb : SUCCESS in 3m 17s (non-voting)\n- openstack-chef-integration-centos-7 https://zuul.opendev.org/t/openstack/build/b8aed6a7bca742cab6add1fd85ad4ee2 : FAILURE in 17m 48s (non-voting)\n- openstack-chef-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/0a008885afb54428b6e8ed8c831b068a : FAILURE in 28m 17s (non-voting)\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/b9c61d5f1fcd4416a4fbf4062d711fbd : FAILURE in 12m 01s (non-voting)\n- openstack-chef-minimal-integration-centos-7 https://zuul.opendev.org/t/openstack/build/35ccaa26fd1040cda846679afd29c1ac : FAILURE in 16m 41s (non-voting)\n- openstack-chef-minimal-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/bc1ada7dd19b49c79d0276c531a1460b : FAILURE in 28m 47s (non-voting)\n- openstack-chef-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/9c38718730e34ff7969af96f0becd89f : FAILURE in 30m 09s (non-voting)\n- openstack-chef16-minimal-integration-centos-7 https://zuul.opendev.org/t/openstack/build/421b26e0275a4337b839235f55412469 : FAILURE in 17m 51s (non-voting)\n- openstack-chef16-minimal-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/453a94192f994adca7921e3fe8d01a01 : FAILURE in 25m 39s (non-voting)\n- openstack-chef16-minimal-integration-ubuntu https://zuul.opendev.org/t/openstack/build/07c027189ee84d1f8e45ab06590d93f3 : FAILURE in 30m 12s (non-voting)\n- openstack-cinc16-integration-centos-7 https://zuul.opendev.org/t/openstack/build/b59820c08f684a52b57ec8c1b4bc6b20 : FAILURE in 17m 51s (non-voting)\n- openstack-cinc16-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/0ab0e1d4726d44449c5c3d4e678056b8 : FAILURE in 24m 04s (non-voting)\n- openstack-cinc16-integration-ubuntu https://zuul.opendev.org/t/openstack/build/901646dae86345d5bee15c38b56f6f4a : FAILURE in 11m 44s (non-voting)\n- openstack-cinc-integration-centos-7 https://zuul.opendev.org/t/openstack/build/e41de755f24c44a7abef9971d026656e : FAILURE in 13m 06s (non-voting)\n- openstack-cinc-integration-centos-stream-8 https://zuul.opendev.org/t/openstack/build/02eec8bc93c646eea07370c2d46bc1fc : FAILURE in 19m 21s (non-voting)\n- openstack-cinc-integration-ubuntu https://zuul.opendev.org/t/openstack/build/ee968a7086f84ed2b45022ae2034e249 : FAILURE in 11m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8155386d97e3985231f2c6d96e3ab14dd9f2e5b8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-03 23:03:27.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2402afd6709b54a4b8e7d39bd6f08aeba1ed8504","revisions":{"2402afd6709b54a4b8e7d39bd6f08aeba1ed8504":{"kind":"REWORK","_number":1,"created":"2022-04-18 23:55:53.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/16/838416/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstackclient","ref":"refs/changes/16/838416/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/16/838416/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/16/838416/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/16/838416/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstackclient refs/changes/16/838416/1"}}},"commit":{"parents":[{"commit":"9276352d024fa5f57aa2f9d837daa35fadba0a3b","subject":"Chef 17 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/9276352d024fa5f57aa2f9d837daa35fadba0a3b"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2022-04-18 23:49:28.000000000","tz":-420},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2022-04-18 23:55:27.000000000","tz":-420},"subject":"Migrate to using converge_by and fix idempotency issues","message":"Migrate to using converge_by and fix idempotency issues\n\n- Migrate away from using the log resource to using converge_by. This finally\n  fixes idempotency issues we were having with all of these resources\n- Fix :delete action in openstack_domain by disabling the domain prior to\n  destroying it\n- Add missing references to new_resource parameters\n- Fix :delete action in openstack_endpoint resource\n- Add domain_name property in openstack_project resource. This is required and\n  would throw a deprecation warning in the backend system.\n- Fix logic around user grant/revoke actions\n- Cookstyle fixes\n\nDepends-On: https://review.opendev.org/c/openstack/openstack-chef/+/838415\nChange-Id: I33601eb5595c794a9a025417ed3bc88cfa6cfaf0\nSigned-off-by: Lance Albertson \u003clance@osuosl.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/2402afd6709b54a4b8e7d39bd6f08aeba1ed8504"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstackclient/commit/2402afd6709b54a4b8e7d39bd6f08aeba1ed8504"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9276352d024fa5f57aa2f9d837daa35fadba0a3b","is_merged_in_target_branch":true,"change_id":"If7390377bff2c3c37f861138a92f27d7202c29b5","change_number":813953,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}