)]}'
{"cuedashboard/api.py":[{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"67204457e9554115389a7d12b919efe372d22eb9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def cueclient(request):"},{"line_number":31,"context_line":"    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":32,"context_line":"    auth_url \u003d getattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027)"},{"line_number":33,"context_line":"    auth_version \u003d getattr(settings,"},{"line_number":34,"context_line":"                           \u0027OPENSTACK_API_VERSIONS\u0027, {}).get(\u0027identity\u0027, 2.0)"},{"line_number":35,"context_line":"    if auth_version \u003d\u003d 3:"},{"line_number":36,"context_line":"        auth \u003d v3.Token(auth_url, request.user.token.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_0fabe48a","line":33,"updated":"2015-08-17 19:03:15.000000000","message":"Do we have any guarantee what getattr() will write into auth_version (string or int)?  We may want to type-cast it somewhere with str(getattr()) if we don\u0027t have that guarantee.","commit_id":"bd326fdb4bbdeea2e2faa7385c2b3ea66cbad8ba"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"917030109316d33ba151fde85fbbae8c9b6d6bd1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def cueclient(request):"},{"line_number":31,"context_line":"    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":32,"context_line":"    auth_url \u003d getattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027)"},{"line_number":33,"context_line":"    auth_version \u003d getattr(settings,"},{"line_number":34,"context_line":"                           \u0027OPENSTACK_API_VERSIONS\u0027, {}).get(\u0027identity\u0027, 2.0)"},{"line_number":35,"context_line":"    if auth_version \u003d\u003d 3:"},{"line_number":36,"context_line":"        auth \u003d v3.Token(auth_url, request.user.token.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_76a029f5","line":33,"in_reply_to":"fa1b9901_0fabe48a","updated":"2015-08-18 04:43:35.000000000","message":"yes it returns an int","commit_id":"bd326fdb4bbdeea2e2faa7385c2b3ea66cbad8ba"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"67204457e9554115389a7d12b919efe372d22eb9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        auth \u003d v3.Token(auth_url, request.user.token.id,"},{"line_number":37,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":38,"context_line":"                        project_name\u003drequest.user.project_name)"},{"line_number":39,"context_line":"    elif auth_version \u003d\u003d 2 or 2.0:"},{"line_number":40,"context_line":"        auth \u003d v2.Token(auth_url, request.user.token.id,"},{"line_number":41,"context_line":"                        tenant_id\u003drequest.user.tenant_id,"},{"line_number":42,"context_line":"                        tenant_name\u003drequest.user.tenant_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_2f034875","line":39,"updated":"2015-08-17 19:03:15.000000000","message":"This needs to be:  \n    elif auth_version \u003d\u003d 2 or auth_version \u003d\u003d 2.0\nPython doesn\u0027t handle conditionals this way.  Your statement is equivalent to: \n    elif auth_version \u003d\u003d 2 or if 2.0 is not None\nSince 2.0 isn\u0027t a None, it would always return a true.","commit_id":"bd326fdb4bbdeea2e2faa7385c2b3ea66cbad8ba"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"917030109316d33ba151fde85fbbae8c9b6d6bd1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        auth \u003d v3.Token(auth_url, request.user.token.id,"},{"line_number":37,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":38,"context_line":"                        project_name\u003drequest.user.project_name)"},{"line_number":39,"context_line":"    elif auth_version \u003d\u003d 2 or 2.0:"},{"line_number":40,"context_line":"        auth \u003d v2.Token(auth_url, request.user.token.id,"},{"line_number":41,"context_line":"                        tenant_id\u003drequest.user.tenant_id,"},{"line_number":42,"context_line":"                        tenant_name\u003drequest.user.tenant_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_36cf11b2","line":39,"in_reply_to":"fa1b9901_2f034875","updated":"2015-08-18 04:43:35.000000000","message":"Done","commit_id":"bd326fdb4bbdeea2e2faa7385c2b3ea66cbad8ba"}]}
