)]}'
{"cue/api/controllers/v1/cluster.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"9c550e5fa93d83fc9f3d7f1e19261fe082b45ac7","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_c1960e94","line":130,"updated":"2015-04-01 22:27:32.000000000","message":"Should we change the database so that it doesnt store a string. Or actually, is there a reason why we are storing the network_id in the DB? Perhaps we can just query nova for it.","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"9c550e5fa93d83fc9f3d7f1e19261fe082b45ac7","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                % CONF.api.max_cluster_size)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if len(data.network_id) \u003e 1:"},{"line_number":228,"context_line":"            raise exception.Invalid(_(\"Invalid network_id list size provided\"))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        data \u003d data.as_dict()"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_210a5ad3","line":228,"updated":"2015-04-01 22:27:32.000000000","message":"Do we check to see if the network_id is not provided?","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"fc5d0f68e1c28dd8b9eccc9bf7661a0d04628054","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                % CONF.api.max_cluster_size)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if len(data.network_id) \u003e 1:"},{"line_number":228,"context_line":"            raise exception.Invalid(_(\"Invalid network_id list size provided\"))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        data \u003d data.as_dict()"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_4c26b5bb","line":228,"in_reply_to":"baa041b7_210a5ad3","updated":"2015-04-02 00:52:56.000000000","message":"network_id is a required field. so both cli and api will throw error if its not provided","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2603a31f0a20ad6f697f0aad554b70c5dbf40ed9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"},{"line_number":134,"context_line":"    cluster \u003d ClusterDetails(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_8887bbd6","line":131,"updated":"2015-04-03 21:20:38.000000000","message":"If we are trying to make the API compatible in the future, we should not just expect a list. We should be expecting a list of key value pairs. In other openstack services, like nova, trove etc, you can pass network id, subnet id and port id in the nic param. We should change it to get a list of key value pairs and not just a list of string.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"94a07e152561f748867c22b72a40d4e09ee1f30d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"},{"line_number":134,"context_line":"    cluster \u003d ClusterDetails(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_2327cd65","line":131,"in_reply_to":"9aa53dc9_c68982cc","updated":"2015-04-07 21:32:01.000000000","message":"I believe it\u0027s reference for the customer and we are using it to attach VM\u0027s to the customer\u0027s network.  We need to know what this is while managing the cluster.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"76d3f01625551532d863d05c893d67e2cb62305a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"},{"line_number":134,"context_line":"    cluster \u003d ClusterDetails(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_c68982cc","line":131,"in_reply_to":"9aa53dc9_c6e74211","updated":"2015-04-06 23:27:10.000000000","message":"+ Vipul. Im ok with not implementing port_id now but we should return a list of k/v pairs. That way when (if) we decide to support port or subnet, the api will already support it.\n\nVipul \u0026 Min: I was wondering what is the purpose of saving the network ID in the DB, as supposed to pass the nic params from the client to nova. Currently, the network ID is currently a column in the clusters table. We will need to rework this when we support multiple networks.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"56f7be97bb36a95b053bf38260f4858d86764225","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"},{"line_number":134,"context_line":"    cluster \u003d ClusterDetails(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_c6e74211","line":131,"in_reply_to":"baa041b7_8887bbd6","updated":"2015-04-06 22:59:01.000000000","message":"So one of the issues i see with making it the same as Nova or Trove for example, is that we create Ports explicitly in our flow from the network id that we receive, whereas Trove seems to be deferring that to Nova.  This means we can\u0027t just take in whatever, and expect it work.\n\nIf we want, we could change this and limit the \u0027key\u0027 in the key/value pair to be net-id only.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"963884e044b48c43c3adc3fe4e9a51ced2f7e67c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    cluster_as_dict \u003d cluster_obj.as_dict()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # convert \u0027network_id\u0027 to list for ClusterDetails compatibility"},{"line_number":131,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [cluster_as_dict[\u0027network_id\u0027]]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # construct api cluster object"},{"line_number":134,"context_line":"    cluster \u003d ClusterDetails(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_067c0a71","line":131,"in_reply_to":"baa041b7_8887bbd6","updated":"2015-04-06 22:58:11.000000000","message":"supporting port id has implications with respect to security groups, not sure we should tackle this right now","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"117ef271f852ca2cea3d132d7a99381415bbff05","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                % CONF.api.max_cluster_size)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if len(data.network_id) \u003e 1:"},{"line_number":228,"context_line":"            raise exception.Invalid(_(\"Invalid network_id list size provided\"))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        data \u003d data.as_dict()"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_fa7dedb1","line":228,"updated":"2015-04-03 19:48:18.000000000","message":"this message sounds like there is something wrong with the format of the list being provided.  Something like:  no support for multiple network ids","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"dcd3ab7a8bb713f02206a401e025457ea62af1e5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # convert \u0027network_id\u0027 to list of key-value pair for ClusterDetails"},{"line_number":113,"context_line":"    # compatibility"},{"line_number":114,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [{\"uuid\": cluster_as_dict[\u0027network_id\u0027]}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # construct api cluster object"},{"line_number":117,"context_line":"    cluster \u003d Cluster(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aaa499b_2dcc6488","line":114,"updated":"2015-04-13 19:17:55.000000000","message":"Can you change the key to be \u0027networks\u0027 instead of \u0027network_id\u0027 to keep it consistent with nova. They networks is passed as follow: \n\"networks\": [{\"uuid\": \"123\"}]","commit_id":"c2f2341eed6677e8852bbcc5b30bc5d94b009755"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"a52276cbc4c9aae29bbeac20f68266781675b6a8","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # convert \u0027network_id\u0027 to list of key-value pair for ClusterDetails"},{"line_number":113,"context_line":"    # compatibility"},{"line_number":114,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [{\"uuid\": cluster_as_dict[\u0027network_id\u0027]}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # construct api cluster object"},{"line_number":117,"context_line":"    cluster \u003d Cluster(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aaa499b_5c0e4035","line":114,"in_reply_to":"7aaa499b_2dcc6488","updated":"2015-04-13 22:03:42.000000000","message":"nova also does not use \"uuid\", it uses \"net-id\" or \"port-id\" depending on whether it\u0027s a network or port","commit_id":"c2f2341eed6677e8852bbcc5b30bc5d94b009755"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"fbcfced555a5f83a197d08245be80d52670bc512","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # convert \u0027network_id\u0027 to list of key-value pair for ClusterDetails"},{"line_number":113,"context_line":"    # compatibility"},{"line_number":114,"context_line":"    cluster_as_dict[\u0027network_id\u0027] \u003d [{\"uuid\": cluster_as_dict[\u0027network_id\u0027]}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # construct api cluster object"},{"line_number":117,"context_line":"    cluster \u003d Cluster(**cluster_as_dict)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aaa499b_7c41fc0a","line":114,"in_reply_to":"7aaa499b_5c0e4035","updated":"2015-04-13 22:19:02.000000000","message":"Nova client uses net-id, port-id but the curl request to the API is sent using uuid: Here is an example of the network portion of a request to nova. I am passing two networks and one port:\n\nnetworks\": [{\"uuid\": \"123\"}, {\"port\": \"321\"}, {\"uuid\": \"456\"}]","commit_id":"c2f2341eed6677e8852bbcc5b30bc5d94b009755"}],"cue/common/exception.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"56f7be97bb36a95b053bf38260f4858d86764225","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ConfigurationError(CueException):"},{"line_number":141,"context_line":"    message \u003d _(\"Configuration Error\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_66ee36ee","side":"PARENT","line":141,"updated":"2015-04-06 22:59:01.000000000","message":"unrelated change.","commit_id":"e1338c20d994eb76bde9b83db9f2a0d001fb6a3d"}],"cue/tests/api/v1/test_cluster.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"17a97dc23589daae7b054f8aaa189ffacced787f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        cluster \u003d objects.Cluster.get_cluster_by_id(self.context,"},{"line_number":293,"context_line":"                                                    data.json[\"cluster\"][\"id\"])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        request_data \u003d data.json[\"cluster\"]"},{"line_number":296,"context_line":"        request_data[\u0027network_id\u0027] \u003d request_data[\u0027network_id\u0027][0]"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        self.validate_cluster_values(cluster, request_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_83d43047","line":295,"updated":"2015-03-31 23:36:27.000000000","message":"you are adjusting the network_id data in two different ways in this file.  The first way you are making a copy to \"request_data\"  and make the necessary change.  The second, you make the change to the value returned from the post.  I would stick to one or the other.  \n\nPreferably, making the change directly to data or data_api will require less code.","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"fc5d0f68e1c28dd8b9eccc9bf7661a0d04628054","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        cluster \u003d objects.Cluster.get_cluster_by_id(self.context,"},{"line_number":293,"context_line":"                                                    data.json[\"cluster\"][\"id\"])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        request_data \u003d data.json[\"cluster\"]"},{"line_number":296,"context_line":"        request_data[\u0027network_id\u0027] \u003d request_data[\u0027network_id\u0027][0]"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        self.validate_cluster_values(cluster, request_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_a1742acf","line":295,"in_reply_to":"da9b358b_83d43047","updated":"2015-04-02 00:52:56.000000000","message":"1)\u0027request_data\u0027 in List Class has copied version of original data  because some validations requires the original data without converting the network_id as list type. \n2) \u0027request_data\u0027 in create class is used to convert the data from response object to json type to make network_id as list.","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"963884e044b48c43c3adc3fe4e9a51ced2f7e67c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        data \u003d self.get_json(\u0027/clusters/\u0027 + cluster.id,"},{"line_number":86,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        data[\u0027cluster\u0027][\u0027network_id\u0027] \u003d data[\u0027cluster\u0027][\u0027network_id\u0027][0]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.validate_cluster_values(cluster, data[\"cluster\"])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_866c9a9d","line":88,"updated":"2015-04-06 22:58:11.000000000","message":"why is the list being converted to a scalar?  It seems like validate_cluster_values and other methods expecting the cluster as input need to be updated to expect and use a list rather than a scalar.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"df4cb6c402fd9c55ce575e04a67b73c24c3fab6c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        data \u003d self.get_json(\u0027/clusters/\u0027 + cluster.id,"},{"line_number":86,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        data[\u0027cluster\u0027][\u0027network_id\u0027] \u003d data[\u0027cluster\u0027][\u0027network_id\u0027][0]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.validate_cluster_values(cluster, data[\"cluster\"])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_c32141b6","line":88,"in_reply_to":"9aa53dc9_83e1f99c","updated":"2015-04-07 21:37:15.000000000","message":"The proper solution would be to update the api tests such that comparisons are being done against the same object types (e.g. cluster api objects to cluster api objects).","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"94a07e152561f748867c22b72a40d4e09ee1f30d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        data \u003d self.get_json(\u0027/clusters/\u0027 + cluster.id,"},{"line_number":86,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        data[\u0027cluster\u0027][\u0027network_id\u0027] \u003d data[\u0027cluster\u0027][\u0027network_id\u0027][0]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.validate_cluster_values(cluster, data[\"cluster\"])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_83e1f99c","line":88,"in_reply_to":"9aa53dc9_866c9a9d","updated":"2015-04-07 21:32:01.000000000","message":"the reason being because this function is used to compare cluster api objects and Cue Cluster objects as well.  Another option would be to update this check function compare lists of network_ids then when comparing a cue cluster object to a cluster api object, change the network_id scalar in cue cluster object to a list.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"963884e044b48c43c3adc3fe4e9a51ced2f7e67c","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":274,"context_line":"        self.assertEqual(413, data.status_code,"},{"line_number":275,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":276,"context_line":"        self.assertIn(\u0027Invalid cluster size, max size is: \u0027 +"},{"line_number":277,"context_line":"                      str(CONF.api.max_cluster_size),"},{"line_number":278,"context_line":"                      data.namespace[\"faultstring\"],"},{"line_number":279,"context_line":"                      \u0027Invalid faultstring received.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_06264a68","line":276,"updated":"2015-04-06 22:58:11.000000000","message":"not sure this is a necessary check","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"94a07e152561f748867c22b72a40d4e09ee1f30d","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":274,"context_line":"        self.assertEqual(413, data.status_code,"},{"line_number":275,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":276,"context_line":"        self.assertIn(\u0027Invalid cluster size, max size is: \u0027 +"},{"line_number":277,"context_line":"                      str(CONF.api.max_cluster_size),"},{"line_number":278,"context_line":"                      data.namespace[\"faultstring\"],"},{"line_number":279,"context_line":"                      \u0027Invalid faultstring received.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_a3c51d3d","line":276,"in_reply_to":"9aa53dc9_06264a68","updated":"2015-04-07 21:32:01.000000000","message":"this was a move of an existing test (converging test_cluster.py and test_clusters.py), it\u0027s not new test.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"117ef271f852ca2cea3d132d7a99381415bbff05","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":359,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":360,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":361,"context_line":"        self.assertEqual(\u0027400 Bad Request\u0027, data.status,"},{"line_number":362,"context_line":"                         \u0027Invalid status value received.\u0027)"},{"line_number":363,"context_line":"        self.assertIn(\u0027Invalid network_id list size provided\u0027,"},{"line_number":364,"context_line":"                      data.namespace[\"faultstring\"],"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_7a167d56","line":361,"updated":"2015-04-03 19:48:18.000000000","message":"you can skip the second check, no need to check the status of the request since we are already checking for the correct status code.","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"}],"cue/tests/objects/test_objects.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"963884e044b48c43c3adc3fe4e9a51ced2f7e67c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster_all("},{"line_number":122,"context_line":"                      network_id\u003d[str(uuid.uuid4())])"},{"line_number":123,"context_line":"        data \u003d api_cluster.as_dict()"},{"line_number":124,"context_line":"        data[\u0027network_id\u0027] \u003d data[\u0027network_id\u0027][0]"},{"line_number":125,"context_line":"        object_cluster \u003d objects.Cluster(**data)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.validate_cluster_values(data, object_cluster)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_a6e43e0d","line":124,"updated":"2015-04-06 22:58:11.000000000","message":"why are we converting from list to scalar?","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"94a07e152561f748867c22b72a40d4e09ee1f30d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster_all("},{"line_number":122,"context_line":"                      network_id\u003d[str(uuid.uuid4())])"},{"line_number":123,"context_line":"        data \u003d api_cluster.as_dict()"},{"line_number":124,"context_line":"        data[\u0027network_id\u0027] \u003d data[\u0027network_id\u0027][0]"},{"line_number":125,"context_line":"        object_cluster \u003d objects.Cluster(**data)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.validate_cluster_values(data, object_cluster)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_e3032541","line":124,"in_reply_to":"9aa53dc9_a6e43e0d","updated":"2015-04-07 21:32:01.000000000","message":"same as my previous comment on this question","commit_id":"9b4386d19b8454ec557cf38620d3d6e695b33199"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"a7770b0074a1e95b4a2ecebfd79b9a87c77b482d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # create cluster api object"},{"line_number":131,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster_all().as_dict()"},{"line_number":132,"context_line":"        # adjust network_id from list to single value"},{"line_number":133,"context_line":"        api_cluster[\u0027network_id\u0027] \u003d api_cluster[\u0027network_id\u0027][0]"},{"line_number":134,"context_line":"        # create cue cluster object from api cluster object"},{"line_number":135,"context_line":"        object_cluster \u003d objects.Cluster(**api_cluster).as_dict()"},{"line_number":136,"context_line":"        # verify fields match"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_c7047bc1","line":133,"updated":"2015-04-08 21:42:19.000000000","message":"note:  this conversion is required.","commit_id":"18e04651ee598f496c87eeda57775efef7d47833"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"a7770b0074a1e95b4a2ecebfd79b9a87c77b482d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.validate_cluster_values(api_cluster, object_cluster)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # adjust network_id from single value back to list"},{"line_number":140,"context_line":"        object_cluster[\u0027network_id\u0027] \u003d [object_cluster[\u0027network_id\u0027]]"},{"line_number":141,"context_line":"        # create cluster api object from cue cluster object"},{"line_number":142,"context_line":"        api_cluster_2 \u003d cluster.Cluster(**object_cluster).as_dict()"},{"line_number":143,"context_line":"        # verify fields match to initial api cluster object"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_67300f9f","line":140,"updated":"2015-04-08 21:42:19.000000000","message":"note:  this conversion is required.","commit_id":"18e04651ee598f496c87eeda57775efef7d47833"}],"cue/tests/utils.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"17a97dc23589daae7b054f8aaa189ffacced787f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    cluster_parameters \u003d {"},{"line_number":109,"context_line":"        \u0027name\u0027: test_cluster[\u0027name\u0027],"},{"line_number":110,"context_line":"        \u0027network_id\u0027: test_cluster[\u0027network_id\u0027][0],"},{"line_number":111,"context_line":"        \u0027flavor\u0027: test_cluster[\u0027flavor\u0027],"},{"line_number":112,"context_line":"        \u0027size\u0027: test_cluster[\u0027size\u0027],"},{"line_number":113,"context_line":"        \u0027volume_size\u0027: test_cluster[\u0027volume_size\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_a361743b","line":110,"updated":"2015-03-31 23:36:27.000000000","message":"network_id value isn\u0027t a list, no need to reference first element.","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"17a97dc23589daae7b054f8aaa189ffacced787f","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    cluster_parameters \u003d {"},{"line_number":147,"context_line":"        \u0027name\u0027: test_cluster[\u0027name\u0027],"},{"line_number":148,"context_line":"        \u0027network_id\u0027: test_cluster[\u0027network_id\u0027][0],"},{"line_number":149,"context_line":"        \u0027flavor\u0027: test_cluster[\u0027flavor\u0027],"},{"line_number":150,"context_line":"        \u0027size\u0027: test_cluster[\u0027size\u0027],"},{"line_number":151,"context_line":"        \u0027volume_size\u0027: test_cluster[\u0027volume_size\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_83643049","line":148,"updated":"2015-03-31 23:36:27.000000000","message":"network_id value isn\u0027t a list, no need to reference first element.","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"fc5d0f68e1c28dd8b9eccc9bf7661a0d04628054","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    cluster_parameters \u003d {"},{"line_number":147,"context_line":"        \u0027name\u0027: test_cluster[\u0027name\u0027],"},{"line_number":148,"context_line":"        \u0027network_id\u0027: test_cluster[\u0027network_id\u0027][0],"},{"line_number":149,"context_line":"        \u0027flavor\u0027: test_cluster[\u0027flavor\u0027],"},{"line_number":150,"context_line":"        \u0027size\u0027: test_cluster[\u0027size\u0027],"},{"line_number":151,"context_line":"        \u0027volume_size\u0027: test_cluster[\u0027volume_size\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_a69622ee","line":148,"in_reply_to":"da9b358b_83643049","updated":"2015-04-02 00:52:56.000000000","message":"Done","commit_id":"66e1094905b31a4e3ff2c88fe224592786e4de48"}]}