)]}'
{".gitignore":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"38a4601bd4cf69056f4df3b8458fabe423654441","unresolved":false,"context_lines":[{"line_number":27,"context_line":"*.manifest"},{"line_number":28,"context_line":"*.spec"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":".DS_Store"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# IDE"},{"line_number":33,"context_line":".idea/"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5aa745d1_f23b2e9b","line":30,"updated":"2015-04-15 22:22:29.000000000","message":"No longer needed?  Line 75 below.","commit_id":"662e4988f91f8f55de0df767419f2d8cda761b7a"}],"contrib/devstack/lib/cue":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"CUE_RABBIT_IMAGE_MINDISK\u003d4"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"CUE_DEFAULT_BROKER_NAME\u003d\u0027rabbitmq\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CUE_FLAVOR\u003dcue.small"},{"line_number":63,"context_line":"CUE_FLAVOR_PARAMS\u003d\"--id 8795 --ram 512 --disk $CUE_RABBIT_IMAGE_MINDISK --vcpus 1\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9aa53dc9_85358b47","line":60,"updated":"2015-04-07 18:30:50.000000000","message":"this should be configurable via local.conf, you can enable this by setting the parameter in this manner:\nPARAM\u003d${PARAM:-default}\nPARAM in this case is CUE_DEFAULT_BROKER_NAME and default is rabbitmq\n\nThis would allow someone the flexibility to configure a different broker as required.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"}],"cue/__init__.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               help\u003d\u0027The id representing the management network \u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027default_broker_name\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027rabbitmq\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The name of broker image \u0027)"},{"line_number":44,"context_line":"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_d72497b0","line":43,"updated":"2015-04-06 19:21:03.000000000","message":"\u0027The name of the default broker image\u0027.  also the space was accidentally inserted, we don\u0027t need one at the end of this msg.","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"}],"cue/api/controllers/v1/cluster.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        job_args \u003d {"},{"line_number":236,"context_line":"            \u0027flavor\u0027: cluster.flavor,"},{"line_number":237,"context_line":"            # TODO(sputnik13): need to remove this when image selector is done"},{"line_number":238,"context_line":"            \u0027image\u0027: CONF.api.os_image_id,"},{"line_number":239,"context_line":"            \u0027volume_size\u0027: cluster.volume_size,"},{"line_number":240,"context_line":"            \u0027network_id\u0027: cluster.network_id,"},{"line_number":241,"context_line":"            \u0027port\u0027: \u00275672\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_d504657f","line":238,"updated":"2015-04-02 17:38:44.000000000","message":"need to stop looking at the config value.","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        erlang_cookie \u003d uuidutils.generate_uuid()"},{"line_number":229,"context_line":"        default_rabbit_user \u003d \u0027rabbitmq\u0027"},{"line_number":230,"context_line":"        default_rabbit_pass \u003d cluster.id"},{"line_number":231,"context_line":"        broker_name \u003d CONF.default_broker_name"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        # get the image id of default broker"},{"line_number":234,"context_line":"        image_id \u003d objects.BrokerMetadata.get_image_id(broker_name, context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_d77257ad","line":231,"updated":"2015-04-06 19:21:03.000000000","message":"we should add the broker name used in the log message below","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        job_args \u003d {"},{"line_number":237,"context_line":"            \u0027flavor\u0027: cluster.flavor,"},{"line_number":238,"context_line":"            \u0027image\u0027: image_id,"},{"line_number":239,"context_line":"            \u0027volume_size\u0027: cluster.volume_size,"},{"line_number":240,"context_line":"            \u0027network_id\u0027: cluster.network_id,"},{"line_number":241,"context_line":"            \u0027port\u0027: \u00275672\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b7afd3e2","line":238,"updated":"2015-04-06 19:21:03.000000000","message":"extra space below","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"}],"cue/db/api.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"02216335f54288d30fe89bdc6a1f951fd928016e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @abc.abstractmethod"},{"line_number":183,"context_line":"    def create_broker(self, broker_values, context):"},{"line_number":184,"context_line":"        \"\"\"Creates a new broker."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_6860f701","line":183,"updated":"2015-04-03 21:43:26.000000000","message":"To keep it consistent wit the other methods, can you put the context arg first? ie : def create_broker(self, context, broker_values):\n\nSame for more methods down below :)\nRemember to also change the doc param order :)","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"9ff1b58a3cb45db6a3e799547f5130ed2a8900af","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @abc.abstractmethod"},{"line_number":183,"context_line":"    def create_broker(self, broker_values, context):"},{"line_number":184,"context_line":"        \"\"\"Creates a new broker."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_69223954","line":183,"in_reply_to":"baa041b7_6860f701","updated":"2015-04-04 00:23:36.000000000","message":"context is an optional parameter in all these method as the manage/broker cannot pass in any context.","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"d0e4ddf8b57abd33c26360cd313d3e26c58957c1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @abc.abstractmethod"},{"line_number":183,"context_line":"    def create_broker(self, broker_values, context):"},{"line_number":184,"context_line":"        \"\"\"Creates a new broker."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_9e648e49","line":183,"in_reply_to":"baa041b7_69223954","updated":"2015-04-04 04:17:50.000000000","message":"To make it optional, there should be a default value for it... perhaps context\u003dNone. Otherwise it will always requires them","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @abc.abstractmethod"},{"line_number":183,"context_line":"    def create_broker(self, broker_values, context):"},{"line_number":184,"context_line":"        \"\"\"Creates a new broker."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_54188084","line":183,"in_reply_to":"baa041b7_9e648e49","updated":"2015-04-06 19:21:03.000000000","message":"* Let\u0027s keep context a mandatory parameter (keep pattern with rest of db api)\n* move it to as first field","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    @abc.abstractmethod"},{"line_number":206,"context_line":"    def delete_broker(self, broker_id, context):"},{"line_number":207,"context_line":"        \"\"\"Deletes a Broker object for specified broker_id."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_d40c9044","line":206,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to start","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @abc.abstractmethod"},{"line_number":215,"context_line":"    def update_broker(self, broker_id, broker_value, context):"},{"line_number":216,"context_line":"        \"\"\"Updates a Broker type/status for specified broker_id."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b4090c34","line":215,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to start","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @abc.abstractmethod"},{"line_number":225,"context_line":"    def create_broker_metadata(self, metadata_values, context):"},{"line_number":226,"context_line":"        \"\"\"Creates a new broker metadata."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_74038410","line":225,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to start","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"02216335f54288d30fe89bdc6a1f951fd928016e","unresolved":false,"context_lines":[{"line_number":237,"context_line":"         \"\"\""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @abc.abstractmethod"},{"line_number":240,"context_line":"    def get_broker_metadata_by_broker_id(self, broker_id, context):"},{"line_number":241,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_2808af2b","line":240,"updated":"2015-04-03 21:43:26.000000000","message":"Just nicpicking but how about if we shortern the method name to get_broker_metadata_by_id?","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"9ff1b58a3cb45db6a3e799547f5130ed2a8900af","unresolved":false,"context_lines":[{"line_number":237,"context_line":"         \"\"\""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @abc.abstractmethod"},{"line_number":240,"context_line":"    def get_broker_metadata_by_broker_id(self, broker_id, context):"},{"line_number":241,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_e9d40921","line":240,"in_reply_to":"baa041b7_2808af2b","updated":"2015-04-04 00:23:36.000000000","message":"There are 2 ids in this table- metadata_id and broker_id , and this method is get by broker_id","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"d0e4ddf8b57abd33c26360cd313d3e26c58957c1","unresolved":false,"context_lines":[{"line_number":237,"context_line":"         \"\"\""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @abc.abstractmethod"},{"line_number":240,"context_line":"    def get_broker_metadata_by_broker_id(self, broker_id, context):"},{"line_number":241,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_5e5e0677","line":240,"in_reply_to":"baa041b7_e9d40921","updated":"2015-04-04 04:17:50.000000000","message":"Ok.. got it :)","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"    @abc.abstractmethod"},{"line_number":249,"context_line":"    def delete_broker_metadata(self, broker_metadata_id, context):"},{"line_number":250,"context_line":"        \"\"\"Deletes a BrokerMetadata object for specified broker_id."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        :param broker_metadata_id: UUID of a broker metadata"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_57ff6201","line":249,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to start","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"    # get latest image id"},{"line_number":257,"context_line":"    @abc.abstractmethod"},{"line_number":258,"context_line":"    def get_image_id(self, broker_name, context):"},{"line_number":259,"context_line":"        \"\"\"Returns a image_id for the broker"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f70d5638","line":258,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to start","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"    @abc.abstractmethod"},{"line_number":257,"context_line":"    def get_image_id(self, context, broker_name):"},{"line_number":258,"context_line":"        \"\"\"Returns a image_id for the broker"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        :param context: request context object"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_3a001501","line":257,"updated":"2015-04-07 18:30:50.000000000","message":"get_image_id_by_broker_name","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"}],"cue/db/sqlalchemy/alembic/versions/3917e931a55a_create_brokers.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    ### commands auto generated by Alembic - please adjust! ###"},{"line_number":37,"context_line":"    op.create_table(\u0027brokers\u0027,"},{"line_number":38,"context_line":"    sa.Column(\u0027id\u0027, types.UUID(), nullable\u003dFalse),"},{"line_number":39,"context_line":"    sa.Column(\u0027type\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":40,"context_line":"    sa.Column(\u0027active_status\u0027, sa.Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_8317ca50","line":37,"updated":"2015-04-02 17:38:44.000000000","message":"rename to \u0027broker\u0027","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    ### commands auto generated by Alembic - please adjust! ###"},{"line_number":37,"context_line":"    op.create_table(\u0027brokers\u0027,"},{"line_number":38,"context_line":"    sa.Column(\u0027id\u0027, types.UUID(), nullable\u003dFalse),"},{"line_number":39,"context_line":"    sa.Column(\u0027type\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":40,"context_line":"    sa.Column(\u0027active_status\u0027, sa.Boolean(), nullable\u003dFalse),"},{"line_number":41,"context_line":"    sa.Column(\u0027deleted\u0027, sa.Boolean(), nullable\u003dFalse),"},{"line_number":42,"context_line":"    sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_d5ffc5ff","line":39,"updated":"2015-04-02 17:38:44.000000000","message":"should be \u0027name\u0027","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    op.create_table(\u0027brokers\u0027,"},{"line_number":38,"context_line":"    sa.Column(\u0027id\u0027, types.UUID(), nullable\u003dFalse),"},{"line_number":39,"context_line":"    sa.Column(\u0027type\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":40,"context_line":"    sa.Column(\u0027active_status\u0027, sa.Boolean(), nullable\u003dFalse),"},{"line_number":41,"context_line":"    sa.Column(\u0027deleted\u0027, sa.Boolean(), nullable\u003dFalse),"},{"line_number":42,"context_line":"    sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dFalse),"},{"line_number":43,"context_line":"    sa.Column(\u0027updated_at\u0027, sa.DateTime(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_b5044115","line":40,"updated":"2015-04-02 17:38:44.000000000","message":"rename to \u0027active\u0027","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"}],"cue/db/sqlalchemy/api.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        return broker"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def get_broker_by_id(self, broker_id, context):"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        query \u003d model_query(context, models.BrokerMetadata).filter_by("},{"line_number":293,"context_line":"            broker_id\u003dbroker_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_95f37d0a","line":290,"updated":"2015-04-02 17:38:44.000000000","message":"This method is returning broker_metadata not broker","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        query.update(broker_value)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    # get latest image id for API"},{"line_number":309,"context_line":"    def get_image_id(self, context):"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        selected_image \u003d []"},{"line_number":312,"context_line":"        # Sort ACTIVE brokers by created_at time"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_7581194a","line":309,"updated":"2015-04-02 17:38:44.000000000","message":"This should take in broker name","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        selected_image \u003d []"},{"line_number":312,"context_line":"        # Sort ACTIVE brokers by created_at time"},{"line_number":313,"context_line":"        broker_query \u003d (model_query(context, models.Broker).filter_by("},{"line_number":314,"context_line":"            active_status\u003d1).order_by((models.Broker.created_at.desc())))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        all_brokers \u003d broker_query.all()"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_f55f690c","line":314,"updated":"2015-04-02 17:38:44.000000000","message":"active_status\u003dTrue","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"02216335f54288d30fe89bdc6a1f951fd928016e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            db_session \u003d get_session()"},{"line_number":282,"context_line":"            broker.save(db_session)"},{"line_number":283,"context_line":"        except db_exception.DBError:"},{"line_number":284,"context_line":"            raise exception.Invalid(_(\"badly formed broker_id UUID string\"))"},{"line_number":285,"context_line":"        except sql_exception.NoResultFound:"},{"line_number":286,"context_line":"            raise exception.NotFound(_(\"Broker was not found\"))"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_c3780492","line":284,"updated":"2015-04-03 21:43:26.000000000","message":"Capitalize \u0027badly\u0027","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"9ff1b58a3cb45db6a3e799547f5130ed2a8900af","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            db_session \u003d get_session()"},{"line_number":282,"context_line":"            broker.save(db_session)"},{"line_number":283,"context_line":"        except db_exception.DBError:"},{"line_number":284,"context_line":"            raise exception.Invalid(_(\"badly formed broker_id UUID string\"))"},{"line_number":285,"context_line":"        except sql_exception.NoResultFound:"},{"line_number":286,"context_line":"            raise exception.NotFound(_(\"Broker was not found\"))"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_c9d70522","line":284,"in_reply_to":"baa041b7_c3780492","updated":"2015-04-04 00:23:36.000000000","message":"Done","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"02216335f54288d30fe89bdc6a1f951fd928016e","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        selected_image \u003d metadata_query.all()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        if len(selected_image) is not 1:"},{"line_number":326,"context_line":"            raise exception.NotFound(_(\"NO Image found for the given broker\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        image_id \u003d selected_image[0][\u0027value\u0027]"},{"line_number":329,"context_line":"        return image_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_23bb3029","line":326,"updated":"2015-04-03 21:43:26.000000000","message":"nicpick: capitalize \u0027NO\u0027","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"9ff1b58a3cb45db6a3e799547f5130ed2a8900af","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        selected_image \u003d metadata_query.all()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        if len(selected_image) is not 1:"},{"line_number":326,"context_line":"            raise exception.NotFound(_(\"NO Image found for the given broker\"))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        image_id \u003d selected_image[0][\u0027value\u0027]"},{"line_number":329,"context_line":"        return image_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_a9de013d","line":326,"in_reply_to":"baa041b7_23bb3029","updated":"2015-04-04 00:23:36.000000000","message":"Done","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        broker_query \u003d (model_query(context, models.Broker)"},{"line_number":256,"context_line":"                        .filter_by(id\u003dbroker_id))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        broker_value \u003d {"},{"line_number":259,"context_line":"            \u0027deleted\u0027: True,"},{"line_number":260,"context_line":"        }"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_e017a5eb","line":258,"updated":"2015-04-07 18:30:50.000000000","message":"If you are trying to soft delete a record, make use of the safe delete function above.  Take a look at how it\u0027s being used when soft deleting a node or cluster record.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        broker_query \u003d (model_query(context, models.Broker)"},{"line_number":267,"context_line":"                        .filter_by(id\u003dbroker_id))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        broker_query.update(broker_value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def create_broker_metadata(self, context, metadata_values):"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_40cf717f","line":269,"updated":"2015-04-07 18:30:50.000000000","message":"when updating a record, you should set the updated_at time here before issuing the update.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def create_broker_metadata(self, context, metadata_values):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        broker \u003d models.BrokerMetadata()"},{"line_number":274,"context_line":"        broker_query \u003d (model_query(context, models.Broker)"},{"line_number":275,"context_line":"                        .filter_by(id\u003dmetadata_values[\u0027broker_id\u0027]))"},{"line_number":276,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_60403557","line":273,"updated":"2015-04-07 18:30:50.000000000","message":"* the name for this variable is confusing as it\u0027s the same name you are using above for a broker record.  Would be clearer if it\u0027s named: broker_metadata\n* this variable should be instantiated after you are able to query the required broker successfully","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            id\u003dbroker_metadata_id))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        broker_value \u003d {"},{"line_number":303,"context_line":"            \u0027deleted\u0027: True,"},{"line_number":304,"context_line":"        }"},{"line_number":305,"context_line":"        query.update(broker_value)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_578f34cc","line":303,"updated":"2015-04-07 18:30:50.000000000","message":"same as above.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                          .order_by((models.BrokerMetadata.created_at.desc()))."},{"line_number":319,"context_line":"                          limit(1))"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        selected_image \u003d metadata_query.all()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if len(selected_image) is not 1:"},{"line_number":324,"context_line":"            raise exception.NotFound(_(\"No Image found for the given broker\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_3a893527","line":321,"updated":"2015-04-07 18:30:50.000000000","message":"since you are expecting one result (you are filtering to a limit of one), query.one() instead in a try catch (using the same pattern as above in create broker metadata)","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"}],"cue/db/sqlalchemy/models.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    type \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":83,"context_line":"    active_status \u003d sa.Column(sa.Boolean(), default\u003dFalse, nullable\u003dFalse)"},{"line_number":84,"context_line":"    deleted \u003d sa.Column(sa.Boolean(), default\u003dFalse, nullable\u003dFalse)"},{"line_number":85,"context_line":"    sa.Index(\"brokers_id_idx\", \"id\", unique\u003dTrue)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_b53c4194","line":84,"updated":"2015-04-02 17:38:44.000000000","message":"doesn\u0027t the SoftDeleteMixin handle this column?","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        sa.ForeignKey(\u0027brokers.id\u0027), nullable\u003dFalse)"},{"line_number":95,"context_line":"    key \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":96,"context_line":"    value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":97,"context_line":"    deleted \u003d sa.Column(sa.Boolean(), default\u003dFalse, nullable\u003dFalse)"},{"line_number":98,"context_line":"    sa.Index(\"brokerMetadata_id_idx\", \"id\", unique\u003dTrue)"},{"line_number":99,"context_line":"    sa.Index(\"brokerMetadata_broker_id_idx\", \"broker_id\", unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_5573b580","line":97,"updated":"2015-04-02 17:38:44.000000000","message":"doesn\u0027t the SoftDeleteMixin handle this","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"}],"cue/manage/broker.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class BrokerCommands(base.Commands):"},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        super(BrokerCommands, self).__init__()"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_512652bb","line":32,"updated":"2015-04-06 19:21:03.000000000","message":"add some comments.  provide some information on the flow here.  i.e. first add a broker, then add metadata for each supported image?","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @base.args(\u0027--name\u0027, dest\u003d\u0027broker_name\u0027)"},{"line_number":37,"context_line":"    @base.args(\u0027--active\u0027, dest\u003d\u0027active\u0027)"},{"line_number":38,"context_line":"    def add(self, broker_name, active):"},{"line_number":39,"context_line":"        status \u003d strutils.bool_from_string(active)"},{"line_number":40,"context_line":"        broker_values \u003d {"},{"line_number":41,"context_line":"            \u0027name\u0027: broker_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1120ca9a","line":38,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        broker \u003d objects.Broker()"},{"line_number":45,"context_line":"        broker.create_broker(broker_values)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def list(self):"},{"line_number":48,"context_line":"        broker_obj \u003d objects.Broker()"},{"line_number":49,"context_line":"        broker_list \u003d broker_obj.get_brokers()"},{"line_number":50,"context_line":"        list_table \u003d prettytable.PrettyTable([\"Broker id\", \"Broker Name\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f12446b0","line":47,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        print(list_table)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027)"},{"line_number":60,"context_line":"    def delete(self, broker_id):"},{"line_number":61,"context_line":"        broker_obj \u003d objects.Broker()"},{"line_number":62,"context_line":"        broker_obj.delete_broker(broker_id)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b137dee2","line":60,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027)"},{"line_number":65,"context_line":"    @base.args(\u0027--name\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":66,"context_line":"    @base.args(\u0027--active\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":67,"context_line":"    def update(self, broker_id, name, active):"},{"line_number":68,"context_line":"        broker_value \u003d {}"},{"line_number":69,"context_line":"        if active is not None:"},{"line_number":70,"context_line":"            active \u003d strutils.bool_from_string(active)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_514d3271","line":67,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027)"},{"line_number":79,"context_line":"    @base.args(\u0027--image\u0027, dest\u003d\u0027image_id\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":80,"context_line":"    @base.args(\u0027--sec-group\u0027, dest\u003d\u0027sec_group\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":81,"context_line":"    def add_metadata(self, broker_id, image_id, sec_group):"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if image_id is not None:"},{"line_number":84,"context_line":"            metadata_value \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1157aa03","line":81,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            raise exception.Invalid(_(\"Requires atleast one argument\"))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027)"},{"line_number":105,"context_line":"    def list_metadata(self, broker_id):"},{"line_number":106,"context_line":"        metadata \u003d objects.BrokerMetadata()"},{"line_number":107,"context_line":"        broker_metadata \u003d metadata.get_broker_metadata_by_broker_id(broker_id)"},{"line_number":108,"context_line":"        list_table \u003d prettytable.PrettyTable([\"Broker_Metadata id\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f15b262d","line":105,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        print(list_table)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_metadata_id\u0027)"},{"line_number":120,"context_line":"    def delete_metadata(self, broker_metadata_id):"},{"line_number":121,"context_line":"        broker_obj \u003d objects.BrokerMetadata()"},{"line_number":122,"context_line":"        broker_obj.delete_broker_metadata(broker_metadata_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_914bba59","line":120,"updated":"2015-04-06 19:21:03.000000000","message":"comments","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    - To add a new broker use \u0027broker add\u0027."},{"line_number":37,"context_line":"    - To add a new metadata for a broker; get broker_id using \u0027broker list\u0027"},{"line_number":38,"context_line":"      and use the id in th command \u0027broker add_metadata\u0027."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        super(BrokerCommands, self).__init__()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_1a08b190","line":38,"updated":"2015-04-07 18:30:50.000000000","message":"typo - the","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"0616cb308bc158ee55894b17b6213d62e5cdb86d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def list(self):"},{"line_number":57,"context_line":"        \"\"\"List all the brokers.\"\"\""},{"line_number":58,"context_line":"        broker_obj \u003d objects.Broker()"},{"line_number":59,"context_line":"        broker_list \u003d broker_obj.get_brokers(self.context)"},{"line_number":60,"context_line":"        list_table \u003d prettytable.PrettyTable([\"Broker id\", \"Broker Name\","},{"line_number":61,"context_line":"                                              \"Active\", \"Created Time\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_a5d4dc1f","line":58,"updated":"2015-04-08 16:49:21.000000000","message":"get_brokers is a class method, there is no need to instantiate an instance of type broker and call a class method on it.  You can call the class method directly from the Class (you have done this in the Clusters controller api under post):  broker_list \u003d objects.Broker.get_brokers(self.context)","commit_id":"37e85c4532c877b83fb1b0ceae1988ff2ad517a4"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"0616cb308bc158ee55894b17b6213d62e5cdb86d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def list_metadata(self, broker_id):"},{"line_number":124,"context_line":"        \"\"\"List broker metadata for the given broker_id.\"\"\""},{"line_number":125,"context_line":"        metadata \u003d objects.BrokerMetadata()"},{"line_number":126,"context_line":"        broker_metadata \u003d metadata.get_broker_metadata_by_broker_id("},{"line_number":127,"context_line":"            self.context, broker_id)"},{"line_number":128,"context_line":"        list_table \u003d prettytable.PrettyTable([\"Broker_Metadata id\","},{"line_number":129,"context_line":"                                             \"Broker id\", \"Key\", \"Value\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_858c3836","line":126,"updated":"2015-04-08 16:49:21.000000000","message":"same here:\nbroker_metadata \u003d objects.BrokerMetadata.get_broker_metadata_by_broker_id(...)","commit_id":"37e85c4532c877b83fb1b0ceae1988ff2ad517a4"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"c9f62be3d85ab4b4a6f1d658e245354de9c1ec2c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if image_id is None and sec_group is None:"},{"line_number":119,"context_line":"            raise exception.Invalid(_(\"Requires atleast one argument\"))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027)"},{"line_number":122,"context_line":"    def list_metadata(self, broker_id):"},{"line_number":123,"context_line":"        \"\"\"List broker metadata for the given broker_id.\"\"\""},{"line_number":124,"context_line":"        broker_metadata \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"3ab451fb_164a0c84","line":121,"updated":"2015-04-16 23:40:07.000000000","message":"this should be a positional argument not a named argument as it\u0027s a required argument and in most (if not all) other openstack commands an id is a positional argument","commit_id":"04b3b9c5ba756a7bdd53298480c585c0ff282e34"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"cd9aa3985c72193b7b8b08aa1629e562134338e4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        broker_obj \u003d objects.Broker(**broker_id)"},{"line_number":75,"context_line":"        broker_obj.delete_broker(self.context)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027, help\u003d\u0027Broker id\u0027)"},{"line_number":78,"context_line":"    @base.args(\u0027--name\u0027, dest\u003d\u0027broker_name\u0027, nargs\u003d\u0027?\u0027, help\u003d\u0027Broker name\u0027)"},{"line_number":79,"context_line":"    @base.args(\u0027--active\u0027, dest\u003d\u0027active\u0027, nargs\u003d\u0027?\u0027,"},{"line_number":80,"context_line":"               help\u003d\u0027Broker active status\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ab451fb_f6f659d6","line":77,"updated":"2015-04-17 19:44:27.000000000","message":"Is there a reason to keep the id a named argument when the other ones have changed to positional?","commit_id":"4020e4ea58e5fab4d755ce4179f071b69ccb9e94"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"cd9aa3985c72193b7b8b08aa1629e562134338e4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        broker_obj \u003d objects.Broker(**broker_value)"},{"line_number":92,"context_line":"        broker_obj.update_broker(self.context)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @base.args(\u0027--id\u0027, dest\u003d\u0027broker_id\u0027, help\u003d\u0027Broker id\u0027)"},{"line_number":95,"context_line":"    @base.args(\u0027--image\u0027, dest\u003d\u0027image_id\u0027, nargs\u003d\u0027?\u0027, help\u003d\u0027Image id\u0027)"},{"line_number":96,"context_line":"    @base.args(\u0027--sec-group\u0027, dest\u003d\u0027sec_group\u0027, nargs\u003d\u0027?\u0027,"},{"line_number":97,"context_line":"               help\u003d\u0027Security group\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ab451fb_d6035db7","line":94,"updated":"2015-04-17 19:44:27.000000000","message":"same comment as above","commit_id":"4020e4ea58e5fab4d755ce4179f071b69ccb9e94"}],"cue/objects/broker.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            broker[field] \u003d db_broker[field]"},{"line_number":40,"context_line":"        return broker"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create_broker(self, broker_values, context\u003dNone):"},{"line_number":43,"context_line":"        \"\"\"Creates a new broker."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b1a0fe91","line":42,"updated":"2015-04-06 19:21:03.000000000","message":"* use create pattern used by other cue objects classes.\n* move context as first parameter (keep in the same format as other classes) And remove the \u003dNone (when using these methods, instantiate a Context object if you don\u0027t have one and pass it in.","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return [Broker._from_db_object(Broker(), obj) for obj in db_brokers]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def delete_broker(cls, broker_id, context\u003dNone):"},{"line_number":72,"context_line":"        \"\"\"Deletes a Broker object for specified broker_id."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_d4549055","line":71,"updated":"2015-04-06 19:21:03.000000000","message":"* move under create and change to instance method to follow cue objects pattern\n* move context id as first field","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        cls.dbapi.delete_broker(broker_id, context)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def update_broker(cls, broker_id, broker_value, context\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Updates a Broker type/status for specified broker_id."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_71a71650","line":81,"updated":"2015-04-06 19:21:03.000000000","message":"* use update pattern used by other cue objects classes\n* move context as first parameter and remove \u003dNone","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"0616cb308bc158ee55894b17b6213d62e5cdb86d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cue.objects import utils as obj_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class Broker(base.CueObject):"},{"line_number":23,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_a5bdfc69","line":22,"updated":"2015-04-08 16:49:21.000000000","message":"this needs some functional tests added (in tests/objects/test_objects.py).  If it is being done as part of our QA efforts, create a bug that tracks this work and refer unit/functional tests to it as part of the description of this patch.","commit_id":"37e85c4532c877b83fb1b0ceae1988ff2ad517a4"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"ae334149811ec92ba2536b962990028a3bfae90f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def _from_db_object(broker, db_broker):"},{"line_number":37,"context_line":"        \"\"\"Convert a database object to a universal broker object.\"\"\""},{"line_number":38,"context_line":"        for field in broker.fields:"},{"line_number":39,"context_line":"            broker[field] \u003d db_broker[field]"},{"line_number":40,"context_line":"        return broker"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_73132db9","line":37,"updated":"2015-04-09 00:14:18.000000000","message":"Capital B in \u0027broker\u0027","commit_id":"295e681fbbd083a9857592034dc1ba3ad58a9ce4"}],"cue/objects/brokerMetadata.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"# Copyright [2014] Hewlett-Packard Development Company, L.P."},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cue.db import api as db_api"},{"line_number":18,"context_line":"from cue.objects import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_15dc0d11","line":15,"updated":"2015-04-02 17:38:44.000000000","message":"https://www.python.org/dev/peps/pep-0008/#package-and-module-names","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"e02aa67fa33d4f4566fbb01fcc17a6ebad62c13e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cue.objects import utils as obj_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class brokerMetadata(base.CueObject):"},{"line_number":23,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_752b5931","line":22,"updated":"2015-04-02 17:38:44.000000000","message":"Class names are always capitalized.  https://www.python.org/dev/peps/pep-0008/#class-names","commit_id":"efd31019d153791bcb33fd7b9a6f65393651a647"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"2c25f9874a8c2aac882576fbf72b8c1b5705dacd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"# Copyright [2014] Hewlett-Packard Development Company, L.P."},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cue.db import api as db_api"},{"line_number":18,"context_line":"from cue.objects import base"},{"line_number":19,"context_line":"from cue.objects import utils as obj_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_4688d222","line":16,"updated":"2015-04-06 23:03:14.000000000","message":"This file is: cue/objects/brokerMetadata.py -- change to broker_metadata.py","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cue.objects import utils as obj_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BrokerMetadata(base.CueObject):"},{"line_number":23,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_5431a00a","line":22,"updated":"2015-04-06 19:21:03.000000000","message":"* do we need support for updating of these objects?","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            broker_metadata[field] \u003d db_broker_metadata[field]"},{"line_number":41,"context_line":"        return broker_metadata"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def add_broker_metadata(self, metadata_values, context\u003dNone):"},{"line_number":44,"context_line":"        \"\"\"Creates a new broker metadata."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"       :param context: request context object"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9493a8fa","line":43,"updated":"2015-04-06 19:21:03.000000000","message":"* name should be: create_broker_metadata\n* use create pattern used by other cue objects\n* move context to start and remove \u003dNone","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self._from_db_object(self, db_broker)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def get_broker_metadata_by_broker_id(cls, broker_id, context\u003dNone):"},{"line_number":62,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        :param broker_id: UUID of a broker"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_14443872","line":61,"updated":"2015-04-06 19:21:03.000000000","message":"move context to start and remove \u003dNone","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                for obj in db_broker_metadata]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"},{"line_number":76,"context_line":"    def delete_broker_metadata(cls, broker_metadata_id, context\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Deletes a BrokerMetadata object for specified broker_id."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param broker_metadata_id: UUID of a broker metadata"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_544ac084","line":76,"updated":"2015-04-06 19:21:03.000000000","message":"* move under create method above\n* use pattern used by other cue objects (like create)\n* move context to start and remove \u003dNone","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"e7b9309c62b889ae5224d62f683d1ddb1bc51003","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        cls.dbapi.delete_broker_metadata(broker_metadata_id, context)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @classmethod"},{"line_number":86,"context_line":"    def get_image_id(cls, broker_name, context\u003dNone):"},{"line_number":87,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b45b4c54","line":86,"updated":"2015-04-06 19:21:03.000000000","message":"* move context to front and remove \u003dNone","commit_id":"157b142ba025d4f82807ef6171b2df4b69433a64"}],"cue/objects/broker_metadata.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self._from_db_object(self, db_broker)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_broker_metadata_by_broker_id(self, context):"},{"line_number":55,"context_line":"        \"\"\"Returns a list of BrokerMetadata objects for specified broker_id."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :param context: request context object"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_7a4fbdbd","line":54,"updated":"2015-04-07 18:30:50.000000000","message":"with get methods, id should be supplied to the function as an input value (class method).  See other examples of Cue objects.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        :returns: a list of :class:\u0027BrokerMetadata\u0027 object"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        broker_id \u003d self.__getitem__(\u0027broker_id\u0027)"},{"line_number":62,"context_line":"        db_broker_metadata \u003d self.dbapi.get_broker_metadata_by_broker_id("},{"line_number":63,"context_line":"            context, broker_id)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_7aab3d1e","line":61,"updated":"2015-04-07 18:30:50.000000000","message":"you can get access to the field by just doing self.broker_id.  This then maps to __getitem__ automatically, you do not have to explicitly call it.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        :param context: request context object"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        broker_metadata_id \u003d self.__getitem__(\u0027id\u0027)"},{"line_number":75,"context_line":"        self.dbapi.delete_broker_metadata(context, broker_metadata_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_ba78a5c5","line":74,"updated":"2015-04-07 18:30:50.000000000","message":"same here, self.id is sufficient.","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"95ee9f53778ac16a524d2c544c6b0d8eaa357327","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.dbapi.delete_broker_metadata(context, broker_metadata_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def get_image_id(cls, context, broker_name):"},{"line_number":79,"context_line":"        \"\"\"Returns a image_id for the broker"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param context: request context object"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_9a3ba138","line":78,"updated":"2015-04-07 18:30:50.000000000","message":"by broker name","commit_id":"cd8653a57468d897225dcedb92bed34c33f34633"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"0616cb308bc158ee55894b17b6213d62e5cdb86d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from cue.objects import utils as obj_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BrokerMetadata(base.CueObject):"},{"line_number":23,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_45bab06f","line":22,"updated":"2015-04-08 16:49:21.000000000","message":"this needs some functional tests added (in tests/objects/test_objects.py)","commit_id":"37e85c4532c877b83fb1b0ceae1988ff2ad517a4"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"0616cb308bc158ee55894b17b6213d62e5cdb86d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        for field in BrokerMetadata.fields:"},{"line_number":40,"context_line":"            broker_metadata[field] \u003d db_broker_metadata[field]"},{"line_number":41,"context_line":"        return broker_metadata"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def add_broker_metadata(self, context):"},{"line_number":44,"context_line":"        \"\"\"Creates a new broker metadata."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_2541eca9","line":42,"updated":"2015-04-08 16:49:21.000000000","message":"to keep with naming conventions, call this:\ncreate_broker_metadata","commit_id":"37e85c4532c877b83fb1b0ceae1988ff2ad517a4"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"ae334149811ec92ba2536b962990028a3bfae90f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def _from_db_object(broker_metadata, db_broker_metadata):"},{"line_number":38,"context_line":"        \"\"\"Convert a database object to a universal brokerMetadata object.\"\"\""},{"line_number":39,"context_line":"        for field in BrokerMetadata.fields:"},{"line_number":40,"context_line":"            broker_metadata[field] \u003d db_broker_metadata[field]"},{"line_number":41,"context_line":"        return broker_metadata"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_5316e9a7","line":38,"updated":"2015-04-09 00:14:18.000000000","message":"Capital b in \u0027brokerMetadata\u0027","commit_id":"295e681fbbd083a9857592034dc1ba3ad58a9ce4"}],"cue/tests/base.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"ae334149811ec92ba2536b962990028a3bfae90f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027active\u0027: \u00271\u0027,"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        broker \u003d objects.Broker(**broker_values)"},{"line_number":178,"context_line":"        broker.create_broker(None)"},{"line_number":179,"context_line":"        broker_list \u003d broker.get_brokers(None)"},{"line_number":180,"context_line":"        broker_id \u003d broker_list[0][\u0027id\u0027]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_f36e1d2e","line":178,"updated":"2015-04-09 00:14:18.000000000","message":"instead of None, should you pass  \u0027self.context\u0027 instead?","commit_id":"295e681fbbd083a9857592034dc1ba3ad58a9ce4"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"4a1502a33491604049fb559febd321fdd3caa2d4","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.set_broker()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def set_broker(self):"},{"line_number":78,"context_line":"        # Loading default broker and image to broker and brokerMetadata table"},{"line_number":79,"context_line":"        broker_values \u003d {"},{"line_number":80,"context_line":"            \u0027name\u0027: \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aaa499b_0be95e14","line":77,"updated":"2015-04-14 23:32:33.000000000","message":"why is this part of the base test class?  seems like this should be part of the unit/functional test for this feature","commit_id":"ef523ee239f62554067dfb9cd5a63bbd02f23561"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"bca2235990228b628490f3e76de4883da4aaf1b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.set_broker()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def set_broker(self):"},{"line_number":78,"context_line":"        # Loading default broker and image to broker and brokerMetadata table"},{"line_number":79,"context_line":"        broker_values \u003d {"},{"line_number":80,"context_line":"            \u0027name\u0027: \u0027rabbitmq\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aa745d1_3de5efa7","line":77,"in_reply_to":"7aaa499b_0be95e14","updated":"2015-04-15 20:51:38.000000000","message":"this method is required for adding a default image_id to the broker table. Without an image_id the api functional test fails.\nAfter the test refactoring now this is in functional/base.","commit_id":"ef523ee239f62554067dfb9cd5a63bbd02f23561"}]}