)]}'
{"cue/taskflow/service.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"3fe7d0ce763374498dc5f7f693d6a74dce1f5e57","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\"Interface to start the ConductorService.\"\"\""},{"line_number":125,"context_line":"        CONF.log_opt_values(LOG, std_logging.INFO)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        policy.init()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        version_string \u003d version.version_info.version_string()"},{"line_number":130,"context_line":"        LOG.debug(\"Starting runner %s on board %s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_d8601738","side":"PARENT","line":127,"updated":"2015-04-21 01:00:18.000000000","message":"Without this, tasks that access the database will fail due to policy errors.","commit_id":"6c3d8521317c464ccfdecdb7858142a0dfa40b66"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"7290e9b60888f64c55893a986e483d2df842529c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\"Interface to start the ConductorService.\"\"\""},{"line_number":125,"context_line":"        CONF.log_opt_values(LOG, std_logging.INFO)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        policy.init()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        version_string \u003d version.version_info.version_string()"},{"line_number":130,"context_line":"        LOG.debug(\"Starting runner %s on board %s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_82446974","side":"PARENT","line":127,"in_reply_to":"dac4157f_d8601738","updated":"2015-04-21 16:34:56.000000000","message":"that doesn\u0027t seem to be the case, I\u0027ve verified that a cluster goes active with this patch, which would require the create cluster flow to access and update the database","commit_id":"6c3d8521317c464ccfdecdb7858142a0dfa40b66"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"4e9d31362563c392b81882ffdb71715e3329f571","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        finally:"},{"line_number":167,"context_line":"            # Close persistence and jobboard if they were created by us"},{"line_number":168,"context_line":"            if self._persistence is None:"},{"line_number":169,"context_line":"                persistence.close()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            if self._jobboard is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_7edda56f","line":168,"updated":"2015-04-28 16:51:07.000000000","message":"Should this be done if self._persistence is not None ? Wouldnt you get a NoneType error if not?","commit_id":"f85b51a6cdf58c3bdda31b73746e9b10ecbe730a"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"118530635c1dd521a25683232e7d354e747cb9b2","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        finally:"},{"line_number":167,"context_line":"            # Close persistence and jobboard if they were created by us"},{"line_number":168,"context_line":"            if self._persistence is None:"},{"line_number":169,"context_line":"                persistence.close()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            if self._jobboard is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_8d928c56","line":168,"in_reply_to":"5ad0253b_7edda56f","updated":"2015-04-28 20:33:03.000000000","message":"no, it\u0027s checking self._persistence then closing persistence, the reason being if self._persistence is None a new persistence instance is created, one \"owned\" by the ConductorService, whereas if if self._persistence is not None, then persistence is set to self._persistence, which was passed in during construction time.  When persistence or jobboard is passed in rather than created, it\u0027s \"owned\" by whoever passed it in, therefore it is not closed.","commit_id":"f85b51a6cdf58c3bdda31b73746e9b10ecbe730a"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"4e9d31362563c392b81882ffdb71715e3329f571","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                persistence.close()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            if self._jobboard is None:"},{"line_number":172,"context_line":"                jobboard.close()"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self._shutdown_event.set()"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_5edae979","line":172,"updated":"2015-04-28 16:51:07.000000000","message":"Same here with the jobboard","commit_id":"f85b51a6cdf58c3bdda31b73746e9b10ecbe730a"}]}