)]}'
{"cue/tests/functional/objects/test_broker.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for db_broker in db_brokers:"},{"line_number":121,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":122,"context_line":"                updated_broker \u003d objects.Broker._from_db_object("},{"line_number":123,"context_line":"                    objects.Broker(), db_broker)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027rabbit1.0\u0027, updated_broker.name)"},{"line_number":126,"context_line":"        self.assertEqual(False, updated_broker.active)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_be433d6c","line":123,"updated":"2015-04-28 17:21:15.000000000","message":"Nikpicking: Add a \u0027break\u0027 when you have find the updated broker object so that it doesnt keep iterating.. But this is test so there wont be too many brokers...","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for db_broker in db_brokers:"},{"line_number":121,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":122,"context_line":"                updated_broker \u003d objects.Broker._from_db_object("},{"line_number":123,"context_line":"                    objects.Broker(), db_broker)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027rabbit1.0\u0027, updated_broker.name)"},{"line_number":126,"context_line":"        self.assertEqual(False, updated_broker.active)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_441d7865","line":123,"in_reply_to":"5ad0253b_be433d6c","updated":"2015-04-28 23:30:35.000000000","message":"Done","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":37,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":38,"context_line":"        # select the created broker from list of brokers"},{"line_number":39,"context_line":"        for db_broker in db_brokers:"},{"line_number":40,"context_line":"            if db_broker.id \u003d\u003d test_broker_dict[\u0027id\u0027]:"},{"line_number":41,"context_line":"                broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":42,"context_line":"                                                            db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_2eb6db3d","line":39,"updated":"2015-04-29 18:33:34.000000000","message":"you can get the exact broker record by directly querying the db with broker id","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":37,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":38,"context_line":"        # select the created broker from list of brokers"},{"line_number":39,"context_line":"        for db_broker in db_brokers:"},{"line_number":40,"context_line":"            if db_broker.id \u003d\u003d test_broker_dict[\u0027id\u0027]:"},{"line_number":41,"context_line":"                broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":42,"context_line":"                                                            db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_cfb0778e","line":39,"in_reply_to":"3acd31a7_2eb6db3d","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":104,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":105,"context_line":"        # select the created broker from list of brokers"},{"line_number":106,"context_line":"        for db_broker in db_brokers:"},{"line_number":107,"context_line":"            if db_broker.id \u003d\u003d test_broker_dict[\u0027id\u0027]:"},{"line_number":108,"context_line":"                obj_broker \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":109,"context_line":"                                                            db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_9425f9c3","line":106,"updated":"2015-04-29 18:33:34.000000000","message":"same as above","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":104,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":105,"context_line":"        # select the created broker from list of brokers"},{"line_number":106,"context_line":"        for db_broker in db_brokers:"},{"line_number":107,"context_line":"            if db_broker.id \u003d\u003d test_broker_dict[\u0027id\u0027]:"},{"line_number":108,"context_line":"                obj_broker \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":109,"context_line":"                                                            db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_cf0cf744","line":106,"in_reply_to":"3acd31a7_9425f9c3","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":121,"context_line":"        # select the updates broker from list of brokers"},{"line_number":122,"context_line":"        for db_broker in db_brokers:"},{"line_number":123,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":124,"context_line":"                updated_broker \u003d objects.Broker._from_db_object("},{"line_number":125,"context_line":"                    objects.Broker(), db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_6f1dea65","line":122,"updated":"2015-04-29 18:33:34.000000000","message":"same as above","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":121,"context_line":"        # select the updates broker from list of brokers"},{"line_number":122,"context_line":"        for db_broker in db_brokers:"},{"line_number":123,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":124,"context_line":"                updated_broker \u003d objects.Broker._from_db_object("},{"line_number":125,"context_line":"                    objects.Broker(), db_broker)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_1a046b13","line":122,"in_reply_to":"3acd31a7_6f1dea65","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.assertEqual(\u0027rabbit1.0\u0027, updated_broker.name)"},{"line_number":129,"context_line":"        self.assertEqual(False, updated_broker.active)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_get_brokers(self):"},{"line_number":132,"context_line":"        \"\"\"Tests getting all brokers from Broker objects API.\"\"\""},{"line_number":133,"context_line":"        new_broker \u003d self.create_object_broker()"},{"line_number":134,"context_line":"        broker_list \u003d objects.Broker.get_brokers(self.context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_0e2b1fed","line":131,"updated":"2015-04-29 18:33:34.000000000","message":"since this is testing list broker functionality, it should at least create a few broker records first then verify that all broker records have been received with the list broker call.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.assertEqual(\u0027rabbit1.0\u0027, updated_broker.name)"},{"line_number":129,"context_line":"        self.assertEqual(False, updated_broker.active)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_get_brokers(self):"},{"line_number":132,"context_line":"        \"\"\"Tests getting all brokers from Broker objects API.\"\"\""},{"line_number":133,"context_line":"        new_broker \u003d self.create_object_broker()"},{"line_number":134,"context_line":"        broker_list \u003d objects.Broker.get_brokers(self.context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_1b790d94","line":131,"in_reply_to":"3acd31a7_0e2b1fed","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def test_delete_broker(self):"},{"line_number":145,"context_line":"        \"\"\"Tests delete from Broker objects API.\"\"\""},{"line_number":146,"context_line":"        new_broker \u003d self.create_object_broker()"},{"line_number":147,"context_line":"        new_broker.delete_broker(self.context)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_4fb6ae3e","line":147,"updated":"2015-04-29 18:33:34.000000000","message":"this is doing a soft delete, which means the record is still there.  See how it is done in this test:  test_create_two_clusters_verify_time_stamps\n\nThis test should retrieve the \"soft deleted\" record and verify deleted flag is set to True.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def test_delete_broker(self):"},{"line_number":145,"context_line":"        \"\"\"Tests delete from Broker objects API.\"\"\""},{"line_number":146,"context_line":"        new_broker \u003d self.create_object_broker()"},{"line_number":147,"context_line":"        new_broker.delete_broker(self.context)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        db_brokers \u003d self.dbapi.get_brokers(self.context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_5ab6633e","line":147,"in_reply_to":"3acd31a7_4fb6ae3e","updated":"2015-04-30 18:13:35.000000000","message":"since its a test from object\u0027s end , just leaving it to test whether the record is retrieved or not.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        is_deleted \u003d True"},{"line_number":152,"context_line":"        # check to see if deleted broker is in list"},{"line_number":153,"context_line":"        for db_broker in db_brokers:"},{"line_number":154,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":155,"context_line":"                is_deleted \u003d False"},{"line_number":156,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_6f904a96","line":153,"updated":"2015-04-29 18:33:34.000000000","message":"same as above","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        is_deleted \u003d True"},{"line_number":152,"context_line":"        # check to see if deleted broker is in list"},{"line_number":153,"context_line":"        for db_broker in db_brokers:"},{"line_number":154,"context_line":"            if db_broker.id \u003d\u003d new_broker.id:"},{"line_number":155,"context_line":"                is_deleted \u003d False"},{"line_number":156,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_5a5f830e","line":153,"in_reply_to":"3acd31a7_6f904a96","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"515c931f5489a196ffdb52b15c057734bcc406bd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":40,"context_line":"        # retrieve created broker"},{"line_number":41,"context_line":"        broker_query \u003d sqlalchemy_api.model_query("},{"line_number":42,"context_line":"            self.context, models.Broker).filter_by(id\u003dtest_broker_dict[\u0027id\u0027])"},{"line_number":43,"context_line":"        db_broker \u003d broker_query.one()"},{"line_number":44,"context_line":"        broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":45,"context_line":"                                                    db_broker)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3acd31a7_71690825","line":42,"updated":"2015-05-01 17:06:21.000000000","message":"It seems odd that we need to do a straight sql query here.  Don\u0027t we have something like dbapi.get_broker_by_id(id)?","commit_id":"10f9bb29547419870075b5135df756339380e4d6"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"a033ef98973eab8d3707894f42bf0cd9613b72d1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":40,"context_line":"        # retrieve created broker"},{"line_number":41,"context_line":"        broker_query \u003d sqlalchemy_api.model_query("},{"line_number":42,"context_line":"            self.context, models.Broker).filter_by(id\u003dtest_broker_dict[\u0027id\u0027])"},{"line_number":43,"context_line":"        db_broker \u003d broker_query.one()"},{"line_number":44,"context_line":"        broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":45,"context_line":"                                                    db_broker)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3acd31a7_ddd34d5e","line":42,"in_reply_to":"3acd31a7_222b4096","updated":"2015-05-01 19:25:20.000000000","message":"we do need a get_broker_by_id in dbapi, but this patch is not for the purpose of expanding on dbapi, so I think it\u0027s fine as is.  In the future when get_broker_by_id is added, a test needs to be added to validate that function, after which we can replace these direct sqlalchemy calls with get_broker_by_id.\n\nPlease log a bug noting the lack of this functionality so we can follow up on it later.","commit_id":"10f9bb29547419870075b5135df756339380e4d6"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"ab6d52d599a898704b15c5f09a3ddc909ef7d81a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":40,"context_line":"        # retrieve created broker"},{"line_number":41,"context_line":"        broker_query \u003d sqlalchemy_api.model_query("},{"line_number":42,"context_line":"            self.context, models.Broker).filter_by(id\u003dtest_broker_dict[\u0027id\u0027])"},{"line_number":43,"context_line":"        db_broker \u003d broker_query.one()"},{"line_number":44,"context_line":"        broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":45,"context_line":"                                                    db_broker)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3acd31a7_d1b69c89","line":42,"in_reply_to":"3acd31a7_71690825","updated":"2015-05-01 17:12:18.000000000","message":"we only have get_brokers() which should be looped through to fetch the newly created broker.","commit_id":"10f9bb29547419870075b5135df756339380e4d6"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"4eb73f1a71671a7b1bc659a4053a2ae33ad7a409","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":40,"context_line":"        # retrieve created broker"},{"line_number":41,"context_line":"        broker_query \u003d sqlalchemy_api.model_query("},{"line_number":42,"context_line":"            self.context, models.Broker).filter_by(id\u003dtest_broker_dict[\u0027id\u0027])"},{"line_number":43,"context_line":"        db_broker \u003d broker_query.one()"},{"line_number":44,"context_line":"        broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":45,"context_line":"                                                    db_broker)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3acd31a7_222b4096","line":42,"in_reply_to":"3acd31a7_d1b69c89","updated":"2015-05-01 19:13:51.000000000","message":"Can we add that to dbapi then?","commit_id":"10f9bb29547419870075b5135df756339380e4d6"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"e74ec7270260ef22c135219fdcbc8d74341acbc0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        new_broker.create_broker(self.context)"},{"line_number":40,"context_line":"        # retrieve created broker"},{"line_number":41,"context_line":"        broker_query \u003d sqlalchemy_api.model_query("},{"line_number":42,"context_line":"            self.context, models.Broker).filter_by(id\u003dtest_broker_dict[\u0027id\u0027])"},{"line_number":43,"context_line":"        db_broker \u003d broker_query.one()"},{"line_number":44,"context_line":"        broker_obj \u003d objects.Broker._from_db_object(objects.Broker(),"},{"line_number":45,"context_line":"                                                    db_broker)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3acd31a7_7d55594e","line":42,"in_reply_to":"3acd31a7_ddd34d5e","updated":"2015-05-01 19:44:19.000000000","message":"Done\nhttps://bugs.launchpad.net/cue/+bug/1450895","commit_id":"10f9bb29547419870075b5135df756339380e4d6"}],"cue/tests/functional/objects/test_broker_metadata.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        new_broker_metadata.create_broker_metadata(self.context)"},{"line_number":44,"context_line":"        return new_broker_metadata"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def validate_broker_metadata_values(self, metadata_ref, metadata_cmp):"},{"line_number":47,"context_line":"        \"\"\"Validate Broker_Metadata Object fields.\"\"\""},{"line_number":48,"context_line":"        self.assertEqual(metadata_ref.id if hasattr(metadata_ref, \"id\") else"},{"line_number":49,"context_line":"                         metadata_ref[\"id\"],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_3e060d21","line":46,"updated":"2015-04-28 17:21:15.000000000","message":"This validate method look very similar to the validate _broker_value. Would it be too hard to combine these two into one. I know each have different attribute you are testing.. So perhaps you can pass them in.\n\nAnyways, since these are tests, i wont be too picking on this :p","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        new_broker_metadata.create_broker_metadata(self.context)"},{"line_number":44,"context_line":"        return new_broker_metadata"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def validate_broker_metadata_values(self, metadata_ref, metadata_cmp):"},{"line_number":47,"context_line":"        \"\"\"Validate Broker_Metadata Object fields.\"\"\""},{"line_number":48,"context_line":"        self.assertEqual(metadata_ref.id if hasattr(metadata_ref, \"id\") else"},{"line_number":49,"context_line":"                         metadata_ref[\"id\"],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_a480cc47","line":46,"in_reply_to":"5ad0253b_3e060d21","updated":"2015-04-28 23:30:35.000000000","message":"yes. the fields in each class is different. so if we need this class validation commonly for some other class method , maybe we can move this to utils or try to combine.","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"         API."},{"line_number":139,"context_line":"         \"\"\""},{"line_number":140,"context_line":"        broker_metadata \u003d self.create_object_broker_metadata()"},{"line_number":141,"context_line":"        metadata \u003d objects.BrokerMetadata.get_broker_metadata_by_broker_id("},{"line_number":142,"context_line":"            self.context, broker_metadata.broker_id)"},{"line_number":143,"context_line":"        self.validate_broker_metadata_values(broker_metadata,"},{"line_number":144,"context_line":"                                             metadata[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_ef81fafc","line":141,"updated":"2015-04-29 18:33:34.000000000","message":"since this returns a list, this test should create a few broker metadata associated with one broker and a couple more associated with a different broker.  Then verify the appropriate list with contents is received.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"         API."},{"line_number":139,"context_line":"         \"\"\""},{"line_number":140,"context_line":"        broker_metadata \u003d self.create_object_broker_metadata()"},{"line_number":141,"context_line":"        metadata \u003d objects.BrokerMetadata.get_broker_metadata_by_broker_id("},{"line_number":142,"context_line":"            self.context, broker_metadata.broker_id)"},{"line_number":143,"context_line":"        self.validate_broker_metadata_values(broker_metadata,"},{"line_number":144,"context_line":"                                             metadata[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_fb565105","line":141,"in_reply_to":"3acd31a7_ef81fafc","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        image_id \u003d objects.BrokerMetadata.get_image_id_by_broker_name("},{"line_number":173,"context_line":"            self.context, new_broker.name)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.assertEqual(image_id, new_broker_metadata.value)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_get_image_id_by_nonexistent_broker_name(self):"},{"line_number":178,"context_line":"        \"\"\"Tests get broker image_id by nonexistent broker_name from"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_8a103450","line":175,"updated":"2015-04-29 18:33:34.000000000","message":"can you also verify the key here too.  Will make it clear that this is a key/value pair","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        image_id \u003d objects.BrokerMetadata.get_image_id_by_broker_name("},{"line_number":173,"context_line":"            self.context, new_broker.name)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.assertEqual(image_id, new_broker_metadata.value)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_get_image_id_by_nonexistent_broker_name(self):"},{"line_number":178,"context_line":"        \"\"\"Tests get broker image_id by nonexistent broker_name from"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_3aee078c","line":175,"in_reply_to":"3acd31a7_8a103450","updated":"2015-04-30 18:13:35.000000000","message":"this method will retrieve only the image_id which is the value of the broker_metadata.so i wont be able to assert the key.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"}],"cue/tests/functional/objects/test_cluster.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\"Test Cluster Object generation from a cluster dictionary object.\"\"\""},{"line_number":50,"context_line":"        cluster_dict \u003d func_utils.get_test_cluster()"},{"line_number":51,"context_line":"        cluster_object \u003d objects.Cluster(**cluster_dict)"},{"line_number":52,"context_line":"        test_utils.validate_cluster_values(self, cluster_object, cluster_dict)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_cluster_api_to_object_to_api(self):"},{"line_number":55,"context_line":"        \"\"\"Tests Cluster api object conversion to Cluster object and back"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_ec60c537","line":52,"updated":"2015-04-23 17:46:41.000000000","message":"The ref object should be what you are verifying function against.  \nref -\u003e cluster_dict (reference object)\ncmp -\u003e cluster_object (test object)","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\"Test Cluster Object generation from a cluster dictionary object.\"\"\""},{"line_number":50,"context_line":"        cluster_dict \u003d func_utils.get_test_cluster()"},{"line_number":51,"context_line":"        cluster_object \u003d objects.Cluster(**cluster_dict)"},{"line_number":52,"context_line":"        test_utils.validate_cluster_values(self, cluster_object, cluster_dict)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_cluster_api_to_object_to_api(self):"},{"line_number":55,"context_line":"        \"\"\"Tests Cluster api object conversion to Cluster object and back"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_124bf288","line":52,"in_reply_to":"bab921fb_ec60c537","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.validate_cluster_deleted_fields(db_cluster_object,"},{"line_number":96,"context_line":"                                             db_cluster_object_2)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_cluster(self):"},{"line_number":99,"context_line":"        \"\"\"Tests create a cluster from Cluster objects API.\"\"\""},{"line_number":100,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":101,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_0fef6be9","line":98,"updated":"2015-04-23 17:46:41.000000000","message":"add _size_one and overwrite the default size in your test dict to 1 (in case the default changes)","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.validate_cluster_deleted_fields(db_cluster_object,"},{"line_number":96,"context_line":"                                             db_cluster_object_2)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_cluster(self):"},{"line_number":99,"context_line":"        \"\"\"Tests create a cluster from Cluster objects API.\"\"\""},{"line_number":100,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":101,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_52596a59","line":98,"in_reply_to":"bab921fb_0fef6be9","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_cluster(self):"},{"line_number":99,"context_line":"        \"\"\"Tests create a cluster from Cluster objects API.\"\"\""},{"line_number":100,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":101,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"},{"line_number":102,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"},{"line_number":103,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_4f94438a","line":100,"updated":"2015-04-23 17:46:41.000000000","message":"this doesn\u0027t really let you test the create since this utility function does the entire cluster creation for you.  You will want to \n1. get a cluster_dict for what you are going to create\n2. create object Cluster with this dict\n3. verify new object cluster is correct\n4. call create instance method on this object Cluster\n5. retrieve the cluster from DB API (like you are doing below)\n6. verify verify this db_cluster values are in fact the same as the original cluster_dict.","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_cluster(self):"},{"line_number":99,"context_line":"        \"\"\"Tests create a cluster from Cluster objects API.\"\"\""},{"line_number":100,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":101,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"},{"line_number":102,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"},{"line_number":103,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_1800b300","line":100,"in_reply_to":"bab921fb_4f94438a","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":104,"context_line":"                                                        db_cluster.id)"},{"line_number":105,"context_line":"        for nodes in cluster_nodes:"},{"line_number":106,"context_line":"            self.assertEqual(nodes.cluster_id, db_cluster.id)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_create_cluster_size_three(self):"},{"line_number":109,"context_line":"        \"\"\"Tests create cluster of size three from Cluster objects API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_6f21474d","line":106,"updated":"2015-04-23 17:46:41.000000000","message":"also check for correct flavor and status is BUILDING","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":104,"context_line":"                                                        db_cluster.id)"},{"line_number":105,"context_line":"        for nodes in cluster_nodes:"},{"line_number":106,"context_line":"            self.assertEqual(nodes.cluster_id, db_cluster.id)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_create_cluster_size_three(self):"},{"line_number":109,"context_line":"        \"\"\"Tests create cluster of size three from Cluster objects API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_d86ebbc8","line":106,"in_reply_to":"bab921fb_6f21474d","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_create_cluster_size_three(self):"},{"line_number":109,"context_line":"        \"\"\"Tests create cluster of size three from Cluster objects API.\"\"\""},{"line_number":110,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":111,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context,"},{"line_number":112,"context_line":"                                                  new_cluster.id)"},{"line_number":113,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_8fe25b02","line":110,"updated":"2015-04-23 17:46:41.000000000","message":"same as above","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_create_cluster_size_three(self):"},{"line_number":109,"context_line":"        \"\"\"Tests create cluster of size three from Cluster objects API.\"\"\""},{"line_number":110,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":111,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context,"},{"line_number":112,"context_line":"                                                  new_cluster.id)"},{"line_number":113,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_b8a8a7dc","line":110,"in_reply_to":"bab921fb_8fe25b02","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        for nodes in cluster_nodes:"},{"line_number":118,"context_line":"            self.assertEqual(nodes.cluster_id, db_cluster.id)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_update(self):"},{"line_number":121,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":122,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":123,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_2fc58f3b","line":120,"updated":"2015-04-23 17:46:41.000000000","message":"make it more specific so to what this is updating","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        for nodes in cluster_nodes:"},{"line_number":118,"context_line":"            self.assertEqual(nodes.cluster_id, db_cluster.id)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_update(self):"},{"line_number":121,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":122,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":123,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_98972390","line":120,"in_reply_to":"bab921fb_2fc58f3b","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_update(self):"},{"line_number":121,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":122,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":123,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"},{"line_number":124,"context_line":"        new_cluster.name \u003d \u0027test_cluster\u0027"},{"line_number":125,"context_line":"        new_cluster.update(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_6ff94780","line":122,"updated":"2015-04-23 17:46:41.000000000","message":"this should be broken up to so we have the original dic of values that where used to create the object to begin with","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_update(self):"},{"line_number":121,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":122,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":123,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"},{"line_number":124,"context_line":"        new_cluster.name \u003d \u0027test_cluster\u0027"},{"line_number":125,"context_line":"        new_cluster.update(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_0ea5e6a0","line":122,"in_reply_to":"bab921fb_6ff94780","updated":"2015-04-24 21:59:24.000000000","message":"original dict is not required here as the validation is against the created cluster obj and the updated one.","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        test_cluster \u003d self.dbapi.get_cluster_by_id(self.context,"},{"line_number":128,"context_line":"                                                    new_cluster.id)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027flavor2\u0027, test_cluster.flavor)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027test_cluster\u0027, test_cluster.name)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_get_clusters(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_cf8df332","line":129,"updated":"2015-04-23 17:46:41.000000000","message":"we should also check that the rest of the values haven\u0027t changed.","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        test_cluster \u003d self.dbapi.get_cluster_by_id(self.context,"},{"line_number":128,"context_line":"                                                    new_cluster.id)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027flavor2\u0027, test_cluster.flavor)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027test_cluster\u0027, test_cluster.name)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_get_clusters(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_abba6c08","line":129,"in_reply_to":"bab921fb_cf8df332","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(\u0027flavor2\u0027, test_cluster.flavor)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027test_cluster\u0027, test_cluster.name)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_get_clusters(self):"},{"line_number":133,"context_line":"        \"\"\"Tests getting all Clusters from Cluster objects API.\"\"\""},{"line_number":134,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":135,"context_line":"        cluster_list \u003d new_cluster.get_clusters(self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_4f6b231f","line":132,"updated":"2015-04-23 17:46:41.000000000","message":"this is getting all clusters when there is one existing.  make name more explicit and we should have another where you get a list of a few clusters (maybe 5)","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(\u0027flavor2\u0027, test_cluster.flavor)"},{"line_number":130,"context_line":"        self.assertEqual(\u0027test_cluster\u0027, test_cluster.name)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_get_clusters(self):"},{"line_number":133,"context_line":"        \"\"\"Tests getting all Clusters from Cluster objects API.\"\"\""},{"line_number":134,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":135,"context_line":"        cluster_list \u003d new_cluster.get_clusters(self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_4b107001","line":132,"in_reply_to":"bab921fb_4f6b231f","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                         new_cluster.id)"},{"line_number":143,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, test_cluster)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_get_cluster_by_invalid_id(self):"},{"line_number":146,"context_line":"        \"\"\"Tests get cluster from Cluster objects API with invalid cluster id."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_8fedbb8d","line":145,"updated":"2015-04-23 17:46:41.000000000","message":"an invalid formatted cluster id or non-existing cluster id?","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                         new_cluster.id)"},{"line_number":143,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, test_cluster)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_get_cluster_by_invalid_id(self):"},{"line_number":146,"context_line":"        \"\"\"Tests get cluster from Cluster objects API with invalid cluster id."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_0eccc668","line":145,"in_reply_to":"bab921fb_8fedbb8d","updated":"2015-04-24 21:59:24.000000000","message":"its a non-existing id. changed the name of the function.","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        new_cluster.create(self.context)"},{"line_number":107,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"},{"line_number":108,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"},{"line_number":109,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                        db_cluster.id)"},{"line_number":111,"context_line":"        for nodes in cluster_nodes:"},{"line_number":112,"context_line":"            self.assertEqual(db_cluster.id, nodes.cluster_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_8920494b","line":109,"updated":"2015-04-28 17:21:15.000000000","message":"Can you add an assert to check that the number of node is one?\nAnd if the number of node expected is one, we dont need a for loop to traverse it.","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        new_cluster.create(self.context)"},{"line_number":107,"context_line":"        db_cluster \u003d self.dbapi.get_cluster_by_id(self.context, new_cluster.id)"},{"line_number":108,"context_line":"        test_utils.validate_cluster_values(self, new_cluster, db_cluster)"},{"line_number":109,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                        db_cluster.id)"},{"line_number":111,"context_line":"        for nodes in cluster_nodes:"},{"line_number":112,"context_line":"            self.assertEqual(db_cluster.id, nodes.cluster_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_c4e628e8","line":109,"in_reply_to":"5ad0253b_8920494b","updated":"2015-04-28 23:30:35.000000000","message":"return type of get_nodes_in_cluster() is of type list, thats the reason i used for loop.changed it to check against 0th index now.","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":128,"context_line":"                                                        db_cluster.id)"},{"line_number":129,"context_line":"        for nodes in cluster_nodes:"},{"line_number":130,"context_line":"            self.assertEqual(db_cluster.id, nodes.cluster_id)"},{"line_number":131,"context_line":"            self.assertEqual(db_cluster.flavor, nodes.flavor)"},{"line_number":132,"context_line":"            self.assertEqual(db_cluster.status, nodes.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_c9dc0149","line":129,"updated":"2015-04-28 17:21:15.000000000","message":"Can we add an assert to check that the node count is 3?","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":128,"context_line":"                                                        db_cluster.id)"},{"line_number":129,"context_line":"        for nodes in cluster_nodes:"},{"line_number":130,"context_line":"            self.assertEqual(db_cluster.id, nodes.cluster_id)"},{"line_number":131,"context_line":"            self.assertEqual(db_cluster.flavor, nodes.flavor)"},{"line_number":132,"context_line":"            self.assertEqual(db_cluster.status, nodes.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_641d140f","line":129,"in_reply_to":"5ad0253b_c9dc0149","updated":"2015-04-28 23:30:35.000000000","message":"validate_cluster_value() asserts the cluster size (node count)","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_cluster(self):"},{"line_number":137,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":138,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":139,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"},{"line_number":140,"context_line":"        new_cluster.name \u003d \u0027test_cluster\u0027"},{"line_number":141,"context_line":"        new_cluster.update(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_aadd3072","line":138,"updated":"2015-04-29 18:33:34.000000000","message":"override default values for the attributes that this test updates","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_cluster(self):"},{"line_number":137,"context_line":"        \"\"\"Tests update cluster from Cluster objects API.\"\"\""},{"line_number":138,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":139,"context_line":"        new_cluster.flavor \u003d \u0027flavor2\u0027"},{"line_number":140,"context_line":"        new_cluster.name \u003d \u0027test_cluster\u0027"},{"line_number":141,"context_line":"        new_cluster.update(self.context, new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_f19c116b","line":138,"in_reply_to":"3acd31a7_aadd3072","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"}],"cue/tests/functional/objects/test_endpoint.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class EndpointObjectsTests(base.FunctionalTestCase):"},{"line_number":30,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def create_object_endpoint(self):"},{"line_number":33,"context_line":"        \"\"\"Create an endpoint object.\"\"\""},{"line_number":34,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":35,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_1a5687d2","line":32,"updated":"2015-04-23 17:46:41.000000000","message":"this creates an entire cluster to.  it would make more sense if this helper function takes in a Node id and creates an endpoint attached to that node ID.  Before calling this function, you setup your environment by calling other utility functions as required.  The way this is designed, it does not allow someone to keep adding endpoints to an existing node, instead it creates an entire new cluster and adds one more endpoint to one of the nodes.","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class EndpointObjectsTests(base.FunctionalTestCase):"},{"line_number":30,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def create_object_endpoint(self):"},{"line_number":33,"context_line":"        \"\"\"Create an endpoint object.\"\"\""},{"line_number":34,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":35,"context_line":"        cluster_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_48806fc0","line":32,"in_reply_to":"bab921fb_1a5687d2","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \"\"\"Test Endpoint Object generation from a cluster dictionary object.\"\"\""},{"line_number":74,"context_line":"        endpoint_dict \u003d func_utils.get_test_endpoint()"},{"line_number":75,"context_line":"        endpoint_object \u003d objects.Endpoint(**endpoint_dict)"},{"line_number":76,"context_line":"        self.validate_endpoint_values(endpoint_object, endpoint_dict)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_endpoint_api_to_object_to_api(self):"},{"line_number":79,"context_line":"        \"\"\"Tests Endpoint api object conversion to Endpoint object and back"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_da05afc2","line":76,"updated":"2015-04-23 17:46:41.000000000","message":"swap -\u003e (ref, cmp)","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \"\"\"Test Endpoint Object generation from a cluster dictionary object.\"\"\""},{"line_number":74,"context_line":"        endpoint_dict \u003d func_utils.get_test_endpoint()"},{"line_number":75,"context_line":"        endpoint_object \u003d objects.Endpoint(**endpoint_dict)"},{"line_number":76,"context_line":"        self.validate_endpoint_values(endpoint_object, endpoint_dict)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_endpoint_api_to_object_to_api(self):"},{"line_number":79,"context_line":"        \"\"\"Tests Endpoint api object conversion to Endpoint object and back"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_eef4f287","line":76,"in_reply_to":"bab921fb_da05afc2","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertRaises(oslo_exception.DBReferenceError, api_endpoint.create,"},{"line_number":126,"context_line":"                          self.context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_update_by_node_id(self):"},{"line_number":129,"context_line":"        \"\"\"Tests update endpoint by node id from Endpoint objects API.\"\"\""},{"line_number":130,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d1)"},{"line_number":131,"context_line":"        cluster_node \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_6abef800","line":128,"updated":"2015-04-29 18:33:34.000000000","message":"test_update_endpoint_by_node_id to be more descriptive","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertRaises(oslo_exception.DBReferenceError, api_endpoint.create,"},{"line_number":126,"context_line":"                          self.context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_update_by_node_id(self):"},{"line_number":129,"context_line":"        \"\"\"Tests update endpoint by node id from Endpoint objects API.\"\"\""},{"line_number":130,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d1)"},{"line_number":131,"context_line":"        cluster_node \u003d self.dbapi.get_nodes_in_cluster(self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_b18d7933","line":128,"in_reply_to":"3acd31a7_6abef800","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        cluster_node \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":132,"context_line":"                                                        new_cluster.id)"},{"line_number":133,"context_line":"        cluster_node_id \u003d cluster_node[0].id"},{"line_number":134,"context_line":"        new_endpoint \u003d self.create_object_endpoint(cluster_node_id)"},{"line_number":135,"context_line":"        endpoint_values \u003d {"},{"line_number":136,"context_line":"            \u0027uri\u0027: \u002710.0.0.2:5672\u0027,"},{"line_number":137,"context_line":"            \u0027type\u0027: \u0027XMPP\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_ea0e88e4","line":134,"updated":"2015-04-29 18:33:34.000000000","message":"override default values for the attributes that this test updates.  Pass in kwargs so your create endpoint test function will set the appropriate overridden values","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        cluster_node \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":132,"context_line":"                                                        new_cluster.id)"},{"line_number":133,"context_line":"        cluster_node_id \u003d cluster_node[0].id"},{"line_number":134,"context_line":"        new_endpoint \u003d self.create_object_endpoint(cluster_node_id)"},{"line_number":135,"context_line":"        endpoint_values \u003d {"},{"line_number":136,"context_line":"            \u0027uri\u0027: \u002710.0.0.2:5672\u0027,"},{"line_number":137,"context_line":"            \u0027type\u0027: \u0027XMPP\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_94826bff","line":134,"in_reply_to":"3acd31a7_ea0e88e4","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"}],"cue/tests/functional/objects/test_node.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NodeObjectsTests(base.FunctionalTestCase):"},{"line_number":28,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def validate_node_values(self, node_ref, node_cmp):"},{"line_number":31,"context_line":"        \"\"\"Validate Node Object fields.\"\"\""},{"line_number":32,"context_line":"        self.assertEqual(node_ref.id if hasattr(node_ref, \"id\") else"},{"line_number":33,"context_line":"                         node_ref[\"id\"],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_89d169fe","line":30,"updated":"2015-04-28 17:21:15.000000000","message":"This method is very similar too the one in broker and broker_metadata... Since this is being done 3 times, we should create a validate_object() method in utils.","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NodeObjectsTests(base.FunctionalTestCase):"},{"line_number":28,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def validate_node_values(self, node_ref, node_cmp):"},{"line_number":31,"context_line":"        \"\"\"Validate Node Object fields.\"\"\""},{"line_number":32,"context_line":"        self.assertEqual(node_ref.id if hasattr(node_ref, \"id\") else"},{"line_number":33,"context_line":"                         node_ref[\"id\"],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_0cf3190c","line":30,"in_reply_to":"5ad0253b_89d169fe","updated":"2015-04-28 23:30:35.000000000","message":"each has different attributes and the compared object can be of type dict/cue object/sqlalchemy object. so if the field type changes between these, then its better to have validation separately for each class.","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2872cb0fdfc3d9241f9b0f23d02fae7038e44fb9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\"Tests update three nodes from Node objects API.\"\"\""},{"line_number":107,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        db_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                   new_cluster.id)"},{"line_number":111,"context_line":"        for current_node in db_nodes:"},{"line_number":112,"context_line":"            current_node \u003d objects.Node._from_db_object(objects.Node(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_89f8497e","line":109,"updated":"2015-04-28 17:21:15.000000000","message":"Can you add a assert to make sure that the size of nodes is 3?","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"751f9ada3e44116cb1bbe4764f753a8800b72f03","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\"Tests update three nodes from Node objects API.\"\"\""},{"line_number":107,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        db_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                   new_cluster.id)"},{"line_number":111,"context_line":"        for current_node in db_nodes:"},{"line_number":112,"context_line":"            current_node \u003d objects.Node._from_db_object(objects.Node(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_aca0a591","line":109,"in_reply_to":"5ad0253b_89f8497e","updated":"2015-04-28 23:30:35.000000000","message":"Done","commit_id":"383aa9ea89d93f24db0648e10bf919383b620f9c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_update_node_size_one(self):"},{"line_number":94,"context_line":"        \"\"\"Tests update node from Node objects API.\"\"\""},{"line_number":95,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        db_node \u003d self.dbapi.get_nodes_in_cluster(self.context, new_cluster.id)"},{"line_number":98,"context_line":"        new_node \u003d objects.Node._from_db_object(objects.Node(), db_node[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_2ad3603a","line":95,"updated":"2015-04-29 18:33:34.000000000","message":"same as below.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_update_node_size_one(self):"},{"line_number":94,"context_line":"        \"\"\"Tests update node from Node objects API.\"\"\""},{"line_number":95,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        db_node \u003d self.dbapi.get_nodes_in_cluster(self.context, new_cluster.id)"},{"line_number":98,"context_line":"        new_node \u003d objects.Node._from_db_object(objects.Node(), db_node[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_f4d87f1f","line":95,"in_reply_to":"3acd31a7_2ad3603a","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_update_node_size_three(self):"},{"line_number":106,"context_line":"        \"\"\"Tests update three nodes from Node objects API.\"\"\""},{"line_number":107,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        db_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                   new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_ea7b287a","line":107,"updated":"2015-04-29 18:33:34.000000000","message":"since we are updating flavor here, override the default flavor when using the utils method in order to ensure it is different from the updated flavor below since this test specifically checks for that.","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_update_node_size_three(self):"},{"line_number":106,"context_line":"        \"\"\"Tests update three nodes from Node objects API.\"\"\""},{"line_number":107,"context_line":"        new_cluster \u003d func_utils.create_object_cluster(self.context, size\u003d3)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        db_nodes \u003d self.dbapi.get_nodes_in_cluster(self.context,"},{"line_number":110,"context_line":"                                                   new_cluster.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_54cbb353","line":107,"in_reply_to":"3acd31a7_ea7b287a","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"}],"cue/tests/functional/utils.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"9da73ece7ee73fe431b5f190330497d7e58fc60d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return all_endpoints"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def get_test_endpoint(**kw):"},{"line_number":187,"context_line":"    return {"},{"line_number":188,"context_line":"        \u0027id\u0027: kw.get(\u0027id\u0027, \u00274ddedb63-ac35-48b7-84ef-f929fb6b065e\u0027),"},{"line_number":189,"context_line":"        \u0027node_id\u0027: kw.get(\u0027node_id\u0027, \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c781\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_ea98c86c","line":186,"updated":"2015-04-29 18:33:34.000000000","message":"would be more clear to append _dict to the end of each of these get_test_* since they return the dictionary equivalent of each respective object","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b49a4f06df2ae304094539f34808e1ae9a2a86d0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return all_endpoints"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def get_test_endpoint(**kw):"},{"line_number":187,"context_line":"    return {"},{"line_number":188,"context_line":"        \u0027id\u0027: kw.get(\u0027id\u0027, \u00274ddedb63-ac35-48b7-84ef-f929fb6b065e\u0027),"},{"line_number":189,"context_line":"        \u0027node_id\u0027: kw.get(\u0027node_id\u0027, \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c781\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_144adbc5","line":186,"in_reply_to":"3acd31a7_ea98c86c","updated":"2015-04-30 18:13:35.000000000","message":"Done","commit_id":"ff2b82addc4a307237291bb9d2bafe88d8e7f61c"}],"cue/tests/unit/objects/test_objects.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027deleted_at\u0027: None,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_as_dict(self):"},{"line_number":46,"context_line":"        \"\"\"test conversion of Cluster object to dict.\"\"\""},{"line_number":47,"context_line":"        cluster \u003d self.get_test_cluster()"},{"line_number":48,"context_line":"        cluster_obj \u003d objects.Cluster(**cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_3594bc89","line":45,"updated":"2015-04-23 17:46:41.000000000","message":"more explicit in test names, add cluster","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027deleted_at\u0027: None,"},{"line_number":43,"context_line":"        }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_as_dict(self):"},{"line_number":46,"context_line":"        \"\"\"test conversion of Cluster object to dict.\"\"\""},{"line_number":47,"context_line":"        cluster \u003d self.get_test_cluster()"},{"line_number":48,"context_line":"        cluster_obj \u003d objects.Cluster(**cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_a45e1910","line":45,"in_reply_to":"bab921fb_3594bc89","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"cff5148bf6097bcca662d67cfc99ef658684d733","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\"test Cluster object changes by setting a valid field.\"\"\""},{"line_number":62,"context_line":"        cluster_obj \u003d objects.Cluster()"},{"line_number":63,"context_line":"        cluster_obj[\u0027status\u0027] \u003d models.Status.DELETING"},{"line_number":64,"context_line":"        cluster_dict \u003d cluster_obj.obj_get_changes()"},{"line_number":65,"context_line":"        # check the changed field"},{"line_number":66,"context_line":"        self.assertEqual(models.Status.DELETING, cluster_dict[\u0027status\u0027])"},{"line_number":67,"context_line":"        # check for an unchanged field"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_d55ea0e8","line":64,"updated":"2015-04-23 17:46:41.000000000","message":"cluster_dict name is confusing, should be cluster_changes_dict","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"c77774a55e26314f4069fb34eae310c1921a177b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\"test Cluster object changes by setting a valid field.\"\"\""},{"line_number":62,"context_line":"        cluster_obj \u003d objects.Cluster()"},{"line_number":63,"context_line":"        cluster_obj[\u0027status\u0027] \u003d models.Status.DELETING"},{"line_number":64,"context_line":"        cluster_dict \u003d cluster_obj.obj_get_changes()"},{"line_number":65,"context_line":"        # check the changed field"},{"line_number":66,"context_line":"        self.assertEqual(models.Status.DELETING, cluster_dict[\u0027status\u0027])"},{"line_number":67,"context_line":"        # check for an unchanged field"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_649fe1b4","line":64,"in_reply_to":"bab921fb_d55ea0e8","updated":"2015-04-24 21:59:24.000000000","message":"Done","commit_id":"ae9801d0db88967a0730fc641756fbed8f7ae3bb"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"3007ce2d944f5df60b152b19f72eadfef118e7ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from cue.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestCueObjects(base.UnitTestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_test_cluster(self):"},{"line_number":30,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_ac3c2530","line":27,"updated":"2015-04-28 23:34:55.000000000","message":"keep this as: CueObjectsTest. The rest of the modules use this pattern. If its something we should change, we should do it in a separate patch and to all modules to keep consistency.","commit_id":"78c953560a4b3d32820851d371a486e4f49b3e17"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"7992a2be927537f0e5eb3201c499af81b52d55e0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from cue.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestCueObjects(base.UnitTestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def get_test_cluster(self):"},{"line_number":30,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_acd8a5f0","line":27,"in_reply_to":"5ad0253b_ac3c2530","updated":"2015-04-28 23:42:29.000000000","message":"Done","commit_id":"78c953560a4b3d32820851d371a486e4f49b3e17"}]}