)]}'
{"cue/tests/functional/db/test_api.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"f46e776b0f8b23813a318dcf18a6ad7fcc136b36","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        db_broker \u003d self.dbapi.create_broker(self.context, broker_values)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(broker_values[\u0027name\u0027], db_broker.name,"},{"line_number":106,"context_line":"                         \"invalid broker name value\")"},{"line_number":107,"context_line":"        self.assertEqual(broker_values[\u0027active\u0027], db_broker.active,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad0253b_29a7f550","line":104,"updated":"2015-04-28 17:29:24.000000000","message":"What is the difference between these tests to Abitha\u0027s in https://review.openstack.org/#/c/176538/? I see that both are calling and testing the cue.db.api functions.","commit_id":"0b1c2a76f3e45e627219b30d1785cf271a6b4d33"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"a548b5b4b0d403d1cd17be4453f249b9cb18a7a7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        db_broker \u003d self.dbapi.create_broker(self.context, broker_values)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(broker_values[\u0027name\u0027], db_broker.name,"},{"line_number":106,"context_line":"                         \"invalid broker name value\")"},{"line_number":107,"context_line":"        self.assertEqual(broker_values[\u0027active\u0027], db_broker.active,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad0253b_6a3efbb9","line":104,"in_reply_to":"5ad0253b_29a7f550","updated":"2015-04-28 18:20:53.000000000","message":"These tests are specifically for the functionality provided by cue/db/sqlalchemy/api.py.  It looks like Abitha is testing the api provided by the cue/objects/broker.py, but is also using sqlalchemy/api.py::get_brokers().  So I think she\u0027s using cue.db.api, but not testing it.","commit_id":"0b1c2a76f3e45e627219b30d1785cf271a6b4d33"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"d30855da926d6d6e89917ade6738c50eb0e12dc4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"UUID2 \u003d str(uuid.uuid4())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestApi(base.FunctionalTestCase):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_a3d1d9fd","line":33,"updated":"2015-04-28 23:00:19.000000000","message":"keep this as: ApiTests.  The rest of the modules use this pattern.  If its something we should change, we should do it in a separate patch and to all modules to keep consistency.","commit_id":"d585e0f4dd972ece842c334ed76402971db0f865"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"9be59764cba1a313415ad2bd19d9e3284c38d95f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"UUID2 \u003d str(uuid.uuid4())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestApi(base.FunctionalTestCase):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_2c7ed5e4","line":33,"in_reply_to":"5ad0253b_a3d1d9fd","updated":"2015-04-28 23:36:24.000000000","message":"Done","commit_id":"d585e0f4dd972ece842c334ed76402971db0f865"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"d30855da926d6d6e89917ade6738c50eb0e12dc4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(broker_values[\u0027active\u0027], db_broker.active,"},{"line_number":108,"context_line":"                         \"invalid broker active value\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_get_brokers(self):"},{"line_number":111,"context_line":"        \"\"\"Verifies get brokers DB API.\"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        brokers \u003d self.dbapi.get_brokers(self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_e334714b","line":110,"updated":"2015-04-28 23:00:19.000000000","message":"name should be more specific as we might have multiple tests of \"get_brokers\".  since this is testing the default broker, good name can be:\ntest_get_default_broker\n\nWe should probably have another tests the retrieval of multiple brokers.","commit_id":"d585e0f4dd972ece842c334ed76402971db0f865"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"9be59764cba1a313415ad2bd19d9e3284c38d95f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(broker_values[\u0027active\u0027], db_broker.active,"},{"line_number":108,"context_line":"                         \"invalid broker active value\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_get_brokers(self):"},{"line_number":111,"context_line":"        \"\"\"Verifies get brokers DB API.\"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        brokers \u003d self.dbapi.get_brokers(self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_6c1dedbc","line":110,"in_reply_to":"5ad0253b_e334714b","updated":"2015-04-28 23:36:24.000000000","message":"Done","commit_id":"d585e0f4dd972ece842c334ed76402971db0f865"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6301de8b180eea072b179cd777c1ea8320080d16","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.assertEqual(brokers[0].name,"},{"line_number":121,"context_line":"                         \"rabbitmq\","},{"line_number":122,"context_line":"                         \"Should have found the default rabbitmq broker, \""},{"line_number":123,"context_line":"                         \"instead found: \" + str(brokers[0].name))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_multiple_brokers(self):"},{"line_number":126,"context_line":"        \"\"\"Verifies get brokers DB API.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_cc72c57c","line":123,"updated":"2015-04-29 20:51:09.000000000","message":"this should be getting a single broker that you create ,instead of the default one.","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"da2fb980ba5ad3392580ea151bac8ded1f45e160","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.assertEqual(brokers[0].name,"},{"line_number":121,"context_line":"                         \"rabbitmq\","},{"line_number":122,"context_line":"                         \"Should have found the default rabbitmq broker, \""},{"line_number":123,"context_line":"                         \"instead found: \" + str(brokers[0].name))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_multiple_brokers(self):"},{"line_number":126,"context_line":"        \"\"\"Verifies get brokers DB API.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_faa40f09","line":123,"in_reply_to":"3acd31a7_cc72c57c","updated":"2015-04-29 23:22:23.000000000","message":"Done","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6301de8b180eea072b179cd777c1ea8320080d16","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self.assertEqual(broker_metadata_values[\u0027value\u0027], db_broker.value,"},{"line_number":219,"context_line":"                         \"invalid broker value\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Testing broker ID that should not exist in the table"},{"line_number":222,"context_line":"        broker_metadata_values[\u0027broker_id\u0027] \u003d UUID1"},{"line_number":223,"context_line":"        try:"},{"line_number":224,"context_line":"            self.assertRaises(exception.NotFound,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_2c3139a3","line":221,"updated":"2015-04-29 20:51:09.000000000","message":"this should be a separate negative test case.","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"da2fb980ba5ad3392580ea151bac8ded1f45e160","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self.assertEqual(broker_metadata_values[\u0027value\u0027], db_broker.value,"},{"line_number":219,"context_line":"                         \"invalid broker value\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Testing broker ID that should not exist in the table"},{"line_number":222,"context_line":"        broker_metadata_values[\u0027broker_id\u0027] \u003d UUID1"},{"line_number":223,"context_line":"        try:"},{"line_number":224,"context_line":"            self.assertRaises(exception.NotFound,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_a05b0854","line":221,"in_reply_to":"3acd31a7_2c3139a3","updated":"2015-04-29 23:22:23.000000000","message":"Done","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6301de8b180eea072b179cd777c1ea8320080d16","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":303,"context_line":"                          self.dbapi.get_image_id_by_broker_name,"},{"line_number":304,"context_line":"                          self.context,"},{"line_number":305,"context_line":"                          \"fake mq\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_4c04757d","line":305,"updated":"2015-04-29 20:51:09.000000000","message":"if its a non-existent broker test should be a separate negative test case.","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"da2fb980ba5ad3392580ea151bac8ded1f45e160","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":303,"context_line":"                          self.dbapi.get_image_id_by_broker_name,"},{"line_number":304,"context_line":"                          self.context,"},{"line_number":305,"context_line":"                          \"fake mq\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_6055f01b","line":305,"in_reply_to":"3acd31a7_4c04757d","updated":"2015-04-29 23:22:23.000000000","message":"Done","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"6868a93403bff529cb3f5353a6814d19d0cd3a9c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_db import exception as oslo_exception"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cue.common import exception"},{"line_number":25,"context_line":"from cue.db.sqlalchemy import api as db_api"},{"line_number":26,"context_line":"from cue.db.sqlalchemy import models"},{"line_number":27,"context_line":"from cue.tests.functional import base"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_23a31b51","line":25,"updated":"2015-05-04 20:23:40.000000000","message":"We should be importing the interface, instead of the sqlalchemy implementation.  I.e. This import shouldn\u0027t change.","commit_id":"d6cf842e154b8a87346ee5ee089c44ddd955210d"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"eb26e5366bc0a3769612d3bf53114d0a527be790","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_db import exception as oslo_exception"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cue.common import exception"},{"line_number":25,"context_line":"from cue.db.sqlalchemy import api as db_api"},{"line_number":26,"context_line":"from cue.db.sqlalchemy import models"},{"line_number":27,"context_line":"from cue.tests.functional import base"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_ede98de7","line":25,"in_reply_to":"3acd31a7_23a31b51","updated":"2015-05-04 21:24:59.000000000","message":"Done","commit_id":"d6cf842e154b8a87346ee5ee089c44ddd955210d"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"6868a93403bff529cb3f5353a6814d19d0cd3a9c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class ApiTests(base.FunctionalTestCase):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    dbapi \u003d db_api.get_backend()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(ApiTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_038b7fc4","line":36,"updated":"2015-05-04 20:23:40.000000000","message":"This shouldn\u0027t change.","commit_id":"d6cf842e154b8a87346ee5ee089c44ddd955210d"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"eb26e5366bc0a3769612d3bf53114d0a527be790","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class ApiTests(base.FunctionalTestCase):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    dbapi \u003d db_api.get_backend()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(ApiTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_adef15e8","line":36,"in_reply_to":"3acd31a7_038b7fc4","updated":"2015-05-04 21:24:59.000000000","message":"Done","commit_id":"d6cf842e154b8a87346ee5ee089c44ddd955210d"}],"cue/tests/unit/manage/broker/test_broker.py":[{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6301de8b180eea072b179cd777c1ea8320080d16","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.cue_manage_broker.add_metadata(broker_id,"},{"line_number":160,"context_line":"                                            broker_name,"},{"line_number":161,"context_line":"                                            broker_sec_group)"},{"line_number":162,"context_line":"        mock_add_metadata.assert_called_with(self.cue_manage_broker.context)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        broker_id \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_0563f5b2","line":161,"updated":"2015-04-29 20:51:09.000000000","message":"add_metadata() takes broker_id, image_id/sec_group or both.. so broker_name has to be changed.","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"da2fb980ba5ad3392580ea151bac8ded1f45e160","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.cue_manage_broker.add_metadata(broker_id,"},{"line_number":160,"context_line":"                                            broker_name,"},{"line_number":161,"context_line":"                                            broker_sec_group)"},{"line_number":162,"context_line":"        mock_add_metadata.assert_called_with(self.cue_manage_broker.context)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        broker_id \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_da48338a","line":161,"in_reply_to":"3acd31a7_0563f5b2","updated":"2015-04-29 23:22:23.000000000","message":"Done","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6301de8b180eea072b179cd777c1ea8320080d16","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        broker_id \u003d None"},{"line_number":165,"context_line":"        broker_name \u003d None"},{"line_number":166,"context_line":"        broker_sec_group \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assertRaises(exception.Invalid,"},{"line_number":169,"context_line":"                          self.cue_manage_broker.add_metadata,"},{"line_number":170,"context_line":"                          broker_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_690043ab","line":167,"updated":"2015-04-29 20:51:09.000000000","message":"this could be a separate negative test case / you could try to add a broker_metadata for a non-existent broker.","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"},{"author":{"_account_id":15904,"name":"Daniel Allegood","email":"daniel.allegood@hp.com","username":"dkalleg"},"change_message_id":"da2fb980ba5ad3392580ea151bac8ded1f45e160","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        broker_id \u003d None"},{"line_number":165,"context_line":"        broker_name \u003d None"},{"line_number":166,"context_line":"        broker_sec_group \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assertRaises(exception.Invalid,"},{"line_number":169,"context_line":"                          self.cue_manage_broker.add_metadata,"},{"line_number":170,"context_line":"                          broker_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_5a7e63af","line":167,"in_reply_to":"3acd31a7_690043ab","updated":"2015-04-29 23:22:23.000000000","message":"Done","commit_id":"d928b09f6a38276a8b523a1cc8345805a10f8ba4"}]}