)]}'
{"cue/client.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"233c300bc61d2c1c0c26da688269f9ae6cee96bd","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def nova_client():"},{"line_number":82,"context_line":"    keystoneSession \u003d get_keystone_session()"},{"line_number":83,"context_line":"    return NovaClient.Client(2,"},{"line_number":84,"context_line":"                             username\u003dCONF.openstack.os_username,"},{"line_number":85,"context_line":"                             api_key\u003dCONF.openstack.os_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5f53546b","line":82,"updated":"2015-08-11 22:15:39.000000000","message":"rename to keystone_session for naming convention","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"233c300bc61d2c1c0c26da688269f9ae6cee96bd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                             username\u003dCONF.openstack.os_username,"},{"line_number":85,"context_line":"                             api_key\u003dCONF.openstack.os_password,"},{"line_number":86,"context_line":"                             project_id\u003dCONF.openstack.os_project_name,"},{"line_number":87,"context_line":"                             tenant_id\u003dCONF.openstack.os_tenant_name,"},{"line_number":88,"context_line":"                             auth_url\u003dCONF.openstack.os_auth_url,"},{"line_number":89,"context_line":"                             region_name\u003dCONF.openstack.os_region_name,"},{"line_number":90,"context_line":"                             insecure\u003dCONF.openstack.os_insecure,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ffa7c04d","line":87,"updated":"2015-08-11 22:15:39.000000000","message":"the constructor takes in a tenant_id and we are passing tenant_name, there seems to be a discrepancy in naming","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"98c0c2492ae69fbb67efa31c3af579ea8bebc508","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                             username\u003dCONF.openstack.os_username,"},{"line_number":85,"context_line":"                             api_key\u003dCONF.openstack.os_password,"},{"line_number":86,"context_line":"                             project_id\u003dCONF.openstack.os_project_name,"},{"line_number":87,"context_line":"                             tenant_id\u003dCONF.openstack.os_tenant_name,"},{"line_number":88,"context_line":"                             auth_url\u003dCONF.openstack.os_auth_url,"},{"line_number":89,"context_line":"                             region_name\u003dCONF.openstack.os_region_name,"},{"line_number":90,"context_line":"                             insecure\u003dCONF.openstack.os_insecure,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4456bf2b","line":87,"in_reply_to":"1a4dcd0f_ffa7c04d","updated":"2015-08-13 19:01:55.000000000","message":"nova client constructor doesn\u0027t support tenant_name or project_name and our config only supports name.","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"233c300bc61d2c1c0c26da688269f9ae6cee96bd","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def cinder_client():"},{"line_number":97,"context_line":"    keystoneSession \u003d get_keystone_session()"},{"line_number":98,"context_line":"    return CinderClient.Client(\u00272\u0027,"},{"line_number":99,"context_line":"                               username\u003dCONF.openstack.os_username,"},{"line_number":100,"context_line":"                               password\u003dCONF.openstack.os_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_bfc85823","line":97,"updated":"2015-08-11 22:15:39.000000000","message":"same as above","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"233c300bc61d2c1c0c26da688269f9ae6cee96bd","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def neutron_client():"},{"line_number":112,"context_line":"    keystoneSession \u003d get_keystone_session()"},{"line_number":113,"context_line":"    return NeutronClient.Client(\u00272.0\u0027,"},{"line_number":114,"context_line":"                                username\u003dCONF.openstack.os_username,"},{"line_number":115,"context_line":"                                password\u003dCONF.openstack.os_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9fd31cd5","line":112,"updated":"2015-08-11 22:15:39.000000000","message":"same as above","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"233c300bc61d2c1c0c26da688269f9ae6cee96bd","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":149,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3())"},{"line_number":150,"context_line":"    else:"},{"line_number":151,"context_line":"        LOG.info(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_bf9618ee","line":151,"updated":"2015-08-11 22:15:39.000000000","message":"we should log error at least or raise an exception since Cue cannot operate without a valid keystone session","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"98c0c2492ae69fbb67efa31c3af579ea8bebc508","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":149,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3())"},{"line_number":150,"context_line":"    else:"},{"line_number":151,"context_line":"        LOG.info(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_873fe9b4","line":151,"in_reply_to":"1a4dcd0f_bf9618ee","updated":"2015-08-13 19:01:55.000000000","message":"Done","commit_id":"fac801d160a3d1206ed2be3768df6cd4d7645a23"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"fe2078161a242225f69be84e2ec8fea10ad4b6fd","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def get_keystone_session():"},{"line_number":131,"context_line":"    if CONF.openstack.os_auth_version \u003d\u003d \u00272.0\u0027:"},{"line_number":132,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v2())"},{"line_number":133,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":134,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3())"},{"line_number":135,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_ceb9837b","line":132,"updated":"2015-08-21 18:03:54.000000000","message":"We also need to honor the cacert / insecure flags.\n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/session.py#L91","commit_id":"e25a53da2c2a71ccbf3794ce7b5992e85df47af9"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"2a2fca99fd87aaff6770937c343f6c839fadbdb7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027os_cacert\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Openstack cacert\u0027,"},{"line_number":56,"context_line":"               default\u003dNone),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027os_tenant_name\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027Openstack tenant name\u0027,"},{"line_number":59,"context_line":"               default\u003dNone),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027os_project_name\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_d07a7977","line":57,"updated":"2015-08-21 20:51:54.000000000","message":"Get rid of this, if we have OS_PROJECT_NAME","commit_id":"ce4be477e301d1c108a96389508e6a0518995fce"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"2a2fca99fd87aaff6770937c343f6c839fadbdb7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    if CONF.openstack.os_auth_version \u003d\u003d \u00272.0\u0027:"},{"line_number":132,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":133,"context_line":"                                        verify\u003dCONF.openstack.os_insecure,"},{"line_number":134,"context_line":"                                        cert\u003dCONF.openstack.os_cacert)"},{"line_number":135,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":136,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":137,"context_line":"                                        verify\u003dCONF.openstack.os_insecure,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_30d73525","line":134,"updated":"2015-08-21 20:51:54.000000000","message":"verify should \u003d true/false OR path to cacert.  we can remove the cert argument.","commit_id":"ce4be477e301d1c108a96389508e6a0518995fce"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9956da1429ab18b6bdc96f8ce6cbaef9305832db","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               default\u003dNone),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Openstack authentication version\u0027,"},{"line_number":41,"context_line":"               default\u003d\u00273\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027os_auth_url\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Openstack Authentication (Identity) URL\u0027,"},{"line_number":44,"context_line":"               default\u003dNone),"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_0aae00e6","line":41,"updated":"2015-08-25 16:34:58.000000000","message":"add choices with a list of valid values\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L960","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"83aa7b907e62cd81ec0b82edd99fb8435f11a465","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               default\u003dNone),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Openstack authentication version\u0027,"},{"line_number":41,"context_line":"               default\u003d\u00273\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027os_auth_url\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Openstack Authentication (Identity) URL\u0027,"},{"line_number":44,"context_line":"               default\u003dNone),"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_ea6c650a","line":41,"in_reply_to":"fa1b9901_0aae00e6","updated":"2015-08-26 22:36:23.000000000","message":"Done","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"26585fa1372d30204e7cff5996251a0af072ef18","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return (keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":132,"context_line":"                                         verify\u003dFalse)"},{"line_number":133,"context_line":"                if insecure else"},{"line_number":134,"context_line":"                keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":135,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":136,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_07dcb971","line":133,"updated":"2015-08-25 16:20:15.000000000","message":"the conditional should be outside the return,\n\nin line 129 do the following instead of nesting a conditional in a return statement\n\nif insecure:\n  verify \u003d CONF.openstac.os_cacert\nelse:\n  verify \u003d False","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"83aa7b907e62cd81ec0b82edd99fb8435f11a465","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        return (keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":132,"context_line":"                                         verify\u003dFalse)"},{"line_number":133,"context_line":"                if insecure else"},{"line_number":134,"context_line":"                keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":135,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":136,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_b3403809","line":133,"in_reply_to":"fa1b9901_07dcb971","updated":"2015-08-26 22:36:23.000000000","message":"Done","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"26585fa1372d30204e7cff5996251a0af072ef18","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":139,"context_line":"        return (keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":140,"context_line":"                                         verify\u003dFalse)"},{"line_number":141,"context_line":"                if insecure else"},{"line_number":142,"context_line":"                keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_07c3598a","line":141,"updated":"2015-08-25 16:20:15.000000000","message":"the conditional should be outside the return,\n\nin line 129 do the following instead of nesting a conditional in a return statement\n\nif insecure:\n  verify \u003d CONF.openstac.os_cacert\nelse:\n  verify \u003d False","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"83aa7b907e62cd81ec0b82edd99fb8435f11a465","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":139,"context_line":"        return (keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":140,"context_line":"                                         verify\u003dFalse)"},{"line_number":141,"context_line":"                if insecure else"},{"line_number":142,"context_line":"                keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_3303c8ba","line":141,"in_reply_to":"fa1b9901_07c3598a","updated":"2015-08-26 22:36:23.000000000","message":"Done","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"26585fa1372d30204e7cff5996251a0af072ef18","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"    else:"},{"line_number":146,"context_line":"        LOG.error(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_e773c57e","line":146,"updated":"2015-08-25 16:20:15.000000000","message":"I wonder whether we should throw an exception at this point, the software is misconfigured, continuing to operate leads to a false perception that Cue is OK","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"83aa7b907e62cd81ec0b82edd99fb8435f11a465","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"    else:"},{"line_number":146,"context_line":"        LOG.error(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_7320604a","line":146,"in_reply_to":"fa1b9901_4a7e386b","updated":"2015-08-26 22:36:23.000000000","message":"Done","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"83aa7b907e62cd81ec0b82edd99fb8435f11a465","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"    else:"},{"line_number":146,"context_line":"        LOG.error(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_aa5e6d43","line":146,"in_reply_to":"fa1b9901_e773c57e","updated":"2015-08-26 22:36:23.000000000","message":"as per your following comment, added the choices and removing this.","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9956da1429ab18b6bdc96f8ce6cbaef9305832db","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                         verify\u003dCONF.openstack.os_cacert)"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"    else:"},{"line_number":146,"context_line":"        LOG.error(\"Supports auth_version 2.0 and 3 only\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_4a7e386b","line":146,"in_reply_to":"fa1b9901_e773c57e","updated":"2015-08-25 16:34:58.000000000","message":"this is unnecessary if we add choices in the config option","commit_id":"e97d97d26a88094228cff9bdf96ee6a5676b5db8"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"392afea188746de66246c9e17f7a07faba9cbdba","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if CONF.openstack.os_auth_version \u003d\u003d \u00272.0\u0027:"},{"line_number":136,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":137,"context_line":"                                        verify\u003dverify)"},{"line_number":138,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":139,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":140,"context_line":"                                        verify\u003dverify)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da20952f_76c5a059","line":138,"updated":"2015-08-26 23:45:57.000000000","message":"Since there are only two options, should this be an \u0027else\u0027 instead of \u0027elif\u0027?","commit_id":"43bebed218375e5dca8d4f9955cd963573e13eda"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"1e26f462af0fc5cdaba632ea2fb98a330230fc0a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if CONF.openstack.os_auth_version \u003d\u003d \u00272.0\u0027:"},{"line_number":136,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v2(),"},{"line_number":137,"context_line":"                                        verify\u003dverify)"},{"line_number":138,"context_line":"    elif CONF.openstack.os_auth_version \u003d\u003d \u00273\u0027:"},{"line_number":139,"context_line":"        return keystone_session.Session(auth\u003dget_auth_v3(),"},{"line_number":140,"context_line":"                                        verify\u003dverify)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da20952f_3a3702b2","line":138,"in_reply_to":"da20952f_76c5a059","updated":"2015-08-27 04:31:27.000000000","message":"Done","commit_id":"43bebed218375e5dca8d4f9955cd963573e13eda"}]}