)]}'
{"contrib/devstack_old/lib/dib":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"dff8c38925da902ff4d07d3c5aa9224e44ae546c","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    glance --os-auth-token $token --os-image-url http://$GLANCE_HOSTPORT \\"},{"line_number":112,"context_line":"        image-create --name $image_name --visibility public \\"},{"line_number":113,"context_line":"        --min-disk 2 --container-format\u003dbare --disk-format qcow2 \\"},{"line_number":114,"context_line":"        \u003c $image_path"},{"line_number":115,"context_line":"}"},{"line_number":116,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1a7b0d38_49dc6d12","line":113,"updated":"2015-12-24 00:07:44.000000000","message":"this change should go in devstack/plugin.sh","commit_id":"bc443ab412f27b8033edfca7687c03e3d01b774c"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"87aabc614e9f08097c4ca180e9fe34bc528d46d4","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    glance --os-auth-token $token --os-image-url http://$GLANCE_HOSTPORT \\"},{"line_number":112,"context_line":"        image-create --name $image_name --visibility public \\"},{"line_number":113,"context_line":"        --min-disk 2 --container-format\u003dbare --disk-format qcow2 \\"},{"line_number":114,"context_line":"        \u003c $image_path"},{"line_number":115,"context_line":"}"},{"line_number":116,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1a7b0d38_099665f0","line":113,"in_reply_to":"1a7b0d38_49dc6d12","updated":"2015-12-24 00:18:01.000000000","message":"Done","commit_id":"bc443ab412f27b8033edfca7687c03e3d01b774c"}],"cue/api/controllers/v1/cluster.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9b5879459d4d30d476075804519ea2dcf666678b","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # image metadata"},{"line_number":318,"context_line":"        nova_client \u003d client.nova_client()"},{"line_number":319,"context_line":"        image_metadata \u003d nova_client.images.get(image_id)"},{"line_number":320,"context_line":"        image_minRam \u003d image_metadata.minRam"},{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_33c9e826","line":319,"updated":"2016-01-05 22:20:05.000000000","message":"what happens if the image doesn\u0027t exist?","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # image metadata"},{"line_number":318,"context_line":"        nova_client \u003d client.nova_client()"},{"line_number":319,"context_line":"        image_metadata \u003d nova_client.images.get(image_id)"},{"line_number":320,"context_line":"        image_minRam \u003d image_metadata.minRam"},{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_aa8c40da","line":319,"in_reply_to":"fa69d971_33c9e826","updated":"2016-01-07 01:48:08.000000000","message":"this would happen in a miss-configured/deployed Cue Service, we should raise an appropriate exception and error code that would point to this problem.  Probably an internal server error","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # image metadata"},{"line_number":318,"context_line":"        nova_client \u003d client.nova_client()"},{"line_number":319,"context_line":"        image_metadata \u003d nova_client.images.get(image_id)"},{"line_number":320,"context_line":"        image_minRam \u003d image_metadata.minRam"},{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_4f480188","line":319,"in_reply_to":"fa69d971_aa8c40da","updated":"2016-01-08 22:41:09.000000000","message":"if the image doesn\u0027t exist nova throws a 404. so fixed to re-raise a 500 from cue-api.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9b5879459d4d30d476075804519ea2dcf666678b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # flavor metadata"},{"line_number":324,"context_line":"        flavor_metadata \u003d nova_client.flavors.get(cluster.flavor)"},{"line_number":325,"context_line":"        flavor_ram \u003d flavor_metadata.ram"},{"line_number":326,"context_line":"        flavor_disk \u003d flavor_metadata.disk"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_d3016c39","line":324,"updated":"2016-01-05 22:20:05.000000000","message":"likewise, what happens if the flavor doesn\u0027t exist?","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # flavor metadata"},{"line_number":324,"context_line":"        flavor_metadata \u003d nova_client.flavors.get(cluster.flavor)"},{"line_number":325,"context_line":"        flavor_ram \u003d flavor_metadata.ram"},{"line_number":326,"context_line":"        flavor_disk \u003d flavor_metadata.disk"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_cf54f122","line":324,"in_reply_to":"fa69d971_ccb43183","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        image_minDisk \u003d image_metadata.minDisk"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # flavor metadata"},{"line_number":324,"context_line":"        flavor_metadata \u003d nova_client.flavors.get(cluster.flavor)"},{"line_number":325,"context_line":"        flavor_ram \u003d flavor_metadata.ram"},{"line_number":326,"context_line":"        flavor_disk \u003d flavor_metadata.disk"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ccb43183","line":324,"in_reply_to":"fa69d971_d3016c39","updated":"2016-01-07 01:48:08.000000000","message":"this would fall into the invalid request bucket","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        flavor_ram \u003d flavor_metadata.ram"},{"line_number":326,"context_line":"        flavor_disk \u003d flavor_metadata.disk"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if (flavor_ram \u003e\u003d image_minRam) and (flavor_disk \u003e\u003d image_minDisk):"},{"line_number":329,"context_line":"            job_args \u003d {"},{"line_number":330,"context_line":"                \u0027tenant_id\u0027: new_cluster.project_id,"},{"line_number":331,"context_line":"                \u0027flavor\u0027: cluster.flavor,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_cc6c31d2","line":328,"range":{"start_line":328,"start_character":12,"end_line":328,"end_character":22},"updated":"2016-01-07 01:48:08.000000000","message":"we should have the if statement check for the error condition only and raise exception if conditions are met.  We should also separate the two error conditions, this would provide the user with a more exact cause of error.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        flavor_ram \u003d flavor_metadata.ram"},{"line_number":326,"context_line":"        flavor_disk \u003d flavor_metadata.disk"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if (flavor_ram \u003e\u003d image_minRam) and (flavor_disk \u003e\u003d image_minDisk):"},{"line_number":329,"context_line":"            job_args \u003d {"},{"line_number":330,"context_line":"                \u0027tenant_id\u0027: new_cluster.project_id,"},{"line_number":331,"context_line":"                \u0027flavor\u0027: cluster.flavor,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_85376aaf","line":328,"range":{"start_line":328,"start_character":12,"end_line":328,"end_character":22},"in_reply_to":"fa69d971_cc6c31d2","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            cluster.unset_empty_fields()"},{"line_number":370,"context_line":"            return cluster"},{"line_number":371,"context_line":"        else:"},{"line_number":372,"context_line":"            raise exception.Invalid(_(\"Flavor disk/ram is smaller than the \""},{"line_number":373,"context_line":"                                      \"minimum specified in image metadata\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_6cb8a511","line":372,"range":{"start_line":372,"start_character":28,"end_line":372,"end_character":35},"updated":"2016-01-07 01:48:08.000000000","message":"since we already have the minimum required disk/ram, those should be included as part of the exception string.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            cluster.unset_empty_fields()"},{"line_number":370,"context_line":"            return cluster"},{"line_number":371,"context_line":"        else:"},{"line_number":372,"context_line":"            raise exception.Invalid(_(\"Flavor disk/ram is smaller than the \""},{"line_number":373,"context_line":"                                      \"minimum specified in image metadata\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a53aae96","line":372,"range":{"start_line":372,"start_character":28,"end_line":372,"end_character":35},"in_reply_to":"fa69d971_6cb8a511","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b3d0b7f03a89c18d9d793e8424f8a88c6dd0c3e","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        # get the image id of default broker"},{"line_number":286,"context_line":"        image_id \u003d objects.BrokerMetadata.get_image_id_by_broker_name("},{"line_number":287,"context_line":"            context, broker_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # get image metadata"},{"line_number":290,"context_line":"        try:"},{"line_number":291,"context_line":"            image_metadata \u003d nova_client.images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_2d445c19","line":288,"updated":"2016-01-08 23:57:28.000000000","message":"Can you extract this to a method? It\u0027s just that it is getting longer.\nPerhaps create a validate_flavor()? You can pass the image_id to this validate method so that you dont have to query it again","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        # get the image id of default broker"},{"line_number":286,"context_line":"        image_id \u003d objects.BrokerMetadata.get_image_id_by_broker_name("},{"line_number":287,"context_line":"            context, broker_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # get image metadata"},{"line_number":290,"context_line":"        try:"},{"line_number":291,"context_line":"            image_metadata \u003d nova_client.images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_c8e20bd5","line":288,"in_reply_to":"fa69d971_2d445c19","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9c8d02407a92c8ae0499613fceb9ae9793f6eac5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                raise exception.ConfigurationError(_(\u0027Invalid image %s \u0027"},{"line_number":297,"context_line":"                                                     \u0027configured\u0027) % image_id)"},{"line_number":298,"context_line":"            else:"},{"line_number":299,"context_line":"                raise"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # get flavor metadata"},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_0dab988a","line":299,"updated":"2016-01-09 00:00:26.000000000","message":"should this be a 500 error?","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                raise exception.ConfigurationError(_(\u0027Invalid image %s \u0027"},{"line_number":297,"context_line":"                                                     \u0027configured\u0027) % image_id)"},{"line_number":298,"context_line":"            else:"},{"line_number":299,"context_line":"                raise"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # get flavor metadata"},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_75e17d29","line":299,"in_reply_to":"fa69d971_0dab988a","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9c8d02407a92c8ae0499613fceb9ae9793f6eac5","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exception.Invalid(_(\u0027Invalid flavor %s provided\u0027) %"},{"line_number":309,"context_line":"                                          cluster_flavor)"},{"line_number":310,"context_line":"            else:"},{"line_number":311,"context_line":"                raise"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if (flavor_disk \u003c image_minDisk):"},{"line_number":314,"context_line":"            raise exception.Invalid(_(\"Flavor disk is smaller than the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_cd958040","line":311,"updated":"2016-01-09 00:00:26.000000000","message":"should this be a 500 error?","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                raise exception.Invalid(_(\u0027Invalid flavor %s provided\u0027) %"},{"line_number":309,"context_line":"                                          cluster_flavor)"},{"line_number":310,"context_line":"            else:"},{"line_number":311,"context_line":"                raise"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if (flavor_disk \u003c image_minDisk):"},{"line_number":314,"context_line":"            raise exception.Invalid(_(\"Flavor disk is smaller than the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_15d12157","line":311,"in_reply_to":"fa69d971_cd958040","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"df5068581403679c1b430e80fe64e3020aa771ac","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if (flavor_disk \u003c image_minDisk):"},{"line_number":314,"context_line":"            raise exception.Invalid(_(\"Flavor disk is smaller than the \""},{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_48ff3e01","line":315,"range":{"start_line":315,"start_character":66,"end_line":315,"end_character":74},"updated":"2016-01-09 00:24:25.000000000","message":"include the minDisk value as part of this message","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if (flavor_disk \u003c image_minDisk):"},{"line_number":314,"context_line":"            raise exception.Invalid(_(\"Flavor disk is smaller than the \""},{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_dab098ff","line":315,"range":{"start_line":315,"start_character":66,"end_line":315,"end_character":74},"in_reply_to":"fa69d971_3a053410","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"ee0be755390cad09c1b5e3dd1ebadcac87e1cc0e","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if (flavor_disk \u003c image_minDisk):"},{"line_number":314,"context_line":"            raise exception.Invalid(_(\"Flavor disk is smaller than the \""},{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_3a053410","line":315,"range":{"start_line":315,"start_character":66,"end_line":315,"end_character":74},"in_reply_to":"fa69d971_48ff3e01","updated":"2016-01-11 18:36:54.000000000","message":"Rather than referencing image metadata, make the error about the broker, since from the client\u0027s perspective the broker is what matters, they don\u0027t care what image metadata nor that there\u0027s an image in the first place.","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"df5068581403679c1b430e80fe64e3020aa771ac","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # convert \u0027network_id\u0027 from list to string type for objects/cluster"},{"line_number":321,"context_line":"        # compatibility"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_6802420b","line":318,"range":{"start_line":318,"start_character":60,"end_line":318,"end_character":65},"updated":"2016-01-09 00:24:25.000000000","message":"include the minRam value as part of this message","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"ee0be755390cad09c1b5e3dd1ebadcac87e1cc0e","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # convert \u0027network_id\u0027 from list to string type for objects/cluster"},{"line_number":321,"context_line":"        # compatibility"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_fa0a3c1f","line":318,"range":{"start_line":318,"start_character":60,"end_line":318,"end_character":65},"in_reply_to":"fa69d971_6802420b","updated":"2016-01-11 18:36:54.000000000","message":"Rather than referencing image metadata, make the error about the broker, since from the client\u0027s perspective the broker is what matters, they don\u0027t care what image metadata nor that there\u0027s an image in the first place.","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":316,"context_line":"        elif (flavor_ram \u003c image_minRam):"},{"line_number":317,"context_line":"            raise exception.Invalid(_(\"Flavor ram is smaller than the \""},{"line_number":318,"context_line":"                                      \"minimum specified in image metadata\"))"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # convert \u0027network_id\u0027 from list to string type for objects/cluster"},{"line_number":321,"context_line":"        # compatibility"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_fab55cec","line":318,"range":{"start_line":318,"start_character":60,"end_line":318,"end_character":65},"in_reply_to":"fa69d971_fa0a3c1f","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"}],"cue/tests/functional/api/v1/test_cluster.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":504,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def test_create_flavor_too_small(self):"},{"line_number":507,"context_line":"        \"\"\"test create a cluster with flavor too small for the image.\"\"\""},{"line_number":508,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster(flavor\u003d\u0027x-tiny\u0027)"},{"line_number":509,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_6a05e811","line":506,"range":{"start_line":506,"start_character":8,"end_line":506,"end_character":36},"updated":"2016-01-07 01:48:08.000000000","message":"we should add tests:\n* Invalid flavor (non existing flavor)\n* test for disk size too small\n* invalid/not found image id","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":504,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def test_create_flavor_too_small(self):"},{"line_number":507,"context_line":"        \"\"\"test create a cluster with flavor too small for the image.\"\"\""},{"line_number":508,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster(flavor\u003d\u0027x-tiny\u0027)"},{"line_number":509,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a66cf19c","line":506,"range":{"start_line":506,"start_character":8,"end_line":506,"end_character":36},"in_reply_to":"fa69d971_6a05e811","updated":"2016-01-08 22:41:09.000000000","message":"disk size too small is covered in this test , the x-tiny flavor is configured with disk size too small for the image.added invalid flavor testcase.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":513,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":514,"context_line":"        self.assertEqual(\u0027400 Bad Request\u0027, data.status,"},{"line_number":515,"context_line":"                         \u0027Invalid status value received.\u0027)"},{"line_number":516,"context_line":"        self.assertIn(\u0027Flavor disk/ram is smaller than the \u0027"},{"line_number":517,"context_line":"                      \u0027minimum specified in image metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_2a15b09a","line":514,"range":{"start_line":514,"start_character":30,"end_line":514,"end_character":33},"updated":"2016-01-07 01:48:08.000000000","message":"don\u0027t need to check fault strings, expected error code is enough.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":513,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":514,"context_line":"        self.assertEqual(\u0027400 Bad Request\u0027, data.status,"},{"line_number":515,"context_line":"                         \u0027Invalid status value received.\u0027)"},{"line_number":516,"context_line":"        self.assertIn(\u0027Flavor disk/ram is smaller than the \u0027"},{"line_number":517,"context_line":"                      \u0027minimum specified in image metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8f991922","line":514,"range":{"start_line":514,"start_character":30,"end_line":514,"end_character":33},"in_reply_to":"fa69d971_2a15b09a","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":514,"context_line":"        self.assertEqual(\u0027400 Bad Request\u0027, data.status,"},{"line_number":515,"context_line":"                         \u0027Invalid status value received.\u0027)"},{"line_number":516,"context_line":"        self.assertIn(\u0027Flavor disk/ram is smaller than the \u0027"},{"line_number":517,"context_line":"                      \u0027minimum specified in image metadata\u0027,"},{"line_number":518,"context_line":"                      data.namespace[\"faultstring\"],"},{"line_number":519,"context_line":"                      \u0027Invalid faultstring received.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ca52d466","line":516,"range":{"start_line":516,"start_character":30,"end_line":516,"end_character":34},"updated":"2016-01-07 01:48:08.000000000","message":"same here.  This would fail if test is running with a different localization language also not a good practice to look for message strings as these can change often while maintaining the same response code, which would then fail the test.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":514,"context_line":"        self.assertEqual(\u0027400 Bad Request\u0027, data.status,"},{"line_number":515,"context_line":"                         \u0027Invalid status value received.\u0027)"},{"line_number":516,"context_line":"        self.assertIn(\u0027Flavor disk/ram is smaller than the \u0027"},{"line_number":517,"context_line":"                      \u0027minimum specified in image metadata\u0027,"},{"line_number":518,"context_line":"                      data.namespace[\"faultstring\"],"},{"line_number":519,"context_line":"                      \u0027Invalid faultstring received.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_0fff6935","line":516,"range":{"start_line":516,"start_character":30,"end_line":516,"end_character":34},"in_reply_to":"fa69d971_ca52d466","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"df5068581403679c1b430e80fe64e3020aa771ac","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":503,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_create_flavor_too_small(self):"},{"line_number":506,"context_line":"        \"\"\"test create a cluster with flavor too small for the image.\"\"\""},{"line_number":507,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster(flavor\u003d\u0027x-tiny\u0027)"},{"line_number":508,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_0820669a","line":505,"range":{"start_line":505,"start_character":8,"end_line":505,"end_character":36},"updated":"2016-01-09 00:24:25.000000000","message":"separate this into a test that simulates flavor with disk that is too small and flavor with ram that is too small since we have two separate checks.","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":503,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_create_flavor_too_small(self):"},{"line_number":506,"context_line":"        \"\"\"test create a cluster with flavor too small for the image.\"\"\""},{"line_number":507,"context_line":"        api_cluster \u003d test_utils.create_api_test_cluster(flavor\u003d\u0027x-tiny\u0027)"},{"line_number":508,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_f56ecdfe","line":505,"range":{"start_line":505,"start_character":8,"end_line":505,"end_character":36},"in_reply_to":"fa69d971_0820669a","updated":"2016-01-11 20:58:27.000000000","message":"Done","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b3d0b7f03a89c18d9d793e8424f8a88c6dd0c3e","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"},{"line_number":520,"context_line":"                              headers\u003dself.auth_headers, expect_errors\u003dTrue)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":523,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def test_create_invalid_volume_size(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_cdf900ca","line":522,"updated":"2016-01-08 23:57:28.000000000","message":"Shouldn\u0027t you get a 404 error? That is what i see from the cluster.py file","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"9c8d02407a92c8ae0499613fceb9ae9793f6eac5","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"},{"line_number":520,"context_line":"                              headers\u003dself.auth_headers, expect_errors\u003dTrue)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":523,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def test_create_invalid_volume_size(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_ed9e4453","line":522,"in_reply_to":"fa69d971_cdf900ca","updated":"2016-01-09 00:00:26.000000000","message":"400 is correct","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"52798cbf4e8c260aa213d57f7cdb4a7a4d36d46e","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        data \u003d self.post_json(\u0027/clusters\u0027, params\u003dapi_cluster,"},{"line_number":520,"context_line":"                              headers\u003dself.auth_headers, expect_errors\u003dTrue)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        self.assertEqual(400, data.status_code,"},{"line_number":523,"context_line":"                         \u0027Invalid status code value received.\u0027)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def test_create_invalid_volume_size(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_152cc100","line":522,"in_reply_to":"fa69d971_cdf900ca","updated":"2016-01-11 20:58:27.000000000","message":"as Min mentioned its a 400. api converts 404 to 400","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"}],"cue/tests/functional/fixtures/nova.py":[{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                 updated\u003dNone):"},{"line_number":50,"context_line":"        self.created \u003d created"},{"line_number":51,"context_line":"        self.human_id \u003d human_id"},{"line_number":52,"context_line":"        self.id \u003d id"},{"line_number":53,"context_line":"        self.minDisk \u003d minDisk"},{"line_number":54,"context_line":"        self.minRam \u003d minRam"},{"line_number":55,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ec833501","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":20},"updated":"2016-01-07 01:48:08.000000000","message":"self.id \u003d id or str(uuid.uuid4())","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                 updated\u003dNone):"},{"line_number":50,"context_line":"        self.created \u003d created"},{"line_number":51,"context_line":"        self.human_id \u003d human_id"},{"line_number":52,"context_line":"        self.id \u003d id"},{"line_number":53,"context_line":"        self.minDisk \u003d minDisk"},{"line_number":54,"context_line":"        self.minRam \u003d minRam"},{"line_number":55,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_af4dfdc5","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":20},"in_reply_to":"fa69d971_ec833501","updated":"2016-01-08 22:41:09.000000000","message":"Done","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"012b30baba3d046c1ad77de5b6b9601ce126751c","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for image in image_list:"},{"line_number":151,"context_line":"            image_detail \u003d ImageDetails(name\u003dimage,"},{"line_number":152,"context_line":"                                    id\u003d\u0027f7e8c49b-7d1e-472f-a78b-7c46a39c85be\u0027,"},{"line_number":153,"context_line":"                                    minDisk\u003d4)"},{"line_number":154,"context_line":"            self._image_list.update({"},{"line_number":155,"context_line":"                image_detail.id: image_detail"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ecb1f5e0","line":152,"range":{"start_line":152,"start_character":36,"end_line":152,"end_character":38},"updated":"2016-01-07 01:48:08.000000000","message":"no need to hard code the uuid here, update the constructor above if id is not provided","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"6d6af0898f8a81a4b5b1ed5152da719afd314d40","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for image in image_list:"},{"line_number":151,"context_line":"            image_detail \u003d ImageDetails(name\u003dimage,"},{"line_number":152,"context_line":"                                    id\u003d\u0027f7e8c49b-7d1e-472f-a78b-7c46a39c85be\u0027,"},{"line_number":153,"context_line":"                                    minDisk\u003d4)"},{"line_number":154,"context_line":"            self._image_list.update({"},{"line_number":155,"context_line":"                image_detail.id: image_detail"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_2faa6d86","line":152,"range":{"start_line":152,"start_character":36,"end_line":152,"end_character":38},"in_reply_to":"fa69d971_ecb1f5e0","updated":"2016-01-08 22:41:09.000000000","message":"this has to be hardcoded because that is the uuid that is configured in the in-memory broker_metadata table as default rabbitmq image.","commit_id":"0c3cdcd6262a2d0f917b7b75ea3354689859db96"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"df5068581403679c1b430e80fe64e3020aa771ac","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            })"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for flavor in flavor_list:"},{"line_number":159,"context_line":"            if flavor is \u0027x-tiny\u0027:"},{"line_number":160,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, disk\u003d1)"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_884bf658","line":159,"range":{"start_line":159,"start_character":27,"end_line":159,"end_character":28},"updated":"2016-01-09 00:24:25.000000000","message":"we can add a \u0027add_flavor\u0027 method to add test-specific flavors and leave a basic valid flavor in the constructor","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b3d0b7f03a89c18d9d793e8424f8a88c6dd0c3e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for flavor in flavor_list:"},{"line_number":159,"context_line":"            if flavor is \u0027x-tiny\u0027:"},{"line_number":160,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, disk\u003d1)"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor)"},{"line_number":163,"context_line":"            self._flavor_list.update({"},{"line_number":164,"context_line":"                flavor_detail.id: flavor_detail"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_4dbaf0e2","line":161,"updated":"2016-01-08 23:57:28.000000000","message":"Since there are two attributes that you are checking (low memory and low disk), can you also create a new test-flavor with low memory and add a new test to make sure you get an error when you use this flavor?","commit_id":"2380d367305baa9c48bf0b5d4f5210b5c5198832"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"25d26b8436502b89f75067ff0f8651cbe995b445","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for image in image_list:"},{"line_number":151,"context_line":"            image_detail \u003d ImageDetails(name\u003dimage,"},{"line_number":152,"context_line":"                                    id\u003d\u0027f7e8c49b-7d1e-472f-a78b-7c46a39c85be\u0027,"},{"line_number":153,"context_line":"                                    minDisk\u003d4, minRam\u003d512)"},{"line_number":154,"context_line":"            self._image_list.update({"},{"line_number":155,"context_line":"                image_detail.id: image_detail"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_cfaef697","line":152,"range":{"start_line":152,"start_character":49,"end_line":152,"end_character":53},"updated":"2016-01-21 20:22:48.000000000","message":"addition of images can be pulled out into a utlity function as well","commit_id":"1d5580e9159d1ed82fbbdcd7c57bba5d5db9f294"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b68bdaa0def621d57fa5d21c21d7143ced4b41cc","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for image in image_list:"},{"line_number":151,"context_line":"            image_detail \u003d ImageDetails(name\u003dimage,"},{"line_number":152,"context_line":"                                    id\u003d\u0027f7e8c49b-7d1e-472f-a78b-7c46a39c85be\u0027,"},{"line_number":153,"context_line":"                                    minDisk\u003d4, minRam\u003d512)"},{"line_number":154,"context_line":"            self._image_list.update({"},{"line_number":155,"context_line":"                image_detail.id: image_detail"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_41a9e822","line":152,"range":{"start_line":152,"start_character":49,"end_line":152,"end_character":53},"in_reply_to":"9a68dd71_cfaef697","updated":"2016-01-25 22:17:02.000000000","message":"will address it in https://review.openstack.org/#/c/272296","commit_id":"1d5580e9159d1ed82fbbdcd7c57bba5d5db9f294"},{"author":{"_account_id":13771,"name":"Davide Agnello","email":"dagnello@hp.com","username":"dagnello"},"change_message_id":"25d26b8436502b89f75067ff0f8651cbe995b445","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            })"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for flavor in flavor_list:"},{"line_number":159,"context_line":"            if flavor is \u0027x-tiny-disk\u0027:"},{"line_number":160,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, disk\u003d1)"},{"line_number":161,"context_line":"            elif flavor is \u0027x-tiny-ram\u0027:"},{"line_number":162,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, ram\u003d256)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_0fa5eeb3","line":159,"range":{"start_line":159,"start_character":28,"end_line":159,"end_character":32},"updated":"2016-01-21 20:22:48.000000000","message":"let\u0027s make the changes that were brought up in patch set 9","commit_id":"1d5580e9159d1ed82fbbdcd7c57bba5d5db9f294"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"40ac6c44d66f0cd4da2db30d0707de09832d8124","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            })"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for flavor in flavor_list:"},{"line_number":159,"context_line":"            if flavor is \u0027x-tiny-disk\u0027:"},{"line_number":160,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, disk\u003d1)"},{"line_number":161,"context_line":"            elif flavor is \u0027x-tiny-ram\u0027:"},{"line_number":162,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, ram\u003d256)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_93f65b5b","line":159,"range":{"start_line":159,"start_character":28,"end_line":159,"end_character":32},"in_reply_to":"9a68dd71_0fa5eeb3","updated":"2016-01-25 19:21:40.000000000","message":"this loop can be moved within the block at line 142 so you don\u0027t even need to do the if check, if the flavor was passed in whatever passed it in should have initialized these flavors","commit_id":"1d5580e9159d1ed82fbbdcd7c57bba5d5db9f294"},{"author":{"_account_id":14955,"name":"Abitha Palaniappan","email":"abitha.palaniappan@hp.com","username":"Abitha"},"change_message_id":"b68bdaa0def621d57fa5d21c21d7143ced4b41cc","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            })"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for flavor in flavor_list:"},{"line_number":159,"context_line":"            if flavor is \u0027x-tiny-disk\u0027:"},{"line_number":160,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, disk\u003d1)"},{"line_number":161,"context_line":"            elif flavor is \u0027x-tiny-ram\u0027:"},{"line_number":162,"context_line":"                flavor_detail \u003d FlavorDetails(name\u003dflavor, ram\u003d256)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_61a42c4a","line":159,"range":{"start_line":159,"start_character":28,"end_line":159,"end_character":32},"in_reply_to":"9a68dd71_93f65b5b","updated":"2016-01-25 22:17:02.000000000","message":"Done","commit_id":"1d5580e9159d1ed82fbbdcd7c57bba5d5db9f294"}]}