)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_3b3b91c8","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":38},"updated":"2020-05-29 01:13:17.000000000","message":"remove","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_5b400536","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":5},"updated":"2020-05-29 01:13:17.000000000","message":"remove","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_fb72b9ac","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":22},"updated":"2020-05-29 01:13:17.000000000","message":"s/FPGAdriver/FPGA driver","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_8403bcbe","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":38},"in_reply_to":"ff570b3c_3b3b91c8","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_640828d9","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":5},"in_reply_to":"ff570b3c_5b400536","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songwenping \u003csongwenping@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_c40db4e9","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":22},"in_reply_to":"ff570b3c_fb72b9ac","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_bb78418f","line":8,"updated":"2020-05-29 01:13:17.000000000","message":"You can add \"This spec proposes to provide the initial design for Cyborg\u0027s Inspur® FPGA driver.\" in the commit message, to improve readability.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-05-27 14:08:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_a4124008","line":8,"in_reply_to":"ff570b3c_bb78418f","updated":"2020-07-01 07:48:22.000000000","message":"Done. Thanks.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"b192e2e648436c8371dc81a24edcc0b2f342f475","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_d4d734c0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2020-06-08 11:59:29.000000000","message":"please add story:XXXX to track this specification.\nI create one for it: https://storyboard.openstack.org/#!/story/2007772","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add IInspur FPGAdriver specification.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5690129986aa143ab5b0578ea69e2a3328666edf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_24fe30ae","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"in_reply_to":"ff570b3c_d4d734c0","updated":"2020-07-01 07:48:22.000000000","message":"So what\u0027s the meaning of adding this?","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"}],"specs/victoria/approved/inspur-fpga-driver-proposal.rst":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"2440fd839f4bc1776bef70a749b53eeaac589bf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff570b3c_0f18d91b","updated":"2020-06-02 05:30:49.000000000","message":"1. Do you plan to add 3rd party CI?\n2. What kinds of programming are supported? with encryption, etc.?\n3. Does it support OpenCL?","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf51134e_c45814fc","in_reply_to":"ff570b3c_0f18d91b","updated":"2020-07-01 07:48:22.000000000","message":"1.Sorry, I cannot add 3rd party CI now.\n2.We use the driver to manage the Inspur FPGA card, we will support programming later.\n3.We will support later. Thanks.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This spec will add a Inspur® FPGA driver for Cyborg to manage specific Inspur®"},{"line_number":18,"context_line":"FPGA devices."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_3b6431e5","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":20},"updated":"2020-05-29 01:13:17.000000000","message":"an","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This spec will add a Inspur® FPGA driver for Cyborg to manage specific Inspur®"},{"line_number":18,"context_line":"FPGA devices."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_04720c7d","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":20},"in_reply_to":"ff570b3c_3b6431e5","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use Cases"},{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up a VM with Inspur® FPGA card  attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the VM(binding)."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_5b976591","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":57},"updated":"2020-05-29 01:13:17.000000000","message":"redunant white space.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Use Cases"},{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up a VM with Inspur® FPGA card  attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the VM(binding)."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_e46ef894","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":57},"in_reply_to":"ff570b3c_5b976591","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up a VM with Inspur® FPGA card  attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the VM(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_9be61d44","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":54},"updated":"2020-05-29 01:13:17.000000000","message":"You can call \"instance\" instead of VM.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up a VM with Inspur® FPGA card  attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the VM(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_446c049c","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":54},"in_reply_to":"ff570b3c_9be61d44","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3c07dc4f7385b5639effd66e02bf624e71388f8c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Performance Impact"},{"line_number":73,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_db36d5b4","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":4},"updated":"2020-05-29 01:13:17.000000000","message":"I think the mainly impact is the user can use Inspur@FPGA driver by Cyborg.","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9d229d308edd48cb655466c1c97aef9d4e693b09","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Performance Impact"},{"line_number":73,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_2469108b","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":4},"in_reply_to":"ff570b3c_db36d5b4","updated":"2020-07-01 07:48:22.000000000","message":"Done","commit_id":"9a86c7c5b230b1e9c8c76088394bbee0d35b0e46"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Use Cases"},{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up an instance with Inspur® FPGA card attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the instance(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_b25ab4ee","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":34},"updated":"2020-07-15 14:17:27.000000000","message":"can you add more info about the definition of TLS workload? any links or introductions.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Use Cases"},{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up an instance with Inspur® FPGA card attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the instance(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_07fb4047","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":34},"in_reply_to":"bf51134e_b25ab4ee","updated":"2020-07-17 08:45:22.000000000","message":"Make a mistake here. Pls see the new commit. Thanks Yumeng.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up an instance with Inspur® FPGA card attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the instance(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_6f679926","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":69},"updated":"2020-07-15 14:17:27.000000000","message":"From my understanding, binding is done by arq bind not driver specific, what the Inspur® FPGA driver does should be discover() (and driver specific program() if there is any)the Inspur® FPGA device and construct device info to cyborg data model, which will be collected by cyborg-agent.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":"* When user want to boot up an instance with Inspur® FPGA card attached in"},{"line_number":23,"context_line":"  order to accelerate TLS workload. Cyborg should be able to manage this kind"},{"line_number":24,"context_line":"  of acceleration resources and to assign it to the instance(binding)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed changes"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_479258fe","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":69},"in_reply_to":"bf51134e_6f679926","updated":"2020-07-17 08:45:22.000000000","message":"Fixed. Thanks.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"information to Cyborg\u0027s unified data model, such as Device, Deployable,"},{"line_number":32,"context_line":"AttachHandle and so on."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The driver should include discover functions which will be called by agent"},{"line_number":35,"context_line":"periodically."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Image Format"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_d225a85d","line":35,"range":{"start_line":34,"start_character":45,"end_line":35,"end_character":13},"updated":"2020-07-15 14:17:27.000000000","message":"nit:which will be called by agent\nperiodically once the driver is enabled.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":31,"context_line":"information to Cyborg\u0027s unified data model, such as Device, Deployable,"},{"line_number":32,"context_line":"AttachHandle and so on."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The driver should include discover functions which will be called by agent"},{"line_number":35,"context_line":"periodically."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Image Format"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_27c004e1","line":35,"range":{"start_line":34,"start_character":45,"end_line":35,"end_character":13},"in_reply_to":"bf51134e_d225a85d","updated":"2020-07-17 08:45:22.000000000","message":"Supplement at the new commit.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"User can manage Inspur® FPGA card by Cyborg Inspur® FPGA driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Performance Impact"},{"line_number":73,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_55b6a23f","line":70,"range":{"start_line":70,"start_character":9,"end_line":70,"end_character":15},"updated":"2020-07-15 14:17:27.000000000","message":"can you also list the supported user management operations  for this specific driver here? eg. with this driver, user can list, retrieve one device with Inspur® FPGA driver, program etc.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"User can manage Inspur® FPGA card by Cyborg Inspur® FPGA driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Performance Impact"},{"line_number":73,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_a7ab741c","line":70,"range":{"start_line":70,"start_character":9,"end_line":70,"end_character":15},"in_reply_to":"bf51134e_55b6a23f","updated":"2020-07-17 08:45:22.000000000","message":"Done.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Other deployer impact"},{"line_number":78,"context_line":"---------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Developer impact"},{"line_number":83,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_d2af687a","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":4},"updated":"2020-07-15 14:17:27.000000000","message":"Does the deployer need to install any specific Inspur FPGA package or management stack that the driver depends on?","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Other deployer impact"},{"line_number":78,"context_line":"---------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Developer impact"},{"line_number":83,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_e7a56c49","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":4},"in_reply_to":"bf51134e_d2af687a","updated":"2020-07-17 08:45:22.000000000","message":"Need to install Inspur Fpga stack. Done.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"7f78deebf303b2ae61ff700e62a278db0757d3a6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Documentation Impact"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Document Inspur® FPGA driver in Cyborg project."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"References"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_720adc89","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":47},"updated":"2020-07-15 14:17:27.000000000","message":"yes, both a user guide and driver test report(third-party makeup) are required.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"3545e63bd97acd14673d3fe27dac66bf2b9628a9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Documentation Impact"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Document Inspur® FPGA driver in Cyborg project."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"References"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_fe70fc42","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":47},"in_reply_to":"bf51134e_4760980e","updated":"2020-07-23 02:39:13.000000000","message":"cool. but please provide and add the report to cyborg documentation(the driver doc part[0]), not in coding patch. documentation is public to all end-users, while the code patch is more narrow to developers. For details, pls see the dicsussion in this ML thread[1].\n[0]https://docs.openstack.org/cyborg/latest/reference/support-matrix.html#driver-support\n[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015875.html","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"72ed00a4ae2be54786e00c4bed1b8d62847d28da","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Documentation Impact"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Document Inspur® FPGA driver in Cyborg project."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"References"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_4760980e","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":47},"in_reply_to":"bf51134e_720adc89","updated":"2020-07-17 08:45:22.000000000","message":"Will provide the test report in coding.","commit_id":"1297a0251ab7e2e2b3e36941ce760719e13711dc"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"3545e63bd97acd14673d3fe27dac66bf2b9628a9","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The driver should include the follow functions:"},{"line_number":40,"context_line":"1. discover()"},{"line_number":41,"context_line":"driver reports devices as following::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  [{"},{"line_number":44,"context_line":"    \"vendor\": \"0x1db4\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_9e33c062","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":37},"updated":"2020-07-23 02:39:13.000000000","message":"if you wanna show what kind of data will be reported to the cyborg-agent by discover() function, you can refer to this https://github.com/openstack/cyborg/blob/0eb12a9892ebba71d18816132f8e8c4e646ba412/cyborg/tests/unit/accelerator/drivers/gpu/test_utils.py#L70. or this https://github.com/openstack/cyborg/blob/0eb12a9892ebba71d18816132f8e8c4e646ba412/cyborg/tests/unit/accelerator/drivers/fpga/intel/test_driver.py#L68. These comply with the new data model, while previous driver specifications in cyborg-spec are merged  much ealier than the new data model is proposed(which maybe a bit old fashioned).","commit_id":"36765ebd957cfd1bdfef45c1c2a3fafefa4fb795"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"52de52c13f060a92e1992628e7dce42cb34bfe3d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The driver should include the follow functions:"},{"line_number":40,"context_line":"1. discover()"},{"line_number":41,"context_line":"driver reports devices as following::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  [{"},{"line_number":44,"context_line":"    \"vendor\": \"0x1db4\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_182b8f94","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":37},"in_reply_to":"9f560f44_3de64546","updated":"2020-07-27 11:48:59.000000000","message":"Thanks Yumeng. Recheck the discription for function `discover()`.","commit_id":"36765ebd957cfd1bdfef45c1c2a3fafefa4fb795"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"2ac20e06787e89ecb91ffdf2a7180e71ea7293dc","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The driver should include the follow functions:"},{"line_number":40,"context_line":"1. discover()"},{"line_number":41,"context_line":"driver reports devices as following::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  [{"},{"line_number":44,"context_line":"    \"vendor\": \"0x1db4\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_fcd48521","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":37},"in_reply_to":"bf51134e_9e33c062","updated":"2020-07-23 03:59:22.000000000","message":"I will complete the full data in coding.\nI think the data model now can support the driver discorver() data.","commit_id":"36765ebd957cfd1bdfef45c1c2a3fafefa4fb795"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"0e751ff72ce05900f3cd09cbfc47adbd281c126a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The driver should include the follow functions:"},{"line_number":40,"context_line":"1. discover()"},{"line_number":41,"context_line":"driver reports devices as following::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  [{"},{"line_number":44,"context_line":"    \"vendor\": \"0x1db4\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_3de64546","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":37},"in_reply_to":"bf51134e_fcd48521","updated":"2020-07-27 11:19:14.000000000","message":"ok. I actually just wanted to point that discover() reports the full data, while what you illustrated here is the device\u0027s raw info collected from the compute node.\nwe\u0027d better mention this as an example of Inspur device info, then say the discover() function will generate the complete data from this info.","commit_id":"36765ebd957cfd1bdfef45c1c2a3fafefa4fb795"}]}