)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yumeng_Bao \u003cyumeng_bao@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-21 11:13:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cyborg NVIDIAGPUDriver support vGPU management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes the enhancement of Cyborg gpu driver to"},{"line_number":10,"context_line":"support vGPU management."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_3a4bf987","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":22},"updated":"2020-10-21 07:23:31.000000000","message":"NVIDIA GPU driver","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"}],"specs/wallaby/approved/vgpu-driver-proposal.rst":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Cyborg NVIDIAGPUDriver support vGPU management"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The NVIDIAGPUDriver has implemented pGPU management in the Train release,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_77a46a09","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":22},"updated":"2020-10-21 07:23:31.000000000","message":"NVIDIA GPU driver","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Cyborg NVIDIAGPUDriver support vGPU management"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The NVIDIAGPUDriver has implemented pGPU management in the Train release,"},{"line_number":12,"context_line":"this spec proposes the specification of supporting vGPU management in the"},{"line_number":13,"context_line":"same driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_97aae6cf","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":19},"updated":"2020-10-21 07:23:31.000000000","message":"NVIDIA GPU driver","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing cyborg gpu driver, NVIDIAGPUDriver, has supported the first method"},{"line_number":35,"context_line":"(PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_5a5b552d","line":34,"range":{"start_line":34,"start_character":32,"end_line":34,"end_character":47},"updated":"2020-10-21 07:23:31.000000000","message":"ditto","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Proposed changes"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"To be brief, we need to enhance NVIDIAGPUDriver to:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* generate rc,traits for vGPU"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_9af4cdd1","line":48,"range":{"start_line":48,"start_character":32,"end_line":48,"end_character":47},"updated":"2020-10-21 07:23:31.000000000","message":"ditto","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"To be brief, we need to enhance NVIDIAGPUDriver to:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* generate rc,traits for vGPU"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_dafe45ad","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":10},"updated":"2020-10-21 07:23:31.000000000","message":"Generate ``rc (resource class)``,``traits``","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"dc4323a39af3786cbf2b4cfa5a4eb60edd082b32","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"To be brief, we need to enhance NVIDIAGPUDriver to:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* generate rc,traits for vGPU"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_7938add2","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":10},"in_reply_to":"3f65232a_dafe45ad","updated":"2020-10-24 03:15:43.000000000","message":"Done","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* generate rc,traits for vGPU"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_3a2db946","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":10},"updated":"2020-10-21 07:23:31.000000000","message":"Generate ``controlpath_id``,``deployable``,``attach_handle`` ...","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"dc4323a39af3786cbf2b4cfa5a4eb60edd082b32","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* generate rc,traits for vGPU"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_993b09d0","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":10},"in_reply_to":"3f65232a_3a2db946","updated":"2020-10-24 03:15:43.000000000","message":"Done","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Image Format"},{"line_number":57,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_3ad2d935","line":54,"range":{"start_line":54,"start_character":53,"end_line":54,"end_character":62},"updated":"2020-10-21 07:23:31.000000000","message":"... after unbinding ...","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Image Format"},{"line_number":57,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_1a327da8","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":8},"updated":"2020-10-21 07:23:31.000000000","message":"Delete","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"dc4323a39af3786cbf2b4cfa5a4eb60edd082b32","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Image Format"},{"line_number":57,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_194d3972","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":8},"in_reply_to":"3f65232a_1a327da8","updated":"2020-10-24 03:15:43.000000000","message":"Done","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"dc4323a39af3786cbf2b4cfa5a4eb60edd082b32","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* generate controlpath_id,deployable,attach_handle for vGPU"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* delete vGPU from /sys/class/mdev_bus/... when vgpu is unbind from a VM"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Image Format"},{"line_number":57,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_d93581dc","line":54,"range":{"start_line":54,"start_character":53,"end_line":54,"end_character":62},"in_reply_to":"3f65232a_3ad2d935","updated":"2020-10-24 03:15:43.000000000","message":"Done","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"For vGPU management, deployers need to make sure that the GPU device has been"},{"line_number":101,"context_line":"successfully virtualized. Otherwise, cyborg will report it as a pGPU device."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Please see ref [1]_ and [2]_ for how to install the Virtual GPU Manager package"},{"line_number":104,"context_line":"to virtualize your GPU devices."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_3a62d917","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":38},"updated":"2020-10-21 07:23:31.000000000","message":"C","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Work Items"},{"line_number":121,"context_line":"----------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Implement NVIDIAGPUDriver enhancement in Cyborg"},{"line_number":124,"context_line":"* Add related test cases."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_daa7654f","line":123,"range":{"start_line":123,"start_character":12,"end_line":123,"end_character":27},"updated":"2020-10-21 07:23:31.000000000","message":"ditto","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"74ff04447427b55eee8f452f5710b6f1eba79e75","unresolved":false,"context_lines":[{"line_number":154,"context_line":"   * - Wallaby"},{"line_number":155,"context_line":"     - Introduced"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"References"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":".. [1] https://docs.nvidia.com/grid/6.0/grid-vgpu-user-guide/index.html"},{"line_number":160,"context_line":".. [2] https://docs.nvidia.com/grid/6.0/grid-vgpu-user-guide/index.html#install-vgpu-package-generic-linux-kvm"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f65232a_9765c6e4","line":157,"updated":"2020-10-21 07:23:31.000000000","message":"This section should merge to Lin141","commit_id":"002e24936b64d9626919931ee9f4daa14e3676e9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"80442aa71c1fd72dff560e325359526fa85c19d2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"same driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"GPU devices can provide supercomputing capabilities, and can replace the CPU"},{"line_number":19,"context_line":"to provide users with more efficient computing power at a lower cost. GPU cloud"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f65232a_7d08cb27","line":16,"updated":"2020-10-21 07:30:06.000000000","message":"I think we should explain the different of pGPU and vGPU, and their behavior, such as part of the spec in nova: https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/vgpu-multiple-types.html#problem-description","commit_id":"dcd08bdb5f43cd3d227d4d6e44136209a38d3ab9"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Proposed changes"},{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"To be clear, in the following, we will describe the whole process of how does"},{"line_number":50,"context_line":"the NVIDIA GPU Driver discover, generate cyborg specific driver objects of the"},{"line_number":51,"context_line":"vGPU devices(comply with cyborg Database Model), and report it to cyborg-db"},{"line_number":52,"context_line":"and placement by cyborg-conductor. Features that are aleady supported in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_443f8124","line":49,"range":{"start_line":49,"start_character":73,"end_line":49,"end_character":77},"updated":"2020-11-06 08:49:08.000000000","message":"\u0027to do\u0027 maybe better.","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"To be clear, in the following, we will describe the whole process of how does"},{"line_number":50,"context_line":"the NVIDIA GPU Driver discover, generate cyborg specific driver objects of the"},{"line_number":51,"context_line":"vGPU devices(comply with cyborg Database Model), and report it to cyborg-db"},{"line_number":52,"context_line":"and placement by cyborg-conductor. Features that are aleady supported in"},{"line_number":53,"context_line":"current branch is marked as DONE, new changes are marked as NEW CHANGES."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_844999d1","line":51,"range":{"start_line":51,"start_character":66,"end_line":51,"end_character":75},"updated":"2020-11-06 08:49:08.000000000","message":"nit: confuse with cyborg-conductor service, redundant \u0027-\u0027.","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"4738cf3e698e534d8e165753870c5f8662e1be4c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"     |               |                      |"},{"line_number":75,"context_line":"  4 vGPUs     4 attach_handles    ---\u003e inventories(total:4)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Generate resource_class and traits for device, which later will also be"},{"line_number":78,"context_line":"  reported to placement, and used by nova-scheduler to filter appropriate"},{"line_number":79,"context_line":"  accelerators.(NEW CHANGE)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_4e95e03f","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":2},"updated":"2020-11-06 02:26:08.000000000","message":"* Support configuring enabled_vgpu_types for each device in cyborg.conf.(NEW CHANGE)","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"4738cf3e698e534d8e165753870c5f8662e1be4c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  Pass-through GPU device will report \u0027PGPU\u0027 as its resource class,"},{"line_number":84,"context_line":"  Virtualized GPU device will report \u0027VGPU\u0027 as its resource class."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  ``traits`` follows the placement custom trait format [7]_, and it is based"},{"line_number":87,"context_line":"  on a new configuration enabled_vgpu_types in cyborg.conf, where operator"},{"line_number":88,"context_line":"  set this vgpu type for each device, and later driver retrieve this type and"},{"line_number":89,"context_line":"  report to placement as part of trait. But the enabled_vgpu_types and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_cea1f0ab","line":86,"range":{"start_line":86,"start_character":54,"end_line":86,"end_character":55},"updated":"2020-11-06 02:26:08.000000000","message":"with prefix OWNER_CYBORG_","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  need to mapping this according to the sys info about gpu devices."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  ``traits`` format will be"},{"line_number":94,"context_line":"  OWNER_CYBORG_CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":97,"context_line":"                reported by cyborg when the inventory is reported to placement."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_e45fad6f","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":67},"updated":"2020-11-06 08:49:08.000000000","message":"As pGPU report CUSTOM_GPU_NVIDIA and CUSTOM_GPU_PRODUCT_ID_1EB8 traits, so vGPU report only one trait?","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  PRODUCT_ID: product ID of the GPU device."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Virtual_GPU_Type: please refer to [8]_ for introduction and see valud Virtual"},{"line_number":105,"context_line":"                    GPU Types for Supported GPUs."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  In the following, we will give an example."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_447e6119","line":104,"range":{"start_line":104,"start_character":66,"end_line":104,"end_character":71},"updated":"2020-11-06 08:49:08.000000000","message":"valid","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  In the cyborg.conf file, configuration will be:"},{"line_number":120,"context_line":"  ::"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    enabled_vgpu_types\u003dnvidia-223"},{"line_number":123,"context_line":"    [nvidia-223]"},{"line_number":124,"context_line":"    pci_adreess\u003d0000:af:00.0"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  Traits format will be:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_249ec553","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":28},"updated":"2020-11-06 08:49:08.000000000","message":"Better to config like nova.\n[devices]\nenabled_vgpu_types \u003d nvidia-35, nvidia-36\n\n[vgpu_nvidia-35]\ndevice_addresses \u003d 0000:84:00.0,0000:85:00.0\n\n[vgpu_nvidia-36]\ndevice_addresses \u003d 0000:86:00.0","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89de58035bda7d8369c30d686fed8805ffb10e36","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* (NEW CHANGE)Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":131,"context_line":"  for vGPU."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* (NEW CHANGE)Delete vGPU from sys by echo \"1\" to the remove file when vgpu is"},{"line_number":134,"context_line":"  unbind from a VM. remove_file_path\u003d"},{"line_number":135,"context_line":"  /sys/class/mdev_bus/{pci_address}/mdev_supported_types/{type-id}/UUID/remove"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_e4b5edce","line":132,"updated":"2020-11-06 08:49:08.000000000","message":"what about \u0027attributes\u0027?","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"aba929175e1c209b6c5e577d0c782fa8c4ba4083","unresolved":false,"context_lines":[{"line_number":130,"context_line":"* (NEW CHANGE)Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":131,"context_line":"  for vGPU."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* (NEW CHANGE)Delete vGPU from sys by echo \"1\" to the remove file when vgpu is"},{"line_number":134,"context_line":"  unbind from a VM. remove_file_path\u003d"},{"line_number":135,"context_line":"  /sys/class/mdev_bus/{pci_address}/mdev_supported_types/{type-id}/UUID/remove"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_2ec7c447","line":133,"range":{"start_line":133,"start_character":14,"end_line":133,"end_character":20},"updated":"2020-11-06 02:43:13.000000000","message":"Create the MDEV when binding to VM, and delete the MDEV when unbinding from a VM.","commit_id":"57d372c993b3123d57c3cdcab926413973763dcf"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Cyborg NVIDIA GPU Driver support vGPU management"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The cyborg NVIDIA GPU Driver has implemented pGPU management in the Train"},{"line_number":12,"context_line":"release, this spec proposes the specification of supporting vGPU management"},{"line_number":13,"context_line":"in the same driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_5cc72365","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":60},"updated":"2020-11-11 12:02:08.000000000","message":"It\u0027s better to merged 28d6b88c64d7ff37601255ff7b6f952f71bded78, and add a hyperlink here.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Cyborg NVIDIA GPU Driver support vGPU management"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The cyborg NVIDIA GPU Driver has implemented pGPU management in the Train"},{"line_number":12,"context_line":"release, this spec proposes the specification of supporting vGPU management"},{"line_number":13,"context_line":"in the same driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_e78a9cbc","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":60},"in_reply_to":"1f621f24_5cc72365","updated":"2020-11-17 09:12:06.000000000","message":"IMHO, it seems the pGPU spec is too vague and did not provide more information than in this vGPU spec. I didn\u0027t see much meaning there. Do we really need a copy of that just to show we have a spec?\nIn other words, if we want to add a pGPU spec now, at least we should show some difference compared to vGPU. The rc, traits, resource_provider model, etc.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing cyborg gpu driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":"Please see ref [1]_ for Nova-cyborg vGPU integration spec."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_9c2c1b03","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":23},"updated":"2020-11-11 12:02:08.000000000","message":"GPU","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing cyborg gpu driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":"Please see ref [1]_ for Nova-cyborg vGPU integration spec."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_5c4603c2","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":65},"updated":"2020-11-11 12:02:08.000000000","message":"I am not an expert on EN, but this sentence seems to be inappropriate,how about \"The existing cyborg gpu driver (NVIDIA GPU Driver) has supported...\"","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing cyborg gpu driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":"Please see ref [1]_ for Nova-cyborg vGPU integration spec."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_aa20699c","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":65},"in_reply_to":"1f621f24_5c4603c2","updated":"2020-11-17 09:12:06.000000000","message":"Your suggestion is ok. But there is nothing inappropriate in this sentence. This is apposition, pls see\nhttps://dictionary.cambridge.org/zhs/%E8%AF%AD%E6%B3%95/%E8%8B%B1%E5%BC%8F%E8%AF%AD%E6%B3%95/apposition","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When user is using cyborg to manage GPU devices, one will want to boot up a"},{"line_number":42,"context_line":"  VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the vedio"},{"line_number":43,"context_line":"  coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed changes"},{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_3c7b47be","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":61},"updated":"2020-11-11 12:02:08.000000000","message":"How about to say: As an user, I would like to manage GPU devices by Cyborg, which to achieve the management of acceleration devices, that can boot up a server with GPU (pGPU or vGPU) attached in order to accelerate the vedio coding and decoding.\n\nIMO, *Use Cases* should directly express what the user wants to achieve.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When user is using cyborg to manage GPU devices, one will want to boot up a"},{"line_number":42,"context_line":"  VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the vedio"},{"line_number":43,"context_line":"  coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed changes"},{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_f541a2a7","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":61},"in_reply_to":"1f621f24_3c7b47be","updated":"2020-11-17 09:12:06.000000000","message":"I think it is already very clearly expressed here. when a user is using cyborg to XXXX, and he wants to boot up a VM with acc.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"current branch is marked as DONE, new changes are marked as NEW CHANGES."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"},{"line_number":56,"context_line":"nvidia related keyword.(DONE)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Parsing details from each record including vendor_id, product_id and"},{"line_number":59,"context_line":"pci_address.(DONE)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_9fea4d0c","line":56,"updated":"2020-11-11 12:02:08.000000000","message":"1. Collect raw info of GPU devices from compute node by \n   \"lspci\" and grep nvidia related keyword.(DONE)\n\nformat the indentation as below 2,3,4,5,6,7,8..","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":53,"context_line":"current branch is marked as DONE, new changes are marked as NEW CHANGES."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"},{"line_number":56,"context_line":"nvidia related keyword.(DONE)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Parsing details from each record including vendor_id, product_id and"},{"line_number":59,"context_line":"pci_address.(DONE)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_ca3845d4","line":56,"in_reply_to":"1f621f24_9fea4d0c","updated":"2020-11-17 09:12:06.000000000","message":"There is no problem here. nova-spec also has this kind of format","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"},{"line_number":56,"context_line":"nvidia related keyword.(DONE)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Parsing details from each record including vendor_id, product_id and"},{"line_number":59,"context_line":"pci_address.(DONE)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"3. Generate cyborg specific driver objects and resource provider modeling"},{"line_number":62,"context_line":"for the GPU device as well as its mdiated devices. Below is the objects to"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_1f991dc3","line":59,"range":{"start_line":58,"start_character":46,"end_line":59,"end_character":11},"updated":"2020-11-11 12:02:08.000000000","message":"``vendor_id``, ``product_id`` and ``pci_address``","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"},{"line_number":56,"context_line":"nvidia related keyword.(DONE)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Parsing details from each record including vendor_id, product_id and"},{"line_number":59,"context_line":"pci_address.(DONE)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"3. Generate cyborg specific driver objects and resource provider modeling"},{"line_number":62,"context_line":"for the GPU device as well as its mdiated devices. Below is the objects to"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_aa5509fc","line":59,"range":{"start_line":58,"start_character":46,"end_line":59,"end_character":11},"in_reply_to":"1f621f24_1f991dc3","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"     |               |                      |"},{"line_number":75,"context_line":"  4 vGPUs     4 attach_handles    ---\u003e inventories(total:4)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"4. Supporting set vgpu type for each exact pGPU in cyborg.conf. The"},{"line_number":78,"context_line":"implementation is similar to that in nova [9]_.(NEW CHANGE)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Firstly, we propose [devices]/enabled_vgpu_types to define which cyborg"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_bff589ef","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":22},"updated":"2020-11-11 12:02:08.000000000","message":"vGPU","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":74,"context_line":"     |               |                      |"},{"line_number":75,"context_line":"  4 vGPUs     4 attach_handles    ---\u003e inventories(total:4)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"4. Supporting set vgpu type for each exact pGPU in cyborg.conf. The"},{"line_number":78,"context_line":"implementation is similar to that in nova [9]_.(NEW CHANGE)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Firstly, we propose [devices]/enabled_vgpu_types to define which cyborg"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_d56e262d","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":22},"in_reply_to":"1f621f24_bff589ef","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  **OWNER_CYBORG_CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":138,"context_line":"  Meaning of each parameter is listed below."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":141,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":142,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_dfda0549","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":16},"updated":"2020-11-11 12:02:08.000000000","message":"Ah, I saw you update OWNER_NOVA in the vGPU SPEC [1], greate.\nI think we should have a NOTE to simple describe the *OWNER_NOVA* namespace expressing manged by Nova, it\u0027s easy for us to review this after a long time.\n\n[1]https://review.opendev.org/#/c/750116/8/specs/wallaby/approved/support-vGPU-nova-cyborg-interaction.rst@141","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f21f2aa3b11703fe02f99d710316f65f292ffa66","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  **OWNER_CYBORG_CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":138,"context_line":"  Meaning of each parameter is listed below."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":141,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":142,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_f0fb70ba","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":16},"in_reply_to":"1f621f24_d5d2a6ff","updated":"2020-11-17 09:35:45.000000000","message":"Where is the NOTE?","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  **OWNER_CYBORG_CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":138,"context_line":"  Meaning of each parameter is listed below."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":141,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":142,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_d5d2a6ff","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":16},"in_reply_to":"1f621f24_dfda0549","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  * Virtual_GPU_Type: this parameter is actually another format of the"},{"line_number":149,"context_line":"    enabled_vgpu_types for a specific device set by admin in cyborg.conf."},{"line_number":150,"context_line":"    In order to generate this param, driver will first retrieve"},{"line_number":151,"context_line":"    enabled_vgpu_type and then map it to Virtual_GPU_Type by the way showed"},{"line_number":152,"context_line":"    below. The name is exactly the Virtual_GPU_Type that will be reported in"},{"line_number":153,"context_line":"    traits. For more details about the valid Virtual GPU Types for Supported"},{"line_number":154,"context_line":"    GPUs, please refer to [8]_."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_5f9c3569","line":151,"range":{"start_line":151,"start_character":4,"end_line":151,"end_character":21},"updated":"2020-11-11 12:02:08.000000000","message":"``enabled_vgpu_type``","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  * Virtual_GPU_Type: this parameter is actually another format of the"},{"line_number":149,"context_line":"    enabled_vgpu_types for a specific device set by admin in cyborg.conf."},{"line_number":150,"context_line":"    In order to generate this param, driver will first retrieve"},{"line_number":151,"context_line":"    enabled_vgpu_type and then map it to Virtual_GPU_Type by the way showed"},{"line_number":152,"context_line":"    below. The name is exactly the Virtual_GPU_Type that will be reported in"},{"line_number":153,"context_line":"    traits. For more details about the valid Virtual GPU Types for Supported"},{"line_number":154,"context_line":"    GPUs, please refer to [8]_."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_b591ea54","line":151,"range":{"start_line":151,"start_character":4,"end_line":151,"end_character":21},"in_reply_to":"1f621f24_5f9c3569","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    In order to generate this param, driver will first retrieve"},{"line_number":151,"context_line":"    enabled_vgpu_type and then map it to Virtual_GPU_Type by the way showed"},{"line_number":152,"context_line":"    below. The name is exactly the Virtual_GPU_Type that will be reported in"},{"line_number":153,"context_line":"    traits. For more details about the valid Virtual GPU Types for Supported"},{"line_number":154,"context_line":"    GPUs, please refer to [8]_."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  ::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_1f7f5d15","line":153,"range":{"start_line":153,"start_character":67,"end_line":153,"end_character":68},"updated":"2020-11-11 12:02:08.000000000","message":"s","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    In order to generate this param, driver will first retrieve"},{"line_number":151,"context_line":"    enabled_vgpu_type and then map it to Virtual_GPU_Type by the way showed"},{"line_number":152,"context_line":"    below. The name is exactly the Virtual_GPU_Type that will be reported in"},{"line_number":153,"context_line":"    traits. For more details about the valid Virtual GPU Types for Supported"},{"line_number":154,"context_line":"    GPUs, please refer to [8]_."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  ::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_159d3e65","line":153,"range":{"start_line":153,"start_character":67,"end_line":153,"end_character":68},"in_reply_to":"1f621f24_1f7f5d15","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"520d0ec190d2e8fce91335d5d1e3df0919ece480","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      device_addresses \u003d 0000:af:00.0"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    2. Restart the cyborg-agent service."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * Finally, trait reported for this device(RP) will be:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    **OWNER_CYBORG_CUSTOM_NVIDIA_1EB8_T4_2B**"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_88750c67","line":187,"updated":"2020-11-10 03:24:52.000000000","message":"do we still use nvidia_gpu_driver for vgpu?","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      device_addresses \u003d 0000:af:00.0"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    2. Restart the cyborg-agent service."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * Finally, trait reported for this device(RP) will be:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    **OWNER_CYBORG_CUSTOM_NVIDIA_1EB8_T4_2B**"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_558cd634","line":187,"in_reply_to":"1f621f24_88750c67","updated":"2020-11-17 09:12:06.000000000","message":"yes, the same","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"520d0ec190d2e8fce91335d5d1e3df0919ece480","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    [vtu@ubuntudbs mdev_supported_types]$ cat nvidia-223/name"},{"line_number":207,"context_line":"    GRID T4-2B"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"6. Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":210,"context_line":"for vGPU.(NEW CHANGE)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"7. Create a mdev device in the sys by echo its UUID (actually is the"},{"line_number":213,"context_line":"attach_handle UUID) to the create file when vgpu is bind to a VM.(NEW CHANGE)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_08073ccc","line":210,"range":{"start_line":209,"start_character":3,"end_line":210,"end_character":21},"updated":"2020-11-10 03:24:52.000000000","message":"no need to change attributes?","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    [vtu@ubuntudbs mdev_supported_types]$ cat nvidia-223/name"},{"line_number":207,"context_line":"    GRID T4-2B"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"6. Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":210,"context_line":"for vGPU.(NEW CHANGE)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"7. Create a mdev device in the sys by echo its UUID (actually is the"},{"line_number":213,"context_line":"attach_handle UUID) to the create file when vgpu is bind to a VM.(NEW CHANGE)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_1576de3e","line":210,"range":{"start_line":209,"start_character":3,"end_line":210,"end_character":21},"in_reply_to":"1f621f24_08073ccc","updated":"2020-11-17 09:12:06.000000000","message":"yes sure","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"520d0ec190d2e8fce91335d5d1e3df0919ece480","unresolved":false,"context_lines":[{"line_number":209,"context_line":"6. Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":210,"context_line":"for vGPU.(NEW CHANGE)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"7. Create a mdev device in the sys by echo its UUID (actually is the"},{"line_number":213,"context_line":"attach_handle UUID) to the create file when vgpu is bind to a VM.(NEW CHANGE)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"create_file_path\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_282b1830","line":212,"range":{"start_line":212,"start_character":3,"end_line":212,"end_character":23},"updated":"2020-11-10 03:24:52.000000000","message":"do we create mdev in cyborg instead nova? and how does cyborg create mdev?","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":209,"context_line":"6. Generate ``controlpath_id``, ``deployable``, ``attach_handle``"},{"line_number":210,"context_line":"for vGPU.(NEW CHANGE)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"7. Create a mdev device in the sys by echo its UUID (actually is the"},{"line_number":213,"context_line":"attach_handle UUID) to the create file when vgpu is bind to a VM.(NEW CHANGE)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"create_file_path\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_b57a8a20","line":212,"range":{"start_line":212,"start_character":3,"end_line":212,"end_character":23},"in_reply_to":"1f621f24_282b1830","updated":"2020-11-17 09:12:06.000000000","message":"added nova side spec here as the plan.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"remove_file_path\u003d"},{"line_number":222,"context_line":"/sys/class/mdev_bus/{pci_address}/mdev_supported_types/{type-id}/UUID/remove"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Image Format"},{"line_number":225,"context_line":"----------------------------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Alternatives"},{"line_number":230,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_7f1ad1cb","line":227,"range":{"start_line":224,"start_character":0,"end_line":227,"end_character":4},"updated":"2020-11-11 12:02:08.000000000","message":"Remove this section, in our templete does not required *Image format* https://opendev.org/openstack/cyborg-specs/src/branch/master/specs/wallaby-template.rst","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":221,"context_line":"remove_file_path\u003d"},{"line_number":222,"context_line":"/sys/class/mdev_bus/{pci_address}/mdev_supported_types/{type-id}/UUID/remove"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Image Format"},{"line_number":225,"context_line":"----------------------------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Alternatives"},{"line_number":230,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_f5708242","line":227,"range":{"start_line":224,"start_character":0,"end_line":227,"end_character":4},"in_reply_to":"1f621f24_7f1ad1cb","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":229,"context_line":"Alternatives"},{"line_number":230,"context_line":"------------"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"None"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Data model impact"},{"line_number":235,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_5fe275a1","line":232,"range":{"start_line":232,"start_character":0,"end_line":232,"end_character":4},"updated":"2020-11-11 12:02:08.000000000","message":"The alternative is that we have been using the vGPU management solution provided by Nova, but it cannot be unified by Cyborg like other accelerators, and it loses some flexibility.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":229,"context_line":"Alternatives"},{"line_number":230,"context_line":"------------"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"None"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Data model impact"},{"line_number":235,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_3594ba36","line":232,"range":{"start_line":232,"start_character":0,"end_line":232,"end_character":4},"in_reply_to":"1f621f24_5fe275a1","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"Other deployer impact"},{"line_number":267,"context_line":"---------------------"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"This feature is highly dependent on the version of libvirt and the physical"},{"line_number":270,"context_line":"devices present on the host."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"For vGPU management, deployers need to make sure that the GPU device has been"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_9f2c0d03","line":269,"range":{"start_line":269,"start_character":50,"end_line":269,"end_character":58},"updated":"2020-11-11 12:02:08.000000000","message":"I think the qemu version also need to be consider.\nAnd we should declare a minimum supported version of libvirt and qemu.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":266,"context_line":"Other deployer impact"},{"line_number":267,"context_line":"---------------------"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"This feature is highly dependent on the version of libvirt and the physical"},{"line_number":270,"context_line":"devices present on the host."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"For vGPU management, deployers need to make sure that the GPU device has been"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_35bddab6","line":269,"range":{"start_line":269,"start_character":50,"end_line":269,"end_character":58},"in_reply_to":"1f621f24_9f2c0d03","updated":"2020-11-17 09:12:06.000000000","message":"Can you name the exact versions of these two and your reason? I think this should be also related to the operating system version required by a specific Nvidia GPU device.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"Developer impact"},{"line_number":279,"context_line":"----------------"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"None"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Implementation"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_bf10e9a9","line":281,"range":{"start_line":281,"start_character":0,"end_line":281,"end_character":4},"updated":"2020-11-11 12:02:08.000000000","message":"I think one is if the developer wants to use this feature, we should upgrade the Cyborg to the latest version to support this feature.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":278,"context_line":"Developer impact"},{"line_number":279,"context_line":"----------------"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"None"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Implementation"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_f5a522a0","line":281,"range":{"start_line":281,"start_character":0,"end_line":281,"end_character":4},"in_reply_to":"1f621f24_bf10e9a9","updated":"2020-11-17 09:12:06.000000000","message":"make sense.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f21f2aa3b11703fe02f99d710316f65f292ffa66","unresolved":false,"context_lines":[{"line_number":278,"context_line":"Developer impact"},{"line_number":279,"context_line":"----------------"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"None"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Implementation"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_70292035","line":281,"range":{"start_line":281,"start_character":0,"end_line":281,"end_character":4},"in_reply_to":"1f621f24_f5a522a0","updated":"2020-11-17 09:35:45.000000000","message":"Hope you can describe that in this section.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"572befca510c23e42061d3d31ed09b624a338d2d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"----------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"* Implement NVIDIA GPU Driver enhancement in Cyborg"},{"line_number":296,"context_line":"* Add related test cases."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Dependencies"},{"line_number":299,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_7f68111c","line":296,"updated":"2020-11-11 12:02:08.000000000","message":"We also need to provide a test result process in the wiki, and add to the device support list.","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9b5cde277ba989768411fd7f450341b912ce8d81","unresolved":false,"context_lines":[{"line_number":293,"context_line":"----------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"* Implement NVIDIA GPU Driver enhancement in Cyborg"},{"line_number":296,"context_line":"* Add related test cases."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Dependencies"},{"line_number":299,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f621f24_b59f2a4e","line":296,"in_reply_to":"1f621f24_7f68111c","updated":"2020-11-17 09:12:06.000000000","message":"Done","commit_id":"6255f66e4478b2bdf9d2934f796387039dbde168"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":21,"context_line":"video encoding and decoding, scientific research and artificial intelligence"},{"line_number":22,"context_line":"(deep learning, machine learning)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"In the OpenStack ecosystem, users can now use nova to pass gpu resources to"},{"line_number":25,"context_line":"guest by two methods:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Pass the GPU hardware to the guest (PCI pass-through)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_4c4c5376","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":50},"updated":"2020-11-19 06:17:05.000000000","message":"Nova","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":21,"context_line":"video encoding and decoding, scientific research and artificial intelligence"},{"line_number":22,"context_line":"(deep learning, machine learning)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"In the OpenStack ecosystem, users can now use nova to pass gpu resources to"},{"line_number":25,"context_line":"guest by two methods:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Pass the GPU hardware to the guest (PCI pass-through)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1c997913_94f15191","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":50},"in_reply_to":"fffc6b78_4c4c5376","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Nova","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_2c510f10","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":35},"updated":"2020-11-19 06:17:05.000000000","message":"Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"}],"source_content_type":"text/x-rst","patch_set":10,"id":"09fc18bf_b28519a4","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":35},"in_reply_to":"fffc6b78_2c510f10","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_6c5b172e","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":22},"updated":"2020-11-19 06:17:05.000000000","message":"Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_ac3cdfbf","line":32,"range":{"start_line":32,"start_character":74,"end_line":32,"end_character":78},"updated":"2020-11-19 06:17:05.000000000","message":"Nova","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."}],"source_content_type":"text/x-rst","patch_set":10,"id":"a72fe0fa_358fa0b6","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":22},"in_reply_to":"fffc6b78_6c5b172e","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Pass the Mediated Device(vGPU) to the guest."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"With the long-term goal that cyborg will manage heterogeneous accelerators"},{"line_number":32,"context_line":"including GPUs, cyborg needs to support GPU management and integrate with nova"},{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."}],"source_content_type":"text/x-rst","patch_set":10,"id":"a899ce39_ca279ca6","line":32,"range":{"start_line":32,"start_character":74,"end_line":32,"end_character":78},"in_reply_to":"fffc6b78_ac3cdfbf","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Nova","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":"Please see ref [1]_ for Nova-cyborg vGPU integration spec."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_0c4a4b54","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":35},"updated":"2020-11-19 06:17:05.000000000","message":"Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":33,"context_line":"to provide users with gpu resources allocation in the aforementioned methods."},{"line_number":34,"context_line":"The existing Cyborg GPU driver, NVIDIA GPU Driver, has supported the first"},{"line_number":35,"context_line":"method (PCI pass-through), while the second method is not yet supported."},{"line_number":36,"context_line":"Please see ref [1]_ for Nova-cyborg vGPU integration spec."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"493188d6_a1150b4c","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":35},"in_reply_to":"fffc6b78_0c4a4b54","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When the user is using cyborg to manage GPU devices, he/she wants to boot"},{"line_number":42,"context_line":"  up a VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the"},{"line_number":43,"context_line":"  vedio coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_ec46e74f","line":41,"range":{"start_line":41,"start_character":25,"end_line":41,"end_character":31},"updated":"2020-11-19 06:17:05.000000000","message":"Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When the user is using cyborg to manage GPU devices, he/she wants to boot"},{"line_number":42,"context_line":"  up a VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the"},{"line_number":43,"context_line":"  vedio coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"613f7b54_a28f6638","line":41,"range":{"start_line":41,"start_character":25,"end_line":41,"end_character":31},"in_reply_to":"fffc6b78_ec46e74f","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When the user is using cyborg to manage GPU devices, he/she wants to boot"},{"line_number":42,"context_line":"  up a VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the"},{"line_number":43,"context_line":"  vedio coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed changes"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_4c757398","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":7},"updated":"2020-11-19 06:17:05.000000000","message":"video","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* When the user is using cyborg to manage GPU devices, he/she wants to boot"},{"line_number":42,"context_line":"  up a VM with Nvidia GPU (pGPU or vGPU) attached in order to accelerate the"},{"line_number":43,"context_line":"  vedio coding and decoding, Cyborg should be able to manage this kind of"},{"line_number":44,"context_line":"  acceleration resources and to assign it to the VM(binding)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed changes"}],"source_content_type":"text/x-rst","patch_set":10,"id":"6761d871_ac023abc","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":7},"in_reply_to":"fffc6b78_4c757398","updated":"2020-11-26 09:22:25.000000000","message":"\u003e video","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":49,"context_line":"To be clear, in the following, we will describe the whole process of how does"},{"line_number":50,"context_line":"the NVIDIA GPU Driver discover, generate cyborg specific driver objects of the"},{"line_number":51,"context_line":"vGPU devices(comply with cyborg Database Model), and report it to cyborg-db"},{"line_number":52,"context_line":"and placement by cyborg-conductor. Features that are aleady supported in"},{"line_number":53,"context_line":"current branch is marked as DONE, new changes are marked as NEW CHANGES."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_2c7aaf87","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":13},"updated":"2020-11-19 06:17:05.000000000","message":"Placement","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":49,"context_line":"To be clear, in the following, we will describe the whole process of how does"},{"line_number":50,"context_line":"the NVIDIA GPU Driver discover, generate cyborg specific driver objects of the"},{"line_number":51,"context_line":"vGPU devices(comply with cyborg Database Model), and report it to cyborg-db"},{"line_number":52,"context_line":"and placement by cyborg-conductor. Features that are aleady supported in"},{"line_number":53,"context_line":"current branch is marked as DONE, new changes are marked as NEW CHANGES."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"1. Collect raw info of GPU devices from compute node by \"lspci\" and grep"}],"source_content_type":"text/x-rst","patch_set":10,"id":"85e02f50_88e1fe62","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":13},"in_reply_to":"fffc6b78_2c7aaf87","updated":"2020-11-26 09:22:25.000000000","message":"\u003e Placement","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  ::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    [devices]"},{"line_number":86,"context_line":"    enabled_vgpu_types \u003d [str_vgpu_type_1, str_vgpu_type_2, ...]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* And also, we propose that cyborg driver will accept configuration sections"},{"line_number":89,"context_line":"  that are related to the [devices]/enabled_vgpu_types and specifies which"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_ece2672f","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":64},"updated":"2020-11-19 06:17:05.000000000","message":"Can we make this section gpu specific, like:\n[gpu]\nenabled_vgpu_types \u003d...\n\nbecause we may have other devices also need this config file, it is better to seperate them. Please refer to:https://review.opendev.org/#/c/758942/1/cyborg/accelerator/drivers/nic/intel/nic.conf","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  ::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    [devices]"},{"line_number":86,"context_line":"    enabled_vgpu_types \u003d [str_vgpu_type_1, str_vgpu_type_2, ...]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* And also, we propose that cyborg driver will accept configuration sections"},{"line_number":89,"context_line":"  that are related to the [devices]/enabled_vgpu_types and specifies which"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7cfaf80c_1752589f","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":64},"in_reply_to":"fffc6b78_0cf08bc9","updated":"2020-11-26 09:22:25.000000000","message":"ok.\n[gpu]\nenabled_vgpu_types \u003d ...\nmakes sense","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a3ec91e140d1ef92bd3769ef9c21c895138f9f77","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  ::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    [devices]"},{"line_number":86,"context_line":"    enabled_vgpu_types \u003d [str_vgpu_type_1, str_vgpu_type_2, ...]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* And also, we propose that cyborg driver will accept configuration sections"},{"line_number":89,"context_line":"  that are related to the [devices]/enabled_vgpu_types and specifies which"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_0cf08bc9","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":64},"in_reply_to":"fffc6b78_ece2672f","updated":"2020-11-19 06:31:15.000000000","message":"Agree, if there is more than one devices to manage, split the device type is easy to maintain.\n[devices]\n[GPU]\nenabled_vgpu_types\u003d....\n\nOr we can use [devices:GPU]","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    [devices]"},{"line_number":121,"context_line":"    enabled_vgpu_types\u003dnvidia-223,nvidia-224"},{"line_number":122,"context_line":"    [vgpu_nvidia-223]"},{"line_number":123,"context_line":"    device_addresses \u003d 0000:af:00.0,0000:86:00.0"},{"line_number":124,"context_line":"    [vgpu_nvidia-224]"},{"line_number":125,"context_line":"    device_addresses \u003d 0000:86:00.0"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_ecbb870b","line":122,"updated":"2020-11-19 06:17:05.000000000","message":"Ah ok, just saw this. So we can add more device section like this.","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    [devices]"},{"line_number":121,"context_line":"    enabled_vgpu_types\u003dnvidia-223,nvidia-224"},{"line_number":122,"context_line":"    [vgpu_nvidia-223]"},{"line_number":123,"context_line":"    device_addresses \u003d 0000:af:00.0,0000:86:00.0"},{"line_number":124,"context_line":"    [vgpu_nvidia-224]"},{"line_number":125,"context_line":"    device_addresses \u003d 0000:86:00.0"}],"source_content_type":"text/x-rst","patch_set":10,"id":"91867476_e1e12a2e","line":122,"in_reply_to":"fffc6b78_ecbb870b","updated":"2020-11-26 09:22:25.000000000","message":"yep.","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  Meaning of each parameter is listed below."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":145,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":146,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  * VENDOR_NAME: vendor name of the GPU device."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_2c3bcf9c","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":22},"updated":"2020-11-19 06:17:05.000000000","message":"Cyborg","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  Meaning of each parameter is listed below."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":145,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":146,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  * VENDOR_NAME: vendor name of the GPU device."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_8c40fb09","line":145,"range":{"start_line":145,"start_character":57,"end_line":145,"end_character":66},"updated":"2020-11-19 06:17:05.000000000","message":"ditto","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  * OWNER_CYBORG: a new namespace in os-traits to remark that a device is"},{"line_number":145,"context_line":"    reported by cyborg when the inventory is reported to placement. It is used"},{"line_number":146,"context_line":"    to distinguish GPU devices reported by nova."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  * VENDOR_NAME: vendor name of the GPU device."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_6c45d717","line":146,"range":{"start_line":146,"start_character":43,"end_line":146,"end_character":47},"updated":"2020-11-19 06:17:05.000000000","message":"ditto","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":231,"context_line":"Alternatives"},{"line_number":232,"context_line":"------------"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Using nova to manage vGPU device [10]_."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Data model impact"},{"line_number":237,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_4c5f33e5","line":234,"range":{"start_line":234,"start_character":6,"end_line":234,"end_character":10},"updated":"2020-11-19 06:17:05.000000000","message":"Nova","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"233ce47998d5ce30615a826817ad4cbdbd571365","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"REST API impact"},{"line_number":243,"context_line":"---------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"None"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_2c646fb9","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":4},"updated":"2020-11-19 06:17:05.000000000","message":"do we need to modify bind API here to create and bind a mdev.","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"ea0f2b9dbf3b69ce59df0f6865c0b61fa6c6e7b5","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"REST API impact"},{"line_number":243,"context_line":"---------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"None"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"e60c0bb5_8eefaa2f","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":4},"in_reply_to":"8d8a5c71_cc820906","updated":"2020-11-26 10:00:03.000000000","message":"ok, so there is no impact in terms of input/output.","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"303ee091d88be80baefa5a9413a13d76bf2ed1da","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"REST API impact"},{"line_number":243,"context_line":"---------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"None"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"34cefc27_31595e15","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":4},"in_reply_to":"e60c0bb5_8eefaa2f","updated":"2020-11-27 06:13:55.000000000","message":"+1","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a3ec91e140d1ef92bd3769ef9c21c895138f9f77","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"REST API impact"},{"line_number":243,"context_line":"---------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"None"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fffc6b78_ccce8382","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":4},"in_reply_to":"fffc6b78_2c646fb9","updated":"2020-11-19 06:31:15.000000000","message":"I think yes, it might be we need a microversion.","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"fa2a8641eee86a7d1d71ac87b0ba1e7bc7a71c99","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"REST API impact"},{"line_number":243,"context_line":"---------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"None"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8d8a5c71_cc820906","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":4},"in_reply_to":"fffc6b78_ccce8382","updated":"2020-11-26 09:22:25.000000000","message":"according to current code. create mdev can be added in arq.apply_patch[0]. This will not have API impact and does not need a microversion because from the interface\u0027s perspective, both the input and return parameters will not change. From cyborg internal perspective, one more internal operation(create mdev) is required before we flush the db.that\u0027s it.\n\n[0]https://github.com/openstack/cyborg/blob/9fa4e71c1fe049e629c0f06da510b45ce6d93195/cyborg/objects/extarq/ext_arq_job.py#L229","commit_id":"099440721bf8d8c784fe46a675ecddfc732e7846"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"ea0f2b9dbf3b69ce59df0f6865c0b61fa6c6e7b5","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  driver, it will report two traits for vGPU accelerator using the format"},{"line_number":137,"context_line":"  below:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  trait1: **OWNER_CYBORG**."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  trait2: **CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"f6bdfb50_905d711c","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":24},"updated":"2020-11-26 10:00:03.000000000","message":"does device profile contain this trait, and let end user to choose the dp. So user is aware of the device owner. If so, I think it expose too much information to user. \n\nOr, does this trait is just an internal mark, which allow admin to manage it.","commit_id":"16de8874ccd3c5fa62c7b8e54b3ade7042c66a2b"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"113e6cbe255fdd29cc3ea41fa44c214c90e8a84c","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  driver, it will report two traits for vGPU accelerator using the format"},{"line_number":137,"context_line":"  below:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  trait1: **OWNER_CYBORG**."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  trait2: **CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fdabe6ff_ab9da3df","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":24},"in_reply_to":"f6bdfb50_905d711c","updated":"2020-11-27 03:24:19.000000000","message":"good question. \nI think device profile should contain this trait. device profile can only be created by system admin, the end user just use it. And once they choose a device profile, they already aware of the device owner. what do you think?","commit_id":"16de8874ccd3c5fa62c7b8e54b3ade7042c66a2b"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"512e2bad32032af81031f77e555cab0313d98dd8","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  driver, it will report two traits for vGPU accelerator using the format"},{"line_number":137,"context_line":"  below:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  trait1: **OWNER_CYBORG**."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  trait2: **CUSTOM_\u003cVENDOR_NAME\u003e_\u003cPRODUCT_ID\u003e_\u003cVirtual_GPU_Type\u003e**."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"19367a2d_f8b7f0c2","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":24},"in_reply_to":"fdabe6ff_ab9da3df","updated":"2020-11-27 08:28:18.000000000","message":"ok, got it. lgtm.","commit_id":"16de8874ccd3c5fa62c7b8e54b3ade7042c66a2b"}]}