)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b6950a9863c41cc53faae5459c0880f22ef1ba7b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-24 03:29:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cyborg Intel X710 Ethernet Adapter Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icb98cb601fbeb9969c298ea5f980ebd30d364b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_99ba09dc","line":8,"updated":"2020-10-29 09:38:31.000000000","message":"It\u0027s better to give some description of this change, and please add the blueprint in nova [1], it\u0027s easy to trace.\n\npart of blueprint https://blueprints.launchpad.net/nova/+spec/sriov-smartnic-support","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"}],"specs/wallaby/approved/add-x710-driver.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1baa4f1ae561229d94def31cfd7d1544563e1028","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_b1da6c14","line":46,"updated":"2020-10-30 09:52:45.000000000","message":"If it just a PF or a VF is needed it can be added with neutron and nova alreasy. Isn\u0027t it the new use case is that the PF or VF can be customized with DDP?","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"14a8c85ced8de0f1cd75b2cc3a1b84c0848da571","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_d5d4abeb","line":46,"in_reply_to":"1f621f24_339c1fbf","updated":"2020-11-11 06:48:40.000000000","message":"\u003e DDP is device wide so it not resticted to just a PF it affacs all\n \u003e PFs and VFs on a card.\n \u003e \nYes, once programmed, it will affect all PFs/Vfs on the card. \n \u003e https://review.opendev.org/#/c/503001/ was the nova spec where we\n \u003e orginaly tried to enable DDP a few years ago\n \u003e i provide some context on this.\n \u003e \n \u003e nova has half of this feature already merged in that we track all\n \u003e the capablitsi in the nova db but we do not have the ablity to mage\n \u003e on it or report it to placemtn\n \u003e \n \u003e https://review.opendev.org/#/c/444415\n \u003e added that functionality.\n \u003e \n \u003e https://review.opendev.org/#/q/topic:bp/enable-sriov-nic-features+(status:open+OR+status:merged)\n \u003e we mergd all the traits too but the scond half of the feature which\n \u003e was enableing a way to requst a nic with a specific feature set via\n \u003e neutron and the reporting to placment was not merged.\n \u003e \n \u003e the code was writend just not merged\n \u003e https://review.opendev.org/#/q/status:abandoned+project:openstack/nova+branch:master+topic:bp/enable-sriov-nic-features\n \u003e \n \u003e\n\nThank you for provide such links, it seems that libvirt driver can discover the profile name and fill it into nova db, but the report part and vm boot process were not supported. Today, by using Cyborg, we can let cyborg do the discover/report things. I think our overall idea is similiar, about the left things like port binding, etc.\n\n \u003e in that orignial spec we were slightly missuing the binding profile\n \u003e to avoid need a neuton cahnge since i predated the device requests.\n \u003e \n \u003e with the new vnic type for cyborg and device profile there is no\n \u003e need for that.\n \u003e \n \u003e the trait request for devices with a specirc DDP profile\n \u003e can be handeled entirely with  the device profile now.\n\n+1\n\n \u003e \n \u003e cyborg will need to determin if it will select a card that already\n \u003e has a ddp profile programed or will select a card that is apable of\n \u003e being programed with a DDP profile.\n \u003e \n \u003e that will have to be done with differnt device-profiles but its\n \u003e really up to cyborg.\n \u003e \n\n+1\n\n \u003e if we were to do this in nova we would proably only do the static\n \u003e assigment of pre programed device prociles and leave anything\n \u003e dynamic to cyborg but im not currently planning to work on the nova\n \u003e way yet.\n \u003e \n\n+1, we should firstly support programmed case which requires neutron/nova/cyborg changes, to complete a workflow to boot up a vm. Then, for dynamic programming, it is almost cyborg\u0027s part.","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd8cfe37f9814375a0770b03ec2bc6bea3dcec31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_339c1fbf","line":46,"in_reply_to":"1f621f24_b1da6c14","updated":"2020-11-10 17:36:24.000000000","message":"DDP is device wide so it not resticted to just a PF it affacs all PFs and VFs on a card.\n\nhttps://review.opendev.org/#/c/503001/ was the nova spec where we orginaly tried to enable DDP a few years ago\ni provide some context on this.\n\nnova has half of this feature already merged in that we track all the capablitsi in the nova db but we do not have the ablity to mage on it or report it to placemtn \n\nhttps://review.opendev.org/#/c/444415\nadded that functionality.\n\nhttps://review.opendev.org/#/q/topic:bp/enable-sriov-nic-features+(status:open+OR+status:merged) we mergd all the traits too but the scond half of the feature which was enableing a way to requst a nic with a specific feature set via neutron and the reporting to placment was not merged.\n\nthe code was writend just not merged \nhttps://review.opendev.org/#/q/status:abandoned+project:openstack/nova+branch:master+topic:bp/enable-sriov-nic-features\n\n\nin that orignial spec we were slightly missuing the binding profile to avoid need a neuton cahnge since i predated the device requests.\n\nwith the new vnic type for cyborg and device profile there is no need for that.\n\nthe trait request for devices with a specirc DDP profile\ncan be handeled entirely with  the device profile now.\n\nprogrammign of DDP dynamically will require cyborg to create a nested resouce provide to model the card and track the profile at teh card level with sub resouce providers for the   PF with inventoies of vfs or pfs.\n\ncyborg will need to determin if it will select a card that already has a ddp profile programed or will select a card that is apable of being programed with a DDP profile.\n\nthat will have to be done with differnt device-profiles but its really up to cyborg.\n\nif we were to do this in nova we would proably only do the static assigment of pre programed device prociles and leave anything dynamic to cyborg but im not currently planning to work on the nova way yet. \n\nwe disucssed that most of the code for tracking pci device in placement via nova was already witten a few years ago. this is what i was refering to then. in that proposal each DDP profile was going to just be reported in the capbalities dict and translated into a CUSTOM_DDP_\u003cprofile name\u003e trait more or less.","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1baa4f1ae561229d94def31cfd7d1544563e1028","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"We should also implement a configuration file to let Cyborg driver to discover"},{"line_number":59,"context_line":"the loaded DDP profile on X710, as well as the physnet name associated with"},{"line_number":60,"context_line":"this nic and then cyborg can report thess as the attributes."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_b1ac2c8d","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":41},"updated":"2020-10-30 09:52:45.000000000","message":"nit: these","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1baa4f1ae561229d94def31cfd7d1544563e1028","unresolved":false,"context_lines":[{"line_number":58,"context_line":"We should also implement a configuration file to let Cyborg driver to discover"},{"line_number":59,"context_line":"the loaded DDP profile on X710, as well as the physnet name associated with"},{"line_number":60,"context_line":"this nic and then cyborg can report thess as the attributes."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_113a4035","line":61,"updated":"2020-10-30 09:52:45.000000000","message":"How will the end user define what customization is needed for this cyborg device? I.e. what pipeline configuration is needed for the requested device.","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d656ce34c8f85c9c2e647287dc2ae3db6a2db9a5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Data model impact"},{"line_number":68,"context_line":"-----------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"REST API impact"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_d17d68e8","line":70,"updated":"2020-10-30 10:22:49.000000000","message":"Could you please add some detail how the new devices will be modeled in placement?","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1baa4f1ae561229d94def31cfd7d1544563e1028","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Developer impact"},{"line_number":99,"context_line":"----------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Deployer need to install DPDK toolkit to confige the DDP feature."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f621f24_91a9307d","line":101,"range":{"start_line":101,"start_character":41,"end_line":101,"end_character":48},"updated":"2020-10-30 09:52:45.000000000","message":"nit: configure","commit_id":"e0645962510ef2b9b1aa874d83ab818340fbe24f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5b8b94e6b9c7a08aafee361ee4563a8dd8790a9a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    [dev-name]"},{"line_number":72,"context_line":"    pci_address\u003d0000:18:00.0"},{"line_number":73,"context_line":"    function_name\u003dGTPv1 // The name of the DDP profile"},{"line_number":74,"context_line":"    physnet\u003dphysnet1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fffc6b78_ecfee7ac","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":26},"updated":"2020-11-19 06:21:34.000000000","message":"nit: Ah, this should be #, a comments. // used in C/C++/Java.","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"bb6234ba225e482a20fcc98616639c4b78beed28","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    [dev-name]"},{"line_number":72,"context_line":"    pci_address\u003d0000:18:00.0"},{"line_number":73,"context_line":"    function_name\u003dGTPv1 // The name of the DDP profile"},{"line_number":74,"context_line":"    physnet\u003dphysnet1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fffc6b78_ecc5475d","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":26},"in_reply_to":"fffc6b78_ecfee7ac","updated":"2020-11-19 06:28:42.000000000","message":"Done","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e59d5fb463de55a74adf5c6264c524a372c6e8af","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  |           |     |            |                 |            |"},{"line_number":121,"context_line":"  |deployable1|     |deployable 2|   ...           |deployable 8|"},{"line_number":122,"context_line":"  +-----------+     +------------+                 +------------+"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"REST API impact"},{"line_number":126,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f621f24_d6c74c95","line":123,"updated":"2020-11-17 11:57:29.000000000","message":"Will these deployable RPs have traits that specifies the accelerator capability loaded to the card?\n\nWill these deployable RPs has a resource inventory?","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"b89f8c3bef922646ab03d2e793f9be488a870c70","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  |           |     |            |                 |            |"},{"line_number":121,"context_line":"  |deployable1|     |deployable 2|   ...           |deployable 8|"},{"line_number":122,"context_line":"  +-----------+     +------------+                 +------------+"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"REST API impact"},{"line_number":126,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f621f24_b669f025","line":123,"in_reply_to":"1f621f24_d6c74c95","updated":"2020-11-17 12:26:21.000000000","message":"\u003e Will these deployable RPs have traits that specifies the\n \u003e accelerator capability loaded to the card?\n \u003e \n\nYes, they will have like CUSTOM_FUNCTION_NAME trait associated.\n\n \u003e Will these deployable RPs has a resource inventory?\n\nYes, for X710 nic, each deployable\u0027s inventory equals 1.","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5b8b94e6b9c7a08aafee361ee4563a8dd8790a9a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Unit tests will be added to test this driver."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fffc6b78_cc20434d","line":176,"updated":"2020-11-19 06:21:34.000000000","message":"Also need to provide a test results with wiki, and we can trait the driver implemention.","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"bb6234ba225e482a20fcc98616639c4b78beed28","unresolved":false,"context_lines":[{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Unit tests will be added to test this driver."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fffc6b78_6cbaf7de","line":176,"in_reply_to":"fffc6b78_cc20434d","updated":"2020-11-19 06:28:42.000000000","message":"Done","commit_id":"15269c3d8c1dc4d27b554f6214393915912949dd"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"57bdaef8786dba3ad3d2d639e9c888796761384e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_2f0a9e89","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":9},"updated":"2020-11-19 11:45:38.000000000","message":"Paragraph 1 may be manage the accelerator resources and Paragraph 2 is binding PF or VF by Cyborg, which is better.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"d568bd991b7e2673fae1cf45d724086e04fa2d63","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_da6587e3","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":9},"in_reply_to":"fffc6b78_2f0a9e89","updated":"2020-11-20 02:26:47.000000000","message":"What you said is 2 part of cyborg\u0027s work. I think this \"use ca se\" section is to describe an end-to-end use case from end user\u0027s perspective.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"bae59b34e2afb1e9fb29628318cd5de847285631","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_f587bcb5","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":9},"in_reply_to":"fffc6b78_55bcc8ba","updated":"2020-11-20 06:34:14.000000000","message":"got it.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"b146f77e55f601d8dd3ece10811a3ca94f4dc9dd","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_55bcc8ba","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":9},"in_reply_to":"fffc6b78_9a13ff0d","updated":"2020-11-20 05:49:09.000000000","message":"\u0027assign it to the VM\u0027 in part 1 means bind ARQ, allocation the card. which is not expressed explicitly in part2, but in part2, we do need to bind ARQ etc. In part 2, the difference is we need to bind ARQ, but also do program action.\n\nIt is the similiar workflow as what fpga driver does.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"5bff6d50121678a630969acee174b1f732e7c108","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"},{"line_number":44,"context_line":"  able to manage this kind of acceleration resources and to assign it to the"},{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_9a13ff0d","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":9},"in_reply_to":"fffc6b78_da6587e3","updated":"2020-11-20 02:45:35.000000000","message":"Now we just support bind the card through the part2 case, I am confused the \u0027assign it to the VM(binding)\u0027 in part1, which is  equivalent to what part2\u0027s description i think.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"57bdaef8786dba3ad3d2d639e9c888796761384e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The driver should include discover functions which will be called by agent"},{"line_number":61,"context_line":"periodically."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"We should also implement a configuration file to let Cyborg driver to discover"},{"line_number":64,"context_line":"the loaded DDP profile on X710, as well as the physnet name associated with"},{"line_number":65,"context_line":"this nic and then Cyborg can report these as the attributes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_6feb06b0","line":62,"updated":"2020-11-19 11:45:38.000000000","message":"Can you explain what the purpose of program function.","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"d568bd991b7e2673fae1cf45d724086e04fa2d63","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The driver should include discover functions which will be called by agent"},{"line_number":61,"context_line":"periodically."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"We should also implement a configuration file to let Cyborg driver to discover"},{"line_number":64,"context_line":"the loaded DDP profile on X710, as well as the physnet name associated with"},{"line_number":65,"context_line":"this nic and then Cyborg can report these as the attributes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fffc6b78_3a63f3de","line":62,"in_reply_to":"fffc6b78_6feb06b0","updated":"2020-11-20 02:26:47.000000000","message":"Done","commit_id":"6eb2043be86ccf6ff55242daa2f9bc44911e4d33"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"c7cd6cffe1db7951a7d78961ae0e45438e7d7ddc","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Cyborg Intel® x710 driver proposal"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to provide a new Cyborg driver for Intel® x710 dirver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4f643331_834d1c79","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"updated":"2020-11-23 07:04:16.000000000","message":"Mention the overall sriov support in OpenStack and add nova spec link here.","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9e840545978522fd5d88e4abaf2d37fad6ad9c65","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Cyborg Intel® x710 driver proposal"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to provide a new Cyborg driver for Intel® x710 dirver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4bbfe3a4_f24c5cc4","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"in_reply_to":"4f643331_834d1c79","updated":"2020-11-23 07:28:32.000000000","message":"Done","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"c7cd6cffe1db7951a7d78961ae0e45438e7d7ddc","unresolved":true,"context_lines":[{"line_number":37,"context_line":"software. The DPDK provides all APIs to handle DDP packages."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4e55d74e_67222962","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":9},"updated":"2020-11-23 07:04:16.000000000","message":"Since use cases should cover operator,end user,(and developer if any) I would suggest say like:\n\n*As an operator, I want to use Cyborg to manage lifycycle of Intel X710. Cyborg side driver should be able to manage this kind of acceleration resources including discover and report.\n \n*As an end user, I want to boot up a VM with Intel X710, cyborg should be able to interact with nova virt driver to assign it the VM.\n\n*As an advanced end user, I want to customize a profile to load on Intel X710 when boot up a VM with it, cyborg driver should be able to provide such program interface? (correct me if I was wrong.)","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9e840545978522fd5d88e4abaf2d37fad6ad9c65","unresolved":false,"context_lines":[{"line_number":37,"context_line":"software. The DPDK provides all APIs to handle DDP packages."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"---------"},{"line_number":42,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":43,"context_line":"  attached in order to accelerate network related workload. Cyborg should be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2fa3daa7_e73750dd","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":9},"in_reply_to":"4e55d74e_67222962","updated":"2020-11-23 07:28:32.000000000","message":"Done","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"c7cd6cffe1db7951a7d78961ae0e45438e7d7ddc","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3947fb4c_3c42ccb5","line":50,"range":{"start_line":48,"start_character":56,"end_line":50,"end_character":9},"updated":"2020-11-23 07:04:16.000000000","message":"this is a very good solution description. I would suggest put it to the \"proposed changes\" part as a solution summary.","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9e840545978522fd5d88e4abaf2d37fad6ad9c65","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  VM(binding)."},{"line_number":46,"context_line":"* When user wants to boot up a VM with Intel® X710 Ethernet Adapter (PF or VF)"},{"line_number":47,"context_line":"  attached, meanwhile he/she want to customize a profile to load on this"},{"line_number":48,"context_line":"  nic by passing the profile\u0027s info in VM boot request. Cyborg should get this"},{"line_number":49,"context_line":"  profile\u0027s info from Nova and let this driver to load profile to the selected"},{"line_number":50,"context_line":"  device."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"71ba8345_9f085498","line":50,"range":{"start_line":48,"start_character":56,"end_line":50,"end_character":9},"in_reply_to":"3947fb4c_3c42ccb5","updated":"2020-11-23 07:28:32.000000000","message":"Done","commit_id":"55910aacc5aef451dc731d97adf47c783084b6d5"}]}