)]}'
{"specs/xena/approved/disable-enable-device.rst":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a23df2da_f3b3c7c1","updated":"2021-07-15 06:14:09.000000000","message":"does the list devices api need return the `device_status` filed?","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f87cc398_b5120c16","in_reply_to":"a23df2da_f3b3c7c1","updated":"2021-07-15 08:10:37.000000000","message":"yes, I think so.","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"5937933b422d8a8179d0b20d5647882e1e8ba846","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55db88d8_f849a9e3","in_reply_to":"e9080756_2c0b39c3","updated":"2021-07-15 09:14:02.000000000","message":"yes, please state in the proposed change","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1dd6e136b0c81075d047684dff3096965c20479f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9080756_2c0b39c3","in_reply_to":"f87cc398_b5120c16","updated":"2021-07-15 08:13:47.000000000","message":"Agree add the device status to the devices\u0027 details info, so we need to add a microversion.","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":"* Alice is an admin user, she don\u0027t want all FPGAs to be reported as an"},{"line_number":32,"context_line":"  accelerator resources and to be allocated to a VM at the time. On the"},{"line_number":33,"context_line":"  contrary, she want to program this FPGA by herself and then enable this"},{"line_number":34,"context_line":"  device in OpenStack environment."}],"source_content_type":"text/x-rst","patch_set":1,"id":"6380b372_27f8ad29","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":36},"updated":"2021-07-15 06:14:09.000000000","message":"doesn\u0027t","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":"* Alice is an admin user, she don\u0027t want all FPGAs to be reported as an"},{"line_number":32,"context_line":"  accelerator resources and to be allocated to a VM at the time. On the"},{"line_number":33,"context_line":"  contrary, she want to program this FPGA by herself and then enable this"},{"line_number":34,"context_line":"  device in OpenStack environment."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c8483f07_d626ac4e","line":34,"range":{"start_line":31,"start_character":2,"end_line":34,"end_character":34},"updated":"2021-07-15 06:14:09.000000000","message":"the use case is not property. the enable/disable api also needs all the FPGAs to be reported.","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  status of a device. If one device is disabled, the status should be set"},{"line_number":41,"context_line":"  to \"maintaining\", and if the device is enabled, the status should be set to"},{"line_number":42,"context_line":"  \"enabled\". The default value should be \"enabled\"."},{"line_number":43,"context_line":"* Cyborg need call Placement API to update the \"reserved\" field for the"},{"line_number":44,"context_line":"  device."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"50032ff3_046cf669","line":44,"range":{"start_line":43,"start_character":2,"end_line":44,"end_character":9},"updated":"2021-07-15 06:14:09.000000000","message":"does the placement already has the api to modify the field?","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  status of a device. If one device is disabled, the status should be set"},{"line_number":41,"context_line":"  to \"maintaining\", and if the device is enabled, the status should be set to"},{"line_number":42,"context_line":"  \"enabled\". The default value should be \"enabled\"."},{"line_number":43,"context_line":"* Cyborg need call Placement API to update the \"reserved\" field for the"},{"line_number":44,"context_line":"  device."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8b3b0f50_883b50bb","line":44,"range":{"start_line":43,"start_character":2,"end_line":44,"end_character":9},"in_reply_to":"50032ff3_046cf669","updated":"2021-07-15 08:10:37.000000000","message":"yes， please see https://docs.openstack.org/api-ref/placement/#update-resource-provider-inventories","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"},{"line_number":52,"context_line":"A new colume `device_status` should be added in Device\u0027s data model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"46b26efa_fb049452","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":13},"updated":"2021-07-15 06:14:09.000000000","message":"column","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"},{"line_number":52,"context_line":"A new colume `device_status` should be added in Device\u0027s data model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9bff2fb8_03f65376","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":13},"in_reply_to":"46b26efa_fb049452","updated":"2021-07-15 08:10:37.000000000","message":"Done","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":58,"context_line":"Disable Device API"},{"line_number":59,"context_line":"^^^^^^^^^^^^^^^^^^"},{"line_number":60,"context_line":"* Disable a device"},{"line_number":61,"context_line":"  URL: ``/device/disable/{device_uuid}``"},{"line_number":62,"context_line":"  METHOD: ``POST``"},{"line_number":63,"context_line":"  Return: 200"},{"line_number":64,"context_line":"  Error Code: 404(the device is not found),403(the role is not admin)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"09eed40c_54d0b19b","line":61,"range":{"start_line":61,"start_character":10,"end_line":61,"end_character":16},"updated":"2021-07-15 06:14:09.000000000","message":"devices","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Disable Device API"},{"line_number":59,"context_line":"^^^^^^^^^^^^^^^^^^"},{"line_number":60,"context_line":"* Disable a device"},{"line_number":61,"context_line":"  URL: ``/device/disable/{device_uuid}``"},{"line_number":62,"context_line":"  METHOD: ``POST``"},{"line_number":63,"context_line":"  Return: 200"},{"line_number":64,"context_line":"  Error Code: 404(the device is not found),403(the role is not admin)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a6c739f1_79eb965e","line":61,"range":{"start_line":61,"start_character":10,"end_line":61,"end_character":16},"in_reply_to":"09eed40c_54d0b19b","updated":"2021-07-15 08:10:37.000000000","message":"Done","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":66,"context_line":"Enable Device API"},{"line_number":67,"context_line":"^^^^^^^^^^^^^^^^^"},{"line_number":68,"context_line":"* Enable a device"},{"line_number":69,"context_line":"  URL: ``/device/enable/{device_uuid}``"},{"line_number":70,"context_line":"  METHOD: ``POST``"},{"line_number":71,"context_line":"  Return: 200"},{"line_number":72,"context_line":"  Error Code: 404(the device is not found),403(the role is not admin)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6de2b889_36c02bc7","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":16},"updated":"2021-07-15 06:14:09.000000000","message":"devices","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Enable Device API"},{"line_number":67,"context_line":"^^^^^^^^^^^^^^^^^"},{"line_number":68,"context_line":"* Enable a device"},{"line_number":69,"context_line":"  URL: ``/device/enable/{device_uuid}``"},{"line_number":70,"context_line":"  METHOD: ``POST``"},{"line_number":71,"context_line":"  Return: 200"},{"line_number":72,"context_line":"  Error Code: 404(the device is not found),403(the role is not admin)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0f6da3d8_43f862de","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":16},"in_reply_to":"6de2b889_36c02bc7","updated":"2021-07-15 08:10:37.000000000","message":"Done","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":"* Add new colume `devices_status` for device table."},{"line_number":110,"context_line":"* Add new API in DeviceController."},{"line_number":111,"context_line":"* Update the RP `reserved` field according to the operation."},{"line_number":112,"context_line":"* Add unit tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"081406b8_c09558cd","line":109,"range":{"start_line":109,"start_character":10,"end_line":109,"end_character":17},"updated":"2021-07-15 06:14:09.000000000","message":"column","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":"* Add new colume `devices_status` for device table."},{"line_number":110,"context_line":"* Add new API in DeviceController."},{"line_number":111,"context_line":"* Update the RP `reserved` field according to the operation."},{"line_number":112,"context_line":"* Add unit tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"21525e16_37c143b9","line":109,"range":{"start_line":109,"start_character":18,"end_line":109,"end_character":32},"updated":"2021-07-15 06:14:09.000000000","message":"device_status","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3064ee1716007bfafeb36352e683843ea081493","unresolved":true,"context_lines":[{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":"* Add new colume `devices_status` for device table."},{"line_number":110,"context_line":"* Add new API in DeviceController."},{"line_number":111,"context_line":"* Update the RP `reserved` field according to the operation."},{"line_number":112,"context_line":"* Add unit tests."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ae5591b6_d1ddf07a","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":60},"updated":"2021-07-15 06:14:09.000000000","message":"please detailed the `reserved` filed changed.","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7ce86ee48e55be4d3c69f04f070a1612c680fefa","unresolved":false,"context_lines":[{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":"* Add new colume `devices_status` for device table."},{"line_number":110,"context_line":"* Add new API in DeviceController."},{"line_number":111,"context_line":"* Update the RP `reserved` field according to the operation."},{"line_number":112,"context_line":"* Add unit tests."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6ef3367f_331dfde3","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":60},"in_reply_to":"ae5591b6_d1ddf07a","updated":"2021-07-15 08:10:37.000000000","message":"Done","commit_id":"8dd9318457bba7ee93a935ec20d790b08573470f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"5937933b422d8a8179d0b20d5647882e1e8ba846","unresolved":true,"context_lines":[{"line_number":113,"context_line":"  `total` field, and for `enable` operation, the `reserved` field will be set"},{"line_number":114,"context_line":"  to zero."},{"line_number":115,"context_line":"* Add unit tests."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"69d38679_9b341f47","line":116,"updated":"2021-07-15 09:14:02.000000000","message":"we also need modify cyborgclient.","commit_id":"77661226dfb15b5116105c92cb65e340ab6bcce1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9d22c3a6e47ddfc58b5824e0646a25afc0e9a580","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  `total` field, and for `enable` operation, the `reserved` field will be set"},{"line_number":114,"context_line":"  to zero."},{"line_number":115,"context_line":"* Add unit tests."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"64ac1038_dfe93f45","line":116,"in_reply_to":"69d38679_9b341f47","updated":"2021-07-15 11:57:20.000000000","message":"Done","commit_id":"77661226dfb15b5116105c92cb65e340ab6bcce1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"141e1173056aa4097ba7e04d9cb2236843a1f812","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Other end user impact"},{"line_number":156,"context_line":"---------------------"},{"line_number":157,"context_line":"None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Performance Impact"},{"line_number":160,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7d28b496_c596eb32","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":4},"updated":"2021-07-15 13:22:53.000000000","message":"One is if you dont update the cyborg release to support this microversion, you cannot using the enable/disable devices API, and it will be rejected.","commit_id":"15b3652602c7ec23c1ad66686a973be16d3bbb9a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"141e1173056aa4097ba7e04d9cb2236843a1f812","unresolved":true,"context_lines":[{"line_number":181,"context_line":"----------"},{"line_number":182,"context_line":"* Add new column `device_status` for device table."},{"line_number":183,"context_line":"* Add new API in DeviceController."},{"line_number":184,"context_line":"* Update the RP `reserved` field according to the operation. For `disable`"},{"line_number":185,"context_line":"  oparation, the `reserved` field need be set by the same value as the"},{"line_number":186,"context_line":"  `total` field, and for `enable` operation, the `reserved` field will be set"},{"line_number":187,"context_line":"  to zero."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9133a9e6_e489fb8b","line":184,"updated":"2021-07-15 13:22:53.000000000","message":"another item is: \"Need to add the changes for devices APIs\"\nthat you can addresse it by follow up.","commit_id":"15b3652602c7ec23c1ad66686a973be16d3bbb9a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"141e1173056aa4097ba7e04d9cb2236843a1f812","unresolved":true,"context_lines":[{"line_number":185,"context_line":"  oparation, the `reserved` field need be set by the same value as the"},{"line_number":186,"context_line":"  `total` field, and for `enable` operation, the `reserved` field will be set"},{"line_number":187,"context_line":"  to zero."},{"line_number":188,"context_line":"* Add disable/enable operation in cyborgclient."},{"line_number":189,"context_line":"* Add unit tests."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9466a86e_7c8196a8","line":188,"updated":"2021-07-15 13:22:53.000000000","message":"And changed the GET/LIST devices API with ``device_status`` to filter the devices.\n\nAs above, that you can addressed by follow up.","commit_id":"15b3652602c7ec23c1ad66686a973be16d3bbb9a"}]}