)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3c5cc1214c569754d1f52bcfcc6762d6d20fe769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b449ecd4_2a5e240e","updated":"2021-10-13 10:26:55.000000000","message":"rebase","commit_id":"f170f14bda2a2f7663d5ba85739189aea79db61e"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"141b6b83_c6e86fd8","updated":"2021-11-08 07:46:40.000000000","message":"lgtm overall, please check some questio inline","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"4d56268525b3c1812d48008a1f0c9676688828a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca53c425_e5309e12","updated":"2021-11-03 09:19:46.000000000","message":"overall is LGTM.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"f4aecc1947a682a3dde0ead74d16206006476e0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c92fdccb_841b572e","updated":"2021-11-29 08:57:07.000000000","message":"LGTM","commit_id":"bf9e153730ef27b6c36d70765d9f5b4de7bb917b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ac46959d4b2d8a49ac721e2129c49569e320a1d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"47c5522f_095c90b8","updated":"2021-11-30 06:00:39.000000000","message":"lgtm","commit_id":"bf9e153730ef27b6c36d70765d9f5b4de7bb917b"}],"specs/xena/approved/pmem-namespace-support.rst":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"14777a7a9d8ea24e2e8ed9aed5ba296a53278aec","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Cyborg Intel PMEM Driver Proposal"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/pmem-namespace-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to provide the initial design for Cyborg\u0027s Intel PMEM"},{"line_number":14,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"96aa346f_5462e92f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"updated":"2021-07-02 10:04:32.000000000","message":"this link is wrong.","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Cyborg Intel PMEM Driver Proposal"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/pmem-namespace-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to provide the initial design for Cyborg\u0027s Intel PMEM"},{"line_number":14,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"756f060c_c1e60193","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"in_reply_to":"96aa346f_5462e92f","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7199807f78e811fddc48e66025fd4e6eb89c1b88","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This spec will add a Intel PMEM driver for Cyborg to manage specific"},{"line_number":20,"context_line":"Intel PMEM  devices."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c7a06ba2_3221ce5c","line":20,"range":{"start_line":20,"start_character":11,"end_line":20,"end_character":12},"updated":"2021-07-08 06:25:39.000000000","message":"extra space","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This spec will add a Intel PMEM driver for Cyborg to manage specific"},{"line_number":20,"context_line":"Intel PMEM  devices."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e77fe704_7ad2e977","line":20,"range":{"start_line":20,"start_character":11,"end_line":20,"end_character":12},"in_reply_to":"c7a06ba2_3221ce5c","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7199807f78e811fddc48e66025fd4e6eb89c1b88","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":"* As an operator, I would like to use Cyborg agent starts or does resource"},{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a2b5cada_74d5e4c9","line":24,"range":{"start_line":24,"start_character":51,"end_line":24,"end_character":65},"updated":"2021-07-08 06:25:39.000000000","message":"typos?","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":"* As an operator, I would like to use Cyborg agent starts or does resource"},{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"24ec42f4_9fe428fb","line":24,"range":{"start_line":24,"start_character":51,"end_line":24,"end_character":65},"in_reply_to":"a2b5cada_74d5e4c9","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7199807f78e811fddc48e66025fd4e6eb89c1b88","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":"* As an operator, I would like to use Cyborg agent starts or does resource"},{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":28,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e8917764_5c303c6e","line":25,"range":{"start_line":25,"start_character":62,"end_line":25,"end_character":70},"updated":"2021-07-08 06:25:39.000000000","message":"provide","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":"* As an operator, I would like to use Cyborg agent starts or does resource"},{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":28,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device."}],"source_content_type":"text/x-rst","patch_set":1,"id":"25f78c0b_a181444b","line":25,"range":{"start_line":25,"start_character":62,"end_line":25,"end_character":70},"in_reply_to":"e8917764_5c303c6e","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7199807f78e811fddc48e66025fd4e6eb89c1b88","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":28,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As a user, I would like to boot up a VM with Intel PMEM Device attached in"},{"line_number":31,"context_line":"  order to accelerate compute ability. Cyborg should be able to manage this"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c16f0b7f_17f499cd","line":28,"range":{"start_line":28,"start_character":49,"end_line":28,"end_character":55},"updated":"2021-07-08 06:25:39.000000000","message":"Device ID?","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  checking periodically, the Cyborg Intel PMEM  driver should provider"},{"line_number":26,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":27,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":28,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As a user, I would like to boot up a VM with Intel PMEM Device attached in"},{"line_number":31,"context_line":"  order to accelerate compute ability. Cyborg should be able to manage this"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b50aba4_2a92f3da","line":28,"range":{"start_line":28,"start_character":49,"end_line":28,"end_character":55},"in_reply_to":"c16f0b7f_17f499cd","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7199807f78e811fddc48e66025fd4e6eb89c1b88","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In general, the goal is to develop a Intel PMEM Device driver that supports"},{"line_number":38,"context_line":"discover interfaces for Intel PMEM accelerator framework. The driver should"},{"line_number":39,"context_line":"include the ``discover()`` function that reports devices\u0027 raw info sample as"},{"line_number":40,"context_line":"following::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  ["},{"line_number":43,"context_line":"    {"},{"line_number":44,"context_line":"    \"vendor\": \"8086\","},{"line_number":45,"context_line":"    \"product\": \"ns200_0\","},{"line_number":46,"context_line":"    \"device\": \"dax0.0\""},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  ]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b138470b_61419ec8","line":48,"range":{"start_line":36,"start_character":0,"end_line":48,"end_character":3},"updated":"2021-07-08 06:25:39.000000000","message":"please add more details in this section, like:\n1. pmem device introduction \n2. how cyborg configure and use it \n3. what the rc and traits looks like\n4. which pmem work mode we plan to support\n5. do we support resize. live migration ops etc.","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In general, the goal is to develop a Intel PMEM Device driver that supports"},{"line_number":38,"context_line":"discover interfaces for Intel PMEM accelerator framework. The driver should"},{"line_number":39,"context_line":"include the ``discover()`` function that reports devices\u0027 raw info sample as"},{"line_number":40,"context_line":"following::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  ["},{"line_number":43,"context_line":"    {"},{"line_number":44,"context_line":"    \"vendor\": \"8086\","},{"line_number":45,"context_line":"    \"product\": \"ns200_0\","},{"line_number":46,"context_line":"    \"device\": \"dax0.0\""},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  ]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d45339f0_27945054","line":48,"range":{"start_line":36,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"b138470b_61419ec8","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"14777a7a9d8ea24e2e8ed9aed5ba296a53278aec","unresolved":true,"context_lines":[{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Intel PMEM driver will not touch Data model."},{"line_number":59,"context_line":"The Cyborg Agent can call Intel PMEM driver to update the database"},{"line_number":60,"context_line":"during the discover operations."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"59188730_12739392","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":44},"updated":"2021-07-02 10:04:32.000000000","message":"need add new type such as PMEM in devices and attach_handers tables.","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"c6720e50109b3a3dec82526125845bb73f44b3e1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Intel PMEM driver will not touch Data model."},{"line_number":59,"context_line":"The Cyborg Agent can call Intel PMEM driver to update the database"},{"line_number":60,"context_line":"during the discover operations."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9dba6f7f_b56c5b3b","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":44},"in_reply_to":"59188730_12739392","updated":"2021-07-15 08:28:51.000000000","message":"Done","commit_id":"9d1db67249f790d0da7a9349250228cc64b19074"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"da5f5bb7e98d12e49e9fc8b8c0acade082e2aab5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Cyborg Intel PMEM Driver Proposal"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/add-pmem-driver"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"2789999d_3da30be7","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":35},"updated":"2021-07-15 11:33:11.000000000","message":"delete this.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"da5f5bb7e98d12e49e9fc8b8c0acade082e2aab5","unresolved":true,"context_lines":[{"line_number":24,"context_line":"of the instance."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PMEM must be partitioned into PMEM namespaces [1]_ for applications to use."},{"line_number":27,"context_line":"This vPMEM feature only uses PMEM namespaces in devdax mode as QEMU vPMEM"},{"line_number":28,"context_line":"backends [2]_. If you want to dive into related notions, the document NVDIMM"},{"line_number":29,"context_line":"Linux kernel document [3]_ is recommended."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a5fa0ac_8e807023","line":27,"range":{"start_line":27,"start_character":63,"end_line":27,"end_character":67},"updated":"2021-07-15 11:33:11.000000000","message":"is it because qemu only support devdax mode?","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e42494babee76e8935a8c9481b69c7074eeb2a2b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"of the instance."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PMEM must be partitioned into PMEM namespaces [1]_ for applications to use."},{"line_number":27,"context_line":"This vPMEM feature only uses PMEM namespaces in devdax mode as QEMU vPMEM"},{"line_number":28,"context_line":"backends [2]_. If you want to dive into related notions, the document NVDIMM"},{"line_number":29,"context_line":"Linux kernel document [3]_ is recommended."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"714835f1_2a645885","line":27,"range":{"start_line":27,"start_character":63,"end_line":27,"end_character":67},"in_reply_to":"1a5fa0ac_8e807023","updated":"2021-07-16 00:11:33.000000000","message":"Yes, in OpenStack we just support AD/devdax mode.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"da5f5bb7e98d12e49e9fc8b8c0acade082e2aab5","unresolved":true,"context_lines":[{"line_number":86,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":87,"context_line":"   trait2:\"CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME\", the NAMESPACESNAME is"},{"line_number":88,"context_line":"   customed at creating PMEM_Namespace, like"},{"line_number":89,"context_line":"   \"ndctl create-namespace --mode\u003ddevdax --map\u003dmem --size\u003d10g --name ns10_0\","},{"line_number":90,"context_line":"   the ns10_0 is NAMESPACESNAME."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8681e2c0_df44627a","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":61},"updated":"2021-07-15 11:33:11.000000000","message":"we should support trait indicating the size of each memory. in majority case, user doesn\u0027t care about the namespace but they care about the capacity.\n\nplease explain more in this spec:\nhow to discover the capacity of each namespace and convert them into trait.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"61e933fd8a74aa83dafd98a4fcff54befe58caa3","unresolved":true,"context_lines":[{"line_number":86,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":87,"context_line":"   trait2:\"CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME\", the NAMESPACESNAME is"},{"line_number":88,"context_line":"   customed at creating PMEM_Namespace, like"},{"line_number":89,"context_line":"   \"ndctl create-namespace --mode\u003ddevdax --map\u003dmem --size\u003d10g --name ns10_0\","},{"line_number":90,"context_line":"   the ns10_0 is NAMESPACESNAME."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d439bcd9_4c291bf4","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":61},"in_reply_to":"8540cf62_3a69b2f7","updated":"2021-08-12 08:18:08.000000000","message":"xinran, this depends on how we schedule, by size or namespace.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"fea5ffe0ba69fd9c1973e027229cffaf355d4fde","unresolved":true,"context_lines":[{"line_number":86,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":87,"context_line":"   trait2:\"CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME\", the NAMESPACESNAME is"},{"line_number":88,"context_line":"   customed at creating PMEM_Namespace, like"},{"line_number":89,"context_line":"   \"ndctl create-namespace --mode\u003ddevdax --map\u003dmem --size\u003d10g --name ns10_0\","},{"line_number":90,"context_line":"   the ns10_0 is NAMESPACESNAME."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f519eb39_fec93ef9","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":61},"in_reply_to":"8681e2c0_df44627a","updated":"2021-07-16 02:38:08.000000000","message":"About how to create PMEM Namespace can reference this link:\n[1] https://docs.openstack.org/nova/latest/admin/virtual-persistent-memory.html#configure-pmem-namespaces-compute\n[2] https://pmem.io/ndctl/ndctl-create-namespace.html\n\nBefore cyborg discover the namespaces, they have been created on the server. All the namespaces  should create at first.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":87,"context_line":"   trait2:\"CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME\", the NAMESPACESNAME is"},{"line_number":88,"context_line":"   customed at creating PMEM_Namespace, like"},{"line_number":89,"context_line":"   \"ndctl create-namespace --mode\u003ddevdax --map\u003dmem --size\u003d10g --name ns10_0\","},{"line_number":90,"context_line":"   the ns10_0 is NAMESPACESNAME."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4f117c0e_26af8411","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":61},"in_reply_to":"d439bcd9_4c291bf4","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"ca025224de7de1bcba9dd287d70c073721512371","unresolved":true,"context_lines":[{"line_number":86,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":87,"context_line":"   trait2:\"CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME\", the NAMESPACESNAME is"},{"line_number":88,"context_line":"   customed at creating PMEM_Namespace, like"},{"line_number":89,"context_line":"   \"ndctl create-namespace --mode\u003ddevdax --map\u003dmem --size\u003d10g --name ns10_0\","},{"line_number":90,"context_line":"   the ns10_0 is NAMESPACESNAME."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8540cf62_3a69b2f7","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":61},"in_reply_to":"f519eb39_fec93ef9","updated":"2021-07-16 07:10:56.000000000","message":"the point is that we should add trait like CUSTOM_PMEM_10G as well, not simply use CUSTOM_PMEM_PRODUCT_ID_NAMESPACESNAME because end user do not care about namespace.","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"da5f5bb7e98d12e49e9fc8b8c0acade082e2aab5","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Data model impact"},{"line_number":98,"context_line":"-----------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Need add new type such as PMEM in devices and attach_handers tables."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"REST API impact"},{"line_number":103,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ca3ac7ac_e1eb6377","line":100,"range":{"start_line":100,"start_character":47,"end_line":100,"end_character":60},"updated":"2021-07-15 11:33:11.000000000","message":"attach_handle","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"da5f5bb7e98d12e49e9fc8b8c0acade082e2aab5","unresolved":true,"context_lines":[{"line_number":165,"context_line":"Documentation Impact"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Document Intel PMEM driver in Cyborg project."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"556ef756_f58e46be","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":45},"updated":"2021-07-15 11:33:11.000000000","message":"also add test report in cyborg wiki","commit_id":"4497e5318905c9964ab6e5f854ef8edf42621ff1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f00744493a4412aa5ee2a0e7011df457f081e4f7","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"   * - Release"},{"line_number":190,"context_line":"     - Description"},{"line_number":191,"context_line":"   * - Xena"},{"line_number":192,"context_line":"     - Introduced"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"0669198c_495e3f18","line":191,"range":{"start_line":191,"start_character":7,"end_line":191,"end_character":11},"updated":"2021-08-15 07:42:10.000000000","message":"Yoga","commit_id":"d19f7282e7681d3f3d2fb76eae57f758bc071675"}],"specs/yoga/approved/pmem-namespace-support.rst":[{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":true,"context_lines":[{"line_number":28,"context_line":"backends [2]_. If you want to dive into related notions, the document NVDIMM"},{"line_number":29,"context_line":"Linux kernel document [3]_ is recommended."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Starting in the 20.0.0 (Train) release, the virtual persistent memory (vPMEM)"},{"line_number":32,"context_line":"feature in Nova allows a deployment using the libvirt compute driver to provide"},{"line_number":33,"context_line":"vPMEMs for instances using physical persistent memory (PMEM) that can provide"},{"line_number":34,"context_line":"virtual devices [4]_."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0a54bf1f_aaba71be","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":21},"updated":"2021-11-08 07:46:40.000000000","message":"could you state the VM operation planed to support by cyborg side implementation, is there any diffenrence with what nova already supported?","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d3bf88c6b3459566d6e7b59cd9dd0593c2e19340","unresolved":true,"context_lines":[{"line_number":28,"context_line":"backends [2]_. If you want to dive into related notions, the document NVDIMM"},{"line_number":29,"context_line":"Linux kernel document [3]_ is recommended."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Starting in the 20.0.0 (Train) release, the virtual persistent memory (vPMEM)"},{"line_number":32,"context_line":"feature in Nova allows a deployment using the libvirt compute driver to provide"},{"line_number":33,"context_line":"vPMEMs for instances using physical persistent memory (PMEM) that can provide"},{"line_number":34,"context_line":"virtual devices [4]_."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"860aeba1_d5524909","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":21},"in_reply_to":"0a54bf1f_aaba71be","updated":"2021-11-16 08:00:49.000000000","message":"we donnot operate PMEM on cyborg side, there are no different supportions with nova now.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"backends [2]_. If you want to dive into related notions, the document NVDIMM"},{"line_number":29,"context_line":"Linux kernel document [3]_ is recommended."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Starting in the 20.0.0 (Train) release, the virtual persistent memory (vPMEM)"},{"line_number":32,"context_line":"feature in Nova allows a deployment using the libvirt compute driver to provide"},{"line_number":33,"context_line":"vPMEMs for instances using physical persistent memory (PMEM) that can provide"},{"line_number":34,"context_line":"virtual devices [4]_."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ebbe5679_bdbcde87","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":21},"in_reply_to":"860aeba1_d5524909","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"4d56268525b3c1812d48008a1f0c9676688828a5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"---------"},{"line_number":38,"context_line":"* As an operator, I would like to use Cyborg agent managing PMEM resource"},{"line_number":39,"context_line":"  and checking periodically, the Cyborg Intel PMEM  driver should provide"},{"line_number":40,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":41,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":42,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device ID."}],"source_content_type":"text/x-rst","patch_set":8,"id":"2f3d17e6_09f4d5c5","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":52},"updated":"2021-11-03 09:19:46.000000000","message":"reduandant space","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"---------"},{"line_number":38,"context_line":"* As an operator, I would like to use Cyborg agent managing PMEM resource"},{"line_number":39,"context_line":"  and checking periodically, the Cyborg Intel PMEM  driver should provide"},{"line_number":40,"context_line":"  ``discover()`` function to enumerate the list of the Intel PMEM devices,"},{"line_number":41,"context_line":"  and report the details of all available Intel PMEM accelerators on the"},{"line_number":42,"context_line":"  host, such as PID(Product id), VID(Vendor id), Device ID."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bec18122_072ea46a","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":52},"in_reply_to":"2f3d17e6_09f4d5c5","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Hardware     Driver objects       Placement data model"},{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"}],"source_content_type":"text/x-rst","patch_set":8,"id":"476bf0d4_eee148c7","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":19},"updated":"2021-11-08 07:46:40.000000000","message":"1?","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Hardware     Driver objects       Placement data model"},{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"}],"source_content_type":"text/x-rst","patch_set":8,"id":"4d63dd8d_ddd739e4","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":19},"in_reply_to":"403f926b_628967d5","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d3bf88c6b3459566d6e7b59cd9dd0593c2e19340","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Hardware     Driver objects       Placement data model"},{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"}],"source_content_type":"text/x-rst","patch_set":8,"id":"403f926b_628967d5","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":19},"in_reply_to":"476bf0d4_eee148c7","updated":"2021-11-16 08:00:49.000000000","message":"+1. yes, this should be 1 device for 1 PMEM.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":true,"context_lines":[{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"},{"line_number":75,"context_line":"     |               |                      |"},{"line_number":76,"context_line":"  n Namespace  n attach_handle    ---\u003e inventories(total:n)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dbf7db79_898fbfad","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":16},"updated":"2021-11-08 07:46:40.000000000","message":"1?","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1582309488042029e2d97c58169bff930516ffa4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"},{"line_number":75,"context_line":"     |               |                      |"},{"line_number":76,"context_line":"  n Namespace  n attach_handle    ---\u003e inventories(total:n)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d23f7fff_c3ad8aa8","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":16},"in_reply_to":"a1e1ad84_427168bc","updated":"2021-11-29 07:49:36.000000000","message":"+1. yes, this also should be 1 deployable for 1 pmem.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f780fe85287a2ae4dd96fb245d237db8f1fe86a5","unresolved":true,"context_lines":[{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"},{"line_number":75,"context_line":"     |               |                      |"},{"line_number":76,"context_line":"  n Namespace  n attach_handle    ---\u003e inventories(total:n)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa16fef4_ec89e216","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":16},"in_reply_to":"b00a75b0_788aa80e","updated":"2021-11-19 06:28:32.000000000","message":"right, cyborg report is the namespace too, one PMEM has one or more namespace, so *n* is right.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d3bf88c6b3459566d6e7b59cd9dd0593c2e19340","unresolved":true,"context_lines":[{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"},{"line_number":75,"context_line":"     |               |                      |"},{"line_number":76,"context_line":"  n Namespace  n attach_handle    ---\u003e inventories(total:n)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b00a75b0_788aa80e","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":16},"in_reply_to":"dbf7db79_898fbfad","updated":"2021-11-16 08:00:49.000000000","message":"as one PMEM has n Namespace and every namespace has different attributes, we should report n depoloyables for one PMEM.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     |               |                      |"},{"line_number":71,"context_line":"  1 PMEM         n device                    |"},{"line_number":72,"context_line":"     |               |                      |"},{"line_number":73,"context_line":"     |         n deployable       ---\u003e resource_provider"},{"line_number":74,"context_line":"     |               |            ---\u003e parent resource_provider: compute node"},{"line_number":75,"context_line":"     |               |                      |"},{"line_number":76,"context_line":"  n Namespace  n attach_handle    ---\u003e inventories(total:n)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a1e1ad84_427168bc","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":16},"in_reply_to":"fa16fef4_ec89e216","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":true,"context_lines":[{"line_number":78,"context_line":"3. Need add the \"enable_driver\u003dintel_pmem_driver\" in the Cyborg Agent"},{"line_number":79,"context_line":"   configure file."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"4. Need add the \"pmem_namespaces\u003d$LABEL:$NSNAME|$NSNAME,$LABEL:$NSNAME|$NSNAME\""},{"line_number":82,"context_line":"   in the Cyborg Agent configure file as:"},{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ce8d37ac_d16956df","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":48},"updated":"2021-11-08 07:46:40.000000000","message":"do we need a new section in cyborg.conf","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"3. Need add the \"enable_driver\u003dintel_pmem_driver\" in the Cyborg Agent"},{"line_number":79,"context_line":"   configure file."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"4. Need add the \"pmem_namespaces\u003d$LABEL:$NSNAME|$NSNAME,$LABEL:$NSNAME|$NSNAME\""},{"line_number":82,"context_line":"   in the Cyborg Agent configure file as:"},{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1d79b8ae_7cdc1c2b","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":48},"in_reply_to":"8a9d6a16_21180eae","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f780fe85287a2ae4dd96fb245d237db8f1fe86a5","unresolved":true,"context_lines":[{"line_number":78,"context_line":"3. Need add the \"enable_driver\u003dintel_pmem_driver\" in the Cyborg Agent"},{"line_number":79,"context_line":"   configure file."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"4. Need add the \"pmem_namespaces\u003d$LABEL:$NSNAME|$NSNAME,$LABEL:$NSNAME|$NSNAME\""},{"line_number":82,"context_line":"   in the Cyborg Agent configure file as:"},{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"8a9d6a16_21180eae","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":48},"in_reply_to":"925a9a5e_3b2df7ad","updated":"2021-11-19 06:28:32.000000000","message":"IMO, we shuold distinguish with nova, the user should know this was reported and managed by cyborg.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d3bf88c6b3459566d6e7b59cd9dd0593c2e19340","unresolved":true,"context_lines":[{"line_number":78,"context_line":"3. Need add the \"enable_driver\u003dintel_pmem_driver\" in the Cyborg Agent"},{"line_number":79,"context_line":"   configure file."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"4. Need add the \"pmem_namespaces\u003d$LABEL:$NSNAME|$NSNAME,$LABEL:$NSNAME|$NSNAME\""},{"line_number":82,"context_line":"   in the Cyborg Agent configure file as:"},{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"925a9a5e_3b2df7ad","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":48},"in_reply_to":"ce8d37ac_d16956df","updated":"2021-11-16 08:00:49.000000000","message":"we can put it in the devices group.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"4d56268525b3c1812d48008a1f0c9676688828a5","unresolved":true,"context_lines":[{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7872a0ac_74cf68ca","line":86,"range":{"start_line":86,"start_character":5,"end_line":86,"end_character":23},"updated":"2021-11-03 09:19:46.000000000","message":"CUSTOM_PMEM_NAMESPACE_$LABEL","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f780fe85287a2ae4dd96fb245d237db8f1fe86a5","unresolved":true,"context_lines":[{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"824bc848_5daba93e","line":86,"range":{"start_line":86,"start_character":5,"end_line":86,"end_character":23},"in_reply_to":"7872a0ac_74cf68ca","updated":"2021-11-19 06:28:32.000000000","message":"+1","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   \"pmem_namespaces \u003d 6GB:ns0|ns1|ns2,LARGE:ns3\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"5. Resource class follows standard resources classes as:"},{"line_number":86,"context_line":"    \"CUSTOM_PMEM_INTEL_$LABEL\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"84d0e22e_26eef05b","line":86,"range":{"start_line":86,"start_character":5,"end_line":86,"end_character":23},"in_reply_to":"824bc848_5daba93e","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"8128ba1698568c3d70c4c33a5705bafd9bd19596","unresolved":true,"context_lines":[{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"},{"line_number":90,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":91,"context_line":"   trait2:\"CUSTOM_PMEM_$LABEL\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"7. Before cyborg discover the namespaces, they should be created. How to create"}],"source_content_type":"text/x-rst","patch_set":8,"id":"96430c78_0830f05f","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":30},"updated":"2021-11-08 07:46:40.000000000","message":"this is duplicate with RC, I think this can be removed.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f780fe85287a2ae4dd96fb245d237db8f1fe86a5","unresolved":true,"context_lines":[{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"},{"line_number":90,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":91,"context_line":"   trait2:\"CUSTOM_PMEM_$LABEL\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"7. Before cyborg discover the namespaces, they should be created. How to create"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a1c871f2_2dfef128","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":30},"in_reply_to":"5fb0eb2d_5f9928bf","updated":"2021-11-19 06:28:32.000000000","message":"This should keep the same with line86.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d3bf88c6b3459566d6e7b59cd9dd0593c2e19340","unresolved":true,"context_lines":[{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"},{"line_number":90,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":91,"context_line":"   trait2:\"CUSTOM_PMEM_$LABEL\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"7. Before cyborg discover the namespaces, they should be created. How to create"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fb0eb2d_5f9928bf","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":30},"in_reply_to":"96430c78_0830f05f","updated":"2021-11-16 08:00:49.000000000","message":"we cannot remove, this trait is for schedule.","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"3580ee64d483aa4ddc0f05e11314f6612adb902a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"6. Traits follows the placement custom trait format. In the Cyborg driver, it"},{"line_number":89,"context_line":"   will report two traits for PMEM accelerator using the format below:"},{"line_number":90,"context_line":"   trait1:\"CUSTOM_PMEM_INTEL\""},{"line_number":91,"context_line":"   trait2:\"CUSTOM_PMEM_$LABEL\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"7. Before cyborg discover the namespaces, they should be created. How to create"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f7936d6f_f6c80788","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":30},"in_reply_to":"a1c871f2_2dfef128","updated":"2021-11-29 06:46:21.000000000","message":"Done","commit_id":"ff2b7e215997f05d5a19540583dcf37e7cb8c3a2"}]}