)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"2324e7ba6ec1099a19608155f335bfd6419a67e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"128feab2_2ff93ec3","updated":"2021-11-01 07:57:11.000000000","message":"LGTM, thanks.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c80af285ec50df71d89074e1b1f619982c754c64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d00e487d_b8ec023d","updated":"2021-11-03 08:48:47.000000000","message":"over all lgtm, but there is a mistake need to fix.\n\nPlease keep the topic as bp/show-resource-with-name  that we can trace the series of this feature changes.","commit_id":"11a597a71d73b979b7c056185f677249a90cf342"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b2db9b12dbced7c0171201f872657ded02a044ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc4eb28a_2f4f8123","updated":"2021-11-04 10:07:18.000000000","message":"LGTM","commit_id":"d28b148cf5f68ba1a52e62fae6e19bbdc7591407"}],"specs/yoga/approved/show-dp-by-name.rst":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Show device_profile by name"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-resource-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is already supported. This spec adds the support that showing a"}],"source_content_type":"text/x-rst","patch_set":5,"id":"47920c44_5fa06cfb","line":11,"range":{"start_line":11,"start_character":61,"end_line":11,"end_character":69},"updated":"2021-10-29 08:17:52.000000000","message":"please change it to device-profile","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Show device_profile by name"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-resource-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is already supported. This spec adds the support that showing a"}],"source_content_type":"text/x-rst","patch_set":5,"id":"72125922_519ab97c","line":11,"range":{"start_line":11,"start_character":61,"end_line":11,"end_character":69},"in_reply_to":"47920c44_5fa06cfb","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-resource-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is already supported. This spec adds the support that showing a"},{"line_number":15,"context_line":"device_profile by it\u0027s name in \u0027python-cyborgclient\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ed7fb9dc_d66687ef","line":14,"range":{"start_line":13,"start_character":57,"end_line":14,"end_character":20},"updated":"2021-10-29 08:17:52.000000000","message":"already support get dp by name?","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-resource-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is already supported. This spec adds the support that showing a"},{"line_number":15,"context_line":"device_profile by it\u0027s name in \u0027python-cyborgclient\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a6422dfa_bc5690f4","line":14,"range":{"start_line":13,"start_character":57,"end_line":14,"end_character":20},"in_reply_to":"ed7fb9dc_d66687ef","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As an administrator or regular user, i want to get the details of the device"},{"line_number":31,"context_line":"  profile by the name."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"200d3501_4583e85c","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":33},"updated":"2021-10-29 08:17:52.000000000","message":"end","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As an administrator or regular user, i want to get the details of the device"},{"line_number":31,"context_line":"  profile by the name."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"695d72f0_0f72793e","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":33},"in_reply_to":"200d3501_4583e85c","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":36,"context_line":"In \u0027python-cyborgclient\u0027, extend"},{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In \u0027cyborg\u0027, change the DP GET api to support to accepting the \u0027name\u0027 as the"},{"line_number":40,"context_line":"input. Add one filter by name for DP LIST api."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"66e15d19_8d80e4fa","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":48},"updated":"2021-10-29 08:17:52.000000000","message":"nit","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":36,"context_line":"In \u0027python-cyborgclient\u0027, extend"},{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In \u0027cyborg\u0027, change the DP GET api to support to accepting the \u0027name\u0027 as the"},{"line_number":40,"context_line":"input. Add one filter by name for DP LIST api."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"b0329e21_65312ba7","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":48},"in_reply_to":"66e15d19_8d80e4fa","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In \u0027cyborg\u0027, change the DP GET api to support to accepting the \u0027name\u0027 as the"},{"line_number":40,"context_line":"input. Add one filter by name for DP LIST api."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"cf5eaa97_c3b42ab2","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":45},"updated":"2021-10-29 08:17:52.000000000","message":"LIST api alreay support","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In \u0027cyborg\u0027, change the DP GET api to support to accepting the \u0027name\u0027 as the"},{"line_number":40,"context_line":"input. Add one filter by name for DP LIST api."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"51fbdd82_40280384","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":45},"in_reply_to":"cf5eaa97_c3b42ab2","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":59,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":60,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"List Device Profile API"},{"line_number":63,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":64,"context_line":"GET /v2/device_profiles"},{"line_number":65,"context_line":"Add \u0027name\u0027 as query parameter."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security impact"},{"line_number":68,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ca9a7932_052f882c","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":30},"updated":"2021-10-29 08:17:52.000000000","message":"neednot","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":59,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":60,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"List Device Profile API"},{"line_number":63,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":64,"context_line":"GET /v2/device_profiles"},{"line_number":65,"context_line":"Add \u0027name\u0027 as query parameter."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security impact"},{"line_number":68,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8ea054d7_b7445e4b","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":30},"in_reply_to":"ca9a7932_052f882c","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"081ead3de8469deab7666ac325b88e794027bdd3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"----------"},{"line_number":102,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":103,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":104,"context_line":"* Add \u0027name\u0027 query parameter for listing device profiles"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ebbd2fd_4c27aa9a","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":56},"updated":"2021-10-29 08:17:52.000000000","message":"neednot","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"532e971db1b72bca2c379cea42aaa05ae106e387","unresolved":false,"context_lines":[{"line_number":101,"context_line":"----------"},{"line_number":102,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":103,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":104,"context_line":"* Add \u0027name\u0027 query parameter for listing device profiles"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ac37a3d1_0e0cc9b6","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":56},"in_reply_to":"9ebbd2fd_4c27aa9a","updated":"2021-11-01 07:48:44.000000000","message":"Done","commit_id":"a4166095a6e2b6b8dd66a672d8800be7cce7bcd6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-device-profile-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is not supported. This spec adds the support that showing a device_profile by"},{"line_number":15,"context_line":"it\u0027s name in \u0027python-cyborgclient\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"024e2891_1e5bc15e","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":49},"updated":"2021-11-03 02:18:20.000000000","message":"I would say: This spec will support getting a device profile by name.\n\nUsing CLI by python-cyborgclient just a way of operation, you can just mention it in Proposed change section.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/show-device-profile-with-name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nowadays, A device_profile can only be got by it\u0027s UUID, but the field \u0027name\u0027"},{"line_number":14,"context_line":"is not supported. This spec adds the support that showing a device_profile by"},{"line_number":15,"context_line":"it\u0027s name in \u0027python-cyborgclient\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ecd94e4e_0179670c","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":49},"in_reply_to":"024e2891_1e5bc15e","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":21,"context_line":"When using `openstack accelerator device profile show` command to getting"},{"line_number":22,"context_line":"one device profile, the \u0027\u003cuuid\u003e\u0027 of the device profile is only accepted."},{"line_number":23,"context_line":"The device profile has \u0027name\u0027 field that can display in humanable manner."},{"line_number":24,"context_line":"So end-users prefer to use name instead of hard-to-remember UUID that"},{"line_number":25,"context_line":"this may reduce the need to list first and then use UUID to query details."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"efda3874_0328ca76","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":2},"updated":"2021-11-03 02:18:20.000000000","message":"s/So/The/","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"When using `openstack accelerator device profile show` command to getting"},{"line_number":22,"context_line":"one device profile, the \u0027\u003cuuid\u003e\u0027 of the device profile is only accepted."},{"line_number":23,"context_line":"The device profile has \u0027name\u0027 field that can display in humanable manner."},{"line_number":24,"context_line":"So end-users prefer to use name instead of hard-to-remember UUID that"},{"line_number":25,"context_line":"this may reduce the need to list first and then use UUID to query details."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"736a5cc4_aa85f093","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":2},"in_reply_to":"efda3874_0328ca76","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":21,"context_line":"When using `openstack accelerator device profile show` command to getting"},{"line_number":22,"context_line":"one device profile, the \u0027\u003cuuid\u003e\u0027 of the device profile is only accepted."},{"line_number":23,"context_line":"The device profile has \u0027name\u0027 field that can display in humanable manner."},{"line_number":24,"context_line":"So end-users prefer to use name instead of hard-to-remember UUID that"},{"line_number":25,"context_line":"this may reduce the need to list first and then use UUID to query details."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d4c18694_b33cd7e4","line":26,"range":{"start_line":24,"start_character":65,"end_line":26,"end_character":0},"updated":"2021-11-03 02:18:20.000000000","message":"You can say directly: ..., by this way you can get the device profile details directly instead of searching its uuid first.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"When using `openstack accelerator device profile show` command to getting"},{"line_number":22,"context_line":"one device profile, the \u0027\u003cuuid\u003e\u0027 of the device profile is only accepted."},{"line_number":23,"context_line":"The device profile has \u0027name\u0027 field that can display in humanable manner."},{"line_number":24,"context_line":"So end-users prefer to use name instead of hard-to-remember UUID that"},{"line_number":25,"context_line":"this may reduce the need to list first and then use UUID to query details."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"b321eb9f_b42481bc","line":26,"range":{"start_line":24,"start_character":65,"end_line":26,"end_character":0},"in_reply_to":"d4c18694_b33cd7e4","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As an administrator or end user, i want to get the details of the device"},{"line_number":31,"context_line":"  profile by the name."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a885db0d_184fff41","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":17},"updated":"2021-11-03 02:18:20.000000000","message":"s/the/its","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* As an administrator or end user, i want to get the details of the device"},{"line_number":31,"context_line":"  profile by the name."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a8826217_39549abf","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":17},"in_reply_to":"a885db0d_184fff41","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"In \u0027python-cyborgclient\u0027, extend"},{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"22e6a392_af4c01a6","line":35,"updated":"2021-11-03 02:18:20.000000000","message":"The mainly change is the `Get One Device Profile` API, after you completed the API then to change the python-cyborgclient with `openstack accelerator device profile show`, to support getting one device profile details by name.\n\nIntroduce a microverison for `Get One Device Profile` API should decribe here too.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"In \u0027python-cyborgclient\u0027, extend"},{"line_number":37,"context_line":"\u0027cyborgclient.osc.v2.device_profile.ShowDeviceProfile\u0027 to add support for name."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bb086e90_20d03632","line":35,"in_reply_to":"22e6a392_af4c01a6","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":58,"context_line":"^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":59,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":60,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"78e8006a_bd4e3337","line":61,"updated":"2021-11-03 02:18:20.000000000","message":"Please add the response body of this changed, although the response body not changed, we also need to show it.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":59,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":60,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"be2060be_b2aba1a2","line":61,"in_reply_to":"78e8006a_bd4e3337","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":96,"context_line":"Work Items"},{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":99,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b4dbe1bb_75def495","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":53},"updated":"2021-11-03 02:18:20.000000000","message":"It\u0027s the fist step.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Work Items"},{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":99,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"32e9faa8_62ad806d","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":53},"in_reply_to":"b4dbe1bb_75def495","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":99,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6d9b2448_e65e19f4","line":100,"updated":"2021-11-03 02:18:20.000000000","message":"* Add related unit tests to cover your changes.","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":"* Extend \u0027python-cyborgclient\u0027 to support \u0027name\u0027"},{"line_number":99,"context_line":"* Change the device profile get api to support \u0027name\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8d8cf9c6_cec5e069","line":100,"in_reply_to":"6d9b2448_e65e19f4","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7b13115bcc4700516396cebc3d143aaff99954","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":"Change the \u0027api-ref/source/device_profile.inc\u0027 to using the \u0027name\u0027 as one"},{"line_number":115,"context_line":"input parameter."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"424e07ce_3b651377","line":116,"updated":"2021-11-03 02:18:20.000000000","message":"And you also need to modify the description of the *device_profile_name_or_id*","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"4ee1f13f4e23e26b94ce4f940bf2397db053ada2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":"Change the \u0027api-ref/source/device_profile.inc\u0027 to using the \u0027name\u0027 as one"},{"line_number":115,"context_line":"input parameter."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"718d24e9_7d906c34","line":116,"in_reply_to":"424e07ce_3b651377","updated":"2021-11-03 07:49:37.000000000","message":"Done","commit_id":"a4663358611f6cf6d288efe844eee61e4734dd6f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c80af285ec50df71d89074e1b1f619982c754c64","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Get Device Profile API"},{"line_number":57,"context_line":"^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":58,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":59,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code-block::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f95543f5_7e3ca469","line":58,"range":{"start_line":58,"start_character":25,"end_line":58,"end_character":39},"updated":"2021-11-03 08:48:47.000000000","message":"device_profile_name_or_uuid","commit_id":"11a597a71d73b979b7c056185f677249a90cf342"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"7530bc8899055963375fddd206882c332c52df1d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Get Device Profile API"},{"line_number":57,"context_line":"^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":58,"context_line":"GET /v2/device_profiles/{device_profile}"},{"line_number":59,"context_line":"The \u0027device_profile\u0027 should be uuid or name, the response has not changed."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code-block::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1afd2a22_6290faab","line":58,"range":{"start_line":58,"start_character":25,"end_line":58,"end_character":39},"in_reply_to":"f95543f5_7e3ca469","updated":"2021-11-03 09:26:26.000000000","message":"Done","commit_id":"11a597a71d73b979b7c056185f677249a90cf342"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b2db9b12dbced7c0171201f872657ded02a044ec","unresolved":true,"context_lines":[{"line_number":158,"context_line":"     - Description"},{"line_number":159,"context_line":"   * - Yoga"},{"line_number":160,"context_line":"     - Introduced"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"58f635d2_af2b56cd","line":161,"updated":"2021-11-04 10:07:18.000000000","message":"nit: redundant two blank line.","commit_id":"d28b148cf5f68ba1a52e62fae6e19bbdc7591407"}]}
