)]}'
{"specs/2026.2/approved/generic-mdev-driver.rst":[{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"5d1619a9_2fa56a56","line":1,"updated":"2026-03-26 17:46:10.000000000","message":"The spec is directly placed in the \u0027approved\u0027 directory without a prior review cycle in an \u0027approved\u0027 workflow, which is the expected process per the repository structure.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Confirming the review process was followed ensures governance compliance for the cyborg-specs repository.\n\n**Recommendation**:\nVerify that this spec has gone through the appropriate review process (e.g., IRC or PTG discussion, blueprint approval) before landing in the approved directory. If this is patchset 1, consider whether the spec should start in a review state.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"1c85b086_75004fde","line":37,"updated":"2026-03-26 17:46:10.000000000","message":"The spec would benefit from an ASCII data flow diagram showing how the generic mdev driver, shared utilities module, sysfs, and Cyborg conductor interact, similar to the diagram in vgpu-driver-proposal.rst.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: An ASCII diagram would help reviewers quickly understand the architecture and data flow, especially the relationship between the shared utilities, the generic driver, and the refactored GPU driver.\n\n**Recommendation**:\nAdd an ASCII diagram in the \u0027Proposed change\u0027 section showing: sysfs -\u003e mdev utils -\u003e generic mdev driver / GPU driver -\u003e driver objects -\u003e conductor -\u003e placement. The vgpu-driver-proposal.rst provides a good reference for the expected style.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"684951ee_4a1f6091","line":67,"updated":"2026-03-26 17:46:10.000000000","message":"The spec proposes a new [mdev] configuration section but does not discuss driver coexistence. When the generic mdev driver is enabled alongside the existing GPU driver on a host, both could discover and report the same mdev-capable devices, leading to duplicate inventory in Placement.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: If both drivers report the same parent devices, Placement would see duplicate resource providers and inventory, causing scheduling confusion or resource over-allocation.\n\n**Suggestion**:\nAdd a note in \u0027Other deployer impact\u0027 or \u0027Proposed change\u0027 addressing driver coexistence: whether the generic driver should be disabled on hosts running the GPU driver, whether defaults prevent overlap, or whether a deduplication mechanism exists.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"d63a81ab_2f66e78d","line":199,"updated":"2026-03-26 17:46:10.000000000","message":"The Testing section lacks detail on how GPU driver refactoring will be validated. The work item says \u0027Update the agent manager and existing GPU driver tests\u0027 but does not describe what specifically will be tested to ensure the refactored GPU driver remains functionally equivalent.\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Insufficient testing description could lead to GPU driver regressions going undetected during the refactoring, since the GPU driver handles production vGPU workloads.\n\n**Priority**: Before merge\n**Why This Matters**: The GPU driver refactor is the highest-risk work item in this spec. Without clear testing criteria, reviewers and implementers may have different expectations about what \u0027update existing GPU driver tests\u0027 means, potentially leading to regressions in production vGPU management.\n\n**Recommendation**:\nExpand the Testing section to explicitly list: (1) which existing GPU driver tests will be updated or added, (2) what functional parity tests will ensure the refactored GPU driver produces identical results, (3) whether integration tests will validate GPU driver behavior with the shared utilities module.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"8ca0a041_3d8ecb32","line":216,"updated":"2026-03-26 17:46:10.000000000","message":"The Tempest testing description mentions sample drivers but does not enumerate specific test scenarios or edge cases that will be covered.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Specific test scenarios would help reviewers evaluate coverage adequacy and ensure important edge cases are considered.\n\n**Recommendation**:\nList 3-5 specific tempest test scenarios, e.g.: (1) discover mdev types with mtty/mdpy sample drivers, (2) verify PCI address filtering excludes unexpected devices, (3) verify mdev type name filtering, (4) verify create/remove lifecycle.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"291324b4_3cc23d22","line":232,"updated":"2026-03-26 17:46:10.000000000","message":"The References section mixes bullet-list references with a footnote-style reference ([1]), creating inconsistent citation formatting.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Inconsistent reference formatting reduces readability. Other specs in this repository (e.g., vgpu-driver-proposal.rst) use footnote syntax consistently.\n\n**Suggestion**:\nConvert all references to use RST footnote syntax (\u0027.. [N] URL\u0027) consistently, matching the convention established by the vgpu-driver-proposal.rst and the existing [1] reference.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"d5169a0029ec45a1a2847aa51dfadab0","url":"https://zuul.teim.app/t/main/buildset/d5169a0029ec45a1a2847aa51dfadab0","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a5efa9c8e81631933c7dfc4e0f7d931b897d84a8","patch_set":1,"id":"ccb4c431_8ed920be","line":235,"updated":"2026-03-26 17:46:10.000000000","message":"Line 235 exceeds the 79-column line length limit specified in the project template. The URL reference is 103 characters wide.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Violates the project template instruction to wrap text at 79 columns. May fail automated line-length checks if configured.\n\n**Suggestion**:\nBreak the reference into a named RST hyperlink target with the full URL on a separate line or use an inline reference that keeps the line under 79 characters.","commit_id":"83d129f572c88d150505b11a585426e61ce8d578"},{"robot_id":"zuul","robot_run_id":"477dfd4a99534168b680e73e1c1bb113","url":"https://zuul.teim.app/t/main/buildset/477dfd4a99534168b680e73e1c1bb113","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"59d7258a1bb54ac142d998d555c4a03b1fff8373","patch_set":2,"id":"ae4259a0_0a95b9e2","line":43,"updated":"2026-04-13 17:06:58.000000000","message":"Typo on line 43: \u0027hadle\u0027 should be \u0027handle\u0027. The sentence reads \u0027The proposed driver will not hadle creation nor deletion of mdevs\u0027 which is a visible error in the rendered spec.\n\n**Severity**: WARNING | **Confidence**: 1.0\n\n**Impact**: Reduces spec readability and appears unprofessional in the rendered documentation. A simple but distracting typo in a key paragraph.\n\n**Suggestion**:\nChange \u0027hadle\u0027 to \u0027handle\u0027 on line 43.","commit_id":"4da4ae10dfb0ed7d84dfb43c4a8a83922b713f93"},{"robot_id":"zuul","robot_run_id":"477dfd4a99534168b680e73e1c1bb113","url":"https://zuul.teim.app/t/main/buildset/477dfd4a99534168b680e73e1c1bb113","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"59d7258a1bb54ac142d998d555c4a03b1fff8373","patch_set":2,"id":"c8793d0f_a97c187f","line":46,"updated":"2026-04-13 17:06:58.000000000","message":"The spec describes a complex object model (DriverDevice -\u003e DriverDeployable -\u003e DriverAttachHandle) and its mapping to Placement resource providers, but lacks an ASCII diagram. The existing vgpu-driver-proposal.rst includes a clear ASCII diagram for its similar object model.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: An ASCII diagram would make the driver object model and Placement mapping immediately clear to reviewers, matching the standard set by the existing vgpu-driver-proposal spec.\n\n**Recommendation**:\nAdd an ASCII diagram after the paragraph describing driver objects (around line 56), similar to the one in specs/2023.1/implemented/vgpu-driver-proposal.rst lines 66-76. Show the Hardware -\u003e Driver objects -\u003e Placement data model mapping.","commit_id":"4da4ae10dfb0ed7d84dfb43c4a8a83922b713f93"},{"robot_id":"zuul","robot_run_id":"477dfd4a99534168b680e73e1c1bb113","url":"https://zuul.teim.app/t/main/buildset/477dfd4a99534168b680e73e1c1bb113","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"59d7258a1bb54ac142d998d555c4a03b1fff8373","patch_set":2,"id":"be1308a3_f91aa24d","line":58,"updated":"2026-04-13 17:06:58.000000000","message":"The spec says resource class names use the format CUSTOM_MDEV_\u003cTYPE_NAME\u003e with the example mtty-2 -\u003e CUSTOM_MDEV_MTTY_2, but does not explicitly state the normalization rules (hyphens to underscores, uppercase). Placement custom resource classes only allow [A-Z0-9_].\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Explicit normalization rules prevent ambiguity for implementers and reviewers, especially for mdev type names with unusual characters.\n\n**Recommendation**:\nAdd a sentence clarifying the transformation: e.g., \u0027The type name is normalized by converting hyphens to underscores and uppercasing all alphabetic characters to produce a valid Placement custom resource class name.\u0027","commit_id":"4da4ae10dfb0ed7d84dfb43c4a8a83922b713f93"},{"robot_id":"zuul","robot_run_id":"477dfd4a99534168b680e73e1c1bb113","url":"https://zuul.teim.app/t/main/buildset/477dfd4a99534168b680e73e1c1bb113","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"59d7258a1bb54ac142d998d555c4a03b1fff8373","patch_set":2,"id":"e7b8fe6e_c23b056a","line":81,"updated":"2026-04-13 17:06:58.000000000","message":"The spec warns that operators must not enable both the generic mdev driver and a vendor-specific driver for the same parent device, but does not specify whether Cyborg should detect and prevent this at runtime.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Adding a startup validation check would prevent accidental double-reporting to Placement, which could cause scheduling errors that are hard to debug.\n\n**Recommendation**:\nConsider adding a sentence such as: \u0027The agent should log a warning at startup if it detects overlapping PCI addresses between the generic mdev driver and other enabled drivers.\u0027 or note this as a follow-up consideration.","commit_id":"4da4ae10dfb0ed7d84dfb43c4a8a83922b713f93"}]}