)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d1b8e24ccfe8f5770617f709e7188f88c51c9616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4605272_0b4d6332","updated":"2026-06-30 08:55:18.000000000","message":"I have query: does stable branch job needs to install tempest from master ?","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b60d3c0f75c2c4a57337775082a1233944eb325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58c8f86d_3804f30f","updated":"2026-06-22 08:36:03.000000000","message":"teim-ci: auto","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57f3b9680e11e8888a28220978dd3090ecf99764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b98cabc1_03d8cb6c","updated":"2026-06-22 23:46:22.000000000","message":"teim-ci: auto","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f2ede5aa187038bdc17821117e29c6efc5b26bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"539232cf_404ce090","in_reply_to":"96d167df_9d39b7d2","updated":"2026-06-30 12:21:42.000000000","message":"Done","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2a74786351e1b42282af122a47149524613d527a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96d167df_9d39b7d2","in_reply_to":"b4605272_0b4d6332","updated":"2026-06-30 12:17:26.000000000","message":"yes all stable brnaches use master tempest until they become unmaintied\nthat is the only time tempest is pinned out side fo caping the veerion if we are braking compatiablity by dropoing a python veriosn or similar.","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"}],"cyborg_tempest_plugin/services/cyborg_rest_client.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d1b8e24ccfe8f5770617f709e7188f88c51c9616","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    def get_headers(self, accept_type\u003dNone, send_type\u003dNone):"},{"line_number":38,"context_line":"        headers \u003d super(CyborgRestClient, self).get_headers("},{"line_number":39,"context_line":"            accept_type\u003daccept_type, send_type\u003dsend_type)"},{"line_number":40,"context_line":"        if self.service_token:"},{"line_number":41,"context_line":"            headers[\u0027X-Service-Token\u0027] \u003d self.service_token"},{"line_number":42,"context_line":"        return headers"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _response_helper(self, resp, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"74f625c0_94a1ec2b","side":"PARENT","line":41,"range":{"start_line":40,"start_character":8,"end_line":41,"end_character":59},"updated":"2026-06-30 08:55:18.000000000","message":"Yes, get_headers() is added in tempest in earlier verson and service token was\nlanded in tempest 46.3.0 https://github.com/openstack/tempest/commit/6499898b74f37d9c125c4a07be20919bba3633cc\n\nMake sense to bump the tempest version to 46.3.0\n\non cyborg-tempest-plugin side, we run stable/2025.1 job and we run install tempest from master \nhttps://bbb05f1419ea95dc5538-e7df3105f5276ae0c433b3674c800227.ssl.cf5.rackcdn.com/openstack/cec7a22ab69842908eb557cca89497b6/job-output.txt\n```\ngit+file:///dev/null@1a502cabe95e31b87b74fcabe8c343a4458da3a8#egg\u003dtempest\n```\npointing to https://github.com/openstack/tempest/commit/1a502cabe95e31b87b74fcabe8c343a4458da3a8 (last week commit )\n\n@smooney@redhat.com, Just checking here, Does stable branch jobs needs to install tempest from master?","commit_id":"c8d945f5e8efe721ed3aa54ddaa0510649bdf8f9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f2ede5aa187038bdc17821117e29c6efc5b26bc8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def get_headers(self, accept_type\u003dNone, send_type\u003dNone):"},{"line_number":38,"context_line":"        headers \u003d super(CyborgRestClient, self).get_headers("},{"line_number":39,"context_line":"            accept_type\u003daccept_type, send_type\u003dsend_type)"},{"line_number":40,"context_line":"        if self.service_token:"},{"line_number":41,"context_line":"            headers[\u0027X-Service-Token\u0027] \u003d self.service_token"},{"line_number":42,"context_line":"        return headers"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _response_helper(self, resp, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d3ed574_c6daa162","side":"PARENT","line":41,"range":{"start_line":40,"start_character":8,"end_line":41,"end_character":59},"in_reply_to":"07b72a3b_f0091b5d","updated":"2026-06-30 12:21:42.000000000","message":"Acknowledged","commit_id":"c8d945f5e8efe721ed3aa54ddaa0510649bdf8f9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2a74786351e1b42282af122a47149524613d527a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    def get_headers(self, accept_type\u003dNone, send_type\u003dNone):"},{"line_number":38,"context_line":"        headers \u003d super(CyborgRestClient, self).get_headers("},{"line_number":39,"context_line":"            accept_type\u003daccept_type, send_type\u003dsend_type)"},{"line_number":40,"context_line":"        if self.service_token:"},{"line_number":41,"context_line":"            headers[\u0027X-Service-Token\u0027] \u003d self.service_token"},{"line_number":42,"context_line":"        return headers"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _response_helper(self, resp, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"07b72a3b_f0091b5d","side":"PARENT","line":41,"range":{"start_line":40,"start_character":8,"end_line":41,"end_character":59},"in_reply_to":"74f625c0_94a1ec2b","updated":"2026-06-30 12:17:26.000000000","message":"yes tempest is brnachless and we alwasy use master on stable","commit_id":"c8d945f5e8efe721ed3aa54ddaa0510649bdf8f9"}],"cyborg_tempest_plugin/tests/scenario/test_arq_service_token_ops.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"db647439ee06487a98ecff9f1c98396017f19b26","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Stop the server first so Nova releases its side, allowing"},{"line_number":92,"context_line":"        # Cyborg to cleanly delete the ARQs."},{"line_number":93,"context_line":"        self.servers_client.stop_server(instance_uuid)"},{"line_number":94,"context_line":"        waiters.wait_for_server_status("},{"line_number":95,"context_line":"            self.servers_client, instance_uuid, \u0027SHUTOFF\u0027)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"434e759e_46fd2e2f","line":93,"updated":"2026-06-23 01:44:05.000000000","message":"The stop_server call on line 93 uses self.servers_client but there is no explicit wait or cleanup guard if the subsequent service-token delete fails. If svc_client.delete_accelerator_request_by_instance_uuid raises, the server is left in SHUTOFF state.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Making the test\u0027s cleanup expectations explicit ensures that a failure during the delete step does not leave the server in an unexpected state for the teardown path.\n\n**Recommendation**:\nThis is acceptable because create_server registers addCleanup for server deletion regardless of state. No change required, but a brief note in the comment block that server teardown is handled by create_server\u0027s cleanup would improve clarity.","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d1b8e24ccfe8f5770617f709e7188f88c51c9616","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        waiters.wait_for_server_status("},{"line_number":95,"context_line":"            self.servers_client, instance_uuid, \u0027SHUTOFF\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Delete with a service token succeeds. A dedicated client"},{"line_number":98,"context_line":"        # instance carries the service token so the shared admin"},{"line_number":99,"context_line":"        # client is not mutated."},{"line_number":100,"context_line":"        svc_client \u003d clients.CyborgRestClient("},{"line_number":101,"context_line":"            self.os_admin.cyborg_client.auth_provider,"},{"line_number":102,"context_line":"            \u0027accelerator\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6cb8d631_eaa40ff9","line":99,"range":{"start_line":97,"start_character":8,"end_line":99,"end_character":32},"updated":"2026-06-30 08:55:18.000000000","message":"Make sense, this will allow to not the share the same service token with other tests.","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"db647439ee06487a98ecff9f1c98396017f19b26","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # Delete with a service token succeeds. A dedicated client"},{"line_number":98,"context_line":"        # instance carries the service token so the shared admin"},{"line_number":99,"context_line":"        # client is not mutated."},{"line_number":100,"context_line":"        svc_client \u003d clients.CyborgRestClient("},{"line_number":101,"context_line":"            self.os_admin.cyborg_client.auth_provider,"},{"line_number":102,"context_line":"            \u0027accelerator\u0027,"},{"line_number":103,"context_line":"            CONF.identity.region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7878a273_a2f10246","line":100,"updated":"2026-06-23 01:44:05.000000000","message":"The new CyborgRestClient constructor call in the test reuses self.os_admin.cyborg_client.auth_provider. Consider adding a brief comment clarifying that reusing the admin auth_provider is intentional and that only the service_token differs from the shared client.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Improves readability for future maintainers who may wonder why a second client is constructed instead of using the existing shared admin client directly.\n\n**Recommendation**:\nThe existing comment on lines 97-99 already explains the rationale well. Optionally extend it to note that the auth_provider reuse means the service token client shares the same authentication identity as the admin client, differing only in the injected X-Service-Token header.","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"}],"requirements.txt":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"db647439ee06487a98ecff9f1c98396017f19b26","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":9,"context_line":"testtools\u003e\u003d2.4.0 # MIT"},{"line_number":10,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":11,"context_line":"tempest\u003e\u003d46.3.0 # Apache-2.0"},{"line_number":12,"context_line":"requests\u003e\u003d2.14.2 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"17d38939_7b56805d","line":11,"updated":"2026-06-23 01:44:05.000000000","message":"The minimum tempest version jumps from 27.0.0 to 46.3.0 (19 major releases). While the commit justifies this for service_token constructor support, such a large lower-constraint bump can break consumers pinned to older tempest in stable branches.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: Any downstream CI or stable branch that installs this plugin with a tempest version below 46.3.0 will fail at import or runtime when the service_token kwarg is not accepted by the constructor.\n\n**Suggestion**:\nConfirm this plugin no longer maintains stable branches that depend on tempest \u003c 46.3.0. If stable branches exist, a backport strategy or a compatibility shim may be needed. The large jump is acceptable for master-only but should be noted in release notes.","commit_id":"6dd66d88428ab86b37ebae80906435a1a656c948"}]}