)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1a7a38da3bf6ab972a2e73808af845d967eb7f44","unresolved":true,"context_lines":[{"line_number":24,"context_line":"test that creates a DP, even when the test also deletes inline."},{"line_number":25,"context_line":"This ensures the name is released even if an assertion fires"},{"line_number":26,"context_line":"before the explicit delete."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NORMAL_DEVICE_PROFILE_DATA1 is kept for scenario tests that"},{"line_number":29,"context_line":"reference it; no API test uses it as a creation target any more."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Partial-Implements: blueprint consistent-and-secure-rbac"},{"line_number":32,"context_line":"Assisted-By: pi opus-4.6 (orchestrator)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ec04ae18_6a10eed1","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":64},"updated":"2026-07-02 07:38:50.000000000","message":"It is not true, NORMAL_DEVICE_PROFILE_DATA1 is used in test_srbac.py (from 992331) https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992331/3/cyborg_tempest_plugin/tests/api/test_srbac.py Line 255.\n\nI think we can rewrite it\n\n```suggestion\n\nNORMAL_DEVICE_PROFILE_DATA1 is kept for test_srbac.py which still references it https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992331\n```","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a2f93537f394959c93e9b56975a6dc70c4fc24a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"test that creates a DP, even when the test also deletes inline."},{"line_number":25,"context_line":"This ensures the name is released even if an assertion fires"},{"line_number":26,"context_line":"before the explicit delete."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NORMAL_DEVICE_PROFILE_DATA1 is kept for scenario tests that"},{"line_number":29,"context_line":"reference it; no API test uses it as a creation target any more."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Partial-Implements: blueprint consistent-and-secure-rbac"},{"line_number":32,"context_line":"Assisted-By: pi opus-4.6 (orchestrator)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d78d6f01_5702152f","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":64},"in_reply_to":"ec04ae18_6a10eed1","updated":"2026-07-06 20:52:21.000000000","message":"Acknowledged","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1a7a38da3bf6ab972a2e73808af845d967eb7f44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0437198_aab2bd22","updated":"2026-07-02 07:38:50.000000000","message":"Leaving -1 as this patch contains one dead code variable needs to be removed and commit message needs update.","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de67d3e880bcdc0231c8d16a12e40258e56ff775","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d6ce674_64a7e03a","updated":"2026-06-22 23:46:28.000000000","message":"teim-ci: auto","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e4d7fcc86a8ff2353a6f08d36d176c88720c388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5b78a05_f303d9c4","updated":"2026-06-22 08:36:09.000000000","message":"teim-ci: auto","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5215e00d19f0884baa2da023a04c91b8046d38d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce5a4968_8eb085f8","updated":"2026-07-06 21:58:59.000000000","message":"i think this is now correct ill revisit this tomorrow","commit_id":"9af03099ea49d97bc3bd162c316e80acd43f5b34"}],"cyborg_tempest_plugin/services/cyborg_data.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"64ccac41954ffdd9b8f20360c1312375bf490ef3","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        }]"},{"line_number":42,"context_line":"    }]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA1 \u003d [{"},{"line_number":45,"context_line":"    \"name\": \"afaas_example_1\","},{"line_number":46,"context_line":"    \"groups\": ["},{"line_number":47,"context_line":"        {"},{"line_number":48,"context_line":"            \"resources:FPGA\": \"1\","},{"line_number":49,"context_line":"            \"trait:CUSTOM_FPGA_1\": \"required\","},{"line_number":50,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":51,"context_line":"        }]"},{"line_number":52,"context_line":"    }]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA2 \u003d [{"},{"line_number":55,"context_line":"    \"name\": \"afaas_example_2\","},{"line_number":56,"context_line":"    \"groups\": ["}],"source_content_type":"text/x-python","patch_set":1,"id":"410f11a0_ecb847ac","line":53,"range":{"start_line":44,"start_character":0,"end_line":53,"end_character":1},"updated":"2026-07-02 07:40:48.000000000","message":"And this also, needs to be removed\n\n```\nchandankumar@fedora:~/programming/cyborg-tempest-plugin$ git grep BATCH_DELETE_DEVICE_PROFILE_DATA1\ncyborg_tempest_plugin/services/cyborg_data.py:BATCH_DELETE_DEVICE_PROFILE_DATA1 \u003d [{\n\n```","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a2f93537f394959c93e9b56975a6dc70c4fc24a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        }]"},{"line_number":42,"context_line":"    }]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA1 \u003d [{"},{"line_number":45,"context_line":"    \"name\": \"afaas_example_1\","},{"line_number":46,"context_line":"    \"groups\": ["},{"line_number":47,"context_line":"        {"},{"line_number":48,"context_line":"            \"resources:FPGA\": \"1\","},{"line_number":49,"context_line":"            \"trait:CUSTOM_FPGA_1\": \"required\","},{"line_number":50,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":51,"context_line":"        }]"},{"line_number":52,"context_line":"    }]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA2 \u003d [{"},{"line_number":55,"context_line":"    \"name\": \"afaas_example_2\","},{"line_number":56,"context_line":"    \"groups\": ["}],"source_content_type":"text/x-python","patch_set":1,"id":"28633781_871accb4","line":53,"range":{"start_line":44,"start_character":0,"end_line":53,"end_character":1},"in_reply_to":"410f11a0_ecb847ac","updated":"2026-07-06 20:52:21.000000000","message":"Done","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1a7a38da3bf6ab972a2e73808af845d967eb7f44","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":51,"context_line":"        }]"},{"line_number":52,"context_line":"    }]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA2 \u003d [{"},{"line_number":55,"context_line":"    \"name\": \"afaas_example_2\","},{"line_number":56,"context_line":"    \"groups\": ["},{"line_number":57,"context_line":"        {"},{"line_number":58,"context_line":"            \"resources:FPGA\": \"1\","},{"line_number":59,"context_line":"            \"trait:CUSTOM_FPGA_1\": \"required\","},{"line_number":60,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":61,"context_line":"        }]"},{"line_number":62,"context_line":"    }]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"_FAKE_DEVICE_GROUPS \u003d ["},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \u0027resources:FPGA\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e179bc10_fed159b1","line":63,"range":{"start_line":53,"start_character":0,"end_line":63,"end_character":1},"updated":"2026-07-02 07:38:50.000000000","message":"As I can see from the git grep, It is not used anywhere. It is a deadcode needs to be drop.\n\n```\nchandankumar@fedora:~/programming/cyborg-tempest-plugin$ git review -d 992347\nDownloading refs/changes/47/992347/1 from gerrit\nSwitched to branch \"review/sean_mooney/992347\"\nchandankumar@fedora:~/programming/cyborg-tempest-plugin$ git grep BATCH_DELETE_DEVICE_PROFILE_DATA2\ncyborg_tempest_plugin/services/cyborg_data.py:BATCH_DELETE_DEVICE_PROFILE_DATA2 \u003d [{\n\n```","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a2f93537f394959c93e9b56975a6dc70c4fc24a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":51,"context_line":"        }]"},{"line_number":52,"context_line":"    }]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"BATCH_DELETE_DEVICE_PROFILE_DATA2 \u003d [{"},{"line_number":55,"context_line":"    \"name\": \"afaas_example_2\","},{"line_number":56,"context_line":"    \"groups\": ["},{"line_number":57,"context_line":"        {"},{"line_number":58,"context_line":"            \"resources:FPGA\": \"1\","},{"line_number":59,"context_line":"            \"trait:CUSTOM_FPGA_1\": \"required\","},{"line_number":60,"context_line":"            \"trait:CUSTOM_FUNCTION_ID_3AFB\": \"required\","},{"line_number":61,"context_line":"        }]"},{"line_number":62,"context_line":"    }]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"_FAKE_DEVICE_GROUPS \u003d ["},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \u0027resources:FPGA\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a15dd5d2_1a9da14c","line":63,"range":{"start_line":53,"start_character":0,"end_line":63,"end_character":1},"in_reply_to":"e179bc10_fed159b1","updated":"2026-07-06 20:52:21.000000000","message":"Done","commit_id":"4db92ff257aaccafa6a7fac5069b4b3c57234b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"463c51ea60940a87de2ab6e45093536ea5aca046","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    so that each test creates a DP with a name that cannot"},{"line_number":57,"context_line":"    collide with any other test running concurrently."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    dp \u003d {\u0027name\u0027: name, \u0027groups\u0027: _FAKE_DEVICE_GROUPS}"},{"line_number":60,"context_line":"    if description is not None:"},{"line_number":61,"context_line":"        dp[\u0027description\u0027] \u003d description"},{"line_number":62,"context_line":"    return [dp]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b29192f_7ac8d422","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":53},"updated":"2026-07-06 21:32:31.000000000","message":"this should use copy.deepcopy to avoid sharing the same  list object","commit_id":"8345a94eb1e9427374b9bfac9b1cfdd9d0524b13"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5215e00d19f0884baa2da023a04c91b8046d38d6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    so that each test creates a DP with a name that cannot"},{"line_number":57,"context_line":"    collide with any other test running concurrently."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    dp \u003d {\u0027name\u0027: name, \u0027groups\u0027: _FAKE_DEVICE_GROUPS}"},{"line_number":60,"context_line":"    if description is not None:"},{"line_number":61,"context_line":"        dp[\u0027description\u0027] \u003d description"},{"line_number":62,"context_line":"    return [dp]"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e987a66_3421e0e2","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":53},"in_reply_to":"4b29192f_7ac8d422","updated":"2026-07-06 21:58:59.000000000","message":"Done","commit_id":"8345a94eb1e9427374b9bfac9b1cfdd9d0524b13"}]}