)]}'
{"pyproject.toml":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"56e728c3c596788fc57db94839181e648500b790","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[tool.ruff]"},{"line_number":42,"context_line":"line-length \u003d 79"},{"line_number":43,"context_line":"target-version \u003d \"py310\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[tool.ruff.lint]"},{"line_number":46,"context_line":"select \u003d [\"E4\", \"E7\", \"E9\", \"F\"]"}],"source_content_type":"text/x-toml","patch_set":2,"id":"4355b326_2d921896","line":43,"updated":"2026-07-06 21:55:49.000000000","message":"The pyproject.toml declares requires-python \u003d \"\u003e\u003d3.11\" and lists classifiers for Python 3.11, 3.12, and 3.13, but the ruff target-version is set to \"py310\". This makes ruff target a Python version one minor release below the minimum supported version, causing ruff to apply autofixes and rule logi...\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: ruff will not enable version-appropriate checks and autofixes for Python 3.11+. While the selected rule set (E4, E7, E9, F) is version-insensitive, this becomes material once UP and other version-dependent rule groups are added in later commits as planned.\n\n**Recommendation**:\nSet target-version to \"py311\" to match the requires-python floor, or document why py310 is intentionally chosen.","commit_id":"e5e80a9cca9cb8df35cc23c94259a594f9179858"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"812fef13552eb159d69c0aaa95f1c27ceb4f6ae6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[tool.ruff]"},{"line_number":42,"context_line":"line-length \u003d 79"},{"line_number":43,"context_line":"target-version \u003d \"py310\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[tool.ruff.lint]"},{"line_number":46,"context_line":"select \u003d [\"E4\", \"E7\", \"E9\", \"F\"]"}],"source_content_type":"text/x-toml","patch_set":3,"id":"998310a7_e26f44b4","line":43,"updated":"2026-07-06 22:45:06.000000000","message":"The ruff configuration sets target-version to py310, but the same pyproject.toml declares requires-python as \u003e\u003d3.11. The minimum supported Python version for this project is 3.11, so the ruff target should be py311.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Ruff will lint against Python 3.10 semantics instead of 3.11. While the current E4/E7/E9/F rule set has minimal version sensitivity, the commit message states later commits will add UP (pyupgrade) rules where target-version is critical. A wrong target-version would produce incorrect upgrade sugge...\n\n**Recommendation**:\nSet target-version \u003d \"py311\" to match the requires-python declaration, or better yet omit target-version and let ruff infer it from requires-python automatically.","commit_id":"b96509056d09c7aa85e73a3a7a75c616767c4061"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f4a0dc3e46f60de79f0aec5caff61b1f611edae","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[tool.ruff]"},{"line_number":42,"context_line":"line-length \u003d 79"},{"line_number":43,"context_line":"target-version \u003d \"py310\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[tool.ruff.lint]"},{"line_number":46,"context_line":"select \u003d [\"E4\", \"E7\", \"E9\", \"F\"]"}],"source_content_type":"text/x-toml","patch_set":3,"id":"9c8bbf76_0ae882f4","line":43,"in_reply_to":"94cbd62e_94dbbbe7","updated":"2026-09-21 15:49:14.000000000","message":"yes although ill adresss that in a followup\n\nthere are a small number of addtioanl change we can make by raisign the target version but its bette to do that after pyupgrade rules are enabled","commit_id":"b96509056d09c7aa85e73a3a7a75c616767c4061"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b74b8812314458110ff19829c6d0d30bbb7df703","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[tool.ruff]"},{"line_number":42,"context_line":"line-length \u003d 79"},{"line_number":43,"context_line":"target-version \u003d \"py310\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[tool.ruff.lint]"},{"line_number":46,"context_line":"select \u003d [\"E4\", \"E7\", \"E9\", \"F\"]"}],"source_content_type":"text/x-toml","patch_set":3,"id":"94cbd62e_94dbbbe7","line":43,"in_reply_to":"998310a7_e26f44b4","updated":"2026-07-22 15:48:04.000000000","message":"this seems valid, according to the ruff docs https://docs.astral.sh/ruff/settings/#target-version teim is correct, and the requires-python should be enough","commit_id":"b96509056d09c7aa85e73a3a7a75c616767c4061"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"af2da267da24dfb10d6c340bf7a6a5dc8931f5e8","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[tool.ruff]"},{"line_number":42,"context_line":"line-length \u003d 79"},{"line_number":43,"context_line":"target-version \u003d \"py310\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[tool.ruff.lint]"},{"line_number":46,"context_line":"select \u003d [\"E4\", \"E7\", \"E9\", \"F\"]"}],"source_content_type":"text/x-toml","patch_set":4,"id":"8f7eb6da_08b65662","line":43,"updated":"2026-09-18 16:17:57.000000000","message":"pyproject.toml:43 pins ruff\u0027s target-version to py310 while the same file declares requires-python \u003d \"\u003e\u003d3.11\" (line 10) and classifiers for 3.11-3.13. When target-version is omitted, ruff infers it from requires-python, so the explicit py310 value actively lowers the lint target below the supported floor. The commit message states UP rules will be enabled in later commits; UP suggestions are gated on target-version, so a py310 target will withhold 3.11+ syntax suggestions and leave the later UP commit configured against the wrong floor.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: The supported Python floor is declared inconsistently within one file: requires-python says \u003e\u003d3.11 while ruff lints as 3.10. No rule in the current E4/E7/E9/F set is target-gated, so behavior is unchanged today, but the planned UP group will base py311+ upgrade suggestions on the stale py310 target, silently suppressing them and inviting a later correction.\n\n**Recommendation**:\nDrop \u0027target-version \u003d \"py310\"\u0027 so ruff infers py311 from requires-python, or change it to \"py311\", keeping the lint target aligned with the supported floor before the UP rule group is enabled.","commit_id":"ed51df7d97b52a36411303166671e722b7e2b434"}]}