)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0c580921e0d9e2ade9d5d322f3719c272faca80a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64333d9c_2ebf18b2","updated":"2026-07-23 11:23:56.000000000","message":"lgtm!","commit_id":"0b38b3262d7310cd1b7117603e77edcea12b2799"}],"cyborg_tempest_plugin/tests/scenario/test_pci_driver_lifecycle.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"5a9c98cf2eaeb1ec021a9257bb50827aec114948","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            ssh_client.exec_command(\u0027sudo reboot\u0027)"},{"line_number":215,"context_line":"        except lib_exc.SSHExecCommandFailed:"},{"line_number":216,"context_line":"            pass"},{"line_number":217,"context_line":"        self._wait_for_ssh_unreachable(ssh_client)"},{"line_number":218,"context_line":"        try:"},{"line_number":219,"context_line":"            waiters.wait_for_ssh(ssh_client)"},{"line_number":220,"context_line":"        except lib_exc.TimeoutException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"45e5c29e_44a0b619","line":217,"updated":"2026-07-22 09:21:50.000000000","message":"The patch inserts _wait_for_ssh_unreachable between the reboot command and wait_for_ssh. This changes the meaning of a subsequent wait_for_ssh timeout, but the error message (\u0027did not start rebooting\u0027) was not updated to reflect that the guest already went down.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: When the test fails because a guest did not come back up after reboot, the error message will incorrectly state that the reboot did not start, leading to wrong debugging direction and wasted triage time.\n\n**Suggestion**:\nUpdate the self.fail() message (lines 222-224) to reflect the new semantics, e.g. \u0027Server {id} did not become reachable again after guest reboot command\u0027.","commit_id":"157682aaa10f18523bc46765d82306afda83e2bb"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"4f17d61187baf5946cd64f5da2e27d471eab197b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                conn \u003d socket.create_connection("},{"line_number":167,"context_line":"                    (ip, port), timeout\u003d5)"},{"line_number":168,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} sucessful\")"},{"line_number":169,"context_line":"                conn.close()"},{"line_number":170,"context_line":"            except OSError:"},{"line_number":171,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} failed\")"},{"line_number":172,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ee6841e8_e8439039","line":169,"updated":"2026-07-22 10:27:03.000000000","message":"The debug log message in _wait_for_guest_unreachable misspells \u0027successful\u0027 as \u0027sucessful\u0027. While this is in a debug-level log, it is a straightforward fix.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Minor cosmetic issue in debug output. Does not affect test behavior but reduces clarity of log messages during debugging.\n\n**Recommendation**:\nChange \u0027sucessful\u0027 to \u0027successful\u0027 in the LOG.debug call.","commit_id":"86b80e625fd8986fa5f84eaca1b632ab0ea22f00"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"249ab8ce26f52157e219f68dc346bc9eab3ba68e","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        \"\"\"Ensure guest is not reachable after a reboot.\"\"\""},{"line_number":164,"context_line":"        def _check():"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                conn \u003d socket.create_connection("},{"line_number":167,"context_line":"                    (ip, port), timeout\u003d5)"},{"line_number":168,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} successful\")"},{"line_number":169,"context_line":"                conn.close()"},{"line_number":170,"context_line":"            except OSError:"},{"line_number":171,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} failed\")"},{"line_number":172,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"8be09b78_c13105c6","line":169,"range":{"start_line":166,"start_character":16,"end_line":169,"end_character":28},"updated":"2026-07-22 13:31:05.000000000","message":"+1 for checking tcp connection to port 22\n\nIn tempest, we have icmp connection check\n- https://github.com/openstack/tempest/blob/406633de5471ef4834c65d2ec5a682d3251251a7/tempest/scenario/manager.py#L1022 - ping_ip_address\n\n- https://github.com/openstack/tempest/blob/406633de5471ef4834c65d2ec5a682d3251251a7/tempest/scenario/manager.py#L1062 - check_vm_connectivity  \n\nBut above check is much suitable after reboot.\nWhat about using context manager here?\n```suggestion\n  with socket.create_connection((ip, port), timeout\u003d5) as conn:\n      LOG.debug(f\"Connection to {ip}:{port} successful\")\n```","commit_id":"114d388aadecb964efbd6a66a363606ceae56a47"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0c580921e0d9e2ade9d5d322f3719c272faca80a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\"Ensure guest is not reachable after a reboot.\"\"\""},{"line_number":164,"context_line":"        def _check():"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                conn \u003d socket.create_connection("},{"line_number":167,"context_line":"                    (ip, port), timeout\u003d5)"},{"line_number":168,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} successful\")"},{"line_number":169,"context_line":"                conn.close()"},{"line_number":170,"context_line":"            except OSError:"},{"line_number":171,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} failed\")"},{"line_number":172,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"8ad0dc84_87364064","line":169,"range":{"start_line":166,"start_character":16,"end_line":169,"end_character":28},"in_reply_to":"3ca22f9b_dc5f7eaf","updated":"2026-07-23 11:23:56.000000000","message":"Done","commit_id":"114d388aadecb964efbd6a66a363606ceae56a47"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7dc39ef98fed8fae4f4fe5a9fd7e9a94bb80b034","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        \"\"\"Ensure guest is not reachable after a reboot.\"\"\""},{"line_number":164,"context_line":"        def _check():"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                conn \u003d socket.create_connection("},{"line_number":167,"context_line":"                    (ip, port), timeout\u003d5)"},{"line_number":168,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} successful\")"},{"line_number":169,"context_line":"                conn.close()"},{"line_number":170,"context_line":"            except OSError:"},{"line_number":171,"context_line":"                LOG.debug(f\"Connection to {ip}: {port} failed\")"},{"line_number":172,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ca22f9b_dc5f7eaf","line":169,"range":{"start_line":166,"start_character":16,"end_line":169,"end_character":28},"in_reply_to":"8be09b78_c13105c6","updated":"2026-07-22 14:45:43.000000000","message":"that is a good suggestion thanks, I\u0027ll use a context manager","commit_id":"114d388aadecb964efbd6a66a363606ceae56a47"}]}