)]}'
{"cyborg/accelerator/drivers/modules/spdk.py":[{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"45a9bc289b9635ccdd15b84ee50e9bb525cf4c7e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.dbconn \u003d api.get_backend()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def initialize_connection(self, accelerator, connector):"},{"line_number":64,"context_line":"        return py_spdk.initialize_connection(accelerator, connector)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def validate_connection(self, connector):"},{"line_number":67,"context_line":"        return py_spdk.initialize_connection(connector)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_55c210eb","line":64,"updated":"2017-12-06 02:07:15.000000000","message":"If import py_spdk failure, py_spdk should be None.","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"},{"author":{"_account_id":26772,"name":"heluwei","email":"heluwei@huawei.com","username":"heluwei"},"change_message_id":"ac671883cb260f40b444351b20f3948a5322f2b1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.dbconn \u003d api.get_backend()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def initialize_connection(self, accelerator, connector):"},{"line_number":64,"context_line":"        return py_spdk.initialize_connection(accelerator, connector)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def validate_connection(self, connector):"},{"line_number":67,"context_line":"        return py_spdk.initialize_connection(connector)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_c21e1cba","line":64,"in_reply_to":"df87a7cf_55c210eb","updated":"2018-01-16 02:01:33.000000000","message":"Yes, you‘re right.  There were no consideration about the processing of error and exception. I will improve it next patch. Thank you for your kindness.","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"},{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"45a9bc289b9635ccdd15b84ee50e9bb525cf4c7e","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def destory_db(self):"},{"line_number":70,"context_line":"        if self.dbconn is not None:"},{"line_number":71,"context_line":"            self.dbconn.close()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def discover_driver(self, driver_type):"},{"line_number":74,"context_line":"        HAVE_SPDK \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_35c8ac20","line":71,"updated":"2017-12-06 02:07:15.000000000","message":"set dbconn to None.","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"},{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"45a9bc289b9635ccdd15b84ee50e9bb525cf4c7e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def discover_driver(self, driver_type):"},{"line_number":74,"context_line":"        HAVE_SPDK \u003d None"},{"line_number":75,"context_line":"        if HAVE_SPDK:"},{"line_number":76,"context_line":"            values \u003d {\u0027acc_type\u0027: self.driver_type}"},{"line_number":77,"context_line":"            self.dbconn.accelerator_create(None, values)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_95e09898","line":75,"updated":"2017-12-06 02:07:15.000000000","message":"HAVE_SPDK always false(None)","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"},{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"45a9bc289b9635ccdd15b84ee50e9bb525cf4c7e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        HAVE_SPDK \u003d None"},{"line_number":75,"context_line":"        if HAVE_SPDK:"},{"line_number":76,"context_line":"            values \u003d {\u0027acc_type\u0027: self.driver_type}"},{"line_number":77,"context_line":"            self.dbconn.accelerator_create(None, values)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def install_driver(self, driver_id, driver_type):"},{"line_number":80,"context_line":"        accelerator \u003d self.dbconn.accelerator_query(None, driver_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_55f4505b","line":77,"updated":"2017-12-06 02:07:15.000000000","message":"dbconn maybe None?","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"},{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"45a9bc289b9635ccdd15b84ee50e9bb525cf4c7e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            nsid \u003d self.get_allocated_nsid(ctrlr)"},{"line_number":86,"context_line":"            self.attach_instance(nsid)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            msg \u003d (_(\"Could not find %s accelerator\") % driver_type)"},{"line_number":89,"context_line":"            raise exception.InvalidAccelerator(msg)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def uninstall_driver(self, driver_id, driver_type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_781dc964","line":88,"range":{"start_line":88,"start_character":56,"end_line":88,"end_character":67},"updated":"2017-12-06 02:07:15.000000000","message":"driver_type is unused parameter.\nsuggested \"driver_id\".","commit_id":"7247fa00f20560b2838afad4065af62176ac06c8"}]}