)]}'
{"specs/proposal/cyborg-fpga-model-proposal.rst":[{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"fbdbd1e22f9205ac609b55fcc528daa1af0303a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"A field-programmable gate array (FPGA) is an integrated circuit designed to be "},{"line_number":20,"context_line":"configured by a customer or a designer after manufacturing. Their advantage lies"},{"line_number":21,"context_line":"in that they are sometimes significantly faster for some applications because of"},{"line_number":22,"context_line":"their parallel nature and optimality in terms of the number of gates used for a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df87a7cf_9637feff","line":19,"range":{"start_line":19,"start_character":78,"end_line":19,"end_character":79},"updated":"2017-12-08 04:19:40.000000000","message":"remove all space in the line endings","commit_id":"8b08e3bf2cf6732b2908be7237af25c71748c851"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"fbdbd1e22f9205ac609b55fcc528daa1af0303a2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"We need to add 2 more tables to Cyborg database, one for tracking all the deploybles"},{"line_number":44,"context_line":"and one for arbitrary key-value pairs of deplyable accosiated attirbutes. Namly: "},{"line_number":45,"context_line":"Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id "}],"source_content_type":"text/x-rst","patch_set":1,"id":"df87a7cf_d64ee636","line":44,"range":{"start_line":44,"start_character":74,"end_line":44,"end_character":79},"updated":"2017-12-08 04:19:40.000000000","message":"Namely","commit_id":"8b08e3bf2cf6732b2908be7237af25c71748c851"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"fbdbd1e22f9205ac609b55fcc528daa1af0303a2","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"},{"line_number":81,"context_line":"As discussed in previous sections, two table will be added: pDeployables and Attributes::"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    CREATE TABLE Deployables"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df87a7cf_56b896e3","line":81,"range":{"start_line":81,"start_character":60,"end_line":81,"end_character":72},"updated":"2017-12-08 04:19:40.000000000","message":"Deployables","commit_id":"8b08e3bf2cf6732b2908be7237af25c71748c851"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"cf4c5b2df465a45de43fec5c74d1c9ead0e2ffec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"When user requests FPGA resoureces, scheduler will use placement agent to select"},{"line_number":31,"context_line":"appropriate hosts that have the requested FPGA resources."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"When a FPGA type resource is allocated to a VM, Cyborg needs to track down which"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df87a7cf_f6106652","line":30,"range":{"start_line":30,"start_character":24,"end_line":30,"end_character":34},"updated":"2017-12-14 03:12:26.000000000","message":"resources","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"When user requests FPGA resoureces, scheduler will use placement agent to select"},{"line_number":31,"context_line":"appropriate hosts that have the requested FPGA resources."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"When a FPGA type resource is allocated to a VM, Cyborg needs to track down which"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df87a7cf_54d79b24","line":30,"range":{"start_line":30,"start_character":24,"end_line":30,"end_character":34},"in_reply_to":"df87a7cf_f6106652","updated":"2018-01-10 20:32:49.000000000","message":"I will fix this in my next patch","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"6e4b7fbf084c64746c565070550619d9c868b63b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"deployables and one for arbitrary key-value pairs of deplyable accosiated attirbutes."},{"line_number":45,"context_line":"Namely: Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id"},{"line_number":48,"context_line":"and a root_id. The parent_id will point to the associated parent deployable and the"},{"line_number":49,"context_line":"root_id will point to the associated root deployable. By doing this, we can form a"},{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf8cb3f7_decf2b7d","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":17},"updated":"2017-12-26 10:46:05.000000000","message":"Is Deployables talbe mainly used for hierarchies?\nCan you update the use case for it?","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":44,"context_line":"deployables and one for arbitrary key-value pairs of deplyable accosiated attirbutes."},{"line_number":45,"context_line":"Namely: Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id"},{"line_number":48,"context_line":"and a root_id. The parent_id will point to the associated parent deployable and the"},{"line_number":49,"context_line":"root_id will point to the associated root deployable. By doing this, we can form a"},{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f91af0f_2935e8da","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":17},"in_reply_to":"bf8cb3f7_decf2b7d","updated":"2018-01-10 20:32:49.000000000","message":"I have put up a graph to explain it in more details in my next patch.","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"6e4b7fbf084c64746c565070550619d9c868b63b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"},{"line_number":51,"context_line":"foreign key named accelerator_id reference to the accelerators table"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":54,"context_line":"In addition, a foreign key deployable_id refers to the Deployables table and a"},{"line_number":55,"context_line":"parent_attribute_id to form nested structured attribute relationships."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf8cb3f7_3e2bb730","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":16},"updated":"2017-12-26 10:46:05.000000000","message":"Will the image uuid be in this table or in accelerators table?\n\nFor code-migration, we maybe migrate a VM from host a to host b.\nHost b maybe find a empty fpga region and re-program it for the accelerator. \nThat need image uuid.\n\nPlease describe it.","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"},{"line_number":51,"context_line":"foreign key named accelerator_id reference to the accelerators table"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":54,"context_line":"In addition, a foreign key deployable_id refers to the Deployables table and a"},{"line_number":55,"context_line":"parent_attribute_id to form nested structured attribute relationships."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f91af0f_49470c4d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":16},"in_reply_to":"bf8cb3f7_3e2bb730","updated":"2018-01-10 20:32:49.000000000","message":"the bitstream id should be tracked desperately from accelerator table. In stead, it should be tracked in the attributes table. Since it is too specific to FPGA, however, deployable is generic description. I have updated it in my next patch.","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"cf4c5b2df465a45de43fec5c74d1c9ead0e2ffec","unresolved":false,"context_lines":[{"line_number":82,"context_line":"As discussed in previous sections, two table will be added: Deployables and Attributes::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CREATE TABLE Deployables"},{"line_number":86,"context_line":"      ("},{"line_number":87,"context_line":"        id           INTEGER NOT NULL ,     /*Primary Key*/"},{"line_number":88,"context_line":"        parent_id    INTEGER ,              /*Pointer to the parent deployable\u0027s primary key*/"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df87a7cf_29764c40","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":28},"updated":"2017-12-14 03:12:26.000000000","message":"How an empty slot(no accelerator programmed) is presented in this table? I assume the accelerator_id should be a reserved value, and is the pcie_address a valid value that time?","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":82,"context_line":"As discussed in previous sections, two table will be added: Deployables and Attributes::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CREATE TABLE Deployables"},{"line_number":86,"context_line":"      ("},{"line_number":87,"context_line":"        id           INTEGER NOT NULL ,     /*Primary Key*/"},{"line_number":88,"context_line":"        parent_id    INTEGER ,              /*Pointer to the parent deployable\u0027s primary key*/"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f91af0f_e9838055","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":28},"in_reply_to":"df87a7cf_29764c40","updated":"2018-01-10 20:32:49.000000000","message":"For a FPGA with no bitstreawm loaded, it should still be tracked here and there must be a accelerator_id assigned to it. However, there will be no other deployables referencing to this one. I will put this detail in my next patch.","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"cf4c5b2df465a45de43fec5c74d1c9ead0e2ffec","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"RPC API impact"},{"line_number":121,"context_line":"---------------"},{"line_number":122,"context_line":"2 sets of conductor apis need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Physical function apis::"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df87a7cf_89c75846","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":19},"updated":"2017-12-14 03:12:26.000000000","message":"Who is going to call these functions? the underlying vendor specific FPGA driver?","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"RPC API impact"},{"line_number":121,"context_line":"---------------"},{"line_number":122,"context_line":"2 sets of conductor apis need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Physical function apis::"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df87a7cf_343697b6","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":19},"in_reply_to":"df87a7cf_89c75846","updated":"2018-01-10 20:32:49.000000000","message":"The FPGA drivers report the resources to the resource tracker, the resource tracker will call these APIs to update the database. I will put these details in my next patch","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"6e4b7fbf084c64746c565070550619d9c868b63b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"will only add two extra REST APIs to allow user query information related to"},{"line_number":142,"context_line":"deployables and their attributes."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"API for retrieving Deployable\u0027s information::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    Url: {base_url}/accelerators/deployable/{uuid}"},{"line_number":147,"context_line":"    Method: GET"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf8cb3f7_9e9e8361","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":45},"updated":"2017-12-26 10:46:05.000000000","message":"Wonder how can I get a fpga with empty region by API?","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":141,"context_line":"will only add two extra REST APIs to allow user query information related to"},{"line_number":142,"context_line":"deployables and their attributes."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"API for retrieving Deployable\u0027s information::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    Url: {base_url}/accelerators/deployable/{uuid}"},{"line_number":147,"context_line":"    Method: GET"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f91af0f_89f514ce","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":45},"in_reply_to":"bf8cb3f7_9e9e8361","updated":"2018-01-10 20:32:49.000000000","message":"I have added a sample call to do this in next patch.","commit_id":"7c8640ec3cfbbb9013844202524f1850bdf54ca6"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Blueprint url is not available yet"},{"line_number":12,"context_line":"https://blueprints.launchpad.net/openstack-cyborg/+spec/cyborg-fpga-modelling"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This spec proposed the DB modelling schema for tracking reprogrammable resources"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_624bbd2a","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":18},"updated":"2018-01-05 21:56:10.000000000","message":"proposes","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":22,"context_line":"their parallel nature and optimality in terms of the number of gates used for a"},{"line_number":23,"context_line":"certain process. Hence, using FPGA for application acceleration in cloud has been"},{"line_number":24,"context_line":"becoming desirable. Cyborg as a management framwork for heterogeneous accelerators"},{"line_number":25,"context_line":",tracking and deploying FPGAs are much needed features."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_023bd19b","line":25,"updated":"2018-01-05 21:56:10.000000000","message":"missing white space","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":31,"context_line":"appropriate hosts that have the requested FPGA resources."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"When a FPGA type resource is allocated to a VM, Cyborg needs to track down which"},{"line_number":34,"context_line":"exact device has been assigned in database. On the other hand, when the resource"},{"line_number":35,"context_line":"is released, Cyborg will need to detached and free the exact resource."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When a new device is plugin to the system(host), Cyborg needs to discover it and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_a25a25f0","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":42},"updated":"2018-01-05 21:56:10.000000000","message":"the database","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"When a FPGA type resource is allocated to a VM, Cyborg needs to track down which"},{"line_number":34,"context_line":"exact device has been assigned in database. On the other hand, when the resource"},{"line_number":35,"context_line":"is released, Cyborg will need to detached and free the exact resource."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When a new device is plugin to the system(host), Cyborg needs to discover it and"},{"line_number":38,"context_line":"store it into the database"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_62741d69","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":41},"updated":"2018-01-05 21:56:10.000000000","message":"be detached","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":34,"context_line":"exact device has been assigned in database. On the other hand, when the resource"},{"line_number":35,"context_line":"is released, Cyborg will need to detached and free the exact resource."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When a new device is plugin to the system(host), Cyborg needs to discover it and"},{"line_number":38,"context_line":"store it into the database"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_826fe190","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":27},"updated":"2018-01-05 21:56:10.000000000","message":"plugged in","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"We need to add 2 more tables to Cyborg database, one for tracking all the"},{"line_number":44,"context_line":"deployables and one for arbitrary key-value pairs of deplyable accosiated attirbutes."},{"line_number":45,"context_line":"Namely: Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_e2058dc3","line":44,"range":{"start_line":44,"start_character":63,"end_line":44,"end_character":84},"updated":"2018-01-05 21:56:10.000000000","message":"associated attributes","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"We need to add 2 more tables to Cyborg database, one for tracking all the"},{"line_number":44,"context_line":"deployables and one for arbitrary key-value pairs of deplyable accosiated attirbutes."},{"line_number":45,"context_line":"Namely: Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id"},{"line_number":48,"context_line":"and a root_id. The parent_id will point to the associated parent deployable and the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_c212c909","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":35},"updated":"2018-01-05 21:56:10.000000000","message":"please format this correctly.","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":44,"context_line":"deployables and one for arbitrary key-value pairs of deplyable accosiated attirbutes."},{"line_number":45,"context_line":"Namely: Deployables and Attributes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Deployables table consists all the common attributes columns as well as a parent_id"},{"line_number":48,"context_line":"and a root_id. The parent_id will point to the associated parent deployable and the"},{"line_number":49,"context_line":"root_id will point to the associated root deployable. By doing this, we can form a"},{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_82f4c1d0","line":47,"range":{"start_line":47,"start_character":18,"end_line":47,"end_character":26},"updated":"2018-01-05 21:56:10.000000000","message":"consists of","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":49,"context_line":"root_id will point to the associated root deployable. By doing this, we can form a"},{"line_number":50,"context_line":"nested tree structure to represent different hierarchies. In addition, there will a"},{"line_number":51,"context_line":"foreign key named accelerator_id reference to the accelerators table. For the case"},{"line_number":52,"context_line":"where FPGA has not been loaded any bitstreams on it, they will sitll be tracked as"},{"line_number":53,"context_line":"a Deployable but no other Deployables referencing to it. For instance, a network of"},{"line_number":54,"context_line":"FPGA hierarchies can be formed using deployables in following scheme::"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_0232f1a7","line":52,"range":{"start_line":52,"start_character":63,"end_line":52,"end_character":68},"updated":"2018-01-05 21:56:10.000000000","message":"still","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"03ced0cbb21eb1cabcf20cf6f18e4d1cdf8742eb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    |Deployable - VF|      |Deployable - VF| -----------------------"},{"line_number":70,"context_line":"    -----------------      -----------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":74,"context_line":"For instance, bitstream_id and function kpi can be tracked in this table.In addition,"},{"line_number":75,"context_line":"a foreign key deployable_id refers to the Deployables table and a parent_attribute_id"},{"line_number":76,"context_line":"to form nested structured attribute relationships."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_89205d4a","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":16},"updated":"2018-01-07 05:10:17.000000000","message":"An open：\nIs the RAM information also in attribute table? \nThere will be RAM on the FPGA card.\nSome accelerators may need RAM allocation. \nWho will maintain the RAM? \n\nDoes cyborg have the responsibility for FPGA RAM management?","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    -----------------      -----------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":74,"context_line":"For instance, bitstream_id and function kpi can be tracked in this table.In addition,"},{"line_number":75,"context_line":"a foreign key deployable_id refers to the Deployables table and a parent_attribute_id"},{"line_number":76,"context_line":"to form nested structured attribute relationships."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_22adb587","line":73,"range":{"start_line":73,"start_character":44,"end_line":73,"end_character":51},"updated":"2018-01-05 21:56:10.000000000","message":"column","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    -----------------      -----------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":74,"context_line":"For instance, bitstream_id and function kpi can be tracked in this table.In addition,"},{"line_number":75,"context_line":"a foreign key deployable_id refers to the Deployables table and a parent_attribute_id"},{"line_number":76,"context_line":"to form nested structured attribute relationships."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_829e0152","line":73,"range":{"start_line":73,"start_character":17,"end_line":73,"end_character":25},"updated":"2018-01-05 21:56:10.000000000","message":"consists of","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Attributes table consists a key and a value columns to represent arbitrary k-v pairs."},{"line_number":74,"context_line":"For instance, bitstream_id and function kpi can be tracked in this table.In addition,"},{"line_number":75,"context_line":"a foreign key deployable_id refers to the Deployables table and a parent_attribute_id"},{"line_number":76,"context_line":"to form nested structured attribute relationships."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_a2b225e5","line":74,"updated":"2018-01-05 21:56:10.000000000","message":"missing whitespace","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":75,"context_line":"a foreign key deployable_id refers to the Deployables table and a parent_attribute_id"},{"line_number":76,"context_line":"to form nested structured attribute relationships."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Cyborg needs to have object classes to represent different types of deployables(e.g."},{"line_number":79,"context_line":"FPGA, Physical Functions, Virtual Functions etc.)."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Cyborg Agent needs to add feature to discover the FPGA resources from FPGA driver"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_22c6154a","line":78,"updated":"2018-01-05 21:56:10.000000000","message":"missing whitespace","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":76,"context_line":"to form nested structured attribute relationships."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Cyborg needs to have object classes to represent different types of deployables(e.g."},{"line_number":79,"context_line":"FPGA, Physical Functions, Virtual Functions etc.)."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Cyborg Agent needs to add feature to discover the FPGA resources from FPGA driver"},{"line_number":82,"context_line":"and report them to the Cyborg DB through the conductor"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_c2eac9aa","line":79,"range":{"start_line":79,"start_character":47,"end_line":79,"end_character":48},"updated":"2018-01-05 21:56:10.000000000","message":"Remove this extra period","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":79,"context_line":"FPGA, Physical Functions, Virtual Functions etc.)."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Cyborg Agent needs to add feature to discover the FPGA resources from FPGA driver"},{"line_number":82,"context_line":"and report them to the Cyborg DB through the conductor"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Conductor needs to add couple sets of APIs for different types of deployable resources"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_42d6b9f3","line":82,"updated":"2018-01-05 21:56:10.000000000","message":"missing period","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Cyborg Agent needs to add feature to discover the FPGA resources from FPGA driver"},{"line_number":82,"context_line":"and report them to the Cyborg DB through the conductor"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Conductor needs to add couple sets of APIs for different types of deployable resources"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Alternatives"},{"line_number":87,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_020af188","line":84,"range":{"start_line":84,"start_character":30,"end_line":84,"end_character":34},"updated":"2018-01-05 21:56:10.000000000","message":"of sets","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":87,"context_line":"------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternativly, instead of having a flat table to track arbitrary hierarchies, we can use"},{"line_number":90,"context_line":"2 different tables in Cyborg database, one for physical functions and one for virtual"},{"line_number":91,"context_line":"functions. physical_functions should have a foreign key constrain to reference the id in"},{"line_number":92,"context_line":"Accelerators table. In addition, virtual_functions should have a foreign key constrain"},{"line_number":93,"context_line":"to reference the id in physical_functions."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_82f5a185","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":1},"updated":"2018-01-05 21:56:10.000000000","message":"two","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternativly, instead of having a flat table to track arbitrary hierarchies, we can use"},{"line_number":90,"context_line":"2 different tables in Cyborg database, one for physical functions and one for virtual"},{"line_number":91,"context_line":"functions. physical_functions should have a foreign key constrain to reference the id in"},{"line_number":92,"context_line":"Accelerators table. In addition, virtual_functions should have a foreign key constrain"},{"line_number":93,"context_line":"to reference the id in physical_functions."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_e22b4de8","line":91,"range":{"start_line":91,"start_character":56,"end_line":91,"end_character":65},"updated":"2018-01-05 21:56:10.000000000","message":"constraint","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Alternativly, instead of having a flat table to track arbitrary hierarchies, we can use"},{"line_number":90,"context_line":"2 different tables in Cyborg database, one for physical functions and one for virtual"},{"line_number":91,"context_line":"functions. physical_functions should have a foreign key constrain to reference the id in"},{"line_number":92,"context_line":"Accelerators table. In addition, virtual_functions should have a foreign key constrain"},{"line_number":93,"context_line":"to reference the id in physical_functions."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"The problems with this design are as follows. First, it can only track up to 3 hierarchies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_022f51f6","line":92,"range":{"start_line":92,"start_character":77,"end_line":92,"end_character":86},"updated":"2018-01-05 21:56:10.000000000","message":"constraint","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":93,"context_line":"to reference the id in physical_functions."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"The problems with this design are as follows. First, it can only track up to 3 hierarchies"},{"line_number":96,"context_line":"of resources. In case we need to add another layer, quite some migaration work will"},{"line_number":97,"context_line":"be required. Second, even if we only need to add some new attribute to the existing"},{"line_number":98,"context_line":"resource type, we need to create new migration scripts for them. Overeall the maintenance"},{"line_number":99,"context_line":"work is tedious."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_823a8131","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":73},"updated":"2018-01-05 21:56:10.000000000","message":"a lot of migration","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":95,"context_line":"The problems with this design are as follows. First, it can only track up to 3 hierarchies"},{"line_number":96,"context_line":"of resources. In case we need to add another layer, quite some migaration work will"},{"line_number":97,"context_line":"be required. Second, even if we only need to add some new attribute to the existing"},{"line_number":98,"context_line":"resource type, we need to create new migration scripts for them. Overeall the maintenance"},{"line_number":99,"context_line":"work is tedious."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_0218b1d0","line":98,"range":{"start_line":98,"start_character":65,"end_line":98,"end_character":73},"updated":"2018-01-05 21:56:10.000000000","message":"Overall","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"},{"line_number":103,"context_line":"As discussed in previous sections, two table will be added: Deployables and Attributes::"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    CREATE TABLE Deployables"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_a20ea58a","line":103,"range":{"start_line":103,"start_character":39,"end_line":103,"end_character":44},"updated":"2018-01-05 21:56:10.000000000","message":"tables","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"RPC API impact"},{"line_number":142,"context_line":"---------------"},{"line_number":143,"context_line":"2 sets of conductor apis need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Physical function apis::"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_62289de1","line":143,"range":{"start_line":143,"start_character":20,"end_line":143,"end_character":24},"updated":"2018-01-05 21:56:10.000000000","message":"APIs","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"RPC API impact"},{"line_number":142,"context_line":"---------------"},{"line_number":143,"context_line":"2 sets of conductor apis need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Physical function apis::"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_c21169ae","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":1},"updated":"2018-01-05 21:56:10.000000000","message":"Two","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Developer impact"},{"line_number":290,"context_line":"----------------"},{"line_number":291,"context_line":"None"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_e2626d3e","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":4},"updated":"2018-01-05 21:56:10.000000000","message":"There will be new functionalities available to the dev because of this.","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"Documentation Impact"},{"line_number":318,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":319,"context_line":"None"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"References"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_c25f2970","line":319,"range":{"start_line":319,"start_character":0,"end_line":319,"end_character":4},"updated":"2018-01-05 21:56:10.000000000","message":"Please add some doc impact here","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4a7a5c9a7811b265dd28792c8a8d9cdcd6033249","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"References"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":323,"context_line":"None"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"History"},{"line_number":326,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_a2d1c5cf","line":323,"range":{"start_line":323,"start_character":0,"end_line":323,"end_character":4},"updated":"2018-01-05 21:56:10.000000000","message":"Please add the relevant references here","commit_id":"2378a0136496980a08d9b8b48f789fe6a844b631"},{"author":{"_account_id":22306,"name":"Justin Kilpatrick","email":"jkilpatr@redhat.com","username":"jkilpatr"},"change_message_id":"cd6070d31b93b13ba2debc73c1798519447ca260","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        assignable   CHAR (1) ,             /*Represent if the deployable can be assigned to users*/"},{"line_number":123,"context_line":"        instance_id  VARCHAR2 (32 BYTE) ,   /*Represent which instance this deployable has been assigned to*/"},{"line_number":124,"context_line":"        availability INTEGER NOT NULL,      /*enum type to represent the status of the deployable(e.g. acclocated/claimed)*/"},{"line_number":125,"context_line":"        accelerator_id INTEGER NOT NULL     /*foreign key references to the accelerator table*/"},{"line_number":126,"context_line":"      ) ;"},{"line_number":127,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_PK PRIMARY KEY ( id ) ;"},{"line_number":128,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_accelerators_FK FOREIGN KEY ( accelerator_id ) REFERENCES accelerators ( id ) ;"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_de72257d","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":40},"updated":"2018-01-10 15:22:05.000000000","message":"shouldn\u0027t the accelerator_id itself be a uuid and of type VARCHAR2 32 byte? I\u0027m not sure there\u0027s any plan on how to represent accelerator ID\u0027s laid out formally but I don\u0027t think it\u0027s just integers.","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"e883141d46a945693764bf464e59d8c19670ce4d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        assignable   CHAR (1) ,             /*Represent if the deployable can be assigned to users*/"},{"line_number":123,"context_line":"        instance_id  VARCHAR2 (32 BYTE) ,   /*Represent which instance this deployable has been assigned to*/"},{"line_number":124,"context_line":"        availability INTEGER NOT NULL,      /*enum type to represent the status of the deployable(e.g. acclocated/claimed)*/"},{"line_number":125,"context_line":"        accelerator_id INTEGER NOT NULL     /*foreign key references to the accelerator table*/"},{"line_number":126,"context_line":"      ) ;"},{"line_number":127,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_PK PRIMARY KEY ( id ) ;"},{"line_number":128,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_accelerators_FK FOREIGN KEY ( accelerator_id ) REFERENCES accelerators ( id ) ;"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_cd8ef5cf","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":40},"in_reply_to":"7f96bb07_de72257d","updated":"2018-01-10 20:43:22.000000000","message":"+1","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"42f7611a642b8393403a38322ee98fab633de774","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        assignable   CHAR (1) ,             /*Represent if the deployable can be assigned to users*/"},{"line_number":123,"context_line":"        instance_id  VARCHAR2 (32 BYTE) ,   /*Represent which instance this deployable has been assigned to*/"},{"line_number":124,"context_line":"        availability INTEGER NOT NULL,      /*enum type to represent the status of the deployable(e.g. acclocated/claimed)*/"},{"line_number":125,"context_line":"        accelerator_id INTEGER NOT NULL     /*foreign key references to the accelerator table*/"},{"line_number":126,"context_line":"      ) ;"},{"line_number":127,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_PK PRIMARY KEY ( id ) ;"},{"line_number":128,"context_line":"    ALTER TABLE Deployables ADD CONSTRAINT Deployables_accelerators_FK FOREIGN KEY ( accelerator_id ) REFERENCES accelerators ( id ) ;"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_33b57aef","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":40},"in_reply_to":"7f96bb07_de72257d","updated":"2018-01-10 20:32:49.000000000","message":"This accelerator_id refers to the id(primary key) in the accelerators table. The uuid of VARCHAR shouldn\u0027t be tracked here. In stead, user should find the uuid from the accelerators table.","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"95d1882a34caf43ce743805f9dfde67feee743fa","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"RPC API impact"},{"line_number":145,"context_line":"---------------"},{"line_number":146,"context_line":"Two sets of conductor APIs need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Physical function apis::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_4623f856","line":146,"updated":"2018-01-17 09:06:03.000000000","message":"and 1 set for attributes?","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"9cc0dd739fafed98903d6f7389cc5ee17edfd1a2","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"RPC API impact"},{"line_number":145,"context_line":"---------------"},{"line_number":146,"context_line":"Two sets of conductor APIs need to be added. 1 set for physical functions, 1 set for virtual functions"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Physical function apis::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_916131ac","line":146,"in_reply_to":"7f96bb07_4623f856","updated":"2018-01-17 14:58:28.000000000","message":"I don\u0027t think we need to have conductor APIs for attributes, as they should be packaged in Deployable Objects(physical function/virual function) already.","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"95d1882a34caf43ce743805f9dfde67feee743fa","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def physical_function_create(context, values)"},{"line_number":151,"context_line":"    def physical_function_get_all_by_filters(context, filters, sort_key\u003d\u0027created_at\u0027, sort_dir\u003d\u0027desc\u0027, limit\u003dNone, marker\u003dNone, columns_to_join\u003dNone)"},{"line_number":152,"context_line":"    def physical_function_update(context, device_vendor_uuid, values, expected\u003dNone)"},{"line_number":153,"context_line":"    def physical_function_destroy(context, uuid)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Virtual function apis::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_637ce61e","line":152,"range":{"start_line":152,"start_character":42,"end_line":152,"end_character":60},"updated":"2018-01-17 09:06:03.000000000","message":"Is this the same as to the virtual_function_update\u0027s uuid parameter?","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"9cc0dd739fafed98903d6f7389cc5ee17edfd1a2","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def physical_function_create(context, values)"},{"line_number":151,"context_line":"    def physical_function_get_all_by_filters(context, filters, sort_key\u003d\u0027created_at\u0027, sort_dir\u003d\u0027desc\u0027, limit\u003dNone, marker\u003dNone, columns_to_join\u003dNone)"},{"line_number":152,"context_line":"    def physical_function_update(context, device_vendor_uuid, values, expected\u003dNone)"},{"line_number":153,"context_line":"    def physical_function_destroy(context, uuid)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Virtual function apis::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_1123e157","line":152,"range":{"start_line":152,"start_character":42,"end_line":152,"end_character":60},"in_reply_to":"7f96bb07_637ce61e","updated":"2018-01-17 14:58:28.000000000","message":"Yes, this is a typo, I will fix it in my next patch.","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"95d1882a34caf43ce743805f9dfde67feee743fa","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    Success Response:"},{"line_number":250,"context_line":"        GET:"},{"line_number":251,"context_line":"            Code: 200"},{"line_number":252,"context_line":"            Content: { deployable: {key : value, uuid: xxx}}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    Error Response"},{"line_number":255,"context_line":"        Code: 401 UNAUTHORIZED"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_463d38c2","line":252,"range":{"start_line":252,"start_character":21,"end_line":252,"end_character":60},"updated":"2018-01-17 09:06:03.000000000","message":"Response body should be { attribute: {key: value} }, such as\nhttps://developer.openstack.org/api-ref/block-storage/v3/index.html#show-a-volume-s-metadata-for-a-specific-key","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"9cc0dd739fafed98903d6f7389cc5ee17edfd1a2","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    Success Response:"},{"line_number":250,"context_line":"        GET:"},{"line_number":251,"context_line":"            Code: 200"},{"line_number":252,"context_line":"            Content: { deployable: {key : value, uuid: xxx}}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    Error Response"},{"line_number":255,"context_line":"        Code: 401 UNAUTHORIZED"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_71ad8599","line":252,"range":{"start_line":252,"start_character":21,"end_line":252,"end_character":60},"in_reply_to":"7f96bb07_463d38c2","updated":"2018-01-17 14:58:28.000000000","message":"You are right, I will fix it in my next patch.","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"},{"author":{"_account_id":25847,"name":"zhuli","email":"zhuli2317@gmail.com","username":"zhuli"},"change_message_id":"95d1882a34caf43ce743805f9dfde67feee743fa","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    Sample Call:"},{"line_number":262,"context_line":"        To get the value of key\u003dkpi for deployable with id\u003d2864a139-c2cd-4f9f-abf3-44eb3f09b83c"},{"line_number":263,"context_line":"        $.ajax({"},{"line_number":264,"context_line":"          url: \"/accelerators/deployable/2864a139-c2cd-4f9f-abf3-44eb3f09b83c/key/kpi\","},{"line_number":265,"context_line":"          dataType: \"json\","},{"line_number":266,"context_line":"          type : \"get\","},{"line_number":267,"context_line":"          success : function(r) {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f96bb07_4340caa5","line":264,"range":{"start_line":264,"start_character":78,"end_line":264,"end_character":81},"updated":"2018-01-17 09:06:03.000000000","message":"attribute","commit_id":"a994394f57c4c7958b6ca930162013ec3abe6855"}]}
