)]}'
{"cyborg/accelerator/drivers/fpga/intel/driver.py":[{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"1406ff4cec36f9d9198ebac08e88f718891f0fe0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        p.wait()"},{"line_number":56,"context_line":"        return p.returncode"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def updateflash(self, device_path, image, layout\u003d\"user\"):"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        Update Flash with FPGA Interface Manager (FIM)"},{"line_number":61,"context_line":"        Image using fpgaflash"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8c878dd8","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":19},"updated":"2018-08-06 03:39:03.000000000","message":"please consider using the python naming convention. update_flash maybe?","commit_id":"82391e26ef08f469301ab0158c5ea154eaa5a972"},{"author":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"change_message_id":"1406ff4cec36f9d9198ebac08e88f718891f0fe0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            layout: A parameter indicates the update"},{"line_number":69,"context_line":"                    area is \u0027user\u0027 or \u0027factory\u0027."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        Return:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        Raises:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec75e1fb","line":71,"range":{"start_line":71,"start_character":14,"end_line":71,"end_character":15},"updated":"2018-08-06 03:39:03.000000000","message":"Please explain the return code.","commit_id":"82391e26ef08f469301ab0158c5ea154eaa5a972"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a64a0ac7ac746bde0461254929232fc1c292891","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            bdf \u003d sysinfo.get_pf_bdf(device_path)"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            bdf \u003d sysinfo.get_bdf_by_path(path)"},{"line_number":85,"context_line":"        cmd \u003d [\"sudo\", \"fpgaflash\"]"},{"line_number":86,"context_line":"        cmd.append(layout)"},{"line_number":87,"context_line":"        cmd.append(image)"},{"line_number":88,"context_line":"        cmd.append(bdf)"},{"line_number":89,"context_line":"        p \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE)"},{"line_number":90,"context_line":"        p.communicate()"},{"line_number":91,"context_line":"        return p.returncode"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_24442c1b","line":90,"range":{"start_line":85,"start_character":8,"end_line":90,"end_character":23},"updated":"2018-08-30 09:35:38.000000000","message":"our default root wrap does not lock down sudo so this is less then ideal but you are not using the Shell\u003dTrue arg so this should be relitivly safe assuminf the bitstream is compablie with the device.","commit_id":"47e64c1f225452788ac4336c2aafb977325f8674"}]}