)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"347dd1a8c78dcfe0e722ed6df4f7a6ed9f69e997","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Li Liu \u003cliliueecg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-23 22:33:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Let the fpga programming api call cyborg agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4217456200670ffa26e18daee9f0c35988a09bc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_2115109c","line":7,"updated":"2018-09-24 23:42:08.000000000","message":"this is incorrect architetually.\n\nits ok for the API layer to directly call the db.\n\nit is not archituclly ok for the restapi\nto call the agents directly. the api should initate\nprograming of a device via the conductor\nthe condoctor is the only entitiy that should be able to\ninvoke rpc apis against the cyborg agents.","commit_id":"4dedb0a58d6c1751e2fa30a25e131049ef4de66a"}],"cyborg/agent/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"abed778df4bc2b9ce67fee843523342b7320b27b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # TODO (Shaohe Feng) Get image from glance."},{"line_number":53,"context_line":"        # And add claim and rollback logical."},{"line_number":54,"context_line":"        LOG.debug(\"Doing FPGA programming\")"},{"line_number":55,"context_line":"        #raise NotImplementedError()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @periodic_task.periodic_task(run_immediately\u003dTrue)"},{"line_number":58,"context_line":"    def update_available_resource(self, context, startup\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_79464dc3","line":55,"range":{"start_line":55,"start_character":7,"end_line":55,"end_character":36},"updated":"2018-08-30 09:13:39.000000000","message":"you probably should remove this.\nalso pep8 will want a space after the #","commit_id":"d72698b54bc519190327b3382105fbad55674a7b"}],"cyborg/api/controllers/v1/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"abed778df4bc2b9ce67fee843523342b7320b27b","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    accelerators \u003d accelerators.AcceleratorsController()"},{"line_number":55,"context_line":"    deployables \u003d deployables.DeployablesController()"},{"line_number":56,"context_line":"    "},{"line_number":57,"context_line":"    @expose.expose(V1)"},{"line_number":58,"context_line":"    def get(self):"},{"line_number":59,"context_line":"        return V1.convert()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f9801dc2","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":4},"updated":"2018-08-30 09:13:39.000000000","message":"nit: extra white space\nthis is also a pep8 issue","commit_id":"d72698b54bc519190327b3382105fbad55674a7b"}]}
